- 19 Sep, 2018 40 commits
-
-
Guido Urdaneta authored
Bug: 860311 Change-Id: I4b2eb3e2c1230ed9388f7e6452d3aa57c9faf61a Reviewed-on: https://chromium-review.googlesource.com/1224050 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592346}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dc8fb9374e0a..5c72f28d1a3f git log dc8fb9374e0a..5c72f28d1a3f --date=short --no-merges --format='%ad %ae %s' 2018-09-19 jgilbert@mozilla.com Remove unused include global_state.h from validationEGL.cpp. Created with: gclient setdep -r src/third_party/angle@5c72f28d1a3f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ibc49bfc532af95ba4dc99d44679a78b898d32021 Reviewed-on: https://chromium-review.googlesource.com/1232629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592345}
-
Patrik Höglund authored
It turns out that's how it works in the old waterfall, so let's keep doing that. Bug: 877018 Change-Id: If3132684e299a8b090e4b9ed82b3f5be1cb7fe74 Reviewed-on: https://chromium-review.googlesource.com/1230061Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#592344}
-
David Jean authored
Added slide in-out cancel button to the password search field. Added replacing 'Enter' on OSK (On-Screen-Keyboard) by 'Search'. Added constraints which hold when rotating device. Search not focused: https://drive.google.com/file/d/1SVrSJuKEzPTaJUx4dhsNBI6WRPltLkg1/view?usp=sharing Search focused: https://drive.google.com/file/d/13jF7BBE1gP0jmKgONVSA4JSnF9oikisY/view?usp=sharing Bug: 883807, 885092 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I56ebf32b57a90c6f4ddc622eb9f192a48bcd3d1e Reviewed-on: https://chromium-review.googlesource.com/1225879 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592343}
-
Koji Ishii authored
compositing/massive-scale-interest-rect.html No longer different from the base, removed flag-specific. compositing/geometry/transfrom-origin-on-zero-size-layer.html Matches better to the base, but text width differ by 1px. Probably from the recent fix for outline thanks to atotic. TBR=eae@chromium.org, mstensho@chromium.org, atotic@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie51a265cb21a277e09878de300ea3625620efb6d Reviewed-on: https://chromium-review.googlesource.com/1233099 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#592342}
-
Matthew Cary authored
Bug: 885071 TBR: pasko@chromium.org Change-Id: I6596edbcf5e8828f1e03b9f0404edb7a9dfaf6e0 Reviewed-on: https://chromium-review.googlesource.com/1233355Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#592341}
-
Gauthier Ambard authored
This CL fixes the fullscreen implementation living outside of web for the NTP and other scrolling issues on web page. It also fixes the animation of the resizing when the animator is triggered. Bug: 849206 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8a13b88af6808472ef84ef6902c75c398451c961 Reviewed-on: https://chromium-review.googlesource.com/1195487Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592340}
-
Yoshifumi Inoue authored
This patch changes |LayoutText::SetFirstInlineFragment()| to call |NGAbstractInlineTextBox::WillDestroy()| if |NGAbstractInlineTextBox| is created so far, to reduce iterating over inline fragments for improving speed of |SetFirstInlineFragment()|. Change-Id: I025a6ae97314247d9e528054ecf77f42a0227142 Reviewed-on: https://chromium-review.googlesource.com/1229674 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Koji Ishii authored
Unskip "virtual/android" for LayoutNG as these tests seem to be relevant for crbug.com/870008. This directory was marked to skip in r499723. TBR=mstensho@chromium.org, atotic@chromium.org, cbiesinger@chromium.org NOTRY=true Bug: 870008 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I37094e5174ba1941ae9d927d5462a0985b1ade7a Reviewed-on: https://chromium-review.googlesource.com/1233273Reviewed-by:
-
Matthew Cary authored
Bug: 885071 TBR: pasko@chromium.org Change-Id: Ic0407e2bf97c98db7324099812874645e087ea37 Reviewed-on: https://chromium-review.googlesource.com/1233335Reviewed-by:
-
Fredrik Söderquist authored
This eliminates an exit-time destructor. Change-Id: I18e3d7a9bd965c6898ba31c110b993258503a2d4 Reviewed-on: https://chromium-review.googlesource.com/1230737 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#592336}
-
Fredrik Söderquist authored
Change-Id: Ibb54621a413f1928a04498dae65a1ae5f3e48361 Reviewed-on: https://chromium-review.googlesource.com/1230716Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#592335}
-
Richard Li authored
The ultimate target of this work is moving fetch_api_request.mojom into third_party/blink/public/mojom/fetch/ folder. To accomplish the goal, the whole work is seperated into six parts. 1. Remove content::RequestContextType. Use blink.mojom.RequestContextType instead. -------- This CL 2. Remove content::ServiceWorkerFetchRequest. Use blink.mojom.FetchAPIRequest instead. 3. Remove blink::WebURLRequest::RequestContext. Use blink.mojom.RequestContextType instead. 4. Remove blink::WebServiceWorkerRequest. Use blink.mojom.FetchAPIRequest instead. 5. Remove blink::WebReferrerPolicy. Use blink::mojom::ReferrerPolicy instead. --------- CL:1212345 6. Remove content::Referrer, blink::Referrer Use blink::mojom::Referrer instead. Once all the above tasks get done, fetch_api_request.mojom can be moved into that folder. Change-Id: Id9bbac8f67a7aa511a0c642ddd5e9a837dcdd4cd Reviewed-on: https://chromium-review.googlesource.com/1229704 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#592334}
-
Dominic Battre authored
Fix typo in disabling WebRtcGetUserMediaBrowserTest.SrcObjectReplaceInactiveTracks TBR=xiyuan@chromium.org Bug: 848330 Change-Id: I13e2a7883b06a930bd0e6fe7e6f3cce9b3f0563f Reviewed-on: https://chromium-review.googlesource.com/1233194Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#592333}
-
yoshiki iguchi authored
Previously, a long press is cancelled only by swipe scroll. This CL adds the same logic for scroll by mouse. Bug: 869345 Test: manual Change-Id: Iefef9847b9b6bcfbaa5cb528d90e3a0ce978e34c Reviewed-on: https://chromium-review.googlesource.com/1220947Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#592332}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77900be4e71e..2fbd3c8eb530 git log 77900be4e71e..2fbd3c8eb530 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2fbd3c8eb530 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I176157613895b42c4c78ce854286e6b4ffab2997 Reviewed-on: https://chromium-review.googlesource.com/1232628Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00df84c3a8a5..2a8d9e908573 Created with: gclient setdep -r src-internal@2a8d9e908573 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6b513a8cdc675dd2bc62201431e6f5bd59b62e80 Reviewed-on: https://chromium-review.googlesource.com/1232627Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592330}
-
BUG=762641 TBR=stevenjb@google.com, tbarzic@google.com Change-Id: I5d6abf6b4902219d8ae17471253e09dbba64175d Reviewed-on: https://chromium-review.googlesource.com/1233293Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592329}
-
Hajime Hoshi authored
This is a part of efforts to forbid V8 execution on the default task runner of the main thread. Bug: 870606 Change-Id: I558cbdeb55f3abdcd4f4fa95f4694c495512f91a Reviewed-on: https://chromium-review.googlesource.com/1229739Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
-
Joel Hockey authored
Renamed: ui/file_manager/file_manager/foreground/js/VolumeManagerWrapper to ui/file_manager/base/js/FilteredVolumeManager Bug: 884107 Change-Id: Iece36d99f152be1f921c8a20d428415ee0921acb Reviewed-on: https://chromium-review.googlesource.com/1229740 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#592327}
-
Yutaka Hirano authored
Layout tests run with "AllowUniversalAccessFromFileURLs" which grants universal access to file: origins. This CL modifies layout tests relying on the settings *for CORS* as out-of-blink CORS doesn't support the settings. This is basically done by adding "access-control-allow-access: *" to a lot of resources. Bug: 870173 Change-Id: Ie38eba9674419786e1acd2a0e12e172bea6ebb1e Reviewed-on: https://chromium-review.googlesource.com/1224151 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#592326}
-
Noel Gordon authored
GalleryBrowserTests flake on the Polymer2 bots due to exceptions about "missing DOM element bottom-toolbar" on the MSAN/ASAN bots. Those bots are correct: the DOM document is still loading when gallery JS tries to access the DOM to construct the JS Gallery. Application of i18 transforms could also applied to an incomplete document. Add a DOMContentLoaded handler and use it initialize the gallery: move the loadTimeData i18 template processing therein and add asserts about the document state when the Gallery is being constructed, catch errors during construction. With this change, the gallery browser tests no longer flake locally in ASAN when run with the --enable-features=WebUIPolymer2 flag: re-enable Gallery browser tests on the WebUIPolymer2 bots therefore. Test: browser_tests --gtest_filter="GalleryBrowserTest*" Bug: 882606 Change-Id: I3bed9bac37e7c82cfdc7c25fd863f5fe0bb03370 Reviewed-on: https://chromium-review.googlesource.com/1227855 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#592325}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/568e0b054ae4..00df84c3a8a5 Created with: gclient setdep -r src-internal@00df84c3a8a5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4aca2043b178a1b2b8a35ed43b350552f5aa5ffe Reviewed-on: https://chromium-review.googlesource.com/1233118Reviewed-by:
-
John Chen authored
This reverts commit 887f2042. Reason for revert: The underlying cause of the timeout (issue #883609) has been resolved, so this mitigation is no longer necessary. Original change's description: > [ChromeDriver] Mitigate Mac builder timeout issue > > The Mac builder for ChromeDriver often times out while waiting for > a Chromium build to become available, because the Mac Chromium > builds are very slow. Mitigate this issue by allowing slightly > older Chromium builds on Mac. > > Bug: chromedriver:2584 > Change-Id: Id219859252b11cb7ec450bdef87314a107c49fef > Reviewed-on: https://chromium-review.googlesource.com/1220400 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590930} TBR=crouleau@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromedriver:2584 Change-Id: Ic4b0440c672dc94e0fba366f2f705377a11341a7 Reviewed-on: https://chromium-review.googlesource.com/1233120Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592323}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/774b566c1308..0ff03808e344 git log 774b566c1308..0ff03808e344 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0fdb956d9c24..dc8fb9374e0a (6 commits) Created with: gclient setdep -r src/third_party/skia@0ff03808e344 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I5db621977a50ba97174140380bb883837e65adbf Reviewed-on: https://chromium-review.googlesource.com/1233117Reviewed-by:
-
Ryo Hashimoto authored
This reverts commit 9dc2f03d. Reason for revert: causes crash loop on grunt Original change's description: > [ozone/common] Make gbm_wrapper to be compiled with system libgbm > > This patch makes use of new minigbm APi names, which are aligned with > Linux libgbm. > > Also, it defines certain definitions, which are different between > libgbm and minigbm. > > What is more, it adds USING_MINIGBM for internal usage to be able > to distinguish between system linux gbm and minigbm. > > Last but not least, drmPrimeHandleToFd is used in case of linux > system libgbm in order to be able to get mappable fds per each > plane, which is neede to add GpuMemoryBuffers support. > > Bug: 869206, 578890, 820047 > Change-Id: I0a743aef1c8bad2bb5792a58ab29abec45ea4585 > Reviewed-on: https://chromium-review.googlesource.com/1158234 > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589475} TBR=rjkroege@chromium.org,spang@chromium.org,msisov@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869206, 578890, 820047 Change-Id: Idd0f9e4aa584bc1e353d3947cef12e4ee8839385 Reviewed-on: https://chromium-review.googlesource.com/1232881Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592321}
-
Lei Zhang authored
TBR=jcliang@chromium.org,sadrul@chromium.org Change-Id: I67921931f36a3e5158df9254961403b0717a94c7 Reviewed-on: https://chromium-review.googlesource.com/1232878 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592320}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fcfd3382d4ab..dc8fb9374e0a git log fcfd3382d4ab..dc8fb9374e0a --date=short --no-merges --format='%ad %ae %s' 2018-09-19 ynovikov@chromium.org Revert "Add FastVector for simple dynamic vector cases." 2018-09-19 jie.a.chen@intel.com Improve dirtybits for compute 2018-09-19 jie.a.chen@intel.com ParallelCompile: Parallelize shader translation 2018-09-18 jmadill@chromium.org Add FastVector for simple dynamic vector cases. 2018-09-18 jmadill@chromium.org Log Renderer string on Android displays. Created with: gclient setdep -r src/third_party/angle@dc8fb9374e0a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849576 TBR=ynovikov@chromium.org Change-Id: If9f4a3294d663f7a0baa496cb82f21e533dc08cd Reviewed-on: https://chromium-review.googlesource.com/1232626Reviewed-by:
-
Luciano Pacheco authored
mtomasz@ isn't working with Files app anymore. Change-Id: I9de275431d10e0ee37fe4742521b207fe59aa0d0 Reviewed-on: https://chromium-review.googlesource.com/1233079Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#592318}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/79c651330b94..77900be4e71e git log 79c651330b94..77900be4e71e --date=short --no-merges --format='%ad %ae %s' 2018-09-19 iannucci@chromium.org [windows_sdk] Allow taskkill mspdbsrv to fail. Created with: gclient setdep -r src/third_party/depot_tools@77900be4e71e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:861512 TBR=agable@chromium.org Change-Id: Ic6c3aadd5d77ae4b4df7be7265c0109dc30bee65 Reviewed-on: https://chromium-review.googlesource.com/1232625Reviewed-by:
-
Zhuoyu Qian authored
The message_port.mojom isn't really anything message port specific, split it in cloneable_message.mojom and transferable_message.mojom. Bug: 868501 Change-Id: I13b52137162579a62d09ff38ae80459ac8d16c25 Reviewed-on: https://chromium-review.googlesource.com/1207789Reviewed-by:
-
Alexey Baskakov authored
Extensions shouldn't leak into chrome/browser/sessions/ code. No behavior changes. Bug: 774918 Change-Id: I5c35749362914bdb3ea46c160abcd4ab36a74957 Reviewed-on: https://chromium-review.googlesource.com/1229722 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#592315}
-
Jinsuk Kim authored
TabUma is managed now by Tab's UserDataHost, and accessed through TabUma.{create|get}. Also made it TabObserver so that most of the operations will be done through the interface implementation instead of direct calls from Tab. Bug: 877878 Change-Id: I038cdeb60aefb74224e7a03f0d908d67d2b89002 Reviewed-on: https://chromium-review.googlesource.com/1214965 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592314}
-
Sam McNally authored
In order to make the test pass: - Change chrome.fileManagerPrivate.setEntryTag() to succeed but take no other action with DriveFS enabled; it won't be supported with DriveFS. - Enable a mock SyncFileSystemService so the use of the syncFileSystem API can succeed locally. - Add support for mounting a USB drive containing a DCIM directory with an image. This test only exercises basic functionality: - There is no previous photo backup history in the syncFileSystem. - Images in the external drive are not duplicated in Drive. Bug: 883628 Change-Id: Ic5244de54bdd6f3fee0c82a356e7e530b85dba64 Reviewed-on: https://chromium-review.googlesource.com/1230193Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592313}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I05c9d8527695a94de3fa65467150184ab3daa344 Reviewed-on: https://chromium-review.googlesource.com/1232585Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#592312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e7930e1e7a4f..568e0b054ae4 Created with: gclient setdep -r src-internal@568e0b054ae4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I37e1eeb1cc535f862eccdb7238838eec987eec2a Reviewed-on: https://chromium-review.googlesource.com/1232623Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/57988b451c5c..274a6922da39 git log 57988b451c5c..274a6922da39 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 dgarrett@google.com chromeos_config: Make external PreCQ builds internal. Created with: gclient setdep -r src/third_party/chromite@274a6922da39 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2c14d26a49e45c88455e92dc4494bb833b45f36b Reviewed-on: https://chromium-review.googlesource.com/1232622Reviewed-by:
-
Anand K. Mistry authored
Additionally, update a few call sites that were missed on previous CLs. No changes to behaviour. Part of ongoing effort to clean up file manager code. BUG=875700 TBR=avi@chromium.org Change-Id: Ic3d5fb246a0610d63d377de7c038f7e2359f1bdc Reviewed-on: https://chromium-review.googlesource.com/1229721Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Extensions shouldn't leak into chrome/browser/ui/ code. Use TabHelper::GetAppId instead of Extension* Since we are going to use std::string for AppId, this change will allow us to use an abstract apps::App and move off the Extensions System in the future. Drive By: Erase unused TabHelper::web_app_info(). Bug: 774918 Change-Id: I3596bb80729c53f53215325abd371dda8a06a50a Reviewed-on: https://chromium-review.googlesource.com/1229719 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#592308}
-
Wenzhao Zang authored
The goal is to show screensaver immediately after demo session logs in. In order to avoid the visual delay during the screensaver installation, we need to: 1. Bypass install_limiter: it's reasonable to make an exception for the screensaver app during demo mode. The choices for the size limit (1MB) and the delay (5000 ms) are somewhat arbitrary in the first place. We'd still like to keep the install limiter in all other cases unless there's a real need to bypass it, ie: 1) All other apps during demo mode, 2) The screensaver app in non-demo mode (only possible if people randomly find it from the web store.) 3) All other apps in non-demo mode (the majority cases). 2. Initiate installation earlier: if we wait until session state becomes active, then its installation will happen later than the policy forced ones. Instead, we can observe the profile creation and start installation right after profile is created. Highlights app should be installed at the same time, but do not change it for now because: 1) Before we disable browser launch for demo sessions, we want Highlights app to appear between the screensaver and the browser window. This is hard to achieve if installing Highlights app at the same time with screensaver (which happens before browser launch). 2) Installing another large app may affect installing the screensaver. Bug: 870851 Change-Id: Ia8f7bb4f02d69e73a4c79839531ee1c190414d3d Reviewed-on: https://chromium-review.googlesource.com/1212448 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592307}
-
