- 12 Aug, 2020 40 commits
-
-
Dan Harrington authored
Changes merged: https://chromium.googlesource.com/feed/+/c80d3c49fa92f00c05130106b29d5b49a735ac97 Change-Id: I7d676b458cc1d8e32aa2db104e0e81591d7a32d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353011 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#797443}
-
Philip Rogers authored
This patch extends the following metrics to M88: Renderer4.MainThreadWheelScrollReason Renderer4.MainThreadGestureScrollReason Bug: 841364 Change-Id: I14bfe66ee5ac1c56f66101007a7e67c513171014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344644Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797442}
-
Eric Seckler authored
Copy/paste bug snuck in, which meant we were reporting into the same histogram twice rather than into two different ones. Correcting. Change-Id: Ia43697b69ff5603cc931e2dbda62fdb5892305b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352189 Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#797441}
-
Emily Stark authored
This CL improves elision behavior in the simplified domain field trials when the omnibox is too narrow to fit the full hostname (or even the full registrable domain). The main change is that if the omnibox is too narrow, we scroll the domain to show as much of it as we can from the right. This is a partial fix, in the simplified domain field trials, for a longstanding security bug (crbug.com/527638). The behavior with this CL is still a little weird because there's no visual cue that the domain is truncated, but I think it's better than the status quo where we show the left edge of the domain in Chrome today (e.g., "google.com..." instead of "...evil.com"). For simplicity, I've made it so that if the domain does not fit in the omnibox's bounds, we don't do any hover animations. I think this is okay from a UX perspective; after all, in this case, we're not eliding anything that the user wouldn't be able to see today. It's simplest to implement because ElideAnimation doesn't know anything about hostname/URL semantics and thus doesn't know that it should align the URL specially when the domain doesn't fit. Bug: 1107912,527638 Change-Id: I0682582b95393ded82dfd6d56f5ab9d0859e92d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342283 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#797440}
-
Yuke Liao authored
In order to promote browser_tests to run in non-experimental mode so that it's sherrifed to prevent regressions. Bug: 1111979 Change-Id: I7668d920cb2ed09583bc3eeb606aac0759d502cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353352Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#797439}
-
Brandon Wylie authored
Bug: 1094885 Change-Id: Ie3fb46b2fb7029671f91612fefee7fcb2352a613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353012Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797438}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a465e2e30890..c95b589112f3 2020-08-12 adlai@google.com Reland "Migrate GrSurfaceContext readPixels to take direct context" 2020-08-12 brianosman@google.com SkRuntimeEffect: Handle different main() signatures on CPU 2020-08-12 robertphillips@google.com Fix bug in op chaining 2020-08-12 mtklein@google.com more careful rrect deserialization 2020-08-12 adlai@google.com Reland "Migrate SkImage::MakeFromTexture to GrRecordingContext" 2020-08-12 mtklein@google.com fix a SkRRect::readFromMemory() fuzzer bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1111169,chromium:1112259 Tbr: fmalita@google.com Change-Id: Ia9a45981611d9ad7bdd9aa3e0d3741aaed82ecd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797437}
-
Michael Thiessen authored
This change adds an assertion that pollUiThread is not called from the UI thread, which is equivalent to calling sleep(), and won't actually run any UI thread tasks. In the few cases where polling the UI Thread from the UI thread is necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests the looper in order to continue running UI tasks. Bug: 1115220 Change-Id: I834251df334c80d657e45dddeab5ae744de0fe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340004Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#797436}
-
Erik Chen authored
Attestation is the process of proving ownership of a private cryptographic key. One side issues a challenge, and the entity must sign the challenge using a private key. chromeOS exposes blessed extension APIs that allow force-installed policy extensions to issue attestation challenges. By default, these are not available on lacros. This CL adds basic plumbing for enterprise.platformKeys.challengeMachineKey. This is not intended to be a fully functional implementation -- that will require further refactoring and debugging from domain experts. Bug: 1113443 Change-Id: I8781ef1367242de59faacb372cf6453925fdfa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324303Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797435}
-
Ben Pastene authored
This test requires 2 Tast vars. Simple Chrome currently doesn't fetch the internal tast vars repo. So disable this test while we figure it out. Bug: 1115622 Change-Id: I31c7404e4eecdff965143a2f3430b114f85e9eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353064 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#797434}
-
Michael Thiessen authored
We were leaking the overridden ApplicationContext, leading to other tests failing when interacting with mocks created by the ExternalNavigationHandler. Not sure why this isn't occurring on bots, but it does locally. Change-Id: Ie283a6f96f69dec2a8e70c4ed11e025f6e475c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353121Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/67615460bea4..383f2cfca4a1 2020-08-12 danilchap@webrtc.org Stop mentioning RTPFragmentationHeader in call/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6037b9236d0ae1202381c9149d83c8f771e31ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351754Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfa133b7b48c..fac64cf60aa2 2020-08-12 lalitm@google.com Merge "tp: strip leading whitespace before looking for comments" 2020-08-12 fmayer@google.com Disable PollBehavesProperly without ASAN. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2a2fe9d6f6cb4127dd3bdd846633818d4bd9e1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351287Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b65408064b1f..ee70c3aabba0 2020-08-12 swiftshader.regress@gmail.com Regres: Update test lists @ 13f04d59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic45323946b11c96b494312d706240b708408369f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353114Reviewed-by:
-
Daniel Murphy authored
While reading the code it isn't clear the WebAppInstallTask may only be used once. Adding DCHECKs and a comment to clarify this for future readers. R=loyso@chromium.org Change-Id: I08c188ac9eaef53ab7b9a82f0bbd93f383a5e936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300830 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#797429}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: CrComponentsNetworkConfigElementBehaviorTestV3.All Change-Id: Iec3529a023fb5c00c341d6f8d535991fe37552d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347072 Commit-Queue: James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#797428}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1aff02d44478..2088cdec6612 2020-08-12 cwallez@chromium.org Update tests to use new mapping APIs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I06ac3b8a6f0093f92267bdb98a9accc241794179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351756Reviewed-by:
-
Stephen McGruer authored
This reverts commit dc5bcc30. Reason for revert: Suspected of breaking win-32-archive build: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15597?blamelist=1#blamelist-tab Original change's description: > Update schema for PolicyRefreshRate and MaxInvalidationFetchDelay > > Include the min and max values already specified in the policy > descriptions and in the code handling the policies. > > The limits for the PolicyRefreshRate policy are specified in > components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc. > > The limits for the MaxInvalidationFetchDelay policy are specified in > chrome/browser/policy/cloud/cloud_policy_invalidator.cc. > > BYPASS_POLICY_COMPATIBILITY_CHECK=Min and max values already specified, > they just were missing from the schema > > Change-Id: Ia1b3904dd1f377d5bc1ee7c2742f3eaeb3f34969 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349211 > Commit-Queue: Chris Sharp <csharp@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797407} TBR=csharp@chromium.org,pmarko@chromium.org Change-Id: I3211f93539d1f5c5d81cc380b13f88e8f543bb9b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353359Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797426}
-
Claude van der Merwe authored
The 'actionable' attribute was added to 'property-box' in network_config_toggle.html. This caused a pointer cursor to be displayed when the element was disabled. This change removes the 'actionable' property and adds css to change the cursor to initial if the element is disabled and pointer if it is enabled. Bug: 1114668 Change-Id: If09818400ae37b3f3c21f15b161d37940ae4ed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347196Reviewed-by:
-
Sammie Quon authored
Update text and change so exit mirror mode will not trigger it. Partial revert of crrev.com/c/2340265 as we may keep around some of the notifications that are currently behind the flag. Test: manual Bug: 1111479 Change-Id: I285e5b41af06aeb940be02f6b9d2255531c9444b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350901Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#797424}
-
Kyle Horimoto authored
We do not start up PhoneHubManager at all when prohibited by policy (see [1]), so this is no longer an appropriate enum value. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2350024/ Bug: 1106937 Change-Id: Ie143f16b363707042d7da191b6891e051f64a50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352210 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#797423}
-
Robert Ma authored
Importantly, this rolls some webdriver/ changes that will fix the regression in issue 1115609. Removed the related expectations introduced in the import https://crrev.com/c/2351549 as well. Bug: 1115609 Change-Id: I5f0ebfc1d657556e166fc6d433b24f3f2ff8a14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351383Reviewed-by:
-
Andrew Comminos authored
When layers associated with multiple different documents (via TransformNode) overlap at an event's position, mitigate any misattribution caused by complex occlusion by discarding attribution when there exists a layer with a document outside of the targeted layer's parent chain. Bug: 910421 Change-Id: I4d98c4a65f0704c06c3bfbc16a7fc8b9c42d28e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351142Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#797421}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597233486-9b99859a3e8f91576b2a111cc083e1a4b72a89f4.profdata to chrome-mac-master-1597255086-4c97f40f3099850ce4002243596e1c9e8589ecba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6fc218658384d9edc07f652faf21f03feabeafb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353098Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4ca4974. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I281db5ed18dfbe4a1afafff4ec819432772b4d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353170Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797419}
-
Meilin Wang authored
Please see screenshot in the linked bug. Bug: b/161481195 Test: manually. Change-Id: Ie276b743b122d447cc658dfff6e72476122aef3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336493 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797418}
-
Brian Malcolm authored
This is intended to replace the NativePrinters policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. NOPRESUBMIT=true BUG=chromium:1113362 Change-Id: I3d0616d9f414fa391be24d71780513df86e2a5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340363 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797417}
-
Kyle Horimoto authored
This class will implement the core functionality for Phone Hub. Currently, it simply instantiates an instance of FeatureStatusProviderImpl. Additionally, we provide a static Get() function to be called by //ash in ash::Shell::OnFirstSessionStarted() to get access to Phone Hub without taking a dependency on //chrome (which is not allowed). Bug: 1106937 Change-Id: I980237970349dc3b0ec47b0d144a59680c1c14bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350024 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/75a11031..9e3426eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I990d5ee5366bfa63ee7fcd321142cb608b38fbd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352756Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797415}
-
Daniel McArdle authored
This is a speculative fix for https://crbug.com/1114334. Logs attached to crash reports indicate that the KeyChainAliasCallback is being invoked twice. Specifically, "No client certificate selected" appears twice in the log, and in one instance we see them appear within 1ms of each other. It's possible that Chrome's maybeShowCertSelection is accidentally invoking the callback one of those times, or that Android's KeyChain framework is double-invoking the callback. The docs do not specify how many times the callback may be invoked. This CL also switches logging to org.chromium.base.Log and limits the TAG to 20 characters, as required by presubmits. Bug: 1114334 Change-Id: I3e5e1f318f579b0b7a4521f058ba1f0a7224c487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344624 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#797414}
-
Xianzhu Wang authored
This is to cover the future cases of backdrop effects without needing a new enum value. Also add the value into histograms/enums.xml Bug: 1115564 Change-Id: I1d190d78186a55f93aa208af3a7f6c3015e9b09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352552Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I31fa2fa16ecb83f82c193e052142b63cc3dec752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351381Reviewed-by:
-
Chris Palmer authored
Fall back to reading from urandom only when that fails. Bug: 995996 Change-Id: I0a357dc39c6b2081eda749e770168e592eaa458b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353190Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797411}
-
Xida Chen authored
This CL removes code that is related to an expired flag: touch-events. No behavior change is expected. Bug: 1110731 Change-Id: I5e94c60415941edc92330d01054e752b0f111009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352765 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#797410}
-
Gang Wu authored
managed by menu item should be setVibility(View.VISIBLE) and setEnabled(false) when shows up. App menu should be kept open after disabled item has been clicked. Previously click on the item will close the app menu. This CL also fixes TalkBack announcing "disabled" for the item. Bug: 997053 Change-Id: I4442bd889c30b850c7287869054a3beff2455b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351419Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09afd88dfed8..dfa133b7b48c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaf0f7565830362fdc1c9012a689e25f32ca713a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352760Reviewed-by:
-
Chris Sharp authored
Include the min and max values already specified in the policy descriptions and in the code handling the policies. The limits for the PolicyRefreshRate policy are specified in components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc. The limits for the MaxInvalidationFetchDelay policy are specified in chrome/browser/policy/cloud/cloud_policy_invalidator.cc. BYPASS_POLICY_COMPATIBILITY_CHECK=Min and max values already specified, they just were missing from the schema Change-Id: Ia1b3904dd1f377d5bc1ee7c2742f3eaeb3f34969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349211 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#797407}
-
Marijn Kruisselbrink authored
This gets rid of the redundant ConfirmDirectoryReadAccess method, and instead just requests read access on the corresponding permission grant instead. In the future this will make it easier to support a single prompt for getting access to a writable directory, instead of the current two separate prompts. To do this, also adds an extra flag to the NFSPermissionGrant::RequestPermission method to indicate if this particular permission requests requires user activation. Bug: 1115632 Change-Id: Ie3980867d162e16723569a0fd36f27323d2700ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341214Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#797406}
-
Yuke Liao authored
In order to promote unit_tests, extensions_unittests and views_unittests to be sheriffed to prevent regressions. Bug: 1111979 Change-Id: Ib326e7eb0d3b54fc58119fd702d8702d48d46973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353152Reviewed-by:
-
Corentin Wallez authored
Following the PSA for API deprecations, the following are removed: - GPUTextureDescriptor.arrayLayerCount - GPUTextureCopyView.arrayLayer - GPUBuffer.setSubData Also updates a couple uses of the deprecated WGPUBufferCopyView members. Bug: dawn:22 Change-Id: If826f85a42cb9c713bb958ef29a512b8583e3f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351970Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#797404}
-
