- 18 Jan, 2021 40 commits
-
-
behdad authored
The interval of last frame in sliding window is used to calculate the total expected frames in window. Test are also updated to reflect this change in calculation of percent dropped frames. Bug: 1167213 Change-Id: I5dd7e608d35b33af90046867d70bc652cced0366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633922Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844549}
-
Mustaq Ahmed authored
This CL adds fields to postMessage data structures that convey the sender Window's intention to delegate a capability to the receiver Window. The change is behind two runtime flags: one flag ("CapabilityDelegation") enables the parsing of a new postMessage option for delegation, while the other flag ("CapabilityDelegationPaymentRequest") enables transmission of payment request delegation information to the receiver Window. Bug: 1130558 Change-Id: Ifad482bc9629ea69b9bd802d5f0f7df7c24645f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568627 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844548}
-
Vidhan authored
profile dedupe has already run The profile deduplication is run once every chrome version. Since, AlternativeStateNameMap needs to be populated before running the deduplication logic, it does not make sense to synchronize populating the map every time on browser startup. With this change, AlternativeStateNameMapUpdater would be populating the AlternativeStateNameMap on the browser startup if the profile deduplication logic has already been run for the current chrome version. Bug: 1111960 Change-Id: I2964d292c726083dcde069bf1e2596e723db2679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632671Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#844547}
-
Matthias Körber authored
Change-Id: I3e7214e59f822812eee25e084a3ee0d61b6d28f1 Bug: 1007974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626288 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#844546}
-
Dominic Battre authored
This CL move the tracking of some form controls to unique renderer IDs. This mitigates a user visible (temporary) leak. Bug: 1144739 Change-Id: I4199750622ea6bfda681a07120ace0b1ad08510a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632951Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#844545}
-
Roman Sorokin authored
Bug: 1162271 Change-Id: I08ec5ae65ac7b6228752fec11490497bb6a5fa9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602284 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844544}
-
Yaron Friedman authored
Bug: 783819 Change-Id: I4c7d5c75a8f58a517324ed2a9d8cd2c475cbd784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633369 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#844543}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1bb49a870088..2a27413fde15 2021-01-18 reed@google.com Remove legacy code from picture-shader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I35f2a6965bda1407d021a23fc1fa3e59f01321b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635943Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844542}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5fcf0fa9382e..66a69e614cbb 2021-01-18 henrysun@google.com dedede: add factory-dedede-13683.B into builder 2021-01-17 manojgupta@chromium.org Revert "sysroot_lib: add -O to MAKEOPTS" 2021-01-16 vapier@chromium.org sysroot_lib: add -O to MAKEOPTS 2021-01-16 saklein@chromium.org dependency_graph.py: A new dependency graph class. 2021-01-15 geohsu@google.com Instantiate M89 builders 2021-01-15 tcwang@google.com afdo: Fix orderfile script path inside chroot If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I17b3175d73dcc85d121e2be4bc0cacaa4de78afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844541}
-
Egor Pasko authored
On Android the call is backed by gettid(3). With bionic this call has gotten a fast TLS cache since [1], which seems to cover all releases supported by Chrome. Keeping the thread id in a thread_local variable adds extra latency from emutls: pthread_getspecific() and an atomic load. Leaving it unchanged on other platforms. Preliminary performance tests show occasional improvements on speedometer2 and regressions on blink_perf. Since the former is more important than the latter, let's land this and go through alerts (green+red) from chromeperf. [1] https://android.git.corp.google.com/platform/bionic/+/5d9a7ba0dc9c24ed4e4efa9cac0e796fd524b308 Bug: None Change-Id: I8a5c5319bdddd368bc44ab4f1e3f066447997172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339669Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844540}
-
Alex Ilin authored
This CL adds more tests to profile_card_menu_test.js test suite. The new tests check: - profile and account names in the remove confirmation dialog - statistics table in the remove confirmation dialog Change-Id: I9284b85d1b0ece2f958da60dd1566f9addf2857f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630048 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#844539}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b06ebb493f2c..f572da65b858 2021-01-18 alexrudenko@chromium.org Enable flexbox tooling experiment by default 2021-01-18 petermarshall@chromium.org [startup] Wait until settings are loaded to load locale data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167695 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie4abd90b6cbf41135bdd048cb122fce3cde58bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844538}
-
Matthias Körber authored
This CL also introduces a class enum for the parsing outcome and moves some code from the test utils header into the cc file. Change-Id: I34c6538a68fe2c33a02646eddb6692b88b155a6e Bug: 1007974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626647 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#844537}
-
Liviu Tinta authored
Because we use static_cast<int> to cast from double to int we expose ourselves to float-cast-overflow. We use clampTo to make sure the result is in int limits. MouseEvent: :layerX, MouseEvent::layerY are returned as integers. Bug: 1164520 Change-Id: I0881323f5508b3f4d3fb2f3f73d6b138aa4202c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622870Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844536}
-
Ella Ge authored
Bug: 1155353 Change-Id: Icfc48b9f991dbccf8c2fbc96a6bdf3ceab0c62ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630225Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#844535}
-
Cheick authored
This CL adds a feature flag for shared highlighting color change. Bug: 1166249 Change-Id: I355710abddc4c2c10dd9d673b5d9a21e30142f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626270Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Cheick Cisse <cheickcisse@google.com> Cr-Commit-Position: refs/heads/master@{#844534}
-
Wan-Teh Chang authored
Document that within blink/renderer we can get a a UkmRecorder instance by using blink::Document::UkmRecorder(). Change-Id: I6c06c87d4e0a2a4fba459ae57e75779a14a91277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634228Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#844533}
-
Monica Basta authored
UIs affected: Profile card on the main view, remove confirmation dialog. After this CL: * The full Gaia name instead of gaia given name. * Use font size: 1em for the gaia name and 1.16em for the local profile name. Screenshots: https://drive.google.com/file/d/1-duldVHMSbdSZELmlJEAB0nTV8Sg3Cvs/view?usp=sharing&resourcekey=0-32oL_7guOgsf9pGzhzKq9Q https://drive.google.com/file/d/1PV9mGbS2Hb_06dKKtsCYKv5SQAOPgMou/view?usp=sharing&resourcekey=0-C_8QVvlFSG3tsRdgXB341Q Fixed: 1167184 Change-Id: Ic6db3698b07d11eb988a6ed6fea9d866d6a2a405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632611 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#844532}
-
Cheick authored
This CL adds to the shared highlighting component a constant default color (light purple) code. Bug: 1166249 Change-Id: Id4c56a010f3f2e80be6f1989b05ec3e0cb88a7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633009Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Cheick Cisse <cheickcisse@google.com> Cr-Commit-Position: refs/heads/master@{#844531}
-
Ben Mason authored
R=rubber-stamper@appspot.gserviceaccount.com Change-Id: I0d9aadfb9854bd809828e585547b0c7e00506960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635069 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844530}
-
Alex Rudenko authored
This CL adds support for emulation of the color-gamut media feature. In particular, 3 values that are currently supported by CSS: srgb, p3, rec2020/bt2020. Spec: https://drafts.csswg.org/mediaqueries-4/#color-gamut Doc: https://goo.gle/devtools-css-color Bug: chromium:1073887 Change-Id: If96f1e955b1bb326af831e3fcfa020fcc9c70208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632609 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#844529}
-
Olesia Marukhno authored
Announce to screenreaders that a permission has requested if chip UI is used. For prompt UI, the bubble is shown and it takes over the focus. Chip UI is less intrusive so it must be explicitly announced for screen reader users. To avoid users not hearing the announcement, it would be reannouced after 2 minutes. Chip UI is now one of the panes (users can cycle through panes with F6). This way users can easily access it with keyboard which is very important for screenreader users. Also to make sure that users don't miss pending permission request, added message about having pending permission request to tab announcement. Previous CL was revered here: https://chromium-review.googlesource.com/c/chromium/src/+/2586966. Bug: 1150836 Change-Id: Ic6a5dddb3368ad4ed90e33cefa7673df843f4b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624468 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#844528}
-
Jan Wilken Dörrie authored
This change extends the Http Migration Password Manager histograms and makes jdoerrie@ the primary owner. R=chromium-metrics-reviews@google.com Fixed: 1165117 Change-Id: I79ae58d058d5bf5d99df5e77473415e222704d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635660 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#844527}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610948968-472c5c5ed4005e92cd456548bcb91e146ae8a09f.profdata to chrome-mac-master-1610970273-8e469593c6a515d27af32fe96ea4451632963806.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4bead3fcd0792b6333caa78e2ad47fe04cb12008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844526}
-
Elizabeth Popova authored
Prior to this change, when the form contained multiple phone numbers, the import was aborted since Autofill currently supports storing only one phone number per profile. Now with AutofillEnableImportWhenMultiplePhoneNumbers enabled we try to import the first phone number and ignore all other phone components in the form. Bug: 1154727 Change-Id: I47dff6abcf862819ad23809c0fc684dfa3ada06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632675Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#844525}
-
Camillo Bruni authored
Previously the repro command was only show when the test failed. Change-Id: Ib7c065fb177b19d0b30083ba38daf0bb4856f8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635145Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844524}
-
Christoph Schwering authored
This CL adds set operations to DenseSet for the union and difference and for subset and disjointness of two DenseSets. The set's size parameter (formerly kEnd, now kMaxValue) is now implicit and defaults to the T::kMaxValue (which according to the chromium-style is the highest value in the enum. Bug: 1007974 Change-Id: Ia8fd96481bf28d361a7736032ea4d65b3dbbab83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630706 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#844523}
-
Viktor Semeniuk authored
Since CompromisedCredentials hold parent_key to PasswordForm, they will be removed automatically due to Cascade implementation of delete. Bug: 1167109, 1137775 Change-Id: I6df183012ecbafd1867d290a062decf6e850b040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626442 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#844522}
-
Nohemi Fernandez authored
The new promo will only be shown on the Settings page with |kMobileIdentityConsistency| enabled. This patch does not update interactions with promo dismissals. Bug: 1151289 Change-Id: I5ca5701415023cca5e20cfbef6427ff16dca8888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565574 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844521}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16b9bbbd..a36b28c1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iddd593a7b609739819742de6a7355537003cd7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632852Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844520}
-
Findit authored
This reverts commit b399fb2c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 844516 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IzOTlmYjJjYjc2Zjg2YTc4YTYxYWI4ZGRiYWQ3M2ZhYWVhNGQyZmIM Sample Failed Build: https://ci.chromium.org/b/8857758622958410288 Sample Failed Step: compile Original change's description: > Remove eugenebut from ios/web owners > > Bug: None > Change-Id: I5c8684a3f17f2f147bb04a41ab84ba503aa56ae0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633193 > Auto-Submit: Eugene But <eugenebut@chromium.org> > Commit-Queue: Ali Juma <ajuma@chromium.org> > Reviewed-by: Ali Juma <ajuma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844516} Change-Id: I8039a97b105dce9af8b85d8c2402a0001c2aa1b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635681 Cr-Commit-Position: refs/heads/master@{#844519}
-
Aya ElAttar authored
- Changed notification helper to observe the clipboard, and close the bubble if the clipboard got changed. - Refactored Bubble & Button classes to base and derived classed, so it'd be easier to support warning mode later. - Moved some of the needed bubble constants to a separate file. Bug: 1167228 Change-Id: I103ef1c95e1036ba28d3c449ed801688d12d2868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632673Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844518}
-
Matthias Körber authored
This change moves field name parsing logic out of the FormStructure class into a separate util file. Also, this change uses StringPieces for the processing and removes side effects from the functions written in the util file. Change-Id: I62b2349f59e271721df23ba1145fc9e23e095cf2 Bug: 1007974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622395 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#844517}
-
Eugene But authored
Bug: None Change-Id: I5c8684a3f17f2f147bb04a41ab84ba503aa56ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633193 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#844516}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bc30234f61ef..b06ebb493f2c 2021-01-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-18 sigurds@chromium.org Extract issue text icon to svg file 2021-01-18 janscheffler@chromium.org [Recorder] Close opened targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098185,chromium:1161512 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I01c0bc7f8a82ef35aff41d04547d1b296deb168a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635939Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844515}
-
Sami Kyostila authored
TBR=mythria@chromium.org Bug: 1167686 Change-Id: I50cc010f3e5f7babd2db5328ec8c4435e47646a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632961Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#844514}
-
Al Muthanna Athamina authored
This CL was created automatically with tools/perf/update_wpr script R=johnchen@chromium.org Bug: chromium:1158374 Change-Id: I710407f0ab9385beae0836e83efca4849f939162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595383 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Tamer Tas <tmrts@google.com> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#844513}
-
Robbie Gibson authored
This CL adds three new tests: 1. Tests that swiping down twice transitions the thumb strip to the revealed state. This means the toolbar is no longer visible and the web content is hidden behind a hider view with the current location text. 2. Tests that scrolling in the web content causes the thumb strip to open and close. 3. Tests that scrolling on the NTP causes the thumb strip to open and close. Bug: 1094335 Change-Id: I038fc784bd5c596de67b40ff547516b5d24a9cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627524Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#844512}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610948968-73b5b51cc98aa3edcd70782870e3aaa675f980cb.profdata to chrome-win32-master-1610959165-8386a0e84f434425b7043e7053c588f46a3ee84d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I37fd41da630cf4f78d4418ad9ca27e3ee1d05c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844511}
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. TBR=olka@chromium.org Bug: 1006541 Change-Id: If614c8e30a439956f7986af1d822683c70716247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627525Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#844510}
-