- 04 Apr, 2018 40 commits
-
-
Jochen Eisinger authored
All other logging in that file is DVLOG(1), so be consistent R=satorux@chromium.org Change-Id: I1c0dc9128cc3c681b6c26dd169fe73a7323af97b Reviewed-on: https://chromium-review.googlesource.com/975602Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#548202}
-
Marijn Kruisselbrink authored
Only record in OnError if callback_ is still set. Otherwise every success case will also result in recording "Aborted", via the destructor of the class calling OnError. Bug: 712693 Change-Id: I0d73119017b6d88fca4378687d5187ed96919b49 Reviewed-on: https://chromium-review.googlesource.com/994232 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#548201}
-
Pavel Feldman authored
Bug: 825771 Change-Id: I98e174f29538fadd104c61706766b28ab0b9db7d Reviewed-on: https://chromium-review.googlesource.com/994377Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#548200}
-
Yuqian Li authored
The flag removal would allow Skia to choose the better AA algorithm for a better performance. bug: chromium:817942 chromium:819185 chromium:817110 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I57f5b1c1ef88eb97172f8aa24be85b9f29c07b84 Reviewed-on: https://chromium-review.googlesource.com/976622Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#548199}
-
Evan Stade authored
- Some interfaces had separate functions for click and button click, while some used parameters to distinguish. Consolidate on shared functions. - Update some notifications to use HandleClickNotificationDelegate or ThunkNotificationDelegate. BUG=776205,755413 Change-Id: Ib133bdf93277c84c99311256c47a250d2b8e571f Reviewed-on: https://chromium-review.googlesource.com/963619 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#548198}
-
Wenzhao Zang authored
Bug: 820783 Change-Id: I267abfb965803de16b5f06d434b0c93783e10d8d Reviewed-on: https://chromium-review.googlesource.com/990729Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#548197}
-
Christopher Cameron authored
Move associated logic over to the browser process side, from the Cocoa side. Bug: 821651 Change-Id: I9c7ef8c3af841af6bfd855fc2982be277398b94a Reviewed-on: https://chromium-review.googlesource.com/991123Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#548196}
-
Fabrice de Gans-Riberi authored
|is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: I682e0aca08051f4c930ea7b3435bdf3ca0c91d2b Reviewed-on: https://chromium-review.googlesource.com/988811Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548195}
-
Scott Violet authored
This updates webkit, services and sandbox. Targets go from foo_features to foo_buildflags And similarly the header now has buildflags in the name. BUG=814485 TEST=covered by build Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: If082636e3f84033a3345d135847d5847436b6814 Reviewed-on: https://chromium-review.googlesource.com/992999Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#548194}
-
Matt Menke authored
With this CL, the NetworkContext owns URLLoaderFactories which own URLLoaders. Each class informs its parent when it can safely be destroyed. URLLoaderFactory::Clone() now adds another binding to the current factory, instead of creating a new one. URLLoaderFactories now stay alive as long as either they have at least one live binding or one live URLLoader. This change will allow a single URLLoaderFactory to own all shared starts URLLoaders created using it need, such as a URLLoader-specific side channel. The previous arrangement, where URLLoaderFactories could be destroyed before URLLoaders created by them, and Clone() created a new URLLoaderFactory, would have required reference counting all shared data, which can make code harder to follow, and lead to a wide array of lifetime issues. This change will also make it trivial to remove the use of URLRequestContextGetter from services/network. Bug: TODO Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I256743b79c333b2648964b03daf7105743d6c55e Reviewed-on: https://chromium-review.googlesource.com/988475 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#548193}
-
David Valleau authored
Screenshots of what the updated UI looks like on a device: - After the user tries to supply invalid PPD (https://screenshot.googleplex.com/omvyD9dhUNp) Bug: 820359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie4651ab9437a5f18b95e5240040e80e6e0ac271a Reviewed-on: https://chromium-review.googlesource.com/971469Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#548192}
-
Jacob Dufault authored
As part of PIN sign-in there is going to be an associated PinStorageCryptohome which calls into cryptohome to do authentication. TBR=battre@chromium.org Bug: 826773 Change-Id: Iaef1c0f669d620290e9a2503d1c46d69bafd0419 Reviewed-on: https://chromium-review.googlesource.com/990935 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#548191}
-
John Budorick authored
Bug: 783000,783001 Change-Id: I690ed41e7a6151f92d1253284a6b66ab87266672 Reviewed-on: https://chromium-review.googlesource.com/982388 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#548190}
-
Philip Rogers authored
DraggedNodeImageBuilder::CreateImage calculates the size and paint offset for drag images. After [1], the paint offset was the position of the dragged layout object in the enclosing layer's space. This was incorrect because a positioned descendant of the dragged object is painted in the drag image so the paint offset needs to be adjusted to the top-left of the bounding box of all content in the drag image (in the enclosing layer's space). This is easy to compute because we already have the bounding box in the enclosing layer's space, so this patch just uses the bounding box's location. [1] http://crrev.com/16b3d20c33 Bug: 820114 Change-Id: Idc634b3ddc79d0a47003362463b0c3d58f6f516c Reviewed-on: https://chromium-review.googlesource.com/996376Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548189}
-
Katie D authored
Fix flakes from SettingsAccessibilityTest.MANAGE_ACCESSIBILITY_aria_valid_attr_value by correcting the aria-described-by to be a valid element ID in manage_a11y_page.html. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9e3ed7c93136b39de2d800d8350e533776f0fe6c Reviewed-on: https://chromium-review.googlesource.com/996024Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#548188}
-
Kevin Marshall authored
This is a reland of 2a112566 , using a newer SDK build which addresses the symbol visibility issues that were causing the "new" operator to break. TBR=wez@chromium.org Original change's description: > Fuchsia: extend the size of the blobstore FVM at build time. > > This CL grows Fuchsia blobstore by a specified amount, large enough to > accommodate packaged executables installed at machine (QEMU) runtime. > > Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion > of fvm.blk. > > Bug: 798851, 707030 > Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6 > Reviewed-on: https://chromium-review.googlesource.com/987012 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547568} Bug: 798851, 707030 Change-Id: I62de331c46b38ed7adb460bf9f5e8335e3f54a02 Reviewed-on: https://chromium-review.googlesource.com/996273 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548187}
-
Fabrice de Gans-Riberi authored
|is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: Id7994872ce40ac1823591b87ec7ef0439d5a8b88 Reviewed-on: https://chromium-review.googlesource.com/988840Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548186}
-
Chris Hamilton authored
This is a helper component for tracking unloaded/loading/loaded state of a tab, abstracting away the logic from TabManager internals, and exposing it for use by external components. A follow-up CL will modify TabLoader to use it BUG=749785 Change-Id: I2edf254fdba190d2822f470257ea2226b459290e Reviewed-on: https://chromium-review.googlesource.com/938970 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#548185}
-
Michael Lippautz authored
The backing store write barrier is enough. Bug: chromium:757440 Change-Id: Id7aa827b2777b4060d4a5c6e2ba0849095f50abd Reviewed-on: https://chromium-review.googlesource.com/995477 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#548184}
-
Owen Min authored
Disable the test on Windows and Mac Tbr: mmenke@chromium.org Bug: 822614, 828927 Change-Id: Ia9437af60a80ab7468e20dc81e495aa10a893428 Reviewed-on: https://chromium-review.googlesource.com/996405Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548183}
-
Moe Ahmadi authored
The crash was being caused by trying to present the error view controller while the payment request's view controller was being dismissed. This CL fixes that by waiting for the payment request's main view controller to get dismissed before presenting the error view controller. Bug: 825827 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0a481c74d7fe654547c83ea3773d3533f1f8df11 Reviewed-on: https://chromium-review.googlesource.com/986467 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548182}
-
chaopeng authored
This crash is caused by query the page scrollbar theme settings after PLSA disposed paint layer. In this patch, we added a HasBeenDisposed check before query the page scrollbar theme settings to prevent the crash. Bug: 828523 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9c47e4daf88c78aa178e3d355e764639580628a9 Reviewed-on: https://chromium-review.googlesource.com/994337Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#548181}
-
Sammie Quon authored
Previously the settings icon would have its own icon set, but entering overview would change its icon to the favicon. Introduce a new window property kHasOverviewIcon which apps that do not need the favicon would set to true (currently only know to be settings). Test: manual Bug: 827619 Change-Id: I9ef99a7491ca3e3513a883c1d84e3e48894ae81a Reviewed-on: https://chromium-review.googlesource.com/991260Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548180}
-
Fabrice de Gans-Riberi authored
|is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Change-Id: Ic0292e13421cecacd54f49a981778cda746c08f0 Reviewed-on: https://chromium-review.googlesource.com/988839Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548179}
-
Patrik Höglund authored
Turns out I was wrong: the gcc builder must be migrated to LUCI before we can add it to the LUCI version of chromium.linux. For now, point to the builder that's actually working. Bug: chromium:776284 Change-Id: Ifffe4eaa634aad6ec95360ced04047b61c816315 Reviewed-on: https://chromium-review.googlesource.com/995492Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#548178}
-
Xianzhu Wang authored
This is a reland of 8bc8a796 Updated unit tests, and add comments to DisplayItemClient::SetDisplayItemsUncached() and PaintController::ClientCacheIsValid() (also made private). Original change's description: > [PE] Change CHECK to LOG(WARNING) in PaintController::FindOutOfOrderCachedItemForward > > The situation doesn't cause corrupted rendering but just slightly > affects performance. It's fine not to DCHECK given that the situation > is rare. > > Bug: 805024 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: Iac8cd617d5df51da2516fc6a9df1308a0daaedd0 > Reviewed-on: https://chromium-review.googlesource.com/990074 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547923} Bug: 805024 Change-Id: Ibcd443972c41b03cf03ea946da3c499987ad3b59 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/994339Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#548177}
-
Adam Langley authored
Change-Id: Iaeddffa11bdf0079b4c027356d3bc8d47f366bf1 Bug: 827575 Reviewed-on: https://chromium-review.googlesource.com/982633 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548176}
-
Andrew Grieve authored
//tools/binary_size/supersize now does a better job of analyzing these. Change-Id: I8fdf607c6985388dbb174f45bbfe8321046a5cf6 Reviewed-on: https://chromium-review.googlesource.com/995953Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#548175}
-
Derek Cheng authored
-max_len=N doesn't guarantee that libfuzzer won't ever try feeding a larger input into the target. So a check is added to the code to enforce the size limit. Bug: 828359 Change-Id: I2aa1404e618350896636de42a0ecc426946c8401 Reviewed-on: https://chromium-review.googlesource.com/996403 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548174}
-
Misha Efimov authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I10071ce60082dc66a4b63c57fe7ad53f51ccdac3 Bug: 812268 Reviewed-on: https://chromium-review.googlesource.com/985056Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#548173}
-
Filip Gorski authored
* This patch updates the bridge to use contextual suggestions object directly * It also wires peek_text to the bridge. Bug: 824182, 827656 Change-Id: Iae3f3cca90bf2d0fe97953d906e270438e1f203c Reviewed-on: https://chromium-review.googlesource.com/994456Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#548172}
-
https://pdfium.googlesource.com/pdfium.git/+log/28bb2f2ffe75..dc566b0a76f9 $ git log 28bb2f2ff..dc566b0a7 --date=short --no-merges --format='%ad %ae %s' 2018-04-04 hnakashima Fix XFA caret blinking only while mouse moves. 2018-04-04 thestig Parse "yy" correctly for AFDate_FormatEx(). 2018-04-04 dsinclair Decrease XML parser buffer size 2018-04-04 dsinclair [fwl] Restrict setting cursor outside text bounds Created with: roll-dep src/third_party/pdfium BUG=chromium:828561,chromium:436572,chromium:813195 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2515beeac588ea2d53d3caa6d92bae0165da4824 Reviewed-on: https://chromium-review.googlesource.com/996232Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548171}
-
Peter Kasting authored
This prevents a DCHECK failure when running infobar browser tests and manually closing the window with the infobar in it. BUG=none TEST=none Change-Id: Iad50464a5a538d9d6e167f7a2c1a22905902770d Reviewed-on: https://chromium-review.googlesource.com/991468Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#548170}
-
Douglas Creager authored
Change-Id: I427e544c6ebb732bb4873c1d2b1f8936d31d6c5e Reviewed-on: https://chromium-review.googlesource.com/996212Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Douglas Creager <dcreager@google.com> Cr-Commit-Position: refs/heads/master@{#548169}
-
Fabrice de Gans-Riberi authored
|is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: 812974 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I25c9a760ea6176935cb5bf946a9c5b499d93e640 Reviewed-on: https://chromium-review.googlesource.com/988793Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#548168}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36ee60c3..68c9ef31 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7c06a860ed13ae165dede96a3cd502003c9d3853 Reviewed-on: https://chromium-review.googlesource.com/995914Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#548167}
-
Dominic Mazzoni authored
This hooks up support for the MSAA put_accValue interface. Also refactors BrowserAccessibility::AccessibilityPerformAction to use a switch instead of a bunch of if statements. Bug: 828946 Change-Id: Ia9169a3156428ae371953f9cbad9c2c72311bd8f Reviewed-on: https://chromium-review.googlesource.com/996178Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#548166}
-
Bailey Berro authored
This change implements Remount on SmbProviderClient which calls Remount on the SmbProvider Daemon via D-Bus. Bug: 757625 Change-Id: I11b419863996e6bba685f14136e54d65db007d0a Reviewed-on: https://chromium-review.googlesource.com/987199 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#548165}
-
Katie D authored
This reverts commit cc52503a. Relands two tests, ACCESSIBILITY and TTS_SUBPAGE. Does not include the flaky test, which I will try to re-add separately with adjustments to make it not flake any more. TBR=hcarmona@chromium.org,zmin@chromium.org Bug: 823359 Change-Id: If81e79fb8ea9a4870eb3886198c41ca166e38fda Reviewed-on: https://chromium-review.googlesource.com/996016Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#548164}
-
Gabriel Charette authored
Instead it now always has a MessageLoop* and is allowed to use APIs which will soon no longer be exposed on MessageLoop::current(). This is a precusor cleanup extracted from https://chromium-review.googlesource.com/c/chromium/src/+/957760/7 in the broader effort to restrict usage of MessageLoop::current(). R=haraken@chromium.org Bug: 825327 Change-Id: I580fe360ff9630a5ffb40b89921c6889d449e67a Reviewed-on: https://chromium-review.googlesource.com/986813 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#548163}
-