- 26 Aug, 2019 40 commits
-
-
Clemens Arbesser authored
This is a reland of 8667827a Original change's description: > [Autofill Assistant] Adds action to use login credentials. > > This CL extends SetFormFieldValueAction such that it can also fill a selector with a previously stored username or password. To this end, the action is refactored to allow for better code reuse and readability. Also, the CL adds unit tests (not just for the new functionality, but for the entire action). > > > Bug: b/128833341 > Change-Id: I43e57bee5681047f1df954040f62265e0ab44f28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728560 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Stephane Zermatten <szermatt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689877} Bug: b/128833341 Change-Id: I87eadf3a335dec9244d5adf94cd004326ed52597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768422Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#690347}
-
Gabriel Charette authored
This is a reland of 0567f059 Reason for reland: - joelhockey@ fixed the chromeos build in https://chromium-review.googlesource.com/c/chromium/src/+/1767447 Original change's description: > Reland "Reland "Reland [base] Require task posters to specify an explicit destination"" > > This is a reland of d7b74986 > > As usual, if this fails **please** paste the build failure, not just > silent revert, logs can be hard to find in retrospect. > > Reason for reland: > - joenotcharles@ fixed the windows build in > https://chromium-review.googlesource.com/c/chromium/src/+/1764471 > - google chromeos build failure fixed in > https://chromium-review.googlesource.com/c/chromium/src/+/1764256 > > Original change's description: > > Reland "Reland [base] Require task posters to specify an explicit destination" > > > > This is a reland of dd34a877 > > > > Rebased on a few more fixes including a local full build of: > > - Windows + is_chrome_branded > > - ChromeOS + is_chrome_branded > > (except for the libassistant portion which is giving weird errors...) > > > > Original change's description: > > > Reland [base] Require task posters to specify an explicit destination > > > > > > This patch makes it a requirement for all task traits to specify their > > > thread affinity. Previously task traits that did not name a specific > > > thread would implicitly run on the thread pool, which could be > > > surprising. To make this more obvious, thread pool tasks must now use > > > the base::ThreadPool() trait. > > > > > > This is the final reland of > > > https://chromium-review.googlesource.com/c/chromium/src/+/1635827 > > > (will attempt to fix errors that caused original revert before > > > relanding). > > > > > > Bug: 968047 > > > Change-Id: Ice339db270a27815b2be68200930e5bc105e8a96 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759056 > > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > > Reviewed-by: François Doray <fdoray@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#688782} > > > > Bug: 968047 > > Change-Id: Iccd12e0a9f1535cb10b903777c5004a7d1acb34a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761362 > > Commit-Queue: Gabriel Charette <gab@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689097} > > Bug: 968047 > Change-Id: Ie338781aba9b5f5990ffe74e02bb85f08fe683d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764398 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689665} Bug: 968047 Change-Id: Idca1ec9ef83aad51def481b2ed4f8f1baf1385da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769080Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#690346}
-
Vasilii Sukhanov authored
TBR=estade@chromium.org Bug: 997649 Change-Id: I3649c29efaa2343f97b5d27cd5c124a033882a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768326Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690345}
-
Friedrich Horschig authored
The spacing around the footer hasn't been consistent across all sheets. This CL generalizes the class that was introduced by two of the three sheets and uses this spacing class in all of them. To fully fix the footer spacing, overscroll is now extended from 8dip to 64dip as shown in the mocks in the linked bug. Bug: 997611 Change-Id: I33f813b174a887f496413240efeebdaea3844426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768466Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#690344}
-
Vasilii Sukhanov authored
TBR=cjamcl@google.com Bug: 997669 Change-Id: I9f3bbb06ebbbed904c82acdb1b89d31d2b7fe09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771399Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c811fa7. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" d7f933bd "Revert "Started implementing the STAPIT algorithm"" d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 6a3beaa9 "[WPT/referrer-policy] Fix races around history.back()" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic5573cecf16ebd835e24e6262e36717790ce9bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771497Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690342}
-
Takashi Toyoshima authored
This is not required, but set for the non-NetworkService code path that does not exist any more. Change-Id: If282d1c49894302c0da22a7ecda4168afb4277c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771370 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#690341}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic4266954f4b667d12c38b4b4ebffa46fd28bccd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771538Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690340}
-
Antonio Gomes authored
... now that mediastream has been Onion Soup'ed and uses ApplyConstrainsRequests. BUG=704136, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1a02b3ea294c0a0d161bf4bff2070e96a4e47394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768779 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#690339}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/40ba72e3..afa3f633 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5b7331a747188188468133e9392065d089052e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771496Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690338}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Iccbef80bb12b1baf684089615470e807989058f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769499Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690337}
-
Antonio Gomes authored
... in renderer/modules/mediastream. WebApplyConstraintsRequest will be removed altogether in a follow up CL. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I06fc9a2ca93f2bcb924b2491676d3457e2dd1067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768778 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Vasilii Sukhanov authored
TBR=caseq@chromium.org Bug: 946990 Change-Id: I0ca05b3b30ac2e09f8852a5c24e6cdffa82a7967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768708Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a2dae38ee772..2ca0b3689f60 git log a2dae38ee772..2ca0b3689f60 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 peah@webrtc.org Correct the handling of sample rates that don't scale well into even 10 ms chunks 2019-08-26 yvesg@webrtc.org [vp9] Array temporal_up_switch wasn't properly initialized. 2019-08-26 nisse@webrtc.org New empty build target api:rtp_parameters 2019-08-23 peah@webrtc.org Use the AEC3 high-pass filter for the whole APM 2019-08-23 peah@webrtc.org Reland "Reland Process 8 kHz audio as 16 kHz internally of the audio processing module" 2019-08-23 artit@webrtc.org Revert "Reland Process 8 kHz audio as 16 kHz internally of the audio processing module" 2019-08-23 kthelgason@webrtc.org Add ObjC interface wrapping new GetImplementations method. 2019-08-23 titovartem@webrtc.org Fix flake in SamplesStatsCounterTest.FullSimpleTest 2019-08-23 kthelgason@webrtc.org Set required alignment to 2 for iOS. 2019-08-23 peah@webrtc.org Reland Process 8 kHz audio as 16 kHz internally of the audio processing module 2019-08-23 nisse@webrtc.org New const method StreamStatistician::GetStats 2019-08-22 jakobi@webrtc.org Save delays in history for 2 seconds instead of fixed 100 packets. 2019-08-22 orphis@webrtc.org Wire the stable target bitrate from GoogCC to the BitrateAllocator 2019-08-22 nisse@webrtc.org Delete unused function MediaTypeFromString 2019-08-22 kron@webrtc.org Don't include duplicated and incomplete frames in stats. 2019-08-22 peah@webrtc.org Reland "Simplification and refactoring of the AudioBuffer code" Created with: gclient setdep -r src/third_party/webrtc@2ca0b3689f60 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:677543,chromium:None,chromium:990317 Change-Id: Iac2af672b63a1d3689dde8f6d29787b2324078a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771537Reviewed-by:
-
Kush Sinha authored
With Chrome OS Account Manager enabled, SecondaryGoogleAccountSigninAllowed applies to the unified account list in Chrome OS Account Manager, and not just Chrome content area, as the policy documentation claims. Update the documentation to reflect this fact. Another related policy: AllowedDomainsForApps does not require any change. Bug: 967206 Change-Id: Ifde3d6c8a68fb2ec22006bb4cdcc1b0707f15351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768464Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#690333}
-
Stephen McGruer authored
Bug: 900581 Change-Id: I9cd2582aea4792c6bc0fa68f9bbf20f17a74a90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768551Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#690332}
-
Stephen McGruer authored
Bug: 900581 Change-Id: I3a9a292495b86ddf32ebfd67a1531d5995e5879a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769314Reviewed-by:
-
Stephen McGruer authored
Bug: 900581 Change-Id: I40b7d6f983d37726b843e82ad5ba794cec9c1214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768666Reviewed-by:
-
Yi Gu authored
This flaky test was fixed by crrev.com/c/1739386 and is no longer flaky. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=animations%2Fevents%2Fplay-state-initially-paused-start-event.html Bug: 994746 Change-Id: I1beb162bed54c2fef0e88685d03d13358c030786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770084Reviewed-by:
-
Friedrich Horschig authored
This CL removes hard-coded heights and paddings. They are superfluous since ChipView enforces its padding and restricts the line height. This means the duplicate paddings (see screenshots in bug) are gone. Bug: 997611 Change-Id: I805792254fced2c25c63fa75b4bc48021ff90fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769440Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b705a4e15ba7..ef4177b1f655 Created with: gclient setdep -r src-internal@ef4177b1f655 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4fe55b9551c97c51f13ad250e7606a9c5bcc0a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771295Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690327}
-
Mohamed Amir Yosef authored
Before this Patch: TwoClientPasswordsSyncTest were exercised against the 4 combinations of USS and non-USS clients. This caused some tests to be flaky. (check the linked bugs). After this patch: Since the plan is to roll out Sync USS Passwords for M77 (where all the 4 combinations have been tested already) we are now restricting the testing to only USS or non-USS to remove the flakiness. In case the rollout doesn't make it to M77, we should rethink about reinstating the tests again. Change-Id: I402f481723541a1a77314a8173a1144a1560cf77 Bug: 984944,980557,915219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768530Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#690326}
-
Vasilii Sukhanov authored
TBR=grt@chromium.org Bug: 997649 Change-Id: Ia928c720c08e56c39fac597e44d2bf2a6256680f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768465Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds logic to record whether the Password Leak Detection feature is enabled. Bug: 986298 Change-Id: I4d54a61f3b911ef894dbdb840a416ee0f6201037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763763Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#690324}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I3e93b3290299ead85123ae1d6c36ca0522f47580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768627Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690323}
-
Nikita Podguzov authored
This feature was launched year and a half ago, so we can safely delete this flag now. Bug: 995586 Change-Id: I1423340c242893449087af4395fca66f2c9c105b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764192 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#690322}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink.mojom.InsecureInputService interface. Bug: 955171, 978694 Change-Id: I7cda634077cc44e3b797929ff41c48bd6a9f3c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762212Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#690321}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/271fe862460b..b705a4e15ba7 Created with: gclient setdep -r src-internal@b705a4e15ba7 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I0437dafd9eb71ed41a10c969193b3c268417bfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771292Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink.mojom.EmbeddedFrameSinkClient and blink.mojom.EmbeddedFrameSinkProvider interfaces. Bug: 955171, 978694 Change-Id: I243ae820f696410f1b23b894823ef8ebb168558a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764155 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 65f87ce1. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 4afcd1a6 "Started implementing the STAPIT algorithm" d7f933bd "Revert "Started implementing the STAPIT algorithm"" d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 6a3beaa9 "[WPT/referrer-policy] Fix races around history.back()" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8cef577c762b534931a225d759b2334b8f3415cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770483Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/734d60f63cfa..7d1d3b9a0e93 git log 734d60f63cfa..7d1d3b9a0e93 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 wl@gnu.org [type1] Fix `FT_Get_Var_Axis_Flags' (#56804). Created with: gclient setdep -r src/third_party/freetype/src@7d1d3b9a0e93 The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I622f21a277f0a3efcd803e9717fae66096e55513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771377Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3c6b2e1613c8..39e2669a3e92 git log 3c6b2e1613c8..39e2669a3e92 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src aef8f92b2bb6..1eb89172a82b (3 commits) Created with: gclient setdep -r src/third_party/angle@39e2669a3e92 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: chromium:None Change-Id: I3d8a9b3f7c68e5557dac6ad22487f9efb0affce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771291Reviewed-by:
-
Clemens Arbesser authored
This is a reland of 8ee4ef1c Original change's description: > [Autofill Assistant] Let payment request action collect login details. > > This CL adds a new optional section to the payment request: Login details for <domain>. The intent is to let users choose from a list of login options such as 'guest checkout' and 'username@example.com'. Currently, the list may contain custom options (like 'guest checkout') as well as login details stored in the Chrome password manager. The chosen login option is returned to the server. In the case of Chrome PWM logins, the chosen login details are stored in client memory. > > As a special case, if there is no meaningful choice to make in the login section, the section is not shown and the choice is made implicitly. > > This CL only adds the required changes to query and store the login details in the client. There will be a separate CL to read the login details from client memory and autofill the username/password fields. > > Screenshots of the new feature: > - Collapsed: https://screenshot.googleplex.com/uUrpn6jatko.png > - Expanded: https://screenshot.googleplex.com/RKNxrjLvMcJ.png > > Bug: b/128833341 > Change-Id: I204a471f67a3f8856cead71080dd5184846c2090 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713559 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org> > Reviewed-by: Stephane Zermatten <szermatt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689488} Bug: 997124 Bug: b/128833341 Change-Id: I3d01c2cc502dfe36325a98223a147e5c1a50e179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768519 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Christian Dullweber authored
Set NetworkIsolationKey for LoadBasicRequest() in browser_test_utils.cc Similar to site_for_cookies, the NetworkIsolationKey is set to the origin of the url that is requested. Bug: 989067 Change-Id: Idf25303d3fecb0079ab74184765d66999649ae64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764198Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#690314}
-
Antonio Gomes authored
... instead of stack allocated. This is a precusor CL for making use of ApplyConstraintsRequest directly in user_media_client.cc|h and apply_constraints_processor.cc|h, instead of its Blink-exposed wrapper class, WebApplyConstraintsRequest. This is needed because ApplyConstraintsRequest is GC-ed by OilPan, so being UserMediaClient::Request the class that will own it, it needs to be (Oilpan) heap allocated. In a follow up step [1], it was changed to on-Oilpan-heap allocation. [1] https://crrev.com/c/1768778 BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I7b3965d892f99a93d12d65ffee3140f08caafbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768789 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Jose Dapena Paz authored
IWYU: std::unordered_map with value type OptimizationGuideNavigationData requires that type declaration Fix compilation in GNU stdc++ due to missing declaration of the full type: ../../chrome/browser/optimization_guide/optimization_guide_web_contents_observer.h:22:7: note: forward declaration of ‘class OptimizationGuideNavigationData’ class OptimizationGuideNavigationData; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bug: 957519 Change-Id: I9d792c0f288d6544e10cd419adf4d845535aaea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768337Reviewed-by:rajendrant <rajendrant@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#690312}
-
Fredrik Söderquist authored
Since we return false for 'display: contents' in the relevant LayoutObjectIsNeeded() override, we shouldn't need to check for it again here. Bug: 997176 Change-Id: I589ea2291aa2ef31a6ea68d5e8a882251f587ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768459Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#690311}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink.mojom.CrashMemoryMetricsReporter interface. Bug: 955171, 978694 Change-Id: Id46e1be52ee85bbc774171badc1a789b26b62edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761275 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#690310}
-
Chris Harrelson authored
The feature has been in stable for > 2 years. Change-Id: Ibf9969d1cb85ede86280c89e26a30e579522fe14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766456Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#690309}
-
Koji Ishii authored
r690293 crrev.com/c/1768486 fixed the same DCHECK signature, hence removing from TestExpectations. TBR=eae@chromium.org Bug: 992920 Change-Id: Ib84cd2edfd795e6af6e84a001715ff49d66d0d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771362Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#690308}
-
