- 21 Jun, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d3cca8117636..ce6b75e9ac47 Created with: gclient setdep -r src-internal@ce6b75e9ac47 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Id984fe27620e226c0f739cf9380fa90ecbb407e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670700Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671394}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ff9f9ea..58dbd381 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d672762bd5fcaec6ae618779c392099dbda738a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669086Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671393}
-
Mohamed Heikal authored
Using relative paths was causing build failures. To create this change: * find out/Debug -name *_jni.h -delete * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; * ninja $ALL_JNI_HEADERS minus third_party, chromecast, cronet, libassistant * refactor_jni_includes.py --out-dir out/Debug * fix DEPs files manually * split out media/ changes into this cl See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI for discussion on naming scheme. Bug: 964169 Change-Id: I6578acc70af2df7334dc3512540ca20813e5098c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671008 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#671392}
-
Matt Menke authored
This CL does not add a way to specify the NetworkIsolationKey through the NetworkContext's preconnect API, which I'll do in a followup CL. Bug: 966896 Change-Id: I561bfca7a31505baf1c8b48a28bdc901963c92dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670312Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#671391}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/514727027113..6caa1897fd2c git log 514727027113..6caa1897fd2c --date=short --no-merges --format='%ad %ae %s' 2019-06-21 thestig@chromium.org Fix lots of nits in xfa/fwl code. 2019-06-21 thestig@chromium.org Remove some unneeded cfx_renderdevice.h #includes from headers. 2019-06-21 thestig@chromium.org Move class TextCharPos into its own file. Created with: gclient setdep -r src/third_party/pdfium@6caa1897fd2c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I5123f45e7d69347ea9ebde64c490e2f3b014fe42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670697Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671390}
-
Josh Nohle authored
Bug: 951969 Change-Id: Ia186a0c0f7a0785220ecc7641cfcbfafd455ee19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671050 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#671389}
-
Thomas Anderson authored
This reverts commit 47efe3b5. Reason for revert: Necessary CL possibly rolled into src-internal Original change's description: > Revert "Roll GN from 81ee1967 to 8c7f4910" > > This reverts commit 221c6f3d. > > Reason for revert: ChromeOS build failures; see https://crbug.com/974835. > > Original change's description: > > Roll GN from 81ee1967 to 8c7f4910 > > > > https://gn.googlesource.com/gn.git/+log/81ee1967..8c7f4910 > > > > 8c7f491 rust: fix build on older clang by Tomasz Śniatowski > > 8f8178c Escape prerequisites filenames in build.ninja.d depfile by samogot > > 89d5ef5 Minor fixes to tracing by Julie Hockett > > ae93998 An example Rust build by Julie Hockett > > 80a5dc0 Ninja rules for Rust by Julie Hockett > > e906492 Rust GN target generation by Julie Hockett > > 586b028 Rust compilation tool and toolchain support by Julie Hockett > > ed8b690 rust_library and Rust-specific variables by Julie Hockett > > 5b16fb9 Rust substitutions and config values by Julie Hockett > > b89110a Move SourceFileTypeSet to Target by Julie Hockett > > 95a92a9 [espace.h] fix comment by Takuto Ikuta > > 17cc456 json_project_writer: Output response_file_contents for action and action_for_each by Kimmo Kinnunen > > 36c66bf Add additional surce files and example the list of acceptable files by Julie Hockett > > 04f5df5 [args] Fix gn args unstable output by Haowei Wu > > bc3fe2a [gen.py] Use relative -I switches and source paths by Roland McGrath > > 8730b0f Disallow non-buildable sources in binary targets by Tom Anderson > > 0d038c2 Cache source file type in SourceFile by Tom Anderson > > > > BUG=964411 > > R=dpranke > > > > Change-Id: Ib9ea522a075fba2ca81b91ab347731a7829901b9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650093 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#669546} > > TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org > > Change-Id: Icf28406f4f204a5814cbd0d305f2508240df0dc5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 964411 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660809 > Reviewed-by: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669716} TBR=thakis@chromium.org,dpranke@chromium.org,xiaohuic@chromium.org,sdy@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. TBR=dpranke Bug: 964411 Change-Id: I6918691612d8f4aa3899aa3b2ecf6b3f9e5c02fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664207 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#671388}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/954ecb026c5a..11bc2d513286 git log 954ecb026c5a..11bc2d513286 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 ilkos@google.com Merge "Separate the actual trace to pprof conversion" Created with: gclient setdep -r src/third_party/perfetto@11bc2d513286 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I417b2399ae04aa846e6be516fee1f26ddf285944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670696Reviewed-by:
-
Alexander Hendrich authored
This CL refactors schema.h/.cc by: * replacing all deprecated calls to base:Value with their modern replacements (i.e. GetAsDictionary(), HasKey(), etc). * replaces usage of base::DictionaryValue with base::Value * uses range-based for loops with proper usage of auto& Bug: none Change-Id: I3b3c4552c727bbb3e922579d7bb75b68b94c5af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646773 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#671386}
-
Edward Wang authored
Bug: b/134656880 b/134444097 Test: Build and Run Change-Id: Idf225dfcb6a8fa1cf59de207149b764b658a94fa Signed-off-by:
Edward Wang <wangedward@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668537Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#671385}
-
Lucas Furukawa Gadani authored
Bug: 952584 Change-Id: Id88831da6fe68f6e9c295810231d768718d57ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671017 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671384}
-
Henrique Nakashima authored
Create DownloadOfflineContentProviderFactory, a SimpleKeyedServiceFactory that creates and maintains ownership of DownloadOfflineContentProviders associated to ProfileKeys. This gets rid of Android-specific globals and platform-specific ownership in DownloadCoreServiceImpl. Change-Id: Iabee9d98f961849ebdfb35c678cf625db605705f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664995 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671383}
-
Ben Kelly authored
Bug: 957175 Change-Id: Ib2efb5c6579baa0b0e602a059ef97691c04245ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669613Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#671382}
-
Nina Satragno authored
Check that the Relying Party and User icon URLs are a priori-authenticated URLs on the browser side. This check is repeated on the content layer, so the renderer is killed if the check fails. Bug: 957158 Change-Id: Iede025fd53a7b30e5971accc07d4e73a94b29d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669174Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#671381}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c7a773b6fa9a..712f0a7bd31d git log c7a773b6fa9a..712f0a7bd31d --date=short --no-merges --format='%ad %ae %s' 2019-06-21 robertphillips@google.com Fix up wacky_yuv_formats GM 2019-06-21 herb@google.com Start using new APIs for bounds and glyph lookup 2019-06-21 nifong@google.com Reland "Deserialize MultiPictureDocument based SKP files (with image sharing proc) in wasm debugger." 2019-06-21 jvanverth@google.com Fix Mac viewer on command line launch. 2019-06-21 brianosman@google.com ByteCode: Faster eval in getLocation, add safety for double side-effects 2019-06-21 mtklein@google.com rearrange code,data -> data,code Created with: gclient setdep -r src/third_party/skia@712f0a7bd31d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:9176 TBR=bsalomon@google.com Change-Id: Ibafd99db3019280c6eef123fab2da4f901aa7629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670693Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6dc0eea4cbfd..fd047540b0cd git log 6dc0eea4cbfd..fd047540b0cd --date=short --no-merges --format='%ad %ae %s' 2019-06-21 rmhasan@google.com [Telemetry] Add new methods to get tags for Typ's test expectation format Created with: gclient setdep -r src/third_party/catapult@fd047540b0cd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973936 TBR=sadrul@google.com Change-Id: I38c164e1b1958cab31dab7997cc30fc5538c9c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670695Reviewed-by:
-
Jon Mann authored
When a cellular dongle is removed and quick settings is already opened the now empty "Mobile Data" section was previously shifting to the bottom instead of being removed. Bug: 812337 Change-Id: I5082e383220e7c6bb66a34e2435425cbf4dbdd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670412Reviewed-by:
-
Anne Lim authored
Changed art_file_url to art_fife_url in WalletMaskedCreditCard. Change-Id: Icf9d3b9a98580ac77b91d04c15c3018644a41aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668511 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#671377}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f1465c8cf20f..4c41a603c536 git log f1465c8cf20f..4c41a603c536 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 evanhernandez@chromium.org Revert "test: ChromiteUnitTest also logs stderr" Created with: gclient setdep -r src/third_party/chromite@4c41a603c536 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I853c2dc8afebe1d321e8d4b8c1148d5aa78f84ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670694Reviewed-by:
-
Peter Kotwicz authored
This CL renames the resource directories based on whether the resources should be uploaded to the googlestorage build bucket. WebAPKs have 3 types of resources: Type #1 Resources which are not processed by the client and uploaded to the googlestorage build bucket. The server might further process these resources. Type #2: Resources which are processed by the client and then uploaded to the googlestorage build bucket. Type #3: Resources which are not uploaded to the googlestorage build bucket. The server uses icons from the Web Manifest to populate these resources. This CL moves resources of Type #1 to the to_upload/ directory R=hartmanng TBR=wnwen (For editing suppressions.xml due to rename) BUG=None Change-Id: I15b1633e772ec971b1ce2ae976ec060123abefdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650270Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671375}
-
David Black authored
For security reasons, URL loader now prevents setting of request headers that are deemed unsafe. When such headers are set, the request is terminated. This breaks Assistant which currently sets Content-Length headers which are considered unsafe. Until changes can be made in LibAssistant to cease setting these unsafe headers, we need a workaround to unbreak Assistant. This CL checks Assistant's ChromiumHttpConnection when setting request headers to ensure that the headers we are setting are considered safe. If not, those headers are dropped and logged, but the request will be permitted to proceed. The logic that checks for unsafe headers is also moved to a new public API in services/network/public/cpp for visibility. Bug: b:135644733 Change-Id: Ic889037edfaf75a465c33bb4573ea0d717670910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669431 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#671374}
-
Vasilii Sukhanov authored
The two histograms are deprecated: - PasswordManager.NumPasswordsDeletedDuringRollback was unused. - PasswordManager.NumPasswordsDeletedByBulkDelete isn't interesting. Bug: 975553 Change-Id: I93df2bc622e156f32b7d076a414dfdbed2650fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669940 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#671373}
-
Juan Antonio Navarro Perez authored
Replaced with py_utils.WaitFor Bug: 977594 Change-Id: I7418dc2da07203c565d0ecc9ad08fdbf7bba821b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670878 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#671372}
-
Fred Mello authored
TBR=agrieve # Trivial change in //device/vr Bug: 952859 Change-Id: I67ce4945ef0f136a0581bd86d2cb16c37f9126d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667334 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671371}
-
David Schinazi authored
This change also refactors the quic_test_packet_maker to only have one place where it creates QuicPacketHeaders. Change-Id: I504e5d0b4904e262b862a84dd0b37196f65c3e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670270 Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#671370}
-
Ashitha Santhosh authored
Updated GLImageDXGISwapChain to use EGL Images instead of pbuffer surfaces, to avoid creating render target view for front buffer. Bug: 939655 Change-Id: Iec80f399724ee0509dd95d126c0d3dbb883bb87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663014Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Ashitha Santhosh <ashithasantosh@google.com> Cr-Commit-Position: refs/heads/master@{#671369}
-
Sami Kyostila authored
Minor code cleanup. No functional changes. Bug: 849324 Change-Id: Iaf07ae8b2adc48e2bb32aa4ce885966c1bc1a120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670896 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
khachatryan authored
A 'New Window' endpoint was recently added to W3C spec and it is implemented in ChromeDriver build revision 665612. Bug: chromedriver:2690 Change-Id: I9ad99606b5379883422410998a8ece46678710f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670367Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#671367}
-
Scott Graham authored
Add a define to help make base/numerics suitable for use in constrained environments. BASE_NUMERICS_DISABLE_OSTREAM_OPERATORS removes a few uses of ostream. This is motivated by attempting to use base/numerics in the Fuchsia kernel. ostream is simply unavailable, but what's lost is fairly minor. This is part of a downstream CL from johngro@: https://fuchsia-review.googlesource.com/c/fuchsia/+/292396 Change-Id: I1d7a2651e50d8e62c143b048f253b1f4c32971cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669874Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671366}
-
Dan Beam authored
This reverts commit b1a33e63. Reason for revert: Broke Cast Linux bot's compile step https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8910020556818377216/+/steps/compile/0/stdout Original change's description: > [FCP++] Text: Replace node_id with LayoutObject* - part 1 > > FCP++ is currently using node_id to track a layout object. But > we should use LayoutObject* instead to track the nodes. The replacement > will be more efficient and avoid the generation of node id. > > After we use layout object* in text record, we start to get a risk of > UAF. UAF happens when we stop recording, block the LayoutObject > removal hook by is_recording_, and use LayoutObject* in > PopulateTraceValue. The fix to it is to clear up everything > > We also noticed a risk of using |this| in two callback functions, but > it proved to be not a real risk in crbug.com/976357 > > |cached_largest_paint_candidate_| was raw pointer. It's better to be > a WeakPtr so no risk of becoming a dead pointer. > > Note that this CL is mainly to replace node_id with LayoutObject* in > TextPaintTimingDetector's sets & maps. A subsequent patch will be made > to replace node with LayoutObject in the control logic of > TextPaintTimingDetector. And do the same thing for > ImagePaintTimingDetector. > > Bug:967837 > > Change-Id: Iba0496cfca3f5056724c3267ec10226913d4e70e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649467 > Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671360} TBR=wangxianzhu@chromium.org,maxlg@chromium.org Change-Id: Icfc663fe1c7033505a34916b1ce4e62ad0cc937e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 967837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669919Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#671365}
-
Mohamed Heikal authored
Using relative paths was causing build failures. Most of base has already been fixed, this is just fixing the sample/example code. Bug: 964169 Change-Id: Ief41aca3602ddfa567426147ae60021d6130ad7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669077 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#671364}
-
Henry Jian authored
Because Android doesn't distinguish between text files and naked text, a WST can receives naked text while it only expects text files. Vice versa, a WST can receives text files while it only expect naked text. The solution of this problem is for WSTs that accpets either text files or naked texts (not both) to automatically convert text files to naked texts and naked texts to text files. Bug: 951878 Change-Id: I853e2b95e339975ee39051f69e36ec9f40efc1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653326Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Henry Jian <hzjian@google.com> Cr-Commit-Position: refs/heads/master@{#671363}
-
danakj authored
The ChromeBrowserTestApplication needs to be able to provide a DiscardableReferencePool, and in that case the ChromeApplication does not exist. Move the global DiscardableReferencePool into a GlobalDiscardableReferencePool object. Have ChromeApplication and ChromeBrowserTestApplication both instantiate the GlobalDiscardableReferencePool. Then change places that look for ChromeApplication to get the DiscardableReferencePool to look instead for the GlobalDiscardableReferencePool. R=dtrainor@chromium.org Bug: 961849 Change-Id: I9613826bc12fc7c78d6e52029f71a1eeb4f6aa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670279 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#671362}
-
Julien Isorce authored
Recent change uses newer VAProfiles that require vaapi 1.2 (libva 2.2) Just guard them so that we can still build chromium+vaapi on official Ubuntu 18.04 ( https://launchpad.net/ubuntu/bionic/+source/libva ) Regression introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1663173 Bug: 973526 Change-Id: If2068d33ead1cd3e204360f4c6fc4658f9e4f9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670247 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#671361}
-
Liquan(Max) Gu authored
FCP++ is currently using node_id to track a layout object. But we should use LayoutObject* instead to track the nodes. The replacement will be more efficient and avoid the generation of node id. After we use layout object* in text record, we start to get a risk of UAF. UAF happens when we stop recording, block the LayoutObject removal hook by is_recording_, and use LayoutObject* in PopulateTraceValue. The fix to it is to clear up everything We also noticed a risk of using |this| in two callback functions, but it proved to be not a real risk in crbug.com/976357 |cached_largest_paint_candidate_| was raw pointer. It's better to be a WeakPtr so no risk of becoming a dead pointer. Note that this CL is mainly to replace node_id with LayoutObject* in TextPaintTimingDetector's sets & maps. A subsequent patch will be made to replace node with LayoutObject in the control logic of TextPaintTimingDetector. And do the same thing for ImagePaintTimingDetector. Bug:967837 Change-Id: Iba0496cfca3f5056724c3267ec10226913d4e70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649467 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671360}
-
Brian White authored
Some metrics have been removed while others have had their expiry extended to M90. Many calls have also been changed from (caching) macros to function calls to reduce code size where performance is unnecessary. Bug: 975604 Change-Id: I7786867ca1ac5c1625b7e67b3e818caba7c63783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669103Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#671359}
-
Gil Dekel authored
Micro nit CL. Bug: 877694 Test: jpeg_decode_accelerator_unittest Change-Id: Id7d8321615e74d36668fc8b1ef2bd54703da6967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669914 Commit-Queue: Gil Dekel <gildekel@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#671358}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c7a4c0959ca..d3cca8117636 Created with: gclient setdep -r src-internal@d3cca8117636 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Iec58d3671c66e9a6fd4905bafd9fd27b9e876abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670928Reviewed-by:
-
Rakesh Soma authored
the client device via GCPW. Bug: 976543 Change-Id: Iadfc198438c3dc13f0dcfb688b26c41fcd08dfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659512 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#671356}
-
danakj authored
We move the ApplicationStatus.initialize() call up to the base class since they all need to do it. We also initialize the CommandLine there as it needs to be initialized from the Application. The ChromeTabbedActivity would crash during startup when it tries to use the CommandLine otherwise. Do the same in NativeTestApplication base class, instead of in NativeTest, for consistency. This prevents the CommandLine from being destroyed in NativeTest after the NativeBrowserTestApplication has already set it up and is running. Bug: 961849 Change-Id: I715d91fb1b251d4dbbb51e2b60760fb1cc95bc97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670349Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
