- 06 Dec, 2017 40 commits
-
-
Xianzhu Wang authored
Bug: 777259 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id10b46d54508fc3332c2a20336deaa0f74027554 Reviewed-on: https://chromium-review.googlesource.com/806441 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522178}
-
Julia Tuttle authored
Bug: Change-Id: Iab20bd4453111727924d9eb7de040e6a48c13909 Reviewed-on: https://chromium-review.googlesource.com/811825Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#522177}
-
Dianna Hu authored
This CL was intended to change ssize() to size(), but the change to use ssize() was not merged, so this CL is mostly a no-op (except for some minor convergence opportunities). This CL lands server change 177314606 by sbenza. BUG=488484 Change-Id: I14358dc6888026ad59fd0a8e48b52147637b6c51 Reviewed-on: https://chromium-review.googlesource.com/809846 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522176}
-
Stefan Zager authored
A few more layer tree dumps. BUG=711468 Change-Id: I8648cd7070f43a0bddc0bde24f7a30cfe93b0433 Reviewed-on: https://chromium-review.googlesource.com/809847Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#522175}
-
Devlin Cronin authored
The AutomationInternal API currently passes the RenderView routing ID to the API implementation for enableTab and enableDesktop. This routing ID is then stored, and used to "route" a response IPC (ExtensionMsg_AccessibilityEvent or ExtensionMsg_AccessibilityLocationChange) back to the renderer. However, the listener in the renderer is, in fact, just an IPCListener that attaches itself to the main RenderThread. It doesn't look at the routing at all. Thus, we don't need the routing ID for the browser to send the message, and, since that's the only place it was used, don't need to send it in the API params. Remove the routing ID parameter from both automationInternal.enableTab and automationInternal.enableDesktop, and update the IPC messages. Bug: 304341 Change-Id: I3a82ab3193c70e7cf8694277e28c82c47f431ce4 Reviewed-on: https://chromium-review.googlesource.com/721268Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522174}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I41e47e5c6e6ed7ad350dfb0d5ddf79dd4774e3a5 Reviewed-on: https://chromium-review.googlesource.com/810011Reviewed-by:
Krishna Govind <govind@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#522173}
-
Lukasz Anforowicz authored
The LazyInstance::operator== removed by this CL is undesirable, because 1) it didn't have a corresponding operator!= 2) it was only used to compare against nullptr (i.e. to check if the lazy instance was created already or not) This CL removes LazyInstance::operator== and replaces it with LazyInstance::IsCreated() method. Bug: 789738 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idfbb4a9f0699cb10f3f861860070b7f316a16ad6 Reviewed-on: https://chromium-review.googlesource.com/792124Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#522172}
-
Charles Harrison authored
This CL abstracts some logic for "click position" to be shared by both the popup tab helper, and the framebust tab helper. Additionally, it stores a closure on the framebust tab helper to be associated with each individual entry. This is used to collect metrics for tab-under blocking on desktop. Bug: 661629 Change-Id: Ibdc043c1d3068c38dad304be42b2d48133b3f21e Reviewed-on: https://chromium-review.googlesource.com/809098 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#522171}
-
Doug Arnett authored
There is an issue with not having the previews state bits cleared per server previews response headers in the UI thread. This causes an issue for an HTTP->HTTPS redirection that preforms NoScript preview - the previews state confused the PreviewsInfoBarTabHelper. This is a patch to fix M64 Dev channel. The proper fix (setting previews state consistently is a separate change in progress for M65). Bug: 792275 Change-Id: I28788c608ef37f208edbc72df7602294f56995f5 Reviewed-on: https://chromium-review.googlesource.com/811626Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#522170}
-
Derek Cheng authored
Move screen availability logic PresentationDispatcher into Blink code. A new class, blink::PresentationAvailabilityState, is introduced to keep track of the availability and listening states of PresentationAvailability objects. PresentationAvailabilityState is owned by blink::PresentationController and shares its PresentationService mojo ptr to communicate with the browser. Also rename PresentationServiceClient Mojo interface to PresentationController (in parallel with PresentationReceiver). With the rename, we also move its implementation from PresentationDispatcher into blink::PresentationController. This allows us to remove WebPresentationController and WebPresentationAvailabilityObserver. This patch also fixes a bug (which also leads to layout test flakiness) where Mojo message pipes for PresentationService/PresentationController are not removed on navigation. This is fixed by resetting the bindings and mojo ptrs in PresentationServiceImpl::Reset. We also reset the PresentationService mojo ptr in PresentationDispatcher::DidCommitProvisionalLoad as a temp fix while PresentationDispatcher still remains. Bug: 749327, 761561 Change-Id: I8834f130fdc70879119ee81eeaf5b5965fec9098 Reviewed-on: https://chromium-review.googlesource.com/724724Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#522169}
-
Maks Orlovich authored
This concerns the following scenario: Suppose you have a transaction t1, with a cache entry e1. Then t2, with entry e2 comes in, becomes definitive for the same URL, and gets t1 to doom its entry. The following sort of interleaving of events is possible: doom(e1) t2.writeInMemoryCacheHints() t1.writeInMemoryCacheHints() At this point a cache read later will have memory hints based on t1, but cache contents based on t2. Bug: 787958 Change-Id: I8c42d975fdbf8f6d1fb76238a71ee383842a8576 Reviewed-on: https://chromium-review.googlesource.com/791154Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#522168}
-
gogerald authored
TBR=khushalsagar@chromium.org,chrishtr@chromium.org Bug: 792540 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0fb45968230846c0ffb8168d8d31a87bad06fcb5 Reviewed-on: https://chromium-review.googlesource.com/811588Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#522167}
-
Vincent Scheib authored
Comment only changes to explain the different Bluetooth testing APIs. TBR: scheib@chromium.org Change-Id: I04329dd47f485c2e1042f7287ac05b160599ead4 Reviewed-on: https://chromium-review.googlesource.com/810087Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#522166}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/12a18ad357bc..10a4d43462fa $ git log 12a18ad35..10a4d4346 --date=short --no-merges --format='%ad %ae %s' 2017-11-28 xinghua.cao ES31: Enable some dirty bits and dirty objects for compute pipeline Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Iece21897477d2beb8aafb5846545737a151cbba0 Reviewed-on: https://chromium-review.googlesource.com/811449Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522165}
-
Morten Stenshorne authored
It's unclear what it attempted to test. The file name suggests something with margins, but there are no margins in the test. Furthermore, the ref assumes a buggy intrinsic width calculation: There are four words of column content. The max-content-width should be so that the multicol container can hold all the four words on the same line. There are four columns too, so the multicol container actually has to be rather wide. If column-gap is 1em and each character and non-collapsable whitespace also is 1em wide, the width of the line of text will be 4+1+4+1+4+1+4em = 19em. That's the column width we want. But we have 4 columns, so multiply that by 4 -> 76em. Add the 3 gaps between the 4 columns -> 79em. I.e. 1264px if the font-size is 16px. The ref assumes way less than that (22em). Bug: 788337 Change-Id: I076af29bf53914557c40b5e438b5eebfb8439e42 Reviewed-on: https://chromium-review.googlesource.com/811645Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522164}
-
Reilly Grant authored
When SensorProviderProxyImpl receives a connection error on its SensorProvider pipe it should forward that upstream to its clients so that they observe the error instead of never receiving a callback to their GetSensor requests. Bug: 792222 Change-Id: I36f11df4b4ec58631ffd67f07dc1143d65a809f5 Reviewed-on: https://chromium-review.googlesource.com/809922Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#522163}
-
Katie Dektar authored
Fixed positioned elements are not clipped by their ancestors, except by the rootWebArea. Similarly with absolutely positioned elements, except if they have an ancestor with some non-static positioning. Bug: 792124 Change-Id: I9c31c90fed89179434ae7f89aa18528e929348da Reviewed-on: https://chromium-review.googlesource.com/809828 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522162}
-
Matthew Jones authored
This change refactors much of the progress bar code in an effort to simplify the logic that has grown out of control. The significant changes are as follows: - The smooth progress animator runs until progress is finished instead of ending when progress reaches the current complete percentage. - 'finish(...)' is blocked until the progress animators are complete unless it is called with 'fadeOut' set to false (see todo in code). - 'updateVisibleProgress' has been removed as its function had become unclear. - More complete tests to exercise the different functionality. BUG= Change-Id: I95ff4c5918bccaac5bc1ef025254caea13a862c2 Reviewed-on: https://chromium-review.googlesource.com/769772 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#522161}
-
Yuzhu Shen authored
It is only used by the old-style Mojo JS bindings, which have been removed. Bug: 718047 Change-Id: Ib3e112f8b2a9cd772bb15146ee52eb1de63b2eff Reviewed-on: https://chromium-review.googlesource.com/809772 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#522160}
-
Sandra Sun authored
The failure is likely caused by the scrollbar thickness varied across platforms. So I use MaiximumScrollOffset as expected value in test. This patch also check nullptr when getting ScrollableArea to fix a clusterfuzz failure in the previous patch. This is a reland of a9783e12 Original change's description: > Snap at GestureScrollEnd on main thread. > > As the first step of ScrollSnapPoints, this patch implements it on main > thread at GestureScrollEnd. It introduces necessary data structures: > SnapAreaData and SnapContainerData, updates the data after style change > and layout, implements a naive algorithm to select snap points at > intended-end-position, adds unit-tests for logic and adds sim-tests for > behavior. > > Bug: 778257 > Change-Id: I307d51254bd9ab9b7a42b0614d181adac662fa47 > Reviewed-on: https://chromium-review.googlesource.com/756887 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521840} TBR=bokan@chromium.org,jbroman@chromium.org,majidvp@chromium.org,shend@chromium.org Bug: 778257 Change-Id: I437e7491c4a98c8ecaa5b15124c48e97e60fa57a Reviewed-on: https://chromium-review.googlesource.com/810059 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#522159}
-
Sammie Quon authored
Suggestion from oshima@ and xdai@ from https://chromium-review.googlesource.com/c/chromium/src/+/767044 but already commited when seen. Test: ash_unittests SplitViewControllerTest.LongPressExitsSplitView Bug: 784013 Change-Id: Ib4123316e78060c4dbab86eb27dd193b8c888d9f Reviewed-on: https://chromium-review.googlesource.com/798638 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#522158}
-
Katie Dektar authored
NOTRY=true Change-Id: Icc55d5cb438f4f74fb2b8ba66046375262844c08 Reviewed-on: https://chromium-review.googlesource.com/811292Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Katie D <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#522157}
-
Jacob Dufault authored
The views-based login screen shows the users on the device and the basic login flow works, but lots of additional features, such as registering a new user, do not work yet. Bug: 784495 Change-Id: I67ee83d1ca84fedf465882a90e6be47e6b079967 Reviewed-on: https://chromium-review.googlesource.com/767647Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#522156}
-
Weidong Guo authored
Background: Usually if focus traversal is handled by FocusManager, then it will select all text in the textfield in AboutToRequestFocusFromTabTraversal(). But we customized the focus movement by using RequestFocus() to move focus from the first search result to the search box. So AboutToRequestFocusFromTabTraversal() will not be called, so we need to manually select all text. Changes: 1. Search box should select all query on focus traversal. 2. Search box should not select all query when OnFocus() is triggered by key event redirected to the search box. (e.g. backspace, character keys.) Bug: 791754 Change-Id: I4220a83198f5d84780762a670a994cadcdfde05f Reviewed-on: https://chromium-review.googlesource.com/809717Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#522155}
-
Mostyn Bramley-Moore authored
We have not supported valgrind for some time (it was never ported to the GN build IIUC, and has been obsoleted by ASan/MSan/TSan). BUG=791518,431702 Change-Id: Ibfad450ee2973cf5916986559f543aced08e108a Reviewed-on: https://chromium-review.googlesource.com/805894Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#522154}
-
Koji Ishii authored
This patch supports LayoutInline::Paint() when LayoutNGPaintFragments is enabled. Normally LayoutBlockFlow paints its InlineBox (in legacy) or its NGPaintFragment (in LayoutNGPaintFragments), but when the inline box has self painting layer (e.g., position: relative) and in some other cases, this function is used to paint inline boxes. The unexpected clipping still occurs. Investigation continues. Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iccd9fcfbce5b0fc1bbfb523730e7005f7d6e02d6 Reviewed-on: https://chromium-review.googlesource.com/803875 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#522153}
-
Devlin Cronin authored
Extensions can update the default settings of browser actions (such as badge text, popup url, icon, and more). These settings are persisted in storage across runs. However, currently the logic to persist these and rewrite the values in storage is being triggered even if the extension is only updating a specific tab's value (in which case it will just rewrite all the same values). This is costly, as it requires both thread hops and disk IO. As a first step and low-hanging fruit, ensure that we don't try to write the default values if the extension only updated the settings for a specific tab (in which case we should know that nothing in the default settings changed). Bug: 505676 Change-Id: I612408740e88b76b234bf0d38433ab716485829b Reviewed-on: https://chromium-review.googlesource.com/768307 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#522152}
-
Erik Chen authored
By default, small allocations are pruned from the heap dump. This reduces the size of the compressed trace by 100x. If pruning is disabled, the chrome://tracing UI may be unable to take or load the trace. The trace can still be saved directly using chrome://memory-internals. Other mechanisms [e.g. diff_heap_profiler.py] may be necessary to examine the trace. Note that automatically uploaded traces will always be pruned. This only affects manually taken memory-infra traces.; Bug: Change-Id: I9aacc1d4e9ea65185b87f0a6ad53d727083576e8 Reviewed-on: https://chromium-review.googlesource.com/808995 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#522151}
-
Michael Spang authored
This allows the tracing infrastructure to query the list of categories we recognize, so they are shown in the UI. BUG=786091 Change-Id: I6f2fa08855944fd0e0c04f4431704477be551706 Reviewed-on: https://chromium-review.googlesource.com/811587Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#522150}
-
Ned Nguyen authored
Bug:792495 Change-Id: I7a2df9538b156721aa7cddc8171f3a03b5550b8c TBR=hablich@chromium.org Change-Id: I7a2df9538b156721aa7cddc8171f3a03b5550b8c Reviewed-on: https://chromium-review.googlesource.com/810888Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#522149}
-
Alexey Kozyatinskiy authored
With one of the next roll V8 will stop running gc before reporting scripts. R=alph@chromium.org Bug: chromium:655701 Change-Id: I58b86bb151420c0d848d3f1ccd4deb1d7890beb9 Reviewed-on: https://chromium-review.googlesource.com/806799 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#522148}
-
Matthew Jones authored
This change moves all of the swipe detecting from the bottom sheet into its own class. A relatively simple interface has been introduced to prevent needing the entire bottom sheet to detect swipes. BUG= Change-Id: If8c61df4009320e016903d6f1ed0c231c9330e02 Reviewed-on: https://chromium-review.googlesource.com/792337 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#522147}
-
Tom Anderson authored
BUG=761307 R=thestig@chromium.org TBR=dpranke@chromium.org CC=ivica.bogosavljevic@imgtec.com,ukai@chromium.org,yyanagisawa@chromium.org,shinyak@chromium.org Change-Id: Ib3419fc51c849cf8782a1d0910880c0e42c616e0 Reviewed-on: https://chromium-review.googlesource.com/809627Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#522146}
-
Robert Sesek authored
This is the new version of base::debug::ScopedCrashKey. Bug: 598854 Change-Id: Idfea07f414c4c68fb51909de467c8e666acd841d Reviewed-on: https://chromium-review.googlesource.com/811287 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#522145}
-
Manuel Rego Casasnovas authored
Remove ietestcenter/css3/grid/grid-column-003.htm from TestExpectations as we didn't manage to reproduce the leak. Let's see if the bots detect it again or it was already fixed. BUG=622915 Change-Id: Ibd03c81d5074c6c73cf78abba3ef0abec07aea36 Reviewed-on: https://chromium-review.googlesource.com/809206Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#522144}
-
Chris Harrelson authored
To do this, taint the source graphic of a canvas input to filters if it is cross-origin. Bug: 778506 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7e070c887dbb8bfce64f660790d58836f5d75762 Reviewed-on: https://chromium-review.googlesource.com/782649 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#522143}
-
Eugene Ostroukhov authored
Bug: Change-Id: I872a6585d2a8a459ed06eb21d8eb92b8e14fc0b9 Reviewed-on: https://chromium-review.googlesource.com/802035Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#522142}
-
spqchan authored
Currently if you click on an item in the bookmark bar, the item will lose its highlight state. This CL makes sure it retains it by updating the highlight on a mouse up. Testing: Unit test BookmarkButtonTest.MouseUpAndDownHighlight Bug: 613208 Change-Id: I2a3063af49065d3e985f681f69b0978666455243 Reviewed-on: https://chromium-review.googlesource.com/804695Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#522141}
-
Nick Peterson authored
The description for the ExtensionSettings policy exceeds the maximum size for Windows GPO templates. Move the full description to a seperate page on chromium.org and include a link here to the full description. Bug: 789087 Change-Id: Ia56d861af49981b5eac8da57b63ad65040cff3bc Reviewed-on: https://chromium-review.googlesource.com/810106Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nick Peterson <nrpeter@chromium.org> Cr-Commit-Position: refs/heads/master@{#522140}
-
Becca Hughes authored
Add double tap gesture recognition to MediaControlOverlayPlayButton so it can detect double tap gestures on the side and jump accordingly. Adds LayoutTests as a virtual test suite so they are tested with the modern media controls flag on. BUG=779989 TBR=jbroman@chromium.org Change-Id: I2d6e3c79d5ca3b447eda70f35da3dd22283a14b3 Reviewed-on: https://chromium-review.googlesource.com/800150 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#522139}
-