- 08 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4681cecb4151..1607b3aa8ccd 2021-01-08 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-08T04:02:26). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1538678ee6d16803fd26f736adb9b612193dd1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616924Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841440}
-
Jan Wilken Dörrie authored
This change modifies base::string16 to be an alias for std::u16string on non-Windows platforms. This allows the removal of a custom std::char_traits specialization for uint16_t, and now also allows the creation of base::string16s from char literals on all platforms, removing most of the need for helpers like base::ASCIIToUTF16. Lastly, this change also updates blink::WebUChar, ensuring it continues to be the exact same type as base::char16. Bug: 911896 Change-Id: Ifef35543e10cfee2b25f11984be289553532626e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586354Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#841439}
-
Nohemi Fernandez authored
In order to unify the Identity communication across Chrome platforms we expose the user's given name as an Identity property. Bug: 1148764 Change-Id: I96eb98e1ab6ce5f5f2fe5a01cb68b3e9744e63ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615158 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#841438}
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/ui/webui/settings/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: I423bf0ec29479c7942c4e4c5558f9e6ba68b3ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611267Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#841437}
-
Heng-Ruey Hsu authored
This is a reland of 3fc522ff. Original change's description: > Refactor delegate to support multiple clients and manipulate buffers > from corresponding clients according to the stream type. > > Bug: b:151047537 > Test: Manually test > Change-Id: I511be4f20f495a973141a7199f4b4c3c50871f5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351932 > Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> > Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> > Reviewed-by: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835102} TBR=wtlee@chromium.org Bug: b:151047537 Test: Manually test, test pass on krane. Change-Id: I3ed17b631fa8f0bea63c4ad616c64ca2ee8ca77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612313Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841436}
-
Colin Blundell authored
This CL prepares for the upcoming usage of Gaia-keyed URL lookups in Weblayer by turning SafeBrowsingTokenFetcher into an interface and its implementation into a SafeBrowsingPrimaryAccountTokenFetcher subclass. This layer of abstraction is needed as WebLayer will not fetch access tokens via IdentityManager as the current implementation does. A followup CL will abstract the remaining dependences on //components/signin from safe_browsing_token_fetcher.h. Bug: 1080748 Change-Id: Ib9c0cb63a3e1364611c21a3cc069bab7bdba0e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613968 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841435}
-
Taylor Brandstetter authored
This branch now contains three cherry picked commits: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..a3c3ef666b7a Bug: chromium:1163228 Change-Id: Icd506393d323f0fa1dbeb12546a224d09c4a77be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617212Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#841434}
-
David Jean authored
Also includes two #ifdef-out of deprecated code unrelated to orientation. Bug: 1131852 Change-Id: Ia229a421d0b9f9e9d655791d43b0cb59c0b0e75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612898 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#841433}
-
Manuel Rego Casasnovas authored
The :focus-visible tests were modified recently, but that introduced some leaks that were detected by "WebKit Linux Leak" bot. The tests that were failing are using test_driver.click(). This patch modifies the tests, so they pass without issues when passing --enable-leak-detection to tools/run_web_tests.py in a release build. Bug: 1163172 Change-Id: I9b8b1d0459bf7598fc3330495f3cc3ea95d36dae Cq-Include-Trybots: luci.chromium.try:layout_test_leak_detection,leak_detection_linux Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617818Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#841432}
-
Wei Lee authored
There are some use cases which are not guarded by the lock, which might cause race condition since |camera_info_| might be accessed from different threads. In addition, when VendorTagOpsDelegate is reset, we should have a way to let caller know that the initialization state is reset so that we won't wait forever. Bug: b/174126439 Test: Build successfully Change-Id: I270c0989f04896b1fc3df28aa2243dce799b93ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602964Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841431}
-
Tanmoy Mollik authored
Method OnPrimaryAccountSet/Cleared and OnUnconsentedPrimaryAccountChanged is deprecated. So this cl changes these calls to OnPrimaryAccountChanged. Bug: 1158855 Change-Id: Iecb78851b28f90934fb0127b8210ceac5f886457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611097Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841430}
-
Friedrich Horschig authored
The test seems to leak objects only occasionally, e.g. (leak detected: ({"numberOfLiveContextLifecycleStateObservers":[2,8], "numberOfLiveDocuments":[1,4], "numberOfLiveNodes":[4,2204], "numberOfLiveResourceFetchers":[1,4]}), text diff) NOTRY=true TBR=petermarshall@chromium.org Bug: 1046784 Change-Id: Iba2c7b27242a330ad1307ab6a2ea9c1fcec343e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617839Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#841429}
-
Boris Sazonov authored
Changes AccountManagerAsh to use ReceiverSet instead of a single Receiver. This allows having multiple clients talking to the same AccountManagerAsh instance and also prepares the upcoming unification of AccountManagerFacade implementations. AccountManagerAsh ownership will be revised in subsequent CLs. Bug: 1161699, 1148448 Change-Id: Ida66bce494df802bf5ce4fd99f78d081a9540b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614788Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841428}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iaa235f3695bf7ff8303127bda64765ab3da7d7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617621Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841427}
-
Ewann authored
This CL uses a UILabel to display the site URL instead of an NSString, to control auto-resizing. Bug: 1104198 Change-Id: I9c0d508ed209d6bd598584b6ed74a8ecca4b0510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603749 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#841426}
-
Alice Wang authored
This CL simplifies the calling logic of child account status fetching by removing the unnecessary abstraction layers and add unit tests for child account status check. This is a pure refactoring and there is no behavior change. Bug: 1161702 Change-Id: I14bed1f58a433b8b788c73104b4aa4a4729c65b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602419 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841425}
-
Anastasiia N authored
Add `ShowAddAccountDialog` and `ShowReauthAccountDialog` methods to `AccountManagerFacade`. Bug: 1140469 Change-Id: I0d3d1d25b30d872412972fba039379f349fe59f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550669 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841424}
-
jchen10 authored
This uses GpuMemoryBufferVideoFramePool to import software video frames. Bug: 1142754 Change-Id: Ic1a7849ca7a833ecf255892ba962ce2207b57546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603036Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Cr-Commit-Position: refs/heads/master@{#841423}
-
Alexander Timin authored
This is a reland of 20ec4591 Original change's description: > Reland "[tracing] Align --trace-startup and --enable-tracing." > > This is a reland of 0823dbae > > Original change's description: > > [tracing] Align --trace-startup and --enable-tracing. > > > > Use StartupTracingController both for --trace-startup (primary use case: > > browser startup perf profiling) and --enable-tracing (primary use case: > > browser test tracing). > > > > Due to historical reasons both flags are kept, but now their behaviour > > is mostly the same. If both are present, --trace-startup takes > > precedence. > > > > Differences: > > - `trace-startup` finishes after 5 seconds by default, while `enable-tracing` > > continues until the browser is closed. (--trace-startup-duration overrides > > both). > > - `trace-startup-file` always treats the path as absolute, while if > > `enable-tracing-output` ends with /, it uses the provided value as the > > directory and generates the base name based on the current runtime > > metadata. > > > > R=skyostil@chromium.org,eseckler@chromium.org > > BUG=1157954 > > > > Change-Id: Ia76316aa8927b431784e2fb94c8e42e4e2c0b479 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589834 > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > Commit-Queue: Alexander Timin <altimin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#839992} > > TBR=skyostil@chromium.org,eseckler@chromium.org,nasko@chromium.org > > Bug: 1157954 > Change-Id: Ic16992026beebddea39c8a6b247b4301512057e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609139 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840015} TBR=eseckler@chromium.org,skyostil@chromium.org Bug: 1157954 Change-Id: Iab58e0a581f9744138c962d4574ec8fa6d6097ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615539 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#841422}
-
Nasko Oskov authored
This CL updates the documentation for WebUI to reflect recent changes that make it safe to use <iframe> to embed web content in a WebUI page. Bug: 1002276 Change-Id: I1d61d99dd6f71b868f3ae05d3e37c801c6095d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613888 Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#841421}
-
Gauthier Ambard authored
This CL adds a test to navigate back/forward to an error page and check that the page correctly reloads. Bug: none Change-Id: I758c2cb5734fbbca9eb075e86e4ab3d44834ecdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615159Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#841420}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80399af7a213..51690fcadbed 2021-01-08 bmeurer@chromium.org Roll js_protocol.pdl ('wasm' type and 'executeWasmEvaluator' removal). 2021-01-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159402,chromium:1162062 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id9ab18a028b1b81a43dbee70347e48ce7dc02cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841419}
-
Friedrich Horschig authored
The test passes in ~2 out of 10 runs. Therefore, disabling it for now. NOTRY=true TBR=masonfreed@chromium.org Bug: 1164166 Change-Id: I152bb598f20c8ff63cb36fcb9f4729bff8043dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617700Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#841418}
-
Omar Morsi authored
Before this CL, a VPN device state was always being returned from CrosNetworkConfig::GetDeviceStateList even if no VPN services exist. The main reason behind that was to use this state to propagate the VPN disablement state to the UI code. This CL changes this behavior such that a VPN device state is returned if a VPN service exists or the VPN is prohibited by policy. Bug: 1156816 Change-Id: Ie5c894183d205a92a0bedb890bfcd69daeff3e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615038Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#841417}
-
Jun Kokatsu authored
This change clean up unnecessary test cases in the NoTrustedTypesViolation test. Also added few things that makes debugging of the test failure more easier. Bug: 1115643 Change-Id: Ib8ad416fa3af48ab3dd7eb01785e1ffcd34bb50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612397Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#841416}
-
Michael Lippautz authored
- Fix cppgc traits for TraceWrapperV8Reference - Fix ThreadState compilation - Fix String resolution Bug: 1056170 Change-Id: I95f6ce324b632465e936a0b6d00aab082e28507c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616199Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#841415}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610063718-75764fb6f7cc7a2d4d8119e0952784a5ac3fa72a.profdata to chrome-linux-master-1610085553-90a8ab5c2cfb6eb3765af407df5af94b81fb1c7d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1c230835a89834537386fcb9840dd89c800f6a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617648Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841414}
-
Arthur Sonzogni authored
This reverts commit e05911e4. Reason for revert: https://crbug.com1164259 WebViewLayoutTest#testWebViewIncludedStableInterfaces is failing because the new API doesn't set up whether it should be exposed in WebView. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt Original change's description: > webhid: Mark the API stable > > Updates runtime_enabled_features.json5 and the stable webexposed tests > to mark the WebHID API stable on desktop platforms. > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/rL1csFYD1Ms > > Bug: 890096 > Change-Id: I36a6b62475dd9de01a4dbf013b2be00e8901359e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610995 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841185} TBR=chrishtr@chromium.org,mattreynolds@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I16463f8d4b8e9e4893217f5349d2a8a9f7aa76f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616200Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841413}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f7ce1cd243f2..cb3bcf88e382 2021-01-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ebb8289a to f936dc21 (446 revisions) 2021-01-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from fac169113df7 to 00fcab636a05 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I7a0f1725759bcac61e44c9d9ad291282ca9e0794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617309Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841412}
-
Nazerke authored
The crash report shows that the crash of |addConstraintsToTabStrip| is on the iphones only. This CL removes the adding the constraints to the tabstrip from the viewDidLoad, as currently it's crashing on it while it's trying to add the constraints to the tabstripview which is nil on the iphones. Now it is moved to the point when the tabstripview is added, which does not let it run on the iphones as it's not needed and causes crashes. Bug: 1152059, 1128249 Change-Id: Ic161b0d687b828ec57889c455d171c4f6a5fcf42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611977Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#841411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48240126b9fe..589e3dd96b0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: Id21e75bdc6dd85b316c84554c85e272b37776c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617311Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841410}
-
Kuo Jen Wei authored
Bug: b/176266123 Test: Manually toggle different grid line type from toggle button and grid settings. Change-Id: I59dfb3b46415ad0b1a6206ecf4a31344479f0ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611152 Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#841409}
-
Mirko Bonadei authored
This reverts commit 5903b6b1. Reason for revert: This should land after M89 is branched. Original change's description: > Roll src/third_party/usrsctp/usrsctplib/ 995c0b844..4191ca178 (72 commits) > > https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..4191ca1784d8 > > $ git log 995c0b844..4191ca178 --date=short --no-merges --format='%ad %ae %s' > 2021-01-04 vitaly Fixed installation on other than Ubuntu GNU/Linux distributions. (#541) > 2021-01-01 tuexen Improve handling of aborted associations > 2020-12-31 yuquanw2 Add SACK into fuzzer_fragment (#516) > 2020-12-31 61293369+ihsinme Update client_upcall.c (#559) > 2020-12-30 deadbeef Add optional SCTP_USE_OPENSSL_RAND define to use openssll's RNG. (#558) > 2020-12-30 deadbeef Lowercase reference to iphlpapi.lib (#560) > 2020-12-23 tuexen Improve input validation for parameters in ASCONF and ASCONF-ACK chunks > 2020-12-20 deadbeef Fall back to using urandom on Linux if getrandom isn't available. (#557) > 2020-12-14 tuexen Harden the handling of outgoing streams in case of an restart or INIT collision. This avouds an out-of-bounce access in case the peer can break the cookie signature. Thanks to Felix Wilhelm from Google for reporting the issue. > 2020-12-12 tuexen Clean up more resouces of an existing SCTP association in case of a restart. > 2020-11-19 weinrank Sync master with fuzzing branch (#551) > 2020-11-18 CoolmanCZ MinGW release build - initialize variables (#548) > 2020-11-18 deadbeef Call __msan_unpoison after syscall(__NR_getrandom, ...). (#550) > 2020-11-18 deadbeef Support building with emscripten. (#549) > 2020-11-18 sironhide0null Fix a typo in user_mbuf.c (#552) > 2020-11-09 tuexen Fix a potential use-after-free bug introduced in https://github.com/sctplab/usrsctp/commit/b10a5d3b26e94320232dbdf269873497f8f7cff1. > 2020-11-04 weinrank Fix #545 - remove .lib extension (#546) > 2020-11-02 weinrank Use CMAKE's BUILD_SHARED_LIBS flag to build shared library (#543) > 2020-10-22 tuexen Use the SCTP_REUSE_PORT socket option. > 2020-10-17 tuexen Improve the handling of cookie life times. The staleness reported in an error cause is in us, not ms. Enforce limits on the life time via sysct; and socket options consistently. Update the description of the sysctl variable to use the right unit. Also do some minor cleanups. This also fixes an interger overflow issue if the peer can modify the cookie. This was reported by Felix Weinrank by fuzz testing the userland stack and in https://oss-fuzz.com/testcase-detail/4800394024452096 > 2020-10-13 tuexen Improve compilation on Windows. > 2020-10-07 tuexen Whitespace changes > 2020-10-06 tuexen Reset delayed SACK state when restarting an SCTP association > 2020-10-06 tuexen Cleanup. > 2020-10-06 tuexen Accept any cookie if FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION is defined. > 2020-10-06 tuexen Provide RNG for __native_client__ as suggested by Taylor Brandstetter. Fail compilation on all platforms we don't have a specific RNG for. > 2020-10-06 tuexen terminate_non_graceful() never returns... > 2020-10-06 tuexen Initialize variables before using > 2020-10-06 tuexen Remove dead stores reported by clang > 2020-10-06 tuexen Cleanup > 2020-10-06 tuexen Whitespace changes > 2020-10-04 tuexen Use __func__ instead of __FUNCTION__ > 2020-10-04 tuexen Cleanup. No functional change intended > 2020-10-02 tuexen Minor cleanup. > 2020-10-01 deadbeef Call getrandom via syscall directly on Linux. (#533) > 2020-10-01 tuexen I guess Bitrig support arc4random(). > 2020-10-01 tuexen Whitespace change. > 2020-10-01 tuexen Don't start SCTP/UDP receive threads (and don't open corresponding UDP sockets) when the UDP port specified in scpt_init() is 0. > 2020-09-30 deadbeef Add missing return type to init_random. (#531) > 2020-09-30 tuexen Try to fix the Windows build. > 2020-09-30 tuexen Add Android specific code for the random number generator. > 2020-09-30 tuexen Add platform specifc includes to the corresponding code. > 2020-09-30 tuexen Add a cleanup routine for the random number generator. > 2020-09-29 tuexen Improve the input validation and processing of cookies. > 2020-09-28 tuexen Whitespace cleanup > 2020-09-28 tuexen Improve random number generation on __Fuchsia__. > 2020-09-27 tuexen Improve the handling of fragmented, unordered, and unreliable user data using DATA chunks in the receive path. > 2020-09-26 tuexen Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25984 > 2020-09-24 tuexen Whitespace changes > 2020-09-22 deadbeef Avoid duplicate definition of _CRT_RAND_S. (#529) > 2020-09-22 deadbeef Fix gcc/clang type mismatch warnings on Windows (#527) > 2020-09-22 deadbeef Fix -Wunreachable-code in programs/ (#528) > 2020-09-19 tuexen Improve consistency. > 2020-09-19 tuexen Cleanup. > 2020-09-19 tuexen Improve Windows build. > 2020-09-19 tuexen Fix syntax error on windows. > 2020-09-19 tuexen Add include for getrandom() on Linux. > 2020-09-19 tuexen Fix type of init_random() on Linux and Windows. > 2020-09-19 tuexen Improve Windows build. > 2020-09-19 tuexen Improve consistency. > 2020-09-19 tuexen Improve random number generation on Linux and Windows. > 2020-09-19 tuexen Cleanup read_random(). No functional change. > 2020-09-19 tuexen Fix NetBSD related #ifdef. > 2020-09-19 tuexen Whitespace changes > 2020-09-18 tuexen Add license. > 2020-09-18 tuexen Add license statement. > 2020-09-18 tuexen Fox more typos. > 2020-09-18 tuexen Fix typo. > 2020-09-18 tuexen Remove trailing whitspaces. > 2020-09-18 tuexen Improve consistency, no functional change intended. > 2020-09-18 tuexen Check for too short packets when using the receive threads. > 2020-09-18 tuexen Fix mask for ECN bits. > > Created with: > roll-dep src/third_party/usrsctp/usrsctplib > > Bug: chromium:1163228 > Change-Id: I9b0b5f8c98bf3f7c9f51ae6fae24dd0e9b6e3117 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612384 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841036} TBR=hta@chromium.org,deadbeef@chromium.org,mbonadei@chromium.org,orphis@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ifd8bf7e7fb5a50cdc4fb4b128895bc34425f127a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1163228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617778Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#841408}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/87d362bb2c4d..80399af7a213 2021-01-08 bmeurer@chromium.org [e2e] Rebaseline sources tests after Chromium roll. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I48c1b497ee8365c5d1b8c2e6ea58180b3d58f251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841407}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/63bdfe586f8c..425c25a8ad2d $ git log 63bdfe586..425c25a8a --date=short --no-merges --format='%ad %ae %s' 2021-01-07 bnc Add SETTINGS_DEPRECATE_HTTP2_PRIORITIES. 2021-01-07 haoyuewang Add supports to write NewConnectionId/RetireConnectionId via QuicControlFrameManager. 2021-01-07 wub Refactor TlsServerHandshaker to use ProofSourceHandle for cert selection and signature. 2021-01-06 wub In QUIC BBRv2, reset max_bytes_delivered_in_round when a new round starts. 2021-01-06 haoyuewang Add new & retire ConnectionId interface to QuicSession::visitor and implement them in (Gfe)QuicDispatcher. 2021-01-05 haoyuewang Add multiple CID per connection support to time_wait_list. 2021-01-05 quiche-dev Rename gfe2_restart_flag_always_promote_chunk_if_coalesced_2 and remove "enabling_blocked_by". 2020-12-30 vasilvv Fix include paths for quiche/common/platform/impl. 2020-12-30 fayang Fix QUIC_BUG in FlushAckFrame to check whether frames is empty. 2020-12-30 danzh Make QuicConnection count bytes sent/received in probing packets on alternative paths. Created with: roll-dep src/net/third_party/quiche/src Change-Id: I492a96c7f055561f465fe0e7ea5b9907906548d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617418Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#841406}
-
Matt Falkenhagen authored
In the multi-WebContents implementation, history must be copied from the old WebContents's NavigationController. Also adjust a unittest to more fully simulate navigation, as it's necessary to commit the navigation in order to copy the history. Bug: 1132746 Change-Id: I0e2061451779d1fa9e4db2957aa06d0a05bef436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612291Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841405}
-
Matt Giuca authored
This change removes the status bar in installed WebApp windows (the small text box that appears in the lower left hand corner of the window). Bug: 1151487 Change-Id: Ic1088730b7d6cdd622aedcefd1902e21741d7821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617479 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#841404}
-
Yoshisato Yanagisawa authored
Now Goma client is not guaranteed to run on Windows 7. It has no meaning to keep the builders. Bug: b/139556893 Change-Id: I8cda7f1b00a0e356f0ad9ba3c002280ab514d727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617215 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#841403}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4d379d2f..ff24c712 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab1cb0cb4fe365e6a0d0f7062369bee5f06ec0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617211Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841402}
-
Archie Pusaka authored
This adds the following histrograms: * BlueZ.AdvertisementMonitor.NumOfMonitors * BlueZ.AdvertisementMonitor.<SW|MSFT>.FilterPatternsPerMinute * BlueZ.AdvertisementMonitor.<SW|MSFT>.<Add|Remove>.Result Corresponding BlueZ metrics implementation can be found at: go/croscl/2565089 Bug: b/169584341 Test: Verify BlueZ.AdvertisementMonitor* on chrome://histograms Change-Id: Ibab7145580b3ddd3369ee83940090ae0f8052dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596585Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#841401}
-