- 19 Jun, 2018 40 commits
-
-
Francois Doray authored
This will be used to periodically unfreeze LifecycleUnits, to allow them to update their state. Bug: 775644 Change-Id: I498930c8a555ddf3581099e61972aaeac6a36d91 Reviewed-on: https://chromium-review.googlesource.com/1099973 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#568451}
-
Mike Dougherty authored
The ContextMenu.DelayedElementDetails metric ensures that all awaiting requests are eventually processed by either the user cancelling or by the DOM element details being returned. The ContextMenu.CancelSystemTouches metric logs that the system touches were cancelled. This value should match the number of Context Menus shown, otherwise a user could continue to interact with the page after the Context Menu has been displayed. Bug: 817517 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4dc5d9d14eba12c06ca034b80c037bd673230878 Reviewed-on: https://chromium-review.googlesource.com/1102994 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#568450}
-
Oskar Sundbom authored
I stumbled on a couple of crashes where it looks like the audio thread is deadlocked on the event_.Wait() call. From what I can tell, there's no way to recover from a fail thread creation, so any thread that calls SimpleThread::Start() has a chance of freezing indefinitely. This was changed[1] from a CHECK to a DCHECK way back in 2011. There shouldn't be any valid cases where thread creation fails, so it's probably better to get a clean crash as soon as this happens, than possibly getting a crash dump much later, provided a watchdog kicks in. [1] https://codereview.chromium.org/8368009 Bug: 854154 Change-Id: I72f7318642a39b0e1b23964f0841423bc9e87496 Reviewed-on: https://chromium-review.googlesource.com/1104679Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568449}
-
clamy authored
These histograms were introduced to track the time between an intent reception or link click and the commit of the navigation and end of page load. We now have a more robust loading metrics architecture and they have not been used in a while. Bug: 708035, 691867 Change-Id: Ic9bcd7df968ba32e6148483abeccd074a502ddca Reviewed-on: https://chromium-review.googlesource.com/1099171Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568448}
-
jonross authored
Currently SitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView is using a legacy method for waiting for hit test data. This change updates it to use the new HitTestRegionObserver. However there is a bug in the /2 variant of the test, there overlapping hit test regions are not submitted. Due to this I have it exit early in that config. TEST=SitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView Bug: 846798 Change-Id: I410d493f1abc7334e4cc21c3c4edceb4e2edd8c9 Reviewed-on: https://chromium-review.googlesource.com/1102721Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#568447}
-
Ken Rockot authored
Removes the last vestiges of non-Mojo targets depending on Mojo internal types. Changes the //mojo/edk target to only expose the bare minimum API needed for embedders to initialize Mojo and IPC. Deletes some now unused types, PeerConnection and OutgoingBrokerClientInvitation. Cleans up a few scattered dependencies. TBR=dschuff@chromium.org Bug: 844763 Change-Id: I7f6ae2987b25fc2089608efea59bee52f15aec4b Reviewed-on: https://chromium-review.googlesource.com/1102120 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#568446}
-
Carlos IL authored
There are other use cases besides interstitials (which were fixed in crrev.com/c/1101397) that rely on the first call to UpdateControls to be ignored, re-adding the IsInVR check while all those cases get fixed. Bug: 853686 Change-Id: Ic48322c2551f6b35a1bb84e7d1212aa284a72d7f Reviewed-on: https://chromium-review.googlesource.com/1105124Reviewed-by:
-
Mikel Astiz authored
We thought there was no reason to avoid broadcasting notifications when an empty list of remote updates is received, but it turns out that at least one client (iOS RecentTabsMediator) relied on the fact that such events would be ignored (not broadcasted via SyncServiceObserver::OnForeignSessionUpdated()). To avoid behavioral changes with the pre-USS implementation, which dropped such empty updates in an earlier stage (I believe in GenericChangeProcessor::CommitChangesFromSyncModel()), we adopt similar logic for USS (SessionSyncBridge). Bug: 854049 Change-Id: I6d3b6123b7fb15bb0e5bfeccdc0a6d9170427fe4 Reviewed-on: https://chromium-review.googlesource.com/1106143Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568444}
-
Sorin Jianu authored
Bug: 854029 Change-Id: I82f2f12bcca6b5af48127307f1662324bdcda9ce Reviewed-on: https://chromium-review.googlesource.com/1105600Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568443}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb3beb0591ae..f2030783094e git log fb3beb0591ae..f2030783094e --date=short --no-merges --format='%ad %ae %s' 2018-06-19 kjlubick@google.com Revert "added GrSkSLFP and converted DitherEffect to use it" Created with: gclient setdep -r src/third_party/skia@f2030783094e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: If5cf0f7062d25ea9fe01633524495716273c8c13 Reviewed-on: https://chromium-review.googlesource.com/1106018Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568442}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5ecb02850aa4..c5ef6d834a15 git log 5ecb02850aa4..c5ef6d834a15 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 treib@chromium.org Disable flaky ActionRunnerTest.testWait on Mac Created with: gclient setdep -r src/third_party/catapult@c5ef6d834a15 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:853865 TBR=sullivan@chromium.org Change-Id: I57b9ff27d91409e0c79cf2dde0ee583fa5662693 Reviewed-on: https://chromium-review.googlesource.com/1106019Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568441}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I6f1cc34384968ee158eea430a3a8f00d2c378546 Reviewed-on: https://chromium-review.googlesource.com/1102507Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568440}
-
Mustaq Ahmed authored
Bug: 805015 Change-Id: Ic066f3f7d939b5175ed19b6d710f343475fba7a8 Reviewed-on: https://chromium-review.googlesource.com/1100944Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#568439}
-
Michael van Ouwerkerk authored
* Uses AIDL interfaces to work across class loaders * Adds a bottom bar in CCT if the module is loaded Bug: 843161 Change-Id: I8eaaaebf78cfb875f61deebca8df3e98a4f8c0dc Reviewed-on: https://chromium-review.googlesource.com/1085060 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Philip Rogers authored
The main scrolling coordinator update, ScrollingCoordinator:: UpdateAfterPrePaint, does not affect paint and can be moved after paint. This change will make it easier to compare the new PaintTouchActionRects update to the current scrolling coordinator update. This patch also moves the PaintTouchActionRects update into ScrollingCoordinator::UpdateTouchEventTargetRectsIfNeeded so the two codepaths can be directly compared. With this change, the PaintTouchActionRects codepath now uses the existing dirty bits and only runs when touch event rects might have changed. This patch has a bugfix for the following layout test where PaintTouchActionRects would not invalidate the touch action dirty bit: fast/events/touch/compositor-touch-hit-rects-transform-changed-nolayout.html This is a followup to https://crrev.com/566542 which moved the scrolling coordinator update to after PrePaint. Bug: 851513 Change-Id: I8ca1373832b49edd5518b43c524b6dcd57e3b36b Reviewed-on: https://chromium-review.googlesource.com/1103777 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568437}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: Ibb8542a3110e6a4842c7744a879fbeb8d577dace Reviewed-on: https://chromium-review.googlesource.com/1102506Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568436}
-
Koji Ishii authored
Following bot results are included. 6908 6923 6925 6928 6932 6935 6936 6938 6943 6946 1 lines were removed and 1 lines were deflaked by consecutive results since 6904. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I08741cf902301a6dafc20561c5ed391da450eedc Reviewed-on: https://chromium-review.googlesource.com/1103431 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568435}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I2d11ff1898c785ba912e361390e414720800d5cc Reviewed-on: https://chromium-review.googlesource.com/1102472Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568434}
-
Sigurdur Asgeirsson authored
Bug: 755840 Change-Id: I4f693945cb65b7be8360636307dc165a7c317f4f Reviewed-on: https://chromium-review.googlesource.com/1104868 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#568433}
-
Robert Sesek authored
Change-Id: I70184c0164e9064d9f6d86bd3892ae0100cb4178 Reviewed-on: https://chromium-review.googlesource.com/1105064Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568432}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I0f556f544ee09975dcee90e93abc1eda4fcb542e Reviewed-on: https://chromium-review.googlesource.com/1106037 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568431}
-
Gaofeng Huang authored
Need for eureka-internal/178533 Bug: internal b/110284450 Test: on device Change-Id: I17482cbfa0d3812047714e648a1562a8cfe55be8 Reviewed-on: https://chromium-review.googlesource.com/1103671Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568430}
-
Raphael Kubo da Costa authored
TBR=timvolodine@chromium.org Change-Id: I36020efa88606fa42a29c451f3e66164290ba8a7 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1106139 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#568429}
-
Jeremy Roman authored
Change-Id: Ie0f12a43cc9321b24820e9a23fe676abf4d2f244 Reviewed-on: https://chromium-review.googlesource.com/1105382Reviewed-by:
-
Justin Cohen authored
Bug: 853992 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id441f479a233d0aa1cd6c2761da40819e0be2bc2 Reviewed-on: https://chromium-review.googlesource.com/1105998 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568427}
-
Rune Lillesveen authored
EnsureComputedStyle is used to compute style for display:none nodes in an already up-to-date tree. These instances of EnsureComputedStyle in tests broke when trying out changes for issue 831569. Change-Id: I02cc6babcfe1f2193c47673a6a124385c558594a Reviewed-on: https://chromium-review.googlesource.com/1105992Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#568426}
-
Christopher Grant authored
This gives the fade in/out effect on the loading progress bar that 2D UI now has. BUG=853821 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3d07e2ea005c0fbaafb9042a257b3eac4979a4e9 Reviewed-on: https://chromium-review.googlesource.com/1104984 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568425}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72566aa8..7edcaa70 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Icbe83637d4e3f122e133c842fb147bf4f07cc4a7 Reviewed-on: https://chromium-review.googlesource.com/1105716Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568424}
-
Jeremy Roman authored
Change-Id: Ib0644da4b7b06b3b7fcb7e43e8706cb071667f99 Reviewed-on: https://chromium-review.googlesource.com/1105391Reviewed-by:
-
A Olsen authored
When generating the .reg template, policies that are strings are properly escaped. And for policies that are dicts - the strings inside those dicts are properly escaped eg: {"quote_of_the_day": "\"I'll be back\" - Arnold"} But then the dict as a whole is wrapped in quotes but not escaped. Eg: "{"quote_of_the_day": "\"I'll be back\" - Arnold"}" Note that this string ends immediately due to improper escaping: "{" This affects three policies (that are included in the REG file): ManagedBookmarks, ExtensionSettings and RegisteredProtocolHandlers. The diff in the generated REG file is available internally here: go/chromeregdiff Bug: 834893 Change-Id: Ied752f1f4fea4fdf3a31706080f0e3e9484060e8 Reviewed-on: https://chromium-review.googlesource.com/1104465Reviewed-by:Lutz Justen <ljusten@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568422}
-
Jochen Eisinger authored
BUG=809444 R=blundell@chromium.org Change-Id: Iea99e6e7809faa2f03702bab7a575c8a6c4e17b8 Reviewed-on: https://chromium-review.googlesource.com/1104421 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#568421}
-
kylechar authored
It looks like support was added to mojo to allow for platform specific IPCs. Update mojom::DisplayClient so that platform specific IPCs are only compiled on that platform. Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie495671ef90225fecffe07606bbdad3a35c67f78 Reviewed-on: https://chromium-review.googlesource.com/1102558 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#568420}
-
Noel Gordon authored
Now the Quick View browser test suite has been optimized for speed, we can finish off by documenting the Quick View test JS. Two test helpers only lack documentation: document what they do. Comment only change: no change in behavior, no new tests. Bug: 851888 Change-Id: If87c49919cdd3bd51fa35f714130fc74fb84b543 Reviewed-on: https://chromium-review.googlesource.com/1105530Reviewed-by:
-
Mohamed Amir Yosef authored
USS requires atomic writes of sync metadata and native model data to guarantee consistency between both. This patch adds the required functionality to persist the bookmarks sync metadata together with the bookmark model. Two methods are added to the bookmark client that allows encoding/decoding metadata. Bookmark model invokes those methods when writing/reading the stored data respectively. A new keyed service is introduced that owns the BookmarkModelTypeProcessor such that there is a run-time dependency from the bookmark model on the new service. This ensures that the metadata stored in the processor outlives bookmark model and hence would be available whenever the bookmark model needs to be persisted. Bug: 516866 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0e24ebf712d3b83130b0338ed72ffb833a78830f Reviewed-on: https://chromium-review.googlesource.com/1094876 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568418}
-
Marc Treib authored
This reverts commit 0d53513f. Reason for revert: Flaky tests, see bug Bug: 854143 Original change's description: > Headless: don't run unload hooks upon web contents close. > > Change-Id: I6e391fadbbf47aa6427a16495bdca3c88d456b05 > Reviewed-on: https://chromium-review.googlesource.com/1105041 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568213} TBR=dgozman@chromium.org,pfeldman@chromium.org,eseckler@chromium.org Change-Id: I252909f78e6d33b98819f6510f780997327a6901 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1106077Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568417}
-
Oskar Sundbom authored
Leave portless devices alone. Bug: 853693, b/79580580 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0e505b0f87fdb2b416ca080ad104ea6710e2ec6a Reviewed-on: https://chromium-review.googlesource.com/1104433Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568416}
-
Emilio Cobos Álvarez authored
It's already in a block with if (pseudo_id == kPseudoIdFirstLetter). Just a nit I noticed while seeing the patch for issue 853551. Bug: 853551 Change-Id: Ib4fadc46497c2ed4142f88f9d57938273acf622d Reviewed-on: https://chromium-review.googlesource.com/1105831Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#568415}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b8d38118. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19925 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bugsnash@chromium.org, ericwilligers@chromium.org, meade@chromium.org, nainar@chromium.org, rjwright@chromium.org, shend@chromium.org: external/wpt/css/css-conditional yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: Icae359d0cf4f6c466463821019e4b41647aff942 Reviewed-on: https://chromium-review.googlesource.com/1105837 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568414}
-
Raphael Kubo da Costa authored
Commit b47442dc ("viz: Determine fallback strategy in SurfaceAggregator") simplified the code in SurfaceLayerImpl::CreateSurfaceDrawQuad(), but ended up with a construct like this: viz::SharedQuadState* foo = foo = bar(); Simplify the assignment and make it more readable. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I88560e1acd1766d4f1676c2aa90b18be32971a60 Reviewed-on: https://chromium-review.googlesource.com/1105829 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568413}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f13bae2df0b8..5ecb02850aa4 git log f13bae2df0b8..5ecb02850aa4 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 treib@chromium.org Disable flaky ActionRunnerTest.testWaitForElement on Mac Created with: gclient setdep -r src/third_party/catapult@5ecb02850aa4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:852931 TBR=sullivan@chromium.org Change-Id: I02d4be752592d1569f0d182fae6dd200df309b71 Reviewed-on: https://chromium-review.googlesource.com/1105102Reviewed-by:
-
