- 07 May, 2020 40 commits
-
-
Yoshifumi Inoue authored
This patch changes "leave-requested-block.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: I44d05c7c1dd9c33206a61f774de9726731ad4a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186877 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766321}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ic7f0d09214a3b9df1064b333a464ea95f3df105e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169449Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#766320}
-
Roman Sorokin authored
to reduce flakiness of tests. The button is used in tests to interact with real Gaia. Gaia makes this button enable/disable hidden/visible during the signin flow. That might lead to clicks missing and tests failing. This CL adds waiting logic in javascript. It waits for the button being visible and enabled. Also it should remove cros tests dependency on the button name. Bug: 1077836 Test: tast run unicorn.Login Change-Id: I67e9c4ed8a392b05202ddb4a406232d1a8c49f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185090 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#766319}
-
François Beaufort authored
This CL makes sure user is prompted with camera PTZ access if any of the constrained values for pan, tilt, and zoom are present in getUserMedia options. This CL does not check yet for hardware support. This will come in a follow-up CL, as well as applying constraints after getUserMedia succeeds. The camera PTZ permission request is grouped with camera and microphone permission requests. Screenshots: https://i.imgur.com/J9rrWS5.png https://i.imgur.com/aGSUZVY.png Explainer: https://github.com/w3c/mediacapture-image/blob/master/ptz-explainer.md Test: https://ptz.glitch.me/ Change-Id: Ia940cd62952d828598203506ea73992ac1e87e73 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127109 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766318}
-
Rahul Arakeri authored
This CL enables ElasticOverscrollController for the root scroller on Windows to be instantiated. Turning on elastic overscrolling works for PTP but not for touch scrolling, as it does not have the necessary inertial_phase information that InputScrollElasticityController relies on. This CL adds that information for touch scroll events. Bug: 1058071 Change-Id: Ibcb1a373def9564a7b0ea81f62493d455055a8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183709 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#766317}
-
Mike Dougherty authored
TBR=gambard@chromium.org Bug: 1079165 Change-Id: I307de9b7df38f7b1af99639546df6b686cde5f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186359Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#766316}
-
Julian Watson authored
This will allow for mocking of PluginVmManager in tests. Tbring the owners of the following files as the changes are very mechanical: ★ ./chrome/browser/chromeos/policy/lock_to_single_user_manager.cc: ★ ./chrome/browser/task_manager/providers/vm/plugin_vm_process_task.cc: ★ ./chrome/browser/ui/app_list/app_service/app_service_context_menu.cc: ★ ./chrome/browser/ui/ash/launcher/app_service/app_service_shelf_context_menu.cc (2 files): ★ ./chrome/browser/ui/webui/settings/chromeos/plugin_vm_handler.cc: TBR=anqing@chromium.org TBR=afakhry@chromium.org TBR=nancylingwang@chromium.org TBR=jamescook@chromium.org Bug: 1049453 Change-Id: I0c73bc8d2b6b0f4e4de2870c3b7cdba17808d686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186616 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#766315}
-
Yoshifumi Inoue authored
This patch changes "paragraph-separator-in-table-[12].html" to utilize |selection_test()| and unifies into "paragraph_separator_in_table.html" for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Iabe097cddaf3843c6192935b5a43d60cda81957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186876 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#766314}
-
Michael Lippautz authored
The fix in https://crrev.com/de39db161c8f0e032094c3458d399191f116a4c2 had the right idea but missed out on removing the parts that clear the references too eagerly. This patch keeps the same fix but ensures that the old code is removed. I manually verified that this fixes a CF issue (1079033) that still reproduces on master. Bug: chromium:1078751, chromium:1079033 Change-Id: Iaddbbb17b360304c6c9b59399bc6e4e219833c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187269Reviewed-by:
-
Manuel Rego Casasnovas authored
This patch fixes a regression in LayoutNG compared to legacy, when the descendant of an element with padding and "outline: auto" is an inline block. And also when it's an inline element (which was not working properly in legacy layout either, that's why outline-025 and outline-026 tests fail on legacy). We need to rebaseline an old pixel test, as we're coming back to the legacy layout behavior for it. BUG=1078539 TEST=external/wpt/css/css-ui/outline-024.html TEST=external/wpt/css/css-ui/outline-025.html TEST=external/wpt/css/css-ui/outline-026.html Change-Id: I8ccf72fb34e1d9ce6821eec9312f1fecd52e1281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182471Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
We now have VideoCaptureDevice implementation for Fuchsia, so the tests can be enabled now. Bug: 866669, 1075762 Change-Id: Ic7577a6214aaadb6af49ac21fe2b169bea3af9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186193 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Ben Joyce authored
This is no longer needed as references have migrated to androidx. Bug: 1069613 Change-Id: Id39d484c82383b963e3f6f3e30a1fcefcf69c9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144364 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#766310}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e160d4ae8604..3079074f69fa git log e160d4ae8604..3079074f69fa --date=short --first-parent --format='%ad %ae %s' 2020-05-07 taylori@google.com perfetto-ui: Show one letter on a slice if possible Created with: gclient setdep -r src/third_party/perfetto@3079074f69fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:155693182 Tbr: perfetto-bugs@google.com Change-Id: I5deeb68f81c49d02af28065c321ccc3262526e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186945Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766309}
-
Rune Lillesveen authored
These values map to a fixed number of CSS pixels, but zoom was not applied as for other pixel lengths so that the output would not scale with the zoom level. Discovered running wpt/css tests with dpr=2. TEST=external/wpt/css/CSS2/floats-clear/floats-114.xht Bug: 1078776 Change-Id: I6cc8aa6d3f6e077539492166760967ce6fa31b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184889Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#766308}
-
Anders Hartvoll Ruud authored
Recently, we changed our behavior w.r.t. auto-disabling of native appearance on UI elements: we now disable the appearance if any author declaration is seen for background/border, even if those declarations match the UA-specified style. Technically, an author-level 'revert' is still an author declaration, so blindly following the above rules would still disable the native appearance. However, it would not match the author expectation for 'revert'. It is natural that e.g. 'all:revert' on UI elements restore exactly the style the element would have had without author styles. This CL adds kBorder/kBackground flags, and a mechanism for collecting all CSSProperty::Flags seen for the kAuthor origin. Those flags are then used at the end of the Apply process to provide values for SetHasAuthorBorder/Background. Also fix test with commented out subtests, and add bonus test for css-logical. Bug: 579788, 1061846 Change-Id: Ie88d666597f6aa8b38657d9c20fe3006ed5a8e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178891Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Rachel Carpenter authored
This should be shown to all users that are not new, ie they have probably seen the previous app. Also fix hasTouchScreen - the boolean was around the wrong way. Bug: b/155145109 Change-Id: I80c4fe0a339636d5ca2e405632a8f10617af5027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181700Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#766306}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9e97ca6c141..8789cfc7a5bc Created with: gclient setdep -r src-internal@8789cfc7a5bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1054351 Tbr: noel@google.com Change-Id: I564685aa911b2eda6666449710712d3f9c7f90b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186940Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#766305}
-
Simon Zünd authored
This test blocks recent CDP changes to be rolled into DevTools. The CDP change requires the usual dance. Disable the test, roll the CDP change into the frontend, re-baseline and re-enable the test. R=mathias@chromium.org Bug: chromium:1031511 Change-Id: I49d906e362e77f118128fa6c20421af69ae4a903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187169 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#766304}
-
Lei Zhang authored
Bug: 418837 Change-Id: Ic6bd489e5f8ec81dea28eedbc74c8f0289340769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184049Reviewed-by:
Chirantan Ekbote <chirantan@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#766303}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a2ec926cfcc4..101da7573691 git log a2ec926cfcc4..101da7573691 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 cnorthrop@google.com Capture/Replay: Update gfxbench traces 2020-05-06 cnorthrop@google.com Sync state when calling getTexImage Created with: gclient setdep -r src/third_party/angle@101da7573691 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I0219ba9b90438d839fcd01968a3fcfefc813ce29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186932Reviewed-by:
-
Mohsen Izadi authored
The finch experiment is expired and we are stopping it for now. Bug: 993895 Change-Id: I91afba37f087030d3ed05a9a69a356560e75a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2180522Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#766301}
-
Tsuyoshi Horo authored
window.open related tests were flakey on Android assumingly because the renderer process was killed by OOM-killer. To avoid OOM-killer, this CL changes window.open() tests to close the latest opened window. Bug: 1077177 Change-Id: I38fc99ebf08e0878b3db601d30fc06ecaaa0d403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186782 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#766300}
-
Xiaocheng Hu authored
We currently allocate a FontFallbackMap to every FontSelector and FontCache, even when it's never used. This results in a memory regression by a HashTableArea page (128KiB) in each renderer process. This patch fixes that by allocating on demand. Bug: 1078718 Change-Id: Iecc1a91d7ac9c91fbdbad114765023f83993aae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185523 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL stops instantiating WebappActivity#mWebappInfo in the WebappActivity constructor. This is unneeded because: - WebappActivity#getWebappInfo() is not accessed prior to WebappActivity#performPreInflationStartup() - ChromeBrowserInitializer#handlePreNativeStartup() handles the case of BrowserParts#preInflationStartup() finishing the activity and stops activity initialization in this case. - The Android OS does not call Activity#onStart()/Activity#onResume() if Activity#onCreate() finishes the activity. BUG=1077142 Change-Id: I6ae65d5d7805f216ea1c49f4c7756c9adf3536b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181075 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#766298}
-
Adam Langley authored
PublicKey was an interface, implemented by OpaquePublicKey (used by CTAP2) and P256PublicKey (used by U2F). But we only need to store the CBOR bytes (and, in the future, the algorithm and DER bytes too). Thus PublicKey can just be a container for a few members and the different logic is only needed when parsing. Thus this change makes PublicKey a concrete type that stores what we need and P256PublicKey becomes a struct/namespace for functions for creating PublicKey objects from P-256 public keys. Additionally, apply sanity checks in U2F and CTAP2 paths that ensure, for example, that the public key is on the curve. Change-Id: I0e952200f10195e675bd2841100e51bd215b6d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182931 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#766297}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0372f9726d85..4daf9ae6dfb7 git log 0372f9726d85..4daf9ae6dfb7 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@4daf9ae6dfb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifd04ccc01058d25377a53bee4947af0f633dd394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186936Reviewed-by:
-
Jiewei Qian authored
This CL updates a service worker registration check so the installation pipeline don't register service worker for chrome-untrusted:// system apps. Also Added a test to check the installation pipeline does not register service worker for locally served Apps (chrome and chrome-untrusted schemes). Fixed: 1078314 Change-Id: Ib163e443fb0e48fef049e04e81fba0517c7c486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182000 Commit-Queue: Jiewei Qian <qjw@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#766295}
-
Shakti Sahu authored
FakeTileService should be externally visible, currently it is in test_lib which also depends on internal. It's better to separate it into a different target which can be used from external test targets. Change-Id: I99fc63bcda0e24af7b75be353091a931fc433fd9 BUG: 1077913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185441 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766294}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28d920a91654..88d04cb51acf git log 28d920a91654..88d04cb51acf --date=short --first-parent --format='%ad %ae %s' 2020-05-06 bsalomon@google.com Revert "Fix tile modes in SkGpuBlurUtils." 2020-05-06 jlavrova@google.com Lines ending with hard line breaks should not be justified 2020-05-06 nifong@google.com Add markCTM to canvaskit API, use in 3D cube example 2020-05-06 johnstiles@google.com Fix format specifier in skpbench. 2020-05-06 rmistry@google.com Support specifying hash and patch_ref in skia-release & skia-wasm-release Dockerfiles 2020-05-06 fmalita@chromium.org [skottie] Introduce an external layer API 2020-05-06 egdaniel@google.com Split apart creating and updating GrBackendTextures internally. Created with: gclient setdep -r src/third_party/skia@88d04cb51acf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I1156268c535a3a777d2a993cbb621e986acae262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186394Reviewed-by:
-
DongJun Kim authored
EnableMethodManifestUrlForSupportedApps() in manifest_verifier.cc currently marks ALL apps from an app_origin as enabled for a payment method if "supported_origin_strings" of the payment method manifest contains the app origin. This is not always correct. For example, given the following setup: 1) https://alicepay.com/ hosts two apps: - /app1 supports payment method "foo.com" - /app2 supports payment method "bar.com" 2) Both "foo.com" and "bar.com" are in specified in a given PaymentRequest 3) The payment method manifest at "foo.com" has "alicepay.com" in supported_origin_strings 4) The payment method manifest at "bar.com" does NOT have "alicepay.com" in supported_origin_strings without this change, both /app1 and /app2 will be marked as enabled with "foo.com" as the enabled method. With this change, only /app1 will be enabled and /app2 will be removed in ManifestVerifier::RemoveInvalidPaymentApps(). Bug: none Change-Id: I5d5811f9a9a921e30c9bd1de611a7f3c0db07fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174249 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#766292}
-
Scott Little authored
The ProfileMenuClickTest_SyncPaused.ProfileMenuClickTest_SyncPaused/* tests are flaking on the Win7 Tests (1) builder, so this CL disables them for Windows. See bug for more details. TBR=droger@chromium.org Bug: 1079012 Change-Id: I92a594db225a10651f7adaa5e8a4880bf5629018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186452Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#766291}
-
Kent Tamura authored
ruby-position property should work with 'ruby text container boxes'. So ruby-position on <rt> should not work. https://drafts.csswg.org/css-ruby-1/#rubypos Bug: https://github.com/web-platform-tests/wpt/issues/23386 Change-Id: I3c3e7a762c8f88d5ffce1101692b06b6e496e49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186615 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f7df9c456088..f9eef45dbe2e git log f7df9c456088..f9eef45dbe2e --date=short --first-parent --format='%ad %ae %s' 2020-05-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@f9eef45dbe2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I27b9f1f6a5722d439d5c57212adc0c33741677e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186934Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b7dbb4835123..e8bf706d161d git log b7dbb4835123..e8bf706d161d --date=short --first-parent --format='%ad %ae %s' 2020-05-07 jiawei.shao@intel.com Add basic supports of storage textures on D3D12 2020-05-07 enga@chromium.org Expand depth sampling tests 2020-05-06 enga@chromium.org Split ComparisonSampler tests with/without normalized depth textures 2020-05-06 rharrison@chromium.org Add Tint to DEPS for standalone checkouts Created with: gclient setdep -r src/third_party/dawn@e8bf706d161d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ia7981394e05326510f794b6b32b9f93a17240bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186933Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ib5730a2d4ef21520c2032c7a010c00e84812e387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169433 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2bac0da13f74..e9e97ca6c141 Created with: gclient setdep -r src-internal@e9e97ca6c141 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: noel@google.com Change-Id: Ifdec115c450e95fc220ab2fe18f9b504c26e0ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186931Reviewed-by:
-
Makoto Shimazu authored
Cache#add internally calls fetch() API. This CL adds the test to check if Cache#add cannot reach to the network when the service worker is in the offline mode. R=falken@chromium.org, asamidoi@chromium.org Bug: 965802 Change-Id: I2fbe36d0e0d9413b917a88dcb1b590ffffca44ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174438Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#766285}
-
Xing Liu authored
This CL removes two resumption histograms added for the download resumption without strong validator experiment. TBR=holte@chromium.org Bug: 1075623,1075624 Change-Id: I4ee0b573cfa79af26d4d3076247604607e6bc2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168235 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#766284}
-
Hesen Zhang authored
- Fulfill with unit test. - Added suspend result for fetcher. Bug: 1063996 Change-Id: Ic1def777a453caf3a790fb0ff57dda1aae534204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186450 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
Design doc: https://docs.google.com/document/d/1s3N9ny8gTNjp3QrxQ5d5Bh3i8sAiWxdv83T-WJk0Qa0/edit?usp=sharing This CL: - Removes usage of WebappActivity#addWebappInfo() - Unifies onNewIntent() handling in BaseCustomTabActivity BUG=1069311 Change-Id: If2c9b5652296ff662ac2859858140def1c511f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148380 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
-
