GitLab

The histogram was added in https://codereview.chromium.org/159143007/.

R=jar@chromium.org,rch@chromium.org
BUG=none
TEST=none
NOTRY=true

Review URL: https://codereview.chromium.org/171453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252120 0039d316-1c4b-4281-b951-d872f2087c98

This uses the new IRT construction API.

This will allow references to PPAPI to be removed from src/untrusted/irt
in the NaCl repo.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787
TEST=browser_tests

Review URL: https://codereview.chromium.org/171093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252119 0039d316-1c4b-4281-b951-d872f2087c98

A few perf tests were writing results against the same measurement name making it impossible to distinguish and compare measurements. This patch adds modifier strings to make the measurments clear.

BUG=343684

Review URL: https://codereview.chromium.org/167753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252118 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252117 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167305:167430&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/165393015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252116 0039d316-1c4b-4281-b951-d872f2087c98

The test no longer ran correctly due to a change in the exception message since it was disabled. This CL updates the test to run correctly again, makes it more robust against timing issues, and re-enables it.

BUG=306702

Review URL: https://codereview.chromium.org/138913020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252114 0039d316-1c4b-4281-b951-d872f2087c98

This prevents libspeechd from hanging in getline() indefinitely, which may lock other threads that are trying to fflush all the open files.

BUG=333003
R=dtseng@chromium.org,dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/172103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252113 0039d316-1c4b-4281-b951-d872f2087c98

This CL logically reverts r206742 "Split InputMethodWin into InputMethodIMM32 and InputMethodTSF".
That was a tentative solution during the Aura transition.

BUG=330735, 344209
TEST=manually done on Windows 7

Review URL: https://codereview.chromium.org/166063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252112 0039d316-1c4b-4281-b951-d872f2087c98

This metric was added to update_engine to track how the
install-date-days variable is calculated.

BUG=chromium:336838
TEST=Validated the xml, pretty print succeeded.

Review URL: https://codereview.chromium.org/166483007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164227
R=rgustafson@chromium.org, skare@chromium.org, vadimt@chromium.org

Review URL: https://codereview.chromium.org/162273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252109 0039d316-1c4b-4281-b951-d872f2087c98

This change modifies PpapiDispatcher to inherit IPC::Listener and IPC::Sender
instead of ProxyChannel directly. This cleans up the class hierarchy a bit.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/172103008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252108 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=darin@chromium.org, davemoore@chromium.org

Review URL: https://codereview.chromium.org/172433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252103 0039d316-1c4b-4281-b951-d872f2087c98

Generated using:
> git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g"

BUG=343235
TBR=gdk@chromium.org
TBR=weitaosu@chromium.org
TBR=michaeln@chromium.org

Review URL: https://codereview.chromium.org/171813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252102 0039d316-1c4b-4281-b951-d872f2087c98

Generated using:
> cd src/ash
> git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g"

BUG=343235

Review URL: https://codereview.chromium.org/169063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344361

Review URL: https://codereview.chromium.org/171263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252100 0039d316-1c4b-4281-b951-d872f2087c98

Previously, TouchEditableImplAura returned the root window as its native
view which was used as the parent of touch editing handles and quick
menu. This caused some positioning problems in external display. Here,
TouchEditableImplAura is changed to return the browser window as its
native view (similar to Views::Textfield's current behavior).

BUG=339627

Review URL: https://codereview.chromium.org/166443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252099 0039d316-1c4b-4281-b951-d872f2087c98

There is now a TranslateManager per tab.
TranslateManager is owned by TranslateTabHelper.

This changes simplifies all the tracking of WebContents objects,
since there is now one and only one WebContents per TranslateManager.
This allows to get rid of all the |web_contents| parameters as well as the
PendingRequest type.

Users of the TranslateManager now get a manager from a WebContents
object, through the associated TranslateTabHelper.

BUG=332736
TBR=brettw

Review URL: https://codereview.chromium.org/166963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252098 0039d316-1c4b-4281-b951-d872f2087c98

Make ScrollByContentsOffset() work as intended after resize.
contents_scroll_offset_ was not being updated on Update().
Add a test that fails without this fix. Fix an Aura include.

BUG=344490
TEST=Click page icon, click "Show cookies and site data". Expand a node to make a scrollbar appear, scroll down; collapse the node, re-expand the node; scrolling down should work.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/171423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252097 0039d316-1c4b-4281-b951-d872f2087c98

We use unittest.cc suffix for tests that use gtest and are not
interactive ui tests or browser tests. This is also more consistent with
the files around.

BUG=180681
TEST=unit_tests
R=sky@chromium.org

Review URL: https://codereview.chromium.org/169013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252096 0039d316-1c4b-4281-b951-d872f2087c98

The SystemPolicyRequestContext wraps the system request context and is used
to make cloud policy requests that shouldn't be related to a particular user.

Some tests intercept requests sent via the system request context. By
copying the job factory, those interceptors will also see the requests going
through the SystemPolicyRequestContext.

BUG=None

Review URL: https://codereview.chromium.org/172463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252095 0039d316-1c4b-4281-b951-d872f2087c98

This flag is redundant with --disable-gpu which causes us to fall into
software compositing mode.

Depends on: https://codereview.chromium.org/167973003/

R=piman@chromium.org, piman
BUG=

Review URL: https://codereview.chromium.org/166163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252093 0039d316-1c4b-4281-b951-d872f2087c98

ChromeOS always sets this value to 1. Other Aura platforms don't use
the cc scheduler yet so they don't care about this value. Once they
do, they'll want to use 1 as well. So set it to 1 always.

R=piman@chromium.org, piman
BUG=344094

Review URL: https://codereview.chromium.org/168073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252091 0039d316-1c4b-4281-b951-d872f2087c98

Follow up from ShellWindow -> AppWindow rename in http://crbug.com/343591

BUG=344084
TBR=jamescook@chromium.org chrome/browser/ui/ash/*
TBR=benwells@chromium.org chrome/browser/ui/{cocoa,gtk,views}*

Review URL: https://codereview.chromium.org/171593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664
R=kinuko@chromium.org, dgrogan@chromium.org

Review URL: https://codereview.chromium.org/168833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252089 0039d316-1c4b-4281-b951-d872f2087c98

This change is part of eliminating the signin-related notifications in favor of
having clients observe SigninManager.

BUG=333997

Review URL: https://codereview.chromium.org/170383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339878
NOTRY=True
R=frankf@chromium.org

Review URL: https://codereview.chromium.org/170263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252086 0039d316-1c4b-4281-b951-d872f2087c98

The views::LinuxUI* object is global across profiles. However, it stored
profile specific state in the form of a |use_gtk_| variable. This fixes
Gtk2Borders so that they ask their owning view for a ThemeProvider and
expands the ui::ThemeProvider interface so that it exposes the
UsingNativeTheme() call from the ThemeService layer, instead of asking
the views::LinuxUI provider directly, which will likely return stale state.

BUG=340805, 340799

Review URL: https://codereview.chromium.org/171413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252085 0039d316-1c4b-4281-b951-d872f2087c98

This is a small reorganization before a bigger one.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/163023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252082 0039d316-1c4b-4281-b951-d872f2087c98

Public session pods are placed first so this should be reflected in UserManager::EnsureUsersLoaded() because UserManager::GetUsers() user list is used to determine first user wallpaper.

BUG=344858

Review URL: https://codereview.chromium.org/172353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252080 0039d316-1c4b-4281-b951-d872f2087c98

Add some basic perftests that track how long a given WebTouchEvent or
WebGestureEvent takes to propagate through the InputRouter.  This includes both
the time to send and the time to ack a given event, averaged over a typical
touch swipe or scroll gesture sequence.

BUG=339877
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/170913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252079 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug where global_instance_ was not set to zero.
Fix MockRenderThread to call OnChannelClosing properly.

Review URL: https://codereview.chromium.org/169063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252078 0039d316-1c4b-4281-b951-d872f2087c98

Ensure the extension install UI has a profile available to use for image loading, even if the prompt is opened before any browser window are available.

This bug is currently crashing Clusterfuzz ~100 times per hour and polluting the crash statistics.

BUG=344199
TEST=see bug
TBR=miket@chromium.org

Review URL: https://codereview.chromium.org/168823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344938
R=waffles@chromium.org

Review URL: https://codereview.chromium.org/172883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252076 0039d316-1c4b-4281-b951-d872f2087c98

Filter out GestureDoubleTap events on elements with touch-actions
other than auto. When GestureDoubleTap is being filtered out,
we also eliminate the tap delay.

BUG=337534
TEST=TouchActionFilterTest.DoubleTap,
  TouchActionFilterTest.DoubleTapWithTouchActionAuto

Review URL: https://codereview.chromium.org/170603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252073 0039d316-1c4b-4281-b951-d872f2087c98

Generated using:
> cd src/chrome/app
> git grep -l pp_ifdef | xargs sed -i "s:pp_ifdef('\([^']\+\)'):\1:g"

BUG=343235
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/171673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252072 0039d316-1c4b-4281-b951-d872f2087c98

Currently the observer is only removed if the overlay is closed.
Also remove it in case we switch to the create profile overlay.
This fixes an assertion.

BUG=344813
TEST=Switch between import overlay and create profile overlay.
TBR=pam@chromium.org

Review URL: https://codereview.chromium.org/165943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252071 0039d316-1c4b-4281-b951-d872f2087c98

The ui flag is always true on ChromeOS and off elsewhere. The other is
never on and we're not planning to turn it on.

R=piman@chromium.org, piman
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251538

Review URL: https://codereview.chromium.org/164183012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252070 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252069 0039d316-1c4b-4281-b951-d872f2087c98

Changes
r251855: Fix compilation of NSPR and NSPR for aarch64

BUG=314720
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/172143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252068 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=344693

Review URL: https://codereview.chromium.org/171783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252067 0039d316-1c4b-4281-b951-d872f2087c98