GitLab

[1] ensured kPaintLayerPaintingOverflowContents was cleared
when painting a new root but failed to clear
kPaintLayerPaintingCompositingScrollingPhase as well. This
caused a regression where negative z index children of a
scrolled and transformed paint layer would not paint.

This patch fixes and tests the regression from [1], as well
as passing one additional test with root layer scrolling.

[1] https://crrev.com/19f7cb8adfd015bef06b08d0c02eb5a528e8c885

Bug: 779885
Change-Id: Id73ae360000efe866fd9c9c7c1dade186d547cac
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/749059Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513276}

Make DownloadItemView to triger download feedback when user press SAVE
button in generic warning.

Bug: 773105
Change-Id: I119d0f9e119115c38ee3a725345105e8ef93866b
Reviewed-on: https://chromium-review.googlesource.com/747879Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513275}

multibuffer_data_source.h contains a GURL field carried over from a
previous refactor. This field isn't used for anything and should be
removed.

Change-Id: I3767482358342fca2414eedb547daf467ea47411
Reviewed-on: https://chromium-review.googlesource.com/749317Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513274}

The test is failing on intel and amd, but not on nvidia. Disable it
now while I investigate.

TBR=kbr@chromium.org
BUG=780118

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iae399d4079aefdd76facfe08df8280ede8b7327c
Reviewed-on: https://chromium-review.googlesource.com/749784Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513273}

This reverts commit 33fc6c64.

Reason for revert: One or the other of this CL and https://crrev.com/c/748268 (perhaps both in combination?) broke PaletteTrayTestWithVoiceInteraction.StylusBarrelButtonActivatesHighlighter on Linux ChromiumOS Tests (dbg)(1):

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31692

The connection to these voice interaction Cls seems pretty clear. I can't identify which one it is, though, so while I apologize for the trouble, I'm going to revert both to ensure that the bot turns green again.

Original change's description:
> Move assistant icon animation to CompositorAnimationOberver
> 
> BUG=None
> TEST=locally build and see animation running as before.
> 
> Change-Id: I1eb62490108beaaec0795adb4251054c03b364e1
> Reviewed-on: https://chromium-review.googlesource.com/748273
> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513211}

TBR=xiyuan@chromium.org,xiaohuic@chromium.org

Change-Id: I5ef677c189808601f8e357f56a171bf920b10fa0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/749851Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513272}

This reverts commit f69055b7.

Reason for revert: One or the other of this CL and https://crrev.com/c/748273 (perhaps both in combination?) broke PaletteTrayTestWithVoiceInteraction.StylusBarrelButtonActivatesHighlighter on Linux ChromiumOS Tests (dbg)(1):

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31692

The connection to these voice interaction Cls seems pretty clear. I can't identify which one it is, though, so while I apologize for the trouble, I'm going to revert both to ensure that the bot turns green again.

-- Chromium Sheriff

Original change's description:
> Do not play assistant end animation when hiding
> 
> When assistant is started and triggered hiding animation, during a very
> short time window if the user lifted their finger, we would try to play
> end animation.  We should avoid doing that.
> 
> BUG=b:67496461
> TEST=build and flash locally, see animation playing normally
> 
> Change-Id: Idf52f692edd9d05b16ad48687384d291b208a42e
> Reviewed-on: https://chromium-review.googlesource.com/748268
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513208}

TBR=xiyuan@chromium.org,xiaohuic@chromium.org

Change-Id: I13b9410f76829ec1491e9191e53519914d57f7cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:67496461
Reviewed-on: https://chromium-review.googlesource.com/749849Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513271}

MacOS's alert dialog seems to need allowing nestable tasks for tab
navigation to work.

BUG=778562

Change-Id: Ic8654defa4e6ec1c7089639108e8a937e923b486
Reviewed-on: https://chromium-review.googlesource.com/747849
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513270}

As part of the progress to make GRC strongly typed, we also lean towards to
making output mojo interface strongly-typed when needed. This patch removes the
current two generic APIs from the mojo interface and creates two APIs that are
used by the current TabSignalObserver implementation.

BUG=775691

Change-Id: I3ddd06fc723dd63982be21ee39e5809305765751
Reviewed-on: https://chromium-review.googlesource.com/747962Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513269}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/fe94e7274e40..5da404cf35b6

$ git log fe94e7274..5da404cf3 --date=short --no-merges --format='%ad %ae %s'
2017-10-31 maruel Remove code that should have been deleted 3 years ago.
2017-10-31 maruel run_isolated: ignore relative_cwd if isolated's command is not used.
2017-10-30 maruel client: throw if the response is corrupted.
2017-10-27 maruel Do not run tests (and most tests) on upload anymore
2017-10-27 maruel Print more information in case of failure

Created with:
  roll-dep src/tools/swarming_client

-> Feel free to revert if anything goes wrong <-

TBR=vadimsh@chromium.org

Bug: 779718
Change-Id: Id21c679bdee0cd48af58d96a7558759297a9fa9e
Reviewed-on: https://chromium-review.googlesource.com/749583Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513268}

Currently 'network-connected' is fired much to often, causing
significant slowdowns on slower devices, especially in
chrome://network (debugging) but potentially to a lesser degree
in oobe and Settings.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I171e2015b7257f9e19b383687ae20282c0eb6c4c
Reviewed-on: https://chromium-review.googlesource.com/747077Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513267}

https://webrtc.googlesource.com/src.git/+log/6063e98dcb50..464e89c0ca66

$ git log 6063e98dc..464e89c0c --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I416418720bdcf621df6722be91451a53514ca092
Reviewed-on: https://chromium-review.googlesource.com/749661Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513266}

This is more suitable place for it, as it will be used from different layers.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaa3a11f53730216d7c3794fc5cd771fd936c17be
Reviewed-on: https://chromium-review.googlesource.com/748601Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513265}

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib1213187bb32b15cc5b6650d341f6d1433bfd77a
Reviewed-on: https://chromium-review.googlesource.com/748891
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513264}

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I7d85c312088c71d4cb248ed1e36ed84fc8ebb9ef
Reviewed-on: https://chromium-review.googlesource.com/748976
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513263}

The migration tools inadvertently replaced autorelease with "= nil" in this
case.

Originally introducted in 9d30c08f.
Surrounding code was fixed in e5a9cd7d, but this
line was overlooked.

BUG=None

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0872c29999934c04e330cf2e3f20b6d114d2657f
Reviewed-on: https://chromium-review.googlesource.com/749521
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513262}

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I12bd2a76480db77acdff4cf37e2778ee3d7c5fc9
Reviewed-on: https://chromium-review.googlesource.com/749050
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513261}

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ie6ce877aea48b719b1bacbd7825abce107f3c04e
Reviewed-on: https://chromium-review.googlesource.com/748978
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513260}

Bug: 740905
Change-Id: I8b052887895bee3038df20517d8cc68f36389962
Reviewed-on: https://chromium-review.googlesource.com/746803Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513259}

In preparation for sharing the test, move the Create test to
the test template.

(Split from http://crrev.com/c/680100 for AHardwareBuffer-based
GpuMemoryBuffer)

BUG=761432

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I766f115cde35777a93351a57c7a5fa64d62f2368
Reviewed-on: https://chromium-review.googlesource.com/747604
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513258}

Bug: 778780
Change-Id: Ie3cc8633cb03e9711a4777c6c884f4fb07a7ab68
Reviewed-on: https://chromium-review.googlesource.com/740301
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513257}

This CL provides a line of instructions for creating extensions shortcuts.
It also adds interactive feedback during shortcut entry.

Bug: 769576
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I419cb1f4e3ee63aa47fc56ca784faa5ec9f2fdb6
Reviewed-on: https://chromium-review.googlesource.com/748082
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513256}

This changes management of the window position from booleans which live on
ash::wm::WindowState to general aura Window properties. These can be set from
//chrome/ without having to link with the non-public parts of //ash/.

Bug: 780160
Change-Id: I834c268dcf333576bf88a24f99d388cf9732a9e5
Reviewed-on: https://chromium-review.googlesource.com/747876Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513255}

- Explain |view_| member's life time.
- Remove an old comment that does not make sense.
- std::make_unique() everywhere.

Change-Id: I42360b80ea66fbd38705223a162f1683b49ab5b3
Reviewed-on: https://chromium-review.googlesource.com/740709
Commit-Queue: Nick Carter <nick@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513254}

The overridden method is from NetworkChangeObserver and not from
IPAddressObserver.

TBR=isherman@chromium.org

Bug: 754695
Change-Id: Ic37fccfce1abc1e89ad6300b652416cd73a6f39b
Reviewed-on: https://chromium-review.googlesource.com/749302Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513253}

The classifier tries to add all prefixes to the autocomplete input, from
the ones with the smallest number of components to those with largest
num components (e.g. for input 'www.blah.foo', it checks
'http://www.blah.foo' before ''http://www.www.blah.foo'). This CL addds
an additional preference for HTTPS prefixes over HTTP.

Note on the change to history_url_provider.cc: the comparator was failing
to distinguish entries that have all features equal (such as present in the
test). An additional tie-breaker was added to increase the stability of
our tests. One of the tests in HistoryURLProviderTest.MatchURLFormatting
was failing because the url_prefix.cc change was changing the order in
the list of suggestions prior to sorting/deduping.

Bug: 6794
Change-Id: Ie1bdcacaea8213439b2f52c062ce11d17b8f1d51
Reviewed-on: https://chromium-review.googlesource.com/749313Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513252}

Code checks for the size when allocating a raster shape
(for CSS shape-outside) but ASAN defeats this check by
allocating more than the exact image size. Be robust to
this case and other out-of-memory situations by handling
failed allocations.

R=fs@opera.com
BUG=779366

Change-Id: I11b1f9baaac21d89044dbaa1d5ed6cd188ccc813
Reviewed-on: https://chromium-review.googlesource.com/749320Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513251}

Deleting CS Ranker Model. This change is not wire-compatible, but we have not published any CS models yet. So, this should not break anything.

Bug: 759161
Change-Id: I43e6a2885a97ab030eb43edd01e44773e6239693
Reviewed-on: https://chromium-review.googlesource.com/732167Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Philippe Hamel <hamelphi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513250}

https://chromium.googlesource.com/webm/libvpx.git/+log/401e6d48bfd3..3ba9a2c8b234

$ git log 401e6d48b..3ba9a2c8b --date=short --no-merges --format='%ad %ae %s'
2017-10-31 jianj vp9: Move allocation of vt2 after early exits.
2017-10-30 jianj vp9: Reduce stack usage of choose_partitioning.
2017-10-30 jianj vp9: Reduce stack usage of choose_partioning.
2016-07-19 jzern vp8: correct if/else '{' placement
2017-10-26 slavarnway vpx: hadamard: use ptrdiff_t instead of int for stride
2017-10-22 kylesiefring Optimize convolve8 SSSE3 and AVX2 intrinsics
2017-10-23 marpan vp9-svc: Allow for adapt_rd_thresh with row-mt.
2017-10-20 slavarnway vpx: [x86] vpx_hadamard_16x16_avx2() highbitdepth fix
2017-10-20 slavarnway vpx: [x86] vpx_hadamard_16x16_avx2() improvements
2017-10-18 slavarnway vpx: [x86] add vpx_hadamard_16x16_avx2()
2017-10-11 paulwilkins Corpus VBR tweak for undershoot.
2017-10-11 paulwilkins Increase precision of some debug stats output for corpus VBR.
2017-10-11 paulwilkins Prevent double application of min rate in two pass.

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

BUG=b/68362457

Change-Id: If020f2122bea6b00926aa51469d6570b409fc47e
Reviewed-on: https://chromium-review.googlesource.com/749043Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#513249}

https://pdfium.googlesource.com/pdfium.git/+log/a85e5ca5f2df..1bc5e494b675

$ git log a85e5ca5f..1bc5e494b --date=short --no-merges --format='%ad %ae %s'
2017-11-01 dsinclair Add CJX_ThisProxy
2017-11-01 dsinclair Convert CScript classes to have CJX objects
2017-11-01 dsinclair Move CXFA_NodeList JS to CJX_NodeList
2017-11-01 dsinclair Move the item methods into CXFA_Node propertly

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib34123349d969d44fb5c85514df5d1ed12bb5a1c
Reviewed-on: https://chromium-review.googlesource.com/748711
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513248}

Removing IsSwapElementsNeeded since this functionality is no longer
needed, also removing the test for this.

Bug: 678141
Test: Build.
Change-Id: I86c34578d39ec75b2c79a0151cc04ef8366a31e0
Reviewed-on: https://chromium-review.googlesource.com/748709Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513247}

Fixes a regression which i am not sure when it came up. Adds a test
to device_page_tests.

Test: browser_tests CrSettingsDevicePageTest.StylusTest
Bug: 779243
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia658c07b90a816f0bb8ba0051068376f96466ea9
Reviewed-on: https://chromium-review.googlesource.com/742457Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513246}

With the addition of the TransferCache, we need a way to pass support
objects in to the Deserialize function. This adds an empty
DeserializeOptions struct to Deserialize. The transfer cache will be
added to this struct in a future CL.

Bug: 777622
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibf75721d0dd45987335204c9a0a4d91713f2ae99
Reviewed-on: https://chromium-review.googlesource.com/749442Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513245}

The crashe is because TabPersistentStore.mergeState() kicks off an
AsyncTask to restoreTabs and restoreTabs creates a Handler in
LayoutManager.onTabStateInitialized(). But the Handler is not created in
UI thread whose Looper is not created.

Bug: 778447
Change-Id: Ibad4993471c461c0df61903025211488f4e50328
Reviewed-on: https://chromium-review.googlesource.com/746025
Commit-Queue: Lei Tian <ltian@google.com>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513244}

It tests invalidation when visibility changes from hidden to visible,
and expects invalidation of the changed object. However, the object
previously used an invalid color value causing it was never visible.

SPv175 is smart to skip raster invalidations for objects painting
nothing. Fix the test to let SPv1 and SPv175 produce the same result.

Bug: 771643
Change-Id: I09729ac33b993c98b908bc8ec35a288205af04b3
Reviewed-on: https://chromium-review.googlesource.com/749042
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513243}

If I send a second upload tryjob with the same revision/subrevision
as a previous job, it means that I have changed the script and I want
to rebuild that revision/subrevision with my changes, so the correct
thing to do is to rebuild.

Bug: 
Change-Id: I1d1822ec695aecc92df25d24d09c3becc506eb4d
Reviewed-on: https://chromium-review.googlesource.com/747623Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513242}

It used to be that you could select whether to strip cookies and auth
headers for export, with the default being to strip.

The ability to export was since removed, which also lost the option to
disable stripping. This change removes stripping all together.

(With stripping removed from net-internals#events, users can
inadvertently expose data when copy-pasting visualizations of the net
log, however this is considered out of scope.)

Ultimately this won't matter as net-internals#events is slated for
eventual removal (crbug.com/678391).

Bug: 777473
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7833e3c1f15feab8acf8609a82cbc9e2f2dae422
Reviewed-on: https://chromium-review.googlesource.com/747864Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513241}

Ignoring the result of WaitUntilConditionOrTimeout call is incorrect in
many cases. So WaitUntilConditionOrTimeout will have WARN_UNUSED_RESULT
annotation to force callers to do the checks. This CL prepares ios/web
for WaitUntilConditionOrTimeout changes.

Bug: 780062
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ide53b4613df407149c43cdfa68751be171db313f
Reviewed-on: https://chromium-review.googlesource.com/746995Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513240}

R=tomfinegan@chromium.org

Change-Id: Ib12dc27749f3fee141c2367773effcd58a390530
Reviewed-on: https://chromium-review.googlesource.com/746026Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#513239}

Before this CL we had two different paths
for creating pointercancels. One for mouse
pointercancels and one for touch/pen cancels.
This LC refactor the code for these two paths.

Bug: 778351
Change-Id: Ie498c5afb2e3aee7938e51db33ea8de7cb7323dc
Reviewed-on: https://chromium-review.googlesource.com/740144Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513238}

Add a new performance test for line breaking using ShapingLineBreaker to
allow us to catch/detect performance regressions and track progressions.

Test: Source/platform/testing/ShapingLineBreakerPerfTest.cpp
Change-Id: If95c2d3b3f2279219f3d883f0015a3d1de5eaa2a
Reviewed-on: https://chromium-review.googlesource.com/729560
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Walter Korman <wkorman@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513237}