- 01 Feb, 2019 40 commits
-
-
danakj authored
RenderWidgetHostImpl already checks for |delegate_| before calling the method. The other caller does so in the same stack that it uses the WebContents, which is the delegate. The delegate is removed only when the WebContents is destroyed, so we know it will be present in both cases. TBR=ajwong@chromium.org Change-Id: Ia0fe71c00a87bb92b22ebeff545762fbcf72848d Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1443933 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#628349}
-
Charlie Andrews authored
NOTRY=true TBR=crouleau@chromium.org CC=sullivan@chromium.org,tdresser@chromium.org,kouhei@chromium.org,ksakamoto@chromium.org Bug: 927758 Change-Id: I936d18a449e5719b41b1be891a18b786b7bade5a Reviewed-on: https://chromium-review.googlesource.com/c/1450037Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#628348}
-
Sahel Sharify authored
Code coverage shows that the removed functions are never called. Change-Id: I4478bd70839cef2f0401c8c45586df5196b11184 Reviewed-on: https://chromium-review.googlesource.com/c/1448745Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#628347}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/63470298753a..ab56670af981 git log 63470298753a..ab56670af981 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 kwiberg@webrtc.org Add a small README file for api/ 2019-02-01 perkj@webrtc.org Fix heap use overrun in FakeEncoder 2019-02-01 artit@webrtc.org Update internal.*.webrtc iOS bots iOS version, remove redundant config file Created with: gclient setdep -r src/third_party/webrtc@ab56670af981 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iefa5e5b79a3dc5e6b288f1599acf8194a409059a Reviewed-on: https://chromium-review.googlesource.com/c/1449777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628346}
-
David 'Digit' Turner authored
This CL ensures that strings from all Chrome-supported locales are placed in Chrome app bundles, unlike APKs which omit a few locales, to save disk size, except for the specific WebView-related strings. This is achieved by making a few significant changes to the way resources are compiled: - Webview-related string resources are identified at build time by passing --shared-resources-whitelist to compile_resources.py. This CL adds a new option --shared-resources-whitelist-locales, which lists the locales that apply to these specific resources. All other resources are subject to the list of locales provided through --locale-whitelist, if provided. - A new step named _RemoveUnwantedLocalizedStrings() is added to compile_resources.py to properly remove or _filter_ the content of locale-specific xml files. - Second, the build rules are modified as follows: * Before the CL, strings from locales not listed in aapt_locale_whitelist were always omitted from the final APK or app bundle. As such, for Monochrome, aapt_locale_whitelist corresponded to the list of all Chrome-supported locales, and only the values-<locale>.xml listed by each android_resources() target were used to limit the non-WebView strings. * After this CL, string resources covered by shared_resources_whitelist can be of any locale listed in shared_resources_whitelist_locales, a new variable, while aapt_locale_whitelist is only used to restrict all other resources in the output. * The default value of aapt_locale_whitelist for Chrome apks is now the restricted locale list, for APKs, and the full list for bundle modules. MonochromePublic.apk now uses shared_resources_whitelist_locales to ensure that Webview-related resources cover all locales. This change will allow a future CL to add missing values-<locale>.xml files in misc android_resources() targets, without affecting the ouput of APKs, but allowing said strings to be part of bundles. Overall, the effect of this CL is the following (determined by careful manual comparisons): - No changes from Chrome / ChromeModern APKs - For Chrome / ChromeModern bundles, adds strings from our omitted locales, mostly coming from WebView and AR/VR. - No change for Monochrome bundles (which already included all possible strings). - For Monochrome APKs though, this removes AR/VR strings for our omitted locales. They were previously bundled by accident. BUG=882860 R=agrieve@chromium.org, estevenson@chromium.org, yfriedman@chromium.org, benmason@chromium.org Change-Id: I4cc807eaa37815682fe84724e330ae1be28af23e Reviewed-on: https://chromium-review.googlesource.com/c/1448169 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#628345}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8aa4af2f..af7426e2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id92fd2326d4c027ee032145ed23b601a54cd0e59 Reviewed-on: https://chromium-review.googlesource.com/c/1450031Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628344}
-
Alex Newcomer authored
We prevent the AppListButton from being activated in tablet mode, but do not deactivate it upon transitioning. This can result in the button being active if the AppList is showing prior to the tablet mode transition. Bug: 911737 Change-Id: I0796e9ca051e96111cb3e48dbedbe8fea7b33997 Reviewed-on: https://chromium-review.googlesource.com/c/1447038Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#628343}
-
Lan Wei authored
In order to allow users to set radiusX, radiusY, rotationAngle and force for touch points in devtool protocol Input.dispatchTouchEvent, we should add these attributes to SyntheticPointerAction class as well for touch inputs. Bug: 606367 Change-Id: I2aaa43746c5c812ecabc675dadd7927f14a3f31c Reviewed-on: https://chromium-review.googlesource.com/c/1431313Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The invalidation service passed to AccountFetcherService in SetupInvalidationsOnProfileLoad is no longer used (usage was removed during the refactory of the code fetching whether an account is a child account). Remove the parameter and rename the method OnProfileLoaded (further investigation will be necessary to validate whether the method can be completely removed). Remove unused member field scheduled_refresh_enabled_ that was always set to true in the constructor and never changed. Bug: 927363 Change-Id: Id73fe3fc1a06e6248edf915f3fdaa8f039627933 Reviewed-on: https://chromium-review.googlesource.com/c/1448611 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#628341}
-
Tim Volodine authored
AndroidStreamReaderURLLoaderTest currently fails on android-marshmallow-arm64-rel bot (see crbug.com/927358). Removed the check to fix the bot, filed crbug.com/927744, for further follow-up. BUG=927358,927744 TBR=torne@chromium.org,tobiasjs@chromium.org NOTRY=true Change-Id: I95b55ae21af08a635cca21c88db4172c9658a41a Reviewed-on: https://chromium-review.googlesource.com/c/1449669Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#628340}
-
Lowell Manners authored
FakeGaiaCookieManagerService is being eliminated in favor of setting expectations using TestURLLoaderFactory. This is part of step 5 of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: I8ba1f2a07cceb678d13de68d2e00014b82f4ba1e Reviewed-on: https://chromium-review.googlesource.com/c/1448189Reviewed-by:
-
Julie Jeongeun Kim authored
This CL adds OnAccessTokenRemovedFromCache to IdentityManager::DiagnosticsObserver and it's called when IdentityManager gets OnAccessTokenRemoved through OAuth2TokenService::DiagnosticsObserver. Bug: 926827 Change-Id: I844599b67fc2333f0455c8ff5cd66537f50343c7 Reviewed-on: https://chromium-review.googlesource.com/c/1448076 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#628338}
-
Nico Weber authored
Bug: 927738 Change-Id: I9ca953e19137ee1c61257ff32d69c9074142735e Reviewed-on: https://chromium-review.googlesource.com/c/1449819 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#628337}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3dc93896b3a9..1a0126f61a98 git log 3dc93896b3a9..1a0126f61a98 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 reed@google.com skip huge allocation in test on 32bit devices 2019-02-01 robertphillips@google.com Remove destination GrRenderTargetProxy from GrPipeline Created with: gclient setdep -r src/third_party/skia@1a0126f61a98 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I20852b29f683b5ba6008c1279a5dd2db822213e2 Reviewed-on: https://chromium-review.googlesource.com/c/1449776Reviewed-by:
-
Daniel Bratell authored
In Windows (multi dll) builds, headless_shell_switches.cc was compiled twice and with some timings and linkers, that cause a duplicate symbol link error. In other cases one set of symbols was discarded as unused before the link errors. This setup was probably triggered by several build target (headless_renderer, headless_shell_browser_lib, headless_shell_child_lib and more) being compiled as if they were inside headless.dll in component builds. That prevented them from actually accessing the switches inside headless.dll. The fix is to only compile headless.dll ("component headless") with HEADLESS_IMPLEMENTATION, which controls HEADLESS_EXPORT, and to not have a duplicate copy of the switches in headless_shell_browser_lib. Bug: 919231 Change-Id: Id0d5cade84b47b9053474a26a1b14723c576d346 Reviewed-on: https://chromium-review.googlesource.com/c/1440141 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#628335}
-
Sylvain Defresne authored
Change ExtensionPrefValueMap::SetExtensionPref to take the base::Value parameter by value instead as std::unique_ptr<>. Fix client code to use the new API. Bug: 646113 Change-Id: I127b361ea7f44c9e2a753c113adedac90bc9d5bc Reviewed-on: https://chromium-review.googlesource.com/c/1448162 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#628334}
-
Antonio Gomes authored
This is a preliminary step to port AccountReconcilor and its unittests away from GaiaCookieManagerService::Observer BUG=926890 Change-Id: Ifa3b7e18cad45627e29730d2d422688c68a831ab Reviewed-on: https://chromium-review.googlesource.com/c/1446473Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
-
Egor Pasko authored
Chrome on Android/ARM relies on NEON. Counts for "No NEON support" are extremely low, and hence not useful overall. Bug: 489738 Change-Id: Ic96cdc4bc9274400d720b7e8f5c33b6887d04692 Reviewed-on: https://chromium-review.googlesource.com/c/1449659Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#628332}
-
Andreas Haas authored
This is part of our cleanup effort to remove deprecated API from V8. R=haraken@chromium.org Bug: v8:8562 chromium:913887 Change-Id: I5fee15e15d1ff42754650779c543e5ee712b6896 Reviewed-on: https://chromium-review.googlesource.com/c/1449673Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#628331}
-
Guido Urdaneta authored
Before this CL, the RTCIceCandidate constructor threw a nonstandard exception when the candidate field was an empty string. This CL removes this behavior and allows empty candidates. Bug: 683094 Change-Id: I95e1b47ce7909f53fea91e2046ac92723b7146d3 Reviewed-on: https://chromium-review.googlesource.com/c/1442236 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#628330}
-
Adithya Srinivasan authored
This is a reland of 9d473842 Original change's description: > Portals: Expose portalHost to portal's browsing context > > window.portalHost returns a PortalHost to script running inside the main > frame within a portal. > > Bug: 914117 > Change-Id: I26fb4ae9676261bee4446bfbc6ee34b28dc618b1 > Reviewed-on: https://chromium-review.googlesource.com/c/1399569 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#624316} Bug: 914117 Change-Id: I2830cafac26928229d474fd91921fbf2f9a47952 Reviewed-on: https://chromium-review.googlesource.com/c/1425041 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#628329}
-
Antonio Gomes authored
... rather than SigninManager. The delegates now pass IdentityManager instances rather than SigninManager instances to SigninStatusMetricsProvider, and SigninStatusMetricsProvider interact with those IdentityManager instances. PS: In a later CL, both //chrome's SigninManagerFactory::Observer and //ios/chrome's SigninManagerFactoryObserver can be removed. BUG=927345 Change-Id: Ic007bffd658e112261a97cf7027c50f916ba470e Reviewed-on: https://chromium-review.googlesource.com/c/1449278Reviewed-by:
-
Julie Jeongeun Kim authored
This CL removes AccountTrackerService from ProfileDownloader and uses IdentityManager instead of it. As AccountTrackerService is going to be a part of IdentityManager, AccountTrackerService::Observer::OnAccountUpdated is replaced with IdentityManager::Observer::OnAccountUpdated. This CL adds IdentityManager::Observer at the constructor. It doesn't fetch OAuth2 access token on OnRefreshTokenUpdatedForAccount if |waiting_for_refresh_token_| is not set. Bug: 922757, 922758 Change-Id: I8e5743089e208d4abee697ace45fbc99bc41fcea Reviewed-on: https://chromium-review.googlesource.com/c/1436780Reviewed-by:
-
Julie Jeongeun Kim authored
This CL removes SigninManager from profile_window_browsertest.cc and uses IdentityManager instead of it. Bug: 927238 Change-Id: I3f2f962b00cb2bbbd91509be1fa2bfb2869f1a3d Reviewed-on: https://chromium-review.googlesource.com/c/1449433Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Antonio Gomes authored
IdentityManagerFactoryObserver is a parallel interface to //ios/chrome's SigninManagerFactoryObserver. It will be used to replace usage of that observer in follow up CLs. BUG=927343 hange-Id: I5d32caf0fa0c24b692b6d5ccaf6f8d191818fd74 Change-Id: I801a883aa72ee69e3686fff58ddd4b5c893c799c Reviewed-on: https://chromium-review.googlesource.com/c/1448473 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Guido Urdaneta authored
Intent to implement and ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/T6zlVFZhRVY Drive-by: Fix a few minor lint issues. Bug: 683094 Change-Id: I1c8cb27e8583f200d6e4d9fe6f2d1b633e8dab66 Reviewed-on: https://chromium-review.googlesource.com/c/1429969Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87ab0aef9c54..7b80b951e0bf Created with: gclient setdep -r src-internal@7b80b951e0bf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I529304e74f8cccbeb0f5081d2767c43e672715ca Reviewed-on: https://chromium-review.googlesource.com/c/1449775Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628323}
-
Nico Weber authored
It looks like the dep on //content/public/browser:browser_sources isn't needed (and causes link problems); it was merely there to placate `gn check`. Instead, suppress `gn check` for this target and file a bug to fix the issues pointed out by `gn check` for real instead of incorrectly papering over them with this dep. Bug: 927713 Change-Id: If4d991a4961fd36937b75c442514d349d5d60ab0 Reviewed-on: https://chromium-review.googlesource.com/c/1449816 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#628322}
-
Vladislav Kuzkokov authored
Change-Id: I3fd7213c4ff62b17e6d2f101c35920e426f09763 Reviewed-on: https://chromium-review.googlesource.com/c/1448415 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#628321}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/569dda7216cd..3dc93896b3a9 git log 569dda7216cd..3dc93896b3a9 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 michaelludwig@google.com Narrow clear-as-draw workaround on D3D11 ANGLE Created with: gclient setdep -r src/third_party/skia@3dc93896b3a9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I016d42048d274934c6db35d84ef043afa0468354 Reviewed-on: https://chromium-review.googlesource.com/c/1449774Reviewed-by:
-
Dave Tapuska authored
There use to be an abstraction in place because blink couldn't depend on chromium code. With relaxed restrictions now it is possible to remove some abstraction that isn't necessary. Change-Id: I3cafbbafbf9a5e260525c8ce5278d0a8ef9612e0 Reviewed-on: https://chromium-review.googlesource.com/c/1448559Reviewed-by:
-
chrome://invalidationTanja Gornak authored
Bug: 801985 Change-Id: Id091723d11c65b029387f63a30957b1adfb9ef23 Reviewed-on: https://chromium-review.googlesource.com/c/1447734 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#628318}
-
Mikel Astiz authored
Processors track sync metadata per sync entity which includes creation and modification timestamps. We now expose these fields to sync bridges via ModelTypeChangeProcessor. The immediate use-case we have in mind is the smarter detection of likely-duplicate DeviceInfo instances, which is deferred to later patches. Bug: 910390 Change-Id: I1066489865a18e56470cbd8e96a41f3a00eeaec8 Reviewed-on: https://chromium-review.googlesource.com/c/1449652 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#628317}
-
Antonio Gomes authored
IdentityManagerFactory::Observer is a parallel interface to//chrome's SigninManagerFactory::Observer. It will be used to replace usage of that observer in follow up CLs. BUG=927341 Change-Id: Id377b5b5e20e00b49811302b0ab26a611af1d3d4 Reviewed-on: https://chromium-review.googlesource.com/c/1448754 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Gyuyoung Kim authored
As a step to make to use IdentityManager,this CL replaces all uses of ATS with IdentityManager's ones in authentication_service_unittest.mm. Bug: 922796 Change-Id: I74dd7a7b8d640da88c2f999a43fb1439b79e5c97 Reviewed-on: https://chromium-review.googlesource.com/c/1438734Reviewed-by:
-
Marina Ciocea authored
[Sheriff] Disable flaky test WebRtcVideoCaptureServiceEnumerationBrowserTest.RemoveVirtualDeviceAfterItHasBeenEnumerated Bug: 927714 NOTRY=true NOPRESUBMIT=true TBR=chfremer@chromium.org Change-Id: Idd761e6efd21aa06212a4e2f697951bfa2fdb396 Reviewed-on: https://chromium-review.googlesource.com/c/1449663 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#628314}
-
Dan Elphick authored
Replace uses of Get/Set with Context versions that return a Maybe/MaybeLocal and check their return value mostly using ToLocalChecked or Check. Bug: v8:7283, v8:8562 Change-Id: Id8614f6e599cad628f3de8614d5a600d2148eb76 Reviewed-on: https://chromium-review.googlesource.com/c/1449676 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Thomas Tangl authored
- Google services in the service client are marked as not-supported, so they will *not* be turned on during opt-in. - UrlKeyedAnonymizedDataCollection is still part of the opt-in and will get turned on. Note: This CL is kept small for an easy merge back. In a follow up, all dead code will be removed. Bug: 927423 Change-Id: Ia853cef207dbbe86360de45c8a6bfd4195d1b3d2 Reviewed-on: https://chromium-review.googlesource.com/c/1449598Reviewed-by:
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found actual JavaScript execution on some layout tests: e.g. external/wpt/IndexedDB/nested-cloning-large-multiple.html This CL passes a per-frame task runner whenever possible. This CL also passes IPC per-thread task runner at some places, and we plan to replace them with per-frame ones later. Bug: 913912 Change-Id: I847f0c7a804abc187ee78f1b5bef442d7f205c08 Reviewed-on: https://chromium-review.googlesource.com/c/1445952 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#628311}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6808c22d9e24..87ab0aef9c54 Created with: gclient setdep -r src-internal@87ab0aef9c54 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5ef3855f481c1a5b9490f892f8c9a67c973d67fa Reviewed-on: https://chromium-review.googlesource.com/c/1449772Reviewed-by:
-
