- 30 Sep, 2019 40 commits
-
-
Raul Tambre authored
Example error: Traceback (most recent call last): File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 14, in <module> import extract_histograms File "C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py", line 60, in <module> import HTMLParser ModuleNotFoundError: No module named 'HTMLParser' Also fixed deprecation warnings: C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py:150: DeprecationWarning: The unescape method is deprecated and will be removed in 3.5, use html.unescape() instead. return HTMLParser().unescape(line) ...C:\Google\chromium\src\tools\metrics\histograms\extract_histograms_test.py:481: DeprecationWarning: Please use assertEqual instead. self.assertEquals('This is a summary with & and " and \'', The changes are backwards compatible. Bug: 941669 Change-Id: Ieb22e72b37ec26886f3ca1341e487be4f0ba3ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830657 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701265}
-
Maksim Ivanov authored
Add the DCHECK into the ExternalPolicyDataFetcher's destructor that it's executed on the right sequence. Before this CL, the destructor contained the comment that stated that such DCHECK isn't technically possible due to unusual destruction order in some tests, but we can't repro this problem with the current ToT anymore. Bug: 727645 Change-Id: I6490227656a876d546cd5b659f5d88b2d2ec0dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828820Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#701264}
-
Kristi Park authored
For grammatical correctness Change-Id: I2d5faa4acc6b1855c21c25cb23d9afacf243f8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829295Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#701263}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/events to the recommended methods/types. Bug: 1007850 Change-Id: Id725e2236e305a5b0b1eb5f555c3c412b8139416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831866 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#701262}
-
sczs authored
Some ConfirmInfobars like Restore tabs are important enough that we don't want some users to miss them. Either because they are not presented because some other Infobar is being presented, or because they time out before the user has seen it. This CL adds a BOOL flag to InfobarCoordinator, which InfobarContainerCoordinator will use in order to add that Infobar's banner to the top of the queue and display it for a bit longer. I didn't want to create a more granular system since this might be temporary until we migrate some of these Infobars to alerts or something similar, and its also not currently needed. Bug: 961343 Change-Id: Icf03748ec50b63bd9c99ead96ccae5c7fc644b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828237Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#701261}
-
Mario Sanchez Prada authored
Convert the remaining bits in both the implementation and clients from the browser and renderer processes for the shape_detection.mojom.TextDetection interface, and adapt tests. Bug: 955171, 978694 Change-Id: Ic528a0940a051c4dd692c2aa1bf08e1843ff8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826617Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#701260}
-
Ken Rockot authored
This reverts commit b78156eb. Reason for revert: Compile failures regarding template parameter shadowing: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/5546 Original change's description: > Roll abseil_revision 4ef574064e..ccdd1d57b6. > > Change Log: > https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4ef574064e..ccdd1d57b6 > Full diff: > https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4ef574064e..ccdd1d57b6 > > Bug: None > Change-Id: I8df493afa9903590cf61a51cda3b4988d122dfd7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819237 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701231} TBR=thakis@chromium.org,mbonadei@chromium.org Change-Id: I07a7c5ce83040a71d58fe7abc678b6c12a4b93b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831414Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#701259}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/c37a501458e2..839a023619b5 git log c37a501458e2..839a023619b5 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 wl@gnu.org * src/sfnt/sfwoff2.c (reconstruct_font): Fix memory leak. 2019-09-30 wl@gnu.org [woff2] Reject fonts without `head' table. 2019-09-29 wl@gnu.org [woff2] Fix compiler warnings. Created with: gclient setdep -r src/third_party/freetype/src@839a023619b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Icf8a8a0488c0845d9d4fe2d9dd20e19bf5a6efd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#701258}
-
Tim van der Lippe authored
Introduce a new namespace "Root" to be able to disambiguate between Runtime the namespace and Runtime the object. roll CodeMirror The above line is necessary to fix the presubmit, which complains about CodeMirror changes. This is only updating a type reference. Bug: 1006759 Change-Id: I04941d9f18649701060e3035f7eeb2ef3abb51e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829708Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#701257}
-
Kalvin Lee authored
This change makes the display name of print media available earlier - i.e. available from the moment the Papers are constructed in the backend. Bug: chromium:974707 Change-Id: If63b118c6c6c990cd5baa91095ac7195484a0cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829559 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#701256}
-
Sahel Sharify authored
This is a reland of 3dd95e21 The payment_method_change_response is not renamed in the reland since clank repository is using PaymentMethodChangeResponse. The rename will be landed in a separate cl. Original change's description: > [Payments] Enable shipping and contact info delegation [4/5] > > This cl implements shipping address/option change events for PH. With > this change payment handlers can notify the merchant when the user > changes the selected shipping address/option, and wait for updated > details (e.g. new shipping cost, etc) from merchant. > > For overall flow please check > https://chromium-review.googlesource.com/c/chromium/src/+/1779003 > > Bug: 984694 > Change-Id: Id881ba22bf4c846a4570801bacc49e5d4e89a72b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804557 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700238} Bug: 984694 Change-Id: I9a1a84e56701287eb3625b6a681a3f346c47a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828101Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701255}
-
Mike Dougherty authored
Bug: 1007924 Change-Id: I9bf405a97da0209e568299a70d5804d15b2aaed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828746 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#701254}
-
Ken Rockot authored
Bug: 999530 Change-Id: I3fb1beb7ae91322169f441f6425aff0124ba3064 Tbr: cammie@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829913Reviewed-by:
-
Kurt Horimoto authored
This ensures that FullscreenUIUpdaters stop observing their FullscreenControllers upon deallocation, preventing the referenced crash from occurring due to an observer being deallocated without being removed from the observer list. This CL also updates FullscreenUIUpdater to disconnect the observer when the FullscreenController is shut down. Bug: 1008487 Change-Id: Ic55eace199f12b3d5fe0f52301a4113fc770f94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828218 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/32eae4c231b4..4aded80e0498 git log 32eae4c231b4..4aded80e0498 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bd70e4cf..1d84c1e7 (701000:701137) 2019-09-30 mbonadei@webrtc.org Fix -Wtautological-constant-compare in test/fuzzers. 2019-09-30 nisse@webrtc.org New class ScopedJavaRefCounted 2019-09-30 srte@webrtc.org Refactoring CapBitrateToThresholds in SendSideBandwidthEstimation. 2019-09-30 ilnik@webrtc.org Fixes for support of disabling lower spatial layers in VP9 Created with: gclient setdep -r src/third_party/webrtc@4aded80e0498 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1007367 Change-Id: I70091604d042286f17dbc7dec6ac547d7acb066f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832356Reviewed-by:
-
Eric Orth authored
Was just used for MappedHostResolver, but moving to HostResolver to be more generally available to HostResolver implementations. Also rename to FailingRequestImpl. Bug: 1006902 Change-Id: Ifffe9971057d8e93a653593d93a6dc88e053f8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828099 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#701250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c101eb826b8..699a19bcc20b Created with: gclient setdep -r src-internal@699a19bcc20b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Iee3b8281492f73d46165f02635996a4fd81181e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832352Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701249}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0846d68474fb..04b996416735 git log 0846d68474fb..04b996416735 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 senorblanco@chromium.org Dawn: update to new GrGpu::onCreateBackendTexture() semantics. 2019-09-30 egdaniel@google.com Fix reported op bounds on a few ops. 2019-09-30 bsalomon@google.com Rename GrPixelInfo to GrImageInfo. 2019-09-30 halcanary@google.com SkPDF: rasterize bitmap glyphs at 64pt, not em-size 2019-09-30 bsalomon@google.com Revert "Construct GPU SkImages with SkColorType, don't infer from GrPixelConfig" 2019-09-30 benjaminwagner@google.com Add iPhone8 jobs 2019-09-30 benjaminwagner@google.com Use CIPD package for iOS provisioning profile. 2019-09-30 mtklein@google.com fix buffer overflow 2019-09-30 bsalomon@google.com Construct GPU SkImages with SkColorType, don't infer from GrPixelConfig 2019-09-30 bungeman@google.com Improve implementations of copyTable. 2019-09-30 kjlubick@google.com Update gold aggregators to use new struct Created with: gclient setdep -r src/third_party/skia@04b996416735 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:b/141094460,chromium:921585 Change-Id: Id0c93d018834cdcc5f27e1b795cd92d85cb89dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832348Reviewed-by:
-
Tim Dresser authored
Change-Id: I17b3d526490a89f4fa7bfa84bbd7f8398b93df68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829670Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#701247}
-
Rob Schonberger authored
This adds 'minor' the same way the radius_x/major is set, and adds the appropriate unittest for the new behavior. Bug: 1009290 Change-Id: Idbecdae3b47390b63981deb5a6a58f7338825a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832182Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@google.com> Cr-Commit-Position: refs/heads/master@{#701246}
-
Yusuke Sato authored
This allows code outside chrome/ (e.g. components/arc/session/) to observe the scheduler configuration status. BUG=b:139752657 TEST=./out/Release/unit_tests --gtest_filter='*SchedulerConfig*' Change-Id: I15873cedeaa0c66142b0f35947e4a8acf21e003c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815517 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701245}
-
Sebastien authored
Creating a new component to be used to support upcoming games' surfaces. Added directory structure with a basic, stubbed service. More details about this component can be found in this design doc (Googlers Only): https://docs.google.com/document/d/1T5Le4V_a0J5idNWNmcGFZ4qFf_b_uUw2Z00zor8Piuo Bug: 1006874 Change-Id: Id5e4e9785f3d4ab2343d30c09e6dfbd86cc6d3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819680Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#701244}
-
Peter Kotwicz authored
This CL introduces a new test utility class - TestBrowserInstaller - which centralizes code for installing and uninstalling mock browsers in WebAPK tests. BUG=1006269 Change-Id: I61a4c0d1adf0dac531cb489555a67e5e7dbf35fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827587 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#701243}
-
Justin Cohen authored
Allow embedders to prevent certain URLs from restoring. Between session save and session restore, embedder logic may disallow certain URLs. Bug: 1007337 Change-Id: I87a80d7ff2bc0161035c403f637288ea2bbc6159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819503Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Receiving a return value |false| in WebSandboxSupportLinux does not allow discerning whether there was an internal failure to retrieve a fallback font or just no fallback font was found which is more likely and frequent to happen. Stop logging this situation, as it spams the error log output. Bug: 1005508 Change-Id: Id7447b42b717b508721d01a1287a498b7a4ea404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831865 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Peter Wen authored
Update Play Core library to be built from @272011728, this picks up a fix from the Play Core team. Bug: 1003020 Change-Id: I26c5c4f44096ebac523b9e2aadfcef0a39487ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831412 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#701240}
-
Richard Knoll authored
This adds a test for when a browser tab is closed while a sharing dialog is shown. Also includes a refactoring which allows us to record shown dialogs to UKM on ChromeOS too, which was previously missing. Bug: None Change-Id: Icc6c1399e21a667673914e32dae90ff38e4e606d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823857Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#701239}
-
Tarun Bansal authored
attempting to register. When attempting to register for network change callbacks, also get the most recent connection type and notify observers if it has changed. This gets around an Android bug where Chrome does not receive the callbacks from Android when in battery saver mode. This CL fixes the issues (in local testing). The next CL would add some general network metrics to keep track of how many successful page loads happened when Chrome thought it was on connection type wifi/2g/3g/4g/offline. That would help us track this kind of regression automatically. Change-Id: I33c5acbb43f1830618519084ce6a34aa84a49721 Bug: 1007998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827252Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#701238}
-
Yusuke Sato authored
The function is deprecated. BUG=b:139752657 TEST=try Change-Id: Ic2b2b5462c9c02667e3d73ba723f44d2e0a93fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829860 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#701237}
-
Maksim Moskvitin authored
GetKeystoreMigrationTime() is a simple getter used for logging purposes. Bug: 922900 Change-Id: I6968a7eb7a315a1b4bbf2974ee2acfcda2d0bd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814198 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#701236}
-
liberato@chromium.org authored
Test is flaky. Bug: 1006416 Change-Id: I7395e93b95572708c110e7bdd57bc154d552c687 TBR: dmurph@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832246Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#701235}
-
Ken Rockot authored
Bug: 1005456 Change-Id: Ia5130d68f0590993348ce52e2083f1d9ee5e6af3 Tbr: rsorokin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831994Reviewed-by:
-
rbpotter authored
There is no reason to build the :build, :flattened_resources, or :unpak targets when optimize_webui=false. Bug: 1004967 Change-Id: Ib7e2cf5896279ccb984701987519d9e311944d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829753 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#701233}
-
liberato@chromium.org authored
Test is flaky. Bug: 1009570 Change-Id: I606f6be5e316cc1607f5773f3ea273628818bd52 TBR: karandeepb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832294Reviewed-by:
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4ef574064e..ccdd1d57b6 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4ef574064e..ccdd1d57b6 Bug: None Change-Id: I8df493afa9903590cf61a51cda3b4988d122dfd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819237Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#701231}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ec36c06fb12c..7d6c98f10423 git log ec36c06fb12c..7d6c98f10423 --date=short --no-merges --format='%ad %ae %s' 2019-09-30 lamontjones@chromium.org pushimage: sign cr50 firmware. 2019-09-30 hidehiko@chromium.org chromite: Enable Tast tests on betty-pi-arc-release. Created with: gclient setdep -r src/third_party/chromite@7d6c98f10423 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia9d4f6213cd3f0d93798ad794b19e5419a33f1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832351Reviewed-by:
-
Bo Liu authored
Move EventOffsetHandler to ui.base so it can be shared between weblayer and chrome. Also simplied it to not handle x direction since it is always 0. Bug: 1006803 Change-Id: Ifba28649bb75d609de5aa0e8ca7d03352918d06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830081Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701229}
-
Justin Cohen authored
Previously, preload required CopyStateFromAndPrune and CanPruneAllButLastCommittedItem within NavigationManager, but those are not supported with SlimNav. Here, preload is implemented by creating a preload WebState with navigation history by restoring the current WebState. The performance of this implementation depends on Slim Navigation Manager's session restoration performance which can be measured with existing kRestoreNavigationTime metric. Original implementation of this CL was written by eugenebut@, simply updated in this resurrected CL. Bug: 834116 Change-Id: I86c9ecf7e3ed213ebaeddce6264dff3bbb8a8c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815702 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Xing Liu authored
Starts from Android N, notification by default has the app name, so the title should not be same as the app name. The title can be "Sync", and the text can be updated from "Sync: {sync message}" to "{sync message}". Bug: 875906 Change-Id: Ifee2bca85305ad9ae62b6122bec9bbf83d59f026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829740Reviewed-by:Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701227}
-
Ken Rockot authored
The test appears to timeout occasionally. Bug: 1008882 Change-Id: I2439de7a963f4dfab33e4f614c02698b16514e21 Tbr: dtapuska@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829910Reviewed-by:
-
