GitLab

The following hooks are implemented:
  - batch_malloc_function
  - batch_free_function
  - free_definite_size_function

BUG=803276

Change-Id: Icea416e33ec87674c4829115aa99f086cc09f4c5
Reviewed-on: https://chromium-review.googlesource.com/884742
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532743}

ResourceScheduler and CORS code are left behind until the content/ dependencies are removed.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ife204640886541376354e3fcbe0fef631326822e
Reviewed-on: https://chromium-review.googlesource.com/891646
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532742}

This reverts commit 86ff9bc4.

Reason for revert:
flaky, i.e. see

https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634904
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634934
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634954

which fail with
Returned error text: Traceback (most recent call last):
  File "/b/c/b/linux/src/tools/clang/scripts/run_tool.py", line 315, in <module>
    sys.exit(main())
  File "/b/c/b/linux/src/tools/clang/scripts/run_tool.py", line 281, in main
    f.write(compile_db.GenerateWithNinja(args.p))
  File "/b/c/b/linux/src/tools/clang/pylib/clang/compile_db.py", line 94, in GenerateWithNinja
    GetNinjaPath(), '-C', path, '-t', 'compdb', 'cc', 'cxx', 'objc',
  File "/b/c/b/linux/src/tools/clang/pylib/clang/compile_db.py", line 76, in GetNinjaPath
    os.path.dirname(os.realpath(__file__)), '..', '..', '..', 'third_party',
AttributeError: 'module' object has no attribute 'realpath'




Original change's description:
> Activate Network traffic annotation tests for Linux trybot.
>
> Traffic annotation tests are updated to run on the changed files instead
> of the whole repository, which should make tests much faster.
>
> Bug: 690323
> Bug: 788035
> Change-Id: I4eb7c173f5d677cdb9944f02e9c15dfa0a374b10
> Reviewed-on: https://chromium-review.googlesource.com/856456
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528573}

TBR=dpranke@chromium.org,msramek@chromium.org,rhalavati@chromium.org


Bug: 690323, 788035
Change-Id: I048be491eb64c221bb4edeab2e0d2aa051b5faa7
Reviewed-on: https://chromium-review.googlesource.com/892383Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532741}

Removed methods GetSnapshot, GetKnownHistograms and GetHistogramsWithPredicate.
They were replaced by GetHistogram + filter functions WithName and
NonPersistent.

Change-Id: Ia974675e38f29c8ad19a13e1d1fa0c3716503b40
TBR: avi@chromium.org, rsesek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/858244Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532740}

This CL moves Java WebContentsAccessibility to be managed by WebContentsUserData.
WebContentsAccessibility is now a public interface and its implementation is
renamed to WebContentsAccessibilityImpl, and takes over most of the a11y stuff
from CVC.

|WCAX.create| should be called once and only once per WebContents to instantiate
the class (it is guarded with assert to guarantee this), and
|WCAX.fromWebContents(WebContents)| returns the instance. It can return null
if called before |WCAX.create| or after WebContents is destroyed.

Also, moved around the methods in WebContentsAccessibilityImpl to group them by
  interface/native connection.

Bug: 789000
Change-Id: I0525f5761cfd1d541cefacd784e40e4852ee541a
Reviewed-on: https://chromium-review.googlesource.com/858985
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532739}

This CL updates //third_party/sqlite/fuzz/ossfuzz.c with the contents at
//third_party/sqlite/src/test/ossfuzz.c, which is the version that ships
in SQLite release 3.22.0.

Bug: 805126
Change-Id: Idc39bca7c6fd9c136ecd811997ab32d8d84e0682
Reviewed-on: https://chromium-review.googlesource.com/892107Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532738}

The test is flaky on Linux MSAN.

TBR=wjmaclean@chromium.org

Bug: 807116
Change-Id: I6426122f80c33b0420cc816fe3587ee6f80a0e56
Reviewed-on: https://chromium-review.googlesource.com/891840Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532737}

The ideal counter would be triggered on elements with 'auto' value for
the justify-items and "legacy" keyword on their parent's justify-items
value. That's the specific case we want to evaluate to know the impact
of removing the 'auto' value from this property.

The only, or more direct, way to achieve this is to add the UseCounter
call in the StyleAdjusment logic, where we resolve the 'auto' value.
However, during this phase we may lack of a Document to use as an
execution context for the counter.

As an alternative, also valid for the goal of evaluate the above
mentioned removal, would be to add the UseCounter to the property's
parsing logic. We can call in this case the UseCounter API that uses
CSSParserContext instead of the one based on the Document.

Bug: 806791
Change-Id: I2bf9e07957bfaec41d68b6d2c6660283cabff062
Reviewed-on: https://chromium-review.googlesource.com/891818Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#532736}

Server side the test_nano_redirect_push policy flag is removed, making
this test obsolete.  Removing it so it won't be constantly failing.

Bug: 806413
Change-Id: I3410a6ed62f2f49a85baed75a30496a7a78bd0c8
Reviewed-on: https://chromium-review.googlesource.com/892283Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Richard Bustamante <bustamante@google.com>
Cr-Commit-Position: refs/heads/master@{#532735}

This CL was uploaded by git cl split.

R=mathp@chromium.org

Bug: 177475
Change-Id: I6285d5ba0d355e28af3150ef690147a0ba8025d1
Reviewed-on: https://chromium-review.googlesource.com/891922Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532734}

Add JSON as a known mime type in kSecondaryMappings in mime_util.
It's not quite common enough to put in kPrimaryMappings;
kSecondaryMappings will still allow local configurations to
apply on file:// urls.

Bug: 797712
Change-Id: Ia4c8ab8930a2d14da51ad781094df27d9a21afb5
Reviewed-on: https://chromium-review.googlesource.com/889915
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532733}

This API will be used by DownloadManagerCoordinator to ignore callbacks
from hidden tabs.

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I453db842ba93c50bcbb9a9987cf614a29e963d21
Reviewed-on: https://chromium-review.googlesource.com/884363
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532732}

Chrome 66 removes trust in Symantec's Legacy PKI, for certificates
issued before 2016-06-01. This introduces an Enterprise Policy,
EnableSymantecLegacyInfrastructure, which can be used to re-enable
support for the legacy infrastructure for those that need additional
time to transition.

Chrome 70 will fully remove trust in Symantec's Legacy PKI, and this
policy will be removed shortly thereafter (~1-2 releases).

BUG=805459, 797765

Change-Id: I4a6f790d4f5573038e0eb9c208412ae944b6ea52
Reviewed-on: https://chromium-review.googlesource.com/890421Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532731}

Following bot results are included.
3372 3373 3376 3379 3381

10 lines were removed and 42 lines were deflaked by consecutive results
since 3351.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia148ae2d0d2545bbaff2bfecb6f3c97d830b0e0c
Reviewed-on: https://chromium-review.googlesource.com/891081
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532730}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/787ecbb3..95d2f6fb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I281bbe3d04ea31466633ff962d9e09dd980639d9
Reviewed-on: https://chromium-review.googlesource.com/891439Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532729}

zlib calls to crc32() redirect into the other public API function
crc32_z(). Move the SSE4.2 crc32 code to crc32_z(), so that users
of it also benefit from its SSE4.2 SIMD acceleration.

No change in behavior, no new tests.

Bug: 796178
Change-Id: I0d80a6ebf9c703dc3d67be1d1f3457ebfcb150bd
Reviewed-on: https://chromium-review.googlesource.com/890155Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532728}

Refactor ListMenuButton to use AnchoredPoupWindow instead of
ListPopupWindow. Add extra postioning logic and customization to
AnchoredPopupWindow, and add a handful of junit tests for the popup
x and y calculations.

BUG=709522

Change-Id: I6862ca644e9cd6c467e126bde908f6893dfcf530
Reviewed-on: https://chromium-review.googlesource.com/887227
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532727}

Bug: 806965
Change-Id: Icd8acbac6f7928621aa77af7e1d672b8e14043d1
Reviewed-on: https://chromium-review.googlesource.com/892381Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532726}

This CL was uploaded by git cl split.

R=lambroslambrou@chromium.org

Bug: 177475
Change-Id: I633a202d17e7d9789213a95303cdc456c68a939c
Reviewed-on: https://chromium-review.googlesource.com/891898Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532725}

This CL uses selection directional value for commands
from EditCommand SelectionIsDirectional().
This is done because we will remove directional
from SelectionTemplate.

Bug: 740804
Change-Id: Icb6cb608d92c6688139df713a056a7fc972d2441
Reviewed-on: https://chromium-review.googlesource.com/891200
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532724}

BUG=526586
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ic853fb0d20f6721b27cd0244dd9b54371c8ed3f2
Reviewed-on: https://chromium-review.googlesource.com/891058Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532723}

This patch changes "mixed-editability-8.html" to utilize |selection_test()| for
ease of maintenance.

This patch is a preparation for the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Bug: 679977
Change-Id: I09854d42c93751d51a3bc601bb27cbba2ad036dc
Reviewed-on: https://chromium-review.googlesource.com/890901Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532722}

Disabled two tests in WebContentsViewAuraTest:
 - WebContentsViewReparent
 - OverscrollNotInterruptedBySpuriousMouseEvents

QuickOverscrollDirectionChange looks also flaky but I didn't disable it since it
passes on the second run.

TBR=sadrul@chromium.org
NOTRY=true

Bug: 807107, 179532, 705599, 679420, 676156, 668128, 440043, 405945
Change-Id: Ia868b46dc39ed8bc9eec94a60897a51f748c7627
Reviewed-on: https://chromium-review.googlesource.com/892188Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532721}

They seem to be failing for related reasons. Tests disabled:
AwLegacyQuirksTest#testTargetDensityDpi
AwLegacyQuirksTest#testWideViewportInitialScaleDoesNotExpandFixedLayoutWidth
AwLegacyQuirksTest#testZeroValuesQuirk
AwSettingsTest#testZeroLayoutHeightDisablesViewportQuirkWithTwoViews
AwSettingsTest#testUseWideViewportLayoutWidth
AwSettingsTest#testUseWideViewportLayoutWidthNoQuirks

TBR=changwan@chromium.org

Bug: 746264
Change-Id: Ibd5b0ff9d57a9d85fb900551f7d483482f5c4400
Reviewed-on: https://chromium-review.googlesource.com/892204Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532720}

This patch changes "editing/selection/modify_move/move_around_image.html" to
verify one function call instead of multiple function calls for ease of
debugging.

Bug: 778507
Change-Id: I8a8eea53724f34e45c7fd3273635c1aee716773b
Reviewed-on: https://chromium-review.googlesource.com/890899Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532719}

Bug: 786913
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7c5ead72b584672fd322d9b74a0b24b40d958797
Reviewed-on: https://chromium-review.googlesource.com/882061
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532718}

TabActivityWatcher logs URL-keyed metrics about tabs upon tab activity.
Currently, we don't log a UKM for a source if we have already logged
that source within the past 10 seconds. This was intended to ensure
the new UKM logging did not cause unexpected flooding of the UKM
service.

Analysis of Finch experiments demonstrates that removing this timeout
does not substantially affect the rate of events logged or cause UKM's
built-in event limit to be reached more often. This CL therefore
removes this timeout as well as the Finch parameter that controlled it.

The feature flag itself remains as a way to disable TabMetrics logging.

Bug: 804668
Change-Id: Iad821bd9e91ac34eedaca8b7f68436fafffed9ae
Reviewed-on: https://chromium-review.googlesource.com/880143
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532717}

Having guards, per feature, is unneeded since BUILD.gn handles it
for us. Provided the new symbols of any feature code are added to
names.h, mangling their symbol names works, regardless of whether
we have guards in names.h or not. Remove the guards.

No change in behavior, no new tests.

Bug: 796178
Change-Id: I9441544f58c5db82ba0e42bf755872c4a0273e46
Reviewed-on: https://chromium-review.googlesource.com/891198Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532716}

Bug: 777962
Change-Id: I23ffb355ada1efe954b8080c8d2c9e1b2049fd5d
Reviewed-on: https://chromium-review.googlesource.com/886829Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532715}

Bug: 800502
Change-Id: I059c10360312df02b040e3e87667b8a39abce09c
Reviewed-on: https://chromium-review.googlesource.com/891627Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532714}

In preparation for moving the main waterfall mash_browser_tests from
its narrow whitelist to the larger FYI blacklist.

Bug: 678687
Test: browser_tests
Change-Id: I61d512ccb1ba4152cb2ae99a022b4e8cf92c67b6
Reviewed-on: https://chromium-review.googlesource.com/891997Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532713}

https://webrtc.googlesource.com/src.git/+log/22da89f502ab..1f5e98d97eca

$ git log 22da89f50..1f5e98d97 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie8c2abde763dcc5b0a589b83fffd633f6fcb34de
Reviewed-on: https://chromium-review.googlesource.com/892040Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532712}

TBR=oshima@chromium.org

Bug: 805507
Change-Id: I47c6ee4996c0adf1bb2a1646af1c41a20a43db37
Reviewed-on: https://chromium-review.googlesource.com/892047Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532711}

H264 is most affected since VP9 gets 4K portrait support by virtue
of supporting 8K decoding. This cl also adds 8K portrait mode
support for VP9.

BUG=806568
TEST=manually verified video in bug gets GpuVideoDecoder.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4c622e3d3e54c43f85c6d3af0d7624f66a0639b6
Reviewed-on: https://chromium-review.googlesource.com/891670Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532710}

This folder contains "library CDM" related code and will soon be
unrelated to ppapi.

This CL only renames the folder. More clean-up will follow in later CLs.

TBR=thestig@chromium.org
BUG=769833

Change-Id: I346a59d23838d5d4cd93bfea5afd3f28827e147f
Reviewed-on: https://chromium-review.googlesource.com/889693
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532709}

This reverts commit 3d6ada5e.

Reason for revert: wjmaclean@ landed potential fix in https://crrev.com/532661.
Let's see if it worked.

Original change's description:
> Disable flaky BasicSelectionIsolatedScrollMainframe
> 
> TouchSelectionForCrossProcessFramesTests/TouchSelectionControllerClientAuraSiteIsolationTest.BasicSelectionIsolatedScrollMainframe/1 fails on all the platforms.
> 
> TBR=tdresser@chromium.org
> 
> Bug: 805017
> Change-Id: I1ea7c82a4c8fc2fa8e83c83ac47ef65f98cd985f
> Reviewed-on: https://chromium-review.googlesource.com/888753
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532122}

TBR=vasilii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 805017
Change-Id: I59c74f106b2c04632e0826512e75c938587eccbe
Reviewed-on: https://chromium-review.googlesource.com/892203Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532708}

Use the proper BUILDFLAG() macro


Change-Id: I358fd008b5eb081d18782c66e0df904589435140
Reviewed-on: https://chromium-review.googlesource.com/889422
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532707}

The modifier 0 means linear layout (DRM_FORMAT_MOD_LINEAR) which is
different from the legacy behavior of not specifying a modifier.  When
a modifier is not specified, the exact layout (tiling, compression
etc) is communicated through some kind of driver specific back channel.

The few places that build a NativePixmapHandle from scratch want the
implicit legacy behavior, but passing 0 explicitly requests a linear
layout. We introduce gfx::NativePixmapPlane::kNoModifier (equal
to DRM_FORMAT_MOD_INVALID) to indicate that the caller wants the
legacy semantics.

Bug: b:70546200, b:71416883, chromium:789292, b:69238712, b:68003124
Change-Id: Ic7eb4838f53ffb30ede39709abd0bb4639223754
Reviewed-on: https://chromium-review.googlesource.com/885905Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532706}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7a4ced2773b2..6fe29419beee

$ git log 7a4ced277..6fe29419b --date=short --no-merges --format='%ad %ae %s'
2018-01-23 bpastene depot_tools: Add a checkout_chromeos conditional var to gclient.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: Iaabeafeddc47c8525e09a5f6bcfe990855ae7a14
Reviewed-on: https://chromium-review.googlesource.com/892025Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532705}

Due to unspecified function argument evaluation order in C++ some
compilers might choose to evaluate base::Passed earlier than subsequent
smart pointer access, so we need to be extra careful and save raw
pointer values before using them. Otherwise they might no longer be
valid by the time we call ptr.get due to the pointer being already
modified by the base::Passed.

BUG=734325

Change-Id: Icb5a06c42c14018c98ab8ddaffcc1fd41f3111ab
Reviewed-on: https://chromium-review.googlesource.com/885091Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532704}