GitLab

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=DevToolsExtensionTest.DevToolsExtensionSecurityPolicyGrants

NOTRY=TRUE
TBR=dgozman@chromium.org

Bug: 993982
Change-Id: I1690e6db8ec7e6a67182075a45ce7891bc1bc2ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760861Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688110}

OMA-URI example (at step 2):
https://support.google.com/chrome/a/answer/9102677?hl=en

Bug: 985722
Change-Id: I49036c1ccbcd8a0567fdc1687ac537bfa7023516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724664Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688109}

r687811 caused a regression which leads to the Device Sync service
instance outliving its KeyedService dependencies, resulting in a UAF on
browser shutdown. This properly destroys the service instance during
the DeviceSyncClientHolder's KeyedService Shutdown.

Bug: 995010
Change-Id: Ieca3937180f5580798c7ea735dd61e8b8f95c539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759675Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#688108}

https://swiftshader.googlesource.com/SwiftShader.git/+log/dadeb009a297..303ddb5c8807

git log dadeb009a297..303ddb5c8807 --date=short --no-merges --format='%ad %ae %s'
2019-08-19 srisser@google.com Make ClipDstRect/ClipSrcRect cease on non-finite

Created with:
  gclient setdep -r src/third_party/swiftshader@303ddb5c8807

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: None
Change-Id: I7f0c7ce9a5f869c1d3c05ec26dd0a99012af311e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760893Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688107}

Migrated on its own because of the change in test expectations.

R=dcheng@chromium.org

Bug: 992483
Change-Id: I68dfd16a91ab4563cd62870446a8bc44f47dc194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760273
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688106}

This CL replacing the usage of the address of the SkTypeface by it's
uniqueID.

It's adding the script and font to the hashing function since text is
often rendered with fonts of different size. We also observed many
collisions while rendering the same text but with different text
range.

The previous code was working correctly since the HashingMRUCache is
looking for every member with the same hash. It is reducing the amount
of collisions. Under the hood, HashingMRUCache is using an
std::unordered_map.

R=msw@chromium.org

Change-Id: I916798ccd218be2f959aff272768c05633138140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710131
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688105}

Apparently python module names cannot contain -, so naming a script with
a dash prevents importing it as a module. TIL!

TBR because I'm about to mail out some instructions referencing this
file, so it should have the correct name before I do that.

TBR=thakis@chromium.org

Bug: None
Change-Id: I706f5bc25fad29a0a822b30a654893a75e8f45e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760870Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688104}

Bug: 954332
Change-Id: Ia8a590b912962b343e9fceb577875ef03f51a9b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760267
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688103}

Instead of simply looking at the parent node and the child node when
deciding whether to set focus or set the sequential navigation starting
point, look at the node and all ancestor nodes inside the same document.

Bug: 974108
Change-Id: I2cbf6b0f338910f7f7cfa88227be64da2841ed69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728567Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#688102}

Bookmark sync code runs in the UI thread.

Before this patch:
Sync would invoke GetBookmarkNodeByID() for each persisted id. This is
a relatively expensive call that runs recursively through the bookmark
model.

After this patch:
A new util method is introduced to temporarily cache the ids of all
bookmark nodes, in order to avoid per-node recursive call.

Change-Id: I536c1f016b702edbf862fe843f791a1a132c9fc7
Bug: 950869,516866,993322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760289
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688101}

Screenshot: http://screen/X8kgtvykzPC

Bug: 992088
Change-Id: I49ed84f511e8d5498c8d247eb49c96609027cb23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752636Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688100}

Bug: 900581
Change-Id: Ic4e14f4add81f40add7d80906ca402cdd1ed6334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756984Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688099}

Bug: 966388
Change-Id: Iae349be84fb52d489a733beb4629107d4821909c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757020
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688098}

This reverts commit dfede5ad.

Reason for revert: 
No explanation of the failure was provided when this test
was disabled. Re-enabling to get more details. It is very
possible that the test will no longer fail, since
base::ThreadPool code has changed a lot since the test
was disabled.

Original change's description:
> Conditionally Disable HostResolverImplTest.DeleteWithinAbortedCallback_ResolveHost
> 
> TBR=ericorth@chromium.org
> 
> Bug: 930483
> Change-Id: I3d34d27e5e866704778b85e7dc7a83cec7b2110a
> Reviewed-on: https://chromium-review.googlesource.com/c/1462798
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630730}

TBR=jdoerrie@chromium.org,ericorth@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 930483
Change-Id: Ic0eaf36dcb56e7fc4252c4849ace77310bade1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758329
Auto-Submit: François Doray <fdoray@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688097}

JavaScript window.print() requests have been returning back to the
renderer process before the print has actually completed.  When the
print preview is disabled it is easier to expose a race condition
between serving the print logic and whatever comes next in the
JavaScript.

If the script has a popup window to be printed, which has
window.close() immediately after the window.print(), then the document
to be printed has its destruction racing against being printed - and
will typically lose that race, resulting in a lost or empty print job.

Resolve by ensuring that the renderer process does not proceed past
window.print() until the DidPrintDocument message is sufficiently
completed.  Making this message synchonous achieves this effect.

This means that the renderer process will be blocked for all sites
which it serves for slightly longer than it already does. [1]

[1] https://www.chromium.org/developers/design-documents/printing

Bug: 974480
Change-Id: I3ef08899e1792cc291aa8dd3d740da095e2c73bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700275Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688096}

Tests were disabled for a crash that seems unrelated:

[ RUN      ] TabMetricsLoggerTest.GetHasFormEntry
[14286:14286:0404/024920.550507:15005211132:ERROR:render_widget_host_view_base.cc(183)] Not implemented reached in virtual uint32_t content::RenderWidgetHostViewBase::GetCaptureSequenceNumber() const
[14286:14413:0404/024920.559998:15005220584:ERROR:database.cc(1599)] Predictor sqlite error 1802, errno 0: disk I/O error, sql: CREATE VIEW MmapStatus (value) AS SELECT -1
[14286:14411:0404/024920.560201:15005220787:ERROR:model_type_store_service_impl.cc(35)] Failed to initialize ModelTypeStore backend: Init@../../components/sync/model_impl/model_type_store_backend.cc:99: IO error: /b/s/w/it3Us7EL/.org.chromium.Chromium.IVwXVq/Sync Data/LevelDB/MANIFEST-000001: Unable to create writable file (ChromeMethodBFE: 9::NewWritableFile::4)
[14286:14411:0404/024920.561178:15005221763:ERROR:simple_index_file_posix.cc(36)] opendir /b/s/w/it3Us7EL/.org.chromium.Chromium.IVwXVq/Code Cache/js: No such file or directory (2)
[14286:14411:0404/024920.561352:15005221935:ERROR:simple_index_file.cc(612)] Could not reconstruct index from disk
[14286:14413:0404/024920.560039:15005220621:FATAL:database.cc(1612)] disk I/O error

https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/248217

Before spending more time in investigating the failure, I will
re-enable the test and see if it is still flaky.

Bug: 949288
Change-Id: I36f63724108358098499c812f1b5fad2f717992f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758327
Auto-Submit: François Doray <fdoray@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688095}

http://crrev.com/c/1724562 queries the currently focused window at a
time where there is possibly no window being focused at all. This
results in a NULL window pointer that is then dereferenced.

Fix this by checking that we got a non-NULL window before using it.

Bug: b:139524595
Bug: chromium:962848
Test: UI starts without crashing on Kukui.

Change-Id: I7a65f26a13d6b6f67c866a49175a47eea1228cdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760570
Auto-Submit: Alexandre Courbot <acourbot@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688094}

Re-enabling BluetoothLowEnergyApiTest and NavigationPredictorBrowserTest
for skia_renderer_browser_tests.

TEST=skia_renderer_browser_tests

Bug: 982933
Change-Id: I08cb6e286987ea0d2e3973adf554b651afb842ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759010Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688093}

... rather than a weak pointer to UserMediaProcessor.

This is a preliminary step to mo UserMediaProcessor to be GC-able by
OilPan.

In a follow up, the WebPtrFactory in user_media_processor.h will be
completely removed, and UserMediaProcessor will be Oilpan GC-ed.

BUG=704136
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I067ea8a4c58c8758c474d39a3d4d50c06821ad8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757494
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688092}

This test is flaky. See bug for details.

TBR=eirage@chromium.org

Bug: 995285
Change-Id: Ib6bb14387756bbd9db83f88267c84c8ae909655f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760892Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688091}

https://skia.googlesource.com/skia.git/+log/9648b419f5cf..f8221786d088

git log 9648b419f5cf..f8221786d088 --date=short --no-merges --format='%ad %ae %s'
2019-08-19 egdaniel@google.com Remove incorrect metal assert.

Created with:
  gclient setdep -r src/third_party/skia@f8221786d088

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@google.com

Bug: None
Change-Id: I8804534c980879acf09c1ba1f510ecc3b181a40f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760890Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688090}

The `CorsRFC1918` flag currently controls both the CORS-preflight
behavior and the `.addressSpace` getter. As the latter is something
much more likely to be shippable in the somewhat-near future (as part
of [1]), this patch splits it into a distinct runtime feature that
can be enabled independent from the larger CORS-RFC1918 framework.

The new `AddressSpace` runtime flag controls both the `.addressSpace`
getters on Document and Worker interfaces, and also the
`treat-as-public-address` CSP directive.

[1]: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/EeGg7TxW6U4/9aohper3BQAJ

Bug: 986744
Change-Id: I309b64e75901952dd649c19e558ed6484407edbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760734
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688089}

filter-repaint-blur.html, filter-repaint-child-layers.html, and
filter-repaint.html have minor visual differences due to blur, so add
them to crbug.com/972621.

Bug: 954328
Change-Id: I058282af69291f89205bc583e005b3a5cddb6352
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756715
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688088}

This CL adds tests where there is a bunch of content and LCP must observe the
largest (one for when image is largest, one for text).

Bug: 994414
Change-Id: I9330f238e1f8a2a8227dce7a04fd741d2dc666d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757165Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688087}

(well half of them because git cl upload wouldn't let me do
 them all at once...)

This is step #1 of the mass migration. Some of these will be
backported to SingleThreadTaskEnvironment in a later phase.

scoped_task_environment.h will also only move in a follow-up CL.

TBR=dcheng@chromium.org

Bug: 992483
Change-Id: I44bc376deee9b6c95bafac8d54165174d86a5001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756247Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688086}

https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/7c66ab5c1445..2906c3c5b3bf

git log 7c66ab5c1445..2906c3c5b3bf --date=short --no-merges --format='%ad %ae %s'
2019-08-19 rsmoore@google.com {Git LFS} Correct `.gitattributes` to use path and not glob. (#8338)

Created with:
  gclient setdep -r src/ios/third_party/material_components_ios/src@2906c3c5b3bf

The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc
TBR=bling-p10-rolls@google.com

Bug: None
Change-Id: Ibdefe3a6aa230fb8ff58ea2630caf25be5410eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760887Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688085}

Bug: 992896
Change-Id: Ie589e60a99ccabb0a06ea3875360e684b3048960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760305
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688084}

The quota for hasEnrolledInstrument() must be based on the requested
autofill data when Basic Card payment method is being used, so the
merchant cannot iterate over all options (requestShipping,
requestPayerEmail, requestPayerName, requestPayerPhone)  and learn about
user's autofill data.

Disabled by default behind "StrictHasEnrolledAutofillInstrument"
feature.

Explainer:
https://gist.github.com/rsolomakhin/d6d242cbb9306864ada5a29de7ab271e

Design (Googlers only):
https://docs.google.com/document/d/1VVggx4cy_QFsSEWtnZ9yhvtI4lNPONA4rnJKH3VV9jQ/preview

Bug: 993390
Change-Id: I4c2070572a43e7423ba43736741a62546fd8fb8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757293
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688083}

When text track styles were first being introduced, it was decided that any time user styles are present, all author styles for the text track will be ignored (discussed in https://codereview.chromium.org/921833003). There was a complaint by a customer about this policy, and we can also observe that Safari does not follow. For this reason, we are undoing this decision in this patch.

Bug: 979649
Change-Id: I944eeb75d765e7899850ef65337786a6913c59d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733928Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#688082}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7b861aca..92433291

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1d612aa639215cfcaf0f657f78c6f3eb90348d43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760412Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688081}

Prior to enabling native code partitioning, the VR DFM was equipped with
a small dummy library to soak the delivery and opening mechanism. Now
that the real library is present, we can pull out the dummy version.

Bug: None
Change-Id: I4b2b4d576e5428c2eedae47159a55ad4dcccb784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751829Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688080}

- The logic of the link actions remains in ProfileMenuView.
- The link handling is done in ProfileMenuViewBase.

Bug: 966388
Change-Id: I54100962956bd6acc873b88d1da1b196f967ffd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757842Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688079}

This reverts commit 97622f89.

Reason for revert: Sufficient information has been collected.

Original change's description:
> [VizHitTesting V2] Add dump without crash to identify sites with mismatch results
>
> Collect data after fixing the outdated hit test data issue at
> crbug.com/992064 for future investigation.
>
> Bug: 976284
> Change-Id: I2a59f2902908c09162ccbe41ebbd860b0331ac4a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756625
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#687744}

TBR=rjkroege@chromium.org,yigu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 976284, 977092
Change-Id: I3f26396a09bd7b6ab41406c22cd648dab7b85047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760867Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688078}

The chromium linker doesn't have static initializers, which make
assert_static_initializers.py fail. Instead of adding it to the list of
libraries that should be skipped, make sure that it has none.

Bug: 979638
Change-Id: I5450031a2e49dbfbf21d991ac6b901ddbb5c7008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760215Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688077}

Replace the snowman emoji (U+2603) with the sum sign (U+2211) in order
to avoid situations in which a color fallback font is chosen for the
emoji, which cannot be colored white and the reftest thus failing, since
the test case shows and emoji, while the reference content does not
contain any characters.

Bug: 976737
Change-Id: I342d81870418e56575700d3c0941a16544121a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760304
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688076}

This reverts commit bbe68ab3.

Reason for revert: Find it founds this cl with 100% confidence to be the cause of CrostiniInstallerViewBrowserTest.InstallFlow failure on MSAN

Original change's description:
> Factor non-ui logic out of CrostiniInstallerView
> 
> The current CrostiniInstallerView contains a lot of non-ui logic such as
> histogram recording and somewhat complex interaction with CrostiniManager. This
> CL factors out the non-ui logic into new class CrostiniInstaller. This not only
> makes the code cleaner, but also allows us to port the installer UI to WebUI
> much more easily.
> 
> 
> Bug: 912638
> Change-Id: Ie0195c8580518aa39e59aa539ef2fb614978776b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701024
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Reviewed-by: Timothy Loh <timloh@chromium.org>
> Commit-Queue: Jason Lin <lxj@google.com>
> Cr-Commit-Position: refs/heads/master@{#688021}

TBR=benwells@chromium.org,timloh@chromium.org,lxj@google.com

Change-Id: I751183d3e79e4455535750c0d700a7e35ee407a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912638
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759680Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688075}

Change-Id: I00276f97946577bbd15c51ceb5eb64df9975daf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760222Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688074}

- Directory will contain generic superclass files required for both QR and credit code scanner.
- This refactoring is required to help use common elements of the QR scanner in the credit card scanner from a shared abstract class.

Bug: 990744

Change-Id: I830eb4b34cb10fdf940dc28ab1390270d91c12cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760302Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Cr-Commit-Position: refs/heads/master@{#688073}

The test may miss a frame occasionally. See bug for details.

TBR=flackr@chromium.org
NOTRY=true

Bug: 986019
Change-Id: I6bb3e35c26b3d2914a135d52b0b0bb758565da38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760888Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688072}

There's no specialized knowledge for this and it's a single function.

Change-Id: I2d994ff6eac6f26482287b200491b813870d6144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758659
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688071}