- 31 Jul, 2020 40 commits
-
-
Emily Stark authored
Before this CL, RenderText::GetSubstringBounds() rounded up both the starting x and ending x that it computed. As a result, the left edge of the substring could be slightly outside the returned bounds, and the right edge of the returned bounds might contain some small portion of the next characters. When the output of GetSubstringBounds() is used as input for set_display_rect(), this rounding behavior could show up as small artifacts trailing the domain and/or clipping the first character slightly (see screenshots in linked bug). This CL makes GetSubstringBounds() round down the starting x coordinate. This provides the guarantee that the returned bounds always fully contain the substring -- that is, the bounds will be slightly larger rather than slightly smaller when rounding occurs. An alternative I considered was to introduce GetSubstringBoundsF and let consumers do their own rounding. However, as far as I can tell no other caller cares about the rounding behavior so it seemed like unnecessary complexity to add a float version of the method. Bug: 1108045, 1111044 Change-Id: I733326ef0544c4ecbe3e39bb9bd8f7a410bc0047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317820 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793692}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596174933-c71437d8a30297882573ea069b38258c9e90f721.profdata to chrome-win64-master-1596193635-02bce97a1becd63464acfea57c5b1e9a80097f4f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I32373aad7537ea96895aeb14c2801c0eb9e203ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793691}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4766bd88cf78..22b8657a5558 2020-07-31 taylori@google.com Merge "perfetto-ui: Add thread state summary" 2020-07-31 fmayer@google.com Merge "Elaborate unknown architecture error." 2020-07-31 aninditaghosh@google.com Use http.client rather than urllib.request 2020-07-31 aninditaghosh@google.com Merge "Add tests for Python API." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:162165450 Tbr: perfetto-bugs@google.com Change-Id: I7b618ced88c3ef3abc8dd51343ced1cc8fa49b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331920Reviewed-by:
-
Carlos Caballero authored
Access to TabSpecificContentSettings in now done via the frame as the data is attached to the main frame's active document's RenderDocumentHostUserData. Bug: 998171 Change-Id: I6b635b7c80ab61d201685da5e068c6c07d82dc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277737 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#793689}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie224bbcb38bab0de92649936611509d17bb411ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333046Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793688}
-
Yulan Lin authored
Change-Id: I8f8da9aa793b5818f2395795094f0e2313e0af25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321867 Commit-Queue: Andrew Whalley <awhalley@chromium.org> Auto-Submit: Yulan Lin <yulanlin@google.com> Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Cr-Commit-Position: refs/heads/master@{#793687}
-
Nicolas Ouellet-Payeur authored
This reverts commit efc4423e. Reason for revert: Test failures on macOS bots, e.g.: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/19535 Original change's description: > Reland "[LiteVideo] Observe MediaPlayer rebuffer events to stop throttling." > > This is a reland of 57fd8da7 > > This improves the test that was flaking and disables it on > ChromeOS for now. Bug filed to improve test reliability. > > Original change's description: > > [LiteVideo] Observe MediaPlayer rebuffer events to stop throttling. > > > > This change adds plumbing to allow the LiteVideo optimization to > > observe when rebuffer events occur so that all throttling can be > > stopped. > > > > A future change will record the even in the user blocklist and > > record the event in UKM. > > > > Bug: 1082554 > > Change-Id: I9109fe221800b355e46c78e80254f75f433f9448 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316849 > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: rajendrant <rajendrant@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#793232} > > > TBR=dalecurtis@chromium.org,tbansal@chromium.org > > Bug: 1082554 > Change-Id: I8ead8df5c6e0046bc4d7f6c592307e66f5676762 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330076 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793616} TBR=dalecurtis@chromium.org,kinuko@chromium.org,tbansal@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org Change-Id: Id7d522b9c27eb371c01dca824142062428b8c611 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332682Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#793686}
-
Swapnil authored
We have several downloading stages that the force installed extension must go through. We want to add downloading stage event to the existing events for the event based reporting for force installed extensions. Bug: 1108257 Change-Id: I0dacd8f319c1d9eed186fc290d20659c2bbfd223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310539 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#793685}
-
Abigail Klein authored
recognition service is ready. As soon as a user presses play on a video or audio, the caption bubble should appear with the text "Detecting speech...". To do this, this CL introduces an OnSpeechRecognitionReady function to the CaptionHost mojo interface, which is called the first time the ChromeSpeechRecognitionClient receives audio to be sent to the speech service. The ChromeSpeechRecognitionClient is constructed when the media is first constructed, which is why this is called when audio is received rather than when the recognizer is bound (which is when the on_ready_callback is called back to the renderer). The flow of information from the speech recognition service to the UI is as follows: ChromeSpeechRecognitionClient::SendAudioToSpeechRecognitionService() -----chrome::mojom::CaptionHost OnSpeechRecognitionReady----- CaptionHostImpl::OnSpeechRecognitionReady() CaptionController::OnSpeechRecognitionReady( content::WebContents* web_contents) CaptionBubbleControllerViews::OnSpeechRecognitionReady() CaptionBubbleModel::OnReady() Bug: 1055150 Change-Id: Ib5eff4034b236b1ee1c6747628b11f9f21506460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321406Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#793684}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2a2392d4..759f7034 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3745ed0cdb79f53e9883c8f9e662d96647c6ab49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331863Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793683}
-
Alice Wang authored
This CL adjusts the account picker |expand more| icon in dark mode according to the UI mock. Bug: 1107383 Change-Id: I90532fee7b9bd12884e0a4f36c91b6eb17e55665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320168Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793682}
-
dpapad authored
Bug: 1110015 Change-Id: I7978308c2f402f0c221f96131a440c3375aa5726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326830Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#793681}
-
Peter Kasting authored
Bug: none Change-Id: I9fef002a0abf8ca87ecf044f8824448aa865feef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327456 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#793680}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f6c424bb5923..4766bd88cf78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie713de4cf6a388cf4c8a10da0991d5647d80d024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332562Reviewed-by:
-
behdad authored
With recent changes the flaky stories are prevented by invalidating failures using cpu_wall_time_ratio (https://chromium-review.googlesource.com/c/chromium/src/+/2292811), the previously flaky stories do not need to stay marked as experimental. Bug: 1053614,1093313 Change-Id: I64120d9ba34a2363f21a943131b66d65f20e301f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332737Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793678}
-
Haiyang Pan authored
And update the related AVD creation textpb files Assigning larger memory size via ram_size might help mitigate crbug.com/1105697 Bug: 922145, 1105697 Change-Id: I05c765cffb50b2196cdb99963f1d4a2cf3476c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146136 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#793677}
-
Patrick Noland authored
Bug: 1111201 Change-Id: Iac335d42a332e4a6bee7bcda5c588c9d74de679a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331070Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#793676}
-
Tommy Martino authored
This feature splits the scroll to text functionality off of the Shared Highlighting flag. This is needed because: * The Scroll-to-text portion will be launching first * The Scroll-to-text portion is being built in //ios/web to enable external usage. Bug: 1099268 Change-Id: I60cbe5d20907d4889aa46a051ec335dfe55b59b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329947Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#793675}
-
Tanmoy Mollik authored
This preference will be used to show personalized sync promo in main settings page Screenshot: https://crbug.com/1106378#c2 Bug: 1106378 Change-Id: Iae286ef61f8b1d9166c9174a2fe964a12f6cf0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310412 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#793674}
-
Devlin Cronin authored
Update remaining tests under //content/browser/device_sensors to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I422e3b5573d568f3694cc95a0056b16f0a1d5a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319342Reviewed-by:
-
David Grogan authored
I filed some bugs and added the new bug numbers where appropriate. This only messes with lines in flex directories, there are flex tests in other specs' directories that remain untouched. Fixed: 467127 Change-Id: I90b17600bcdad862099041494d1b92aeda9fd3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332556Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793672}
-
Sergey Poromov authored
DlpContentTabHelper is being attached to WebContents and tracks all the frames inside and visibility of WebContents. This information is reported to DlpContentManager that collects it from all WebContents and tracks whether any of confidential data is currently visible. Bug: 1104884 Test: Unit tests added. Change-Id: I02ae3d1bec7485569592e7fa746f6e6c06c991d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288104 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
-
Andrey Zaytsev authored
Screenshot: https://screenshot.googleplex.com/4AkKd8rHMgB.png Bug: 1070620 Change-Id: I132b669082b09243301927b1f74d3d9809e8d684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329166 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
-
Emily Stark authored
This CL fixes a few oddities in the omnibox tests for the simplified domain field trials. - The main fix is to make ExpectElidedToSimplifiedDomain() not sensitive to the rounding behavior of GetSubstringBounds(), which is changing in a follow-up CL (https://chromium-review.googlesource.com/c/chromium/src/+/2317820). Previously we were checking that the display offset is correct by comparing it to the width of the string that should be scrolled offscreen, but that won't work when GetSubstringBounds() is subsequently changed to round outwards so that adjacent substrings' bounds can overlap slightly -- this makes the width of the portion scrolled offscreen slightly larger than the actual display offset. Instead, we now compare the x value of what should be visible with the x value of what should be offscreen to check that the display offset is correct. - Along the way I noticed that one of the checks in ExpectElidedToSimplifiedDomain() was bogus, so I fixed that. - And I noticed that the URL wasn't set properly (it had an extra scheme appended to it) in SetUpSimplifiedDomainTest(). This didn't really matter because all the code looks at the display URL (which was set properly) rather than the actual URL, but I fixed it anyway. Bug: 1108045 Change-Id: I4c233ce8485b5e09613cac7f268f4b3abc87b142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332581Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#793669}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4470ba1491e5..d7c4f9d06425 2020-07-31 brianosman@google.com Add missing <memory> include 2020-07-31 bsalomon@google.com Don't define SK_GL when no other GPU backends are enabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I60696b6201e7f03f5461b67b8d0ea4d1f799786e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331921Reviewed-by:
-
Saurabh Nijhara authored
If an update is required as per DeviceMinimumVersion policy but the device cannot be updated as it has reached end of life or auto update expiration, the product requirement is to show a banner on the top of Chrome OS Settings page. This banner is to inform the user that device needs to be returned back within the specified time frame. After this time frame has expired, the user would not be able to use the device and hence, the close button on the banner does not dismiss it forever but for just current Settings page. Screenshots: https://screenshot.googleplex.com/PnKQdspE7G9 https://screenshot.googleplex.com/MGFnpRJSvrr https://screenshot.googleplex.com/Ab2GT9bZcXH Bug: 1110976 Change-Id: I69686b019eea524d162316d32ef483606e5154f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314496Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#793667}
-
Haiyang Pan authored
This reverts commit 4019e30a. Reason for revert: Need to create new AVDs for crrev.com/c/2146136 and crrev.com/c/2321088. Revert this CL to avoid affect from emulator/system image change. Original change's description: > android: Roll latest releases of emulator and system image for AVD creation > > API 23: > emulator version: 29.0.11 -> 30.0.12 > system image: 31 -> 32 > API 28: > emulator version: 29.0.11 -> 30.0.12 > system image: 9 -> 10 > API 28 with playstore: > emulator version: 30.0.0 -> 30.0.12 > > Change-Id: I1baa0354767f3fed5b52a4bcb31dc2df09500760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251167 > Auto-Submit: Haiyang Pan <hypan@google.com> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779655} TBR=liaoyuke@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I093b5e2168d3a002e32510c443655f1b7d893d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332565Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
Daniel McArdle authored
Change-Id: Iba9ee450e3800c4cc2514f6067f900453b8ed7c8 Bug: 1111804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332680Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#793665}
-
Andy Lu authored
The Siri shortcut accepts a list of URLs and open them in Incognito mode. Also able to accept inputs from scripting actions (i.e. a list) and open the URLs in it successfully. Deletions of lines in intentdefinition are auto-generated during build. No intentional deletion was done. Bug: 1091764 Change-Id: I7de200803f93434db8608b87d693e84802515d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236243 Commit-Queue: Andy Lu <andyhylu@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#793664}
-
Aaron Krajeski authored
With deferred rendering it's possible for a drawImage operation on a canvas to trigger a copy-on-write if another canvas has a read reference to it. This can cause serious regressions due to extra allocations. FlushForImageListener keeps a list of all active 2d contexts on a thread and notifies them when one is attempting copy-on write. If the notified context has a read reference to the canvas attempting a copy-on-write it then flushes so as to make the copy-on-write unnecessary. Results are promising! https://aaronhk.users.x20web.corp.google.com/flush-for-image-performance.html?r=baseline&s=%25%CE%94avg&g=name&c=0 Bug: 1030108 Change-Id: Idc176053224634156b4775545dc56e8af54b0b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304251 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#793663}
-
Yao Xiao authored
Allow for more flexibility in the FLoC PoC privacy analysis. Bug: 1111818 Change-Id: I99944a052fe4a5f54e38fe20ce6cd8bc24dc17ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332117Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#793662}
-
Rouslan Solomakhin authored
Before this patch, Chrome on Android supported invoking its own TWA for an app store billing payment method, without an ability to turn this feature off. This patch adds an "AppStoreBilling" feature flag that is enabled by default on Android and checks this feature flag before looking up payment support in the TWA. The feature flag is disabled on other platforms where app store billing is not implemented yet. After this patch, it's possible to turn off the feature of Chrome invoking its own TWA for an app store billing payment method. Bug: 1110494 Change-Id: I3c50acdb2949debcbf0d3162a14cb9a3fbeed673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329991Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793661}
-
Bo Liu authored
Follow up to last CL. Need to catch the timeout exception and retry. Bug: 1107812 Change-Id: I03136cd8f7cb4418da2e63631020c6f7751562d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332678Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793660}
-
Devlin Cronin authored
Update //content/browser/download/mhtml_generation_browsertest.cc to use WebContentsConsoleObserver instead of ConsoleObserverDelegate. This allows us to observe console messages added without overriding the existing delegate of the WebContents. Bug: 1034150 Change-Id: I79d7d6b8174e5e24c4a9ad776a94e2636ec6a9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327287Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793659}
-
Josh Nohle authored
A NearbySharePrivateCertificate copy constructor will be necessary for testing. Change-Id: Ib82c7be478b6a27218e7fad13832da74db285fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330049 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#793658}
-
Jonathan Ross authored
This reverts commit 3bd0e5ef. Reason for revert: I incorrectly identified this as the cause of crbug.com/1111764 Original change's description: > Revert "vulkan: reuse gl semaphores" > > This reverts commit 5c8c9a69. > > Reason for revert: Two Vulkan angle_perftests have begun crashing consistently with this change in the blame range. Reverting to confirm if this is the cause. > > Otherwise there is also an Angle roll in the range. > > crbug.com/1111764 > > > Original change's description: > > vulkan: reuse gl semaphores > > > > For passthrough, with extension EGL_ANGLE_display_semaphore_share_group, > > semaphores are shared globally. > > For GLES2Decoder, all GL contexts are in the same shared group, so > > semaphores are also shared globally. > > So we can reused GL semaphores cross GL contexts. > > > > Bug: 1004772 > > Change-Id: I1d23cdc991b2e99d6fe70fdd0560c97dafe73e7c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319368 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Jonathan Backer <backer@chromium.org> > > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#793398} > > TBR=penghuang@chromium.org,backer@chromium.org,vasilyt@chromium.org > > Change-Id: I63953b02f7f06a6e77a3266e3fc4eadee2f882f3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1004772 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332677 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793591} TBR=penghuang@chromium.org,backer@chromium.org,jonross@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1004772 Change-Id: I06ccd88922ba2f7163fe553e86529fc550689a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332837Reviewed-by:
-
Numfor Mbiziwo-Tiapo authored
This change updates the existing putAll implementation to match the explainer more. It does not yet support the put-all-or-none behavior, but it does only return one request now. Design Doc: https://docs.google.com/document/d/1wawQ8Pl-Vi6GQN5-y2UVkcghipcOGg0WRAC0ZyBkezg/edit# Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927 Change-Id: I2c5e9d2d71801eaab3c1c9e94a3968afb8d109b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310110 Commit-Queue: Numfor Mbiziwo-tiapo <nums@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#793656}
-
Viktor Semeniuk authored
This change updates string according with the latest mocks. Bug: 1075494 Change-Id: Ief7e24cc8810895652ca893149370d36eb028c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332619Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07ef703f1646..be774187b1ce 2020-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 08a3cc4cfbaa to aa5bd7657e6c (3 revisions) 2020-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 4400cab64b22 to 71573c7f64cb (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I39e17675a0262f30e79d1cda86dcf8bb6d6c1c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332551Reviewed-by:
-
Viviane Yang authored
This CL enables Push Subscriptions to support a expiration time, set by Chrome in push_messaging_constants.h (currently 90 days). This feature is disabled by default, so to try it out you must set --enable-features= PushSubscriptionWithExpirationTime. 3 BrowserTests are added to check the expiration time behaviour when the flag is set or not set. The expiration time is set in PushMessagingServiceImpl when a subscription is made and saved by PushMessagingAppIdentifier in the browser preference. The following CLs prepare for this change: 1. 2292292: [Push] Add expirationTime attribute to PushSubscription https://chromium-review.googlesource.com/c/chromium/src/+/2292292 2. 2302192: [Push] Pass expirationTime attribute from PushMessagingService to PushManager https://chromium-review.googlesource.com/c/chromium/src/+/2302192 3. 2315682: [Push] Add expiration time property in app identifier https://chromium-review.googlesource.com/c/chromium/src/+/2315682 Bug: 1104215 Change-Id: I341f05096fa57246fa18cb338a1a59f7a1ae01ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302610Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#793653}
-
