- 27 Aug, 2011 17 commits
-
-
dmaclach@chromium.org authored
BUG=NONE TEST=1) Start remoting session with Mac as host 2) Go to the preferences file for the browser (com.google.Chrome.plist) 3) Add a bool pref "RemoteAccessHostFirewallTraversal" set to NONE 4) Wait 15 minutes 5) You should not be able to do NAT traversal. Review URL: http://codereview.chromium.org/7748027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98546 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Test fails consistently on Linux Views bots: PrerenderBrowserTest.PrerenderVisibilityBackgroundTab: [6686:6686:0826/200949:368667468:WARNING:zygote_host_linux.cc(148)] Running without the SUID sandbox! See http://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. [6686:6686:0826/200949:368753313:WARNING:proxy_config_service_impl.cc(654)] Error retrieving proxy setting from device [6686:6686:0826/200949:368754972:WARNING:wm_ipc.cc(311)] Missing _CHROME_LAYOUT_MODE property on root window [6686:6691:0826/200949:368757012:INFO:gl_implementation.cc(94)] Using desktop GL implementation. [6686:6691:0826/200949:368762612:ERROR:gl_surface_glx.cc(64)] GLX 1.3 or later is required. [6686:6691:0826/200949:368762779:ERROR:gl_surface_linux.cc(73)] GLSurfaceGLX::InitializeOneOff failed. [6686:6691:0826/200949:368762962:ERROR:gpu_info_collector_linux.cc(216)] gfx::GLContext::InitializeOneOff() failed [6686:6686:0826/200949:368808876:ERROR:timezone_settings.cc(61)] GetTimezoneID: Cannot read timezone symlink /var/lib/timezone/localtime [6686:6686:0826/200949:368808913:ERROR:timezone_settings.cc(141)] Got an empty string for timezone, default to America/Los_Angeles [6686:6686:0826/200949:368816216:WARNING:input_method_manager.cc(146)] No active input methods found. [6686:6686:0826/200949:368818013:WARNING:input_method_manager.cc(146)] No active input methods found. [6686:6686:0826/200949:368818259:WARNING:input_method_manager.cc(146)] No active input methods found. [6686:6686:0826/200950:369084812:WARNING:native_widget_gtk.cc(418)] compositing not supported; allowing anyway chrome/browser/prerender/prerender_browsertest.cc:680: Failure Value of: display_test_result Actual: false Expected: true - Deflake PrerenderExcessiveMemory, fixing a race in setting the visibility state of prerendered RenderViews in the process. Also add some more visibility API tests that would have reliably failed when losing the fixed race. BUG=93081 TEST=PrerenderBrowserTest.PrerenderExcessiveMemory. PrerenderBrowserTest.PrerenderInfiniteLoop Review URL: http://codereview.chromium.org/7693029 TBR=mmenke@chromium.org Review URL: http://codereview.chromium.org/7736003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98545 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/7745046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98544 0039d316-1c4b-4281-b951-d872f2087c98
-
dmaclach@chromium.org authored
BUG=75518, 70793 TEST=Build and then watch builds. Review URL: http://codereview.chromium.org/7764008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98543 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
Disable frame pointer optimization on base::debug::StackTrace() so it works properly in release builds. Similarly disable optimizations in npobject_stub.cc so base::debug::StackTrace() can recognize more frames (This last de-optimization is only temporary, whereas the change to base::debug::StackTrace is intended to be permanent). BUG=94179 Review URL: http://codereview.chromium.org/7763008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98542 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
(Rolling just 1 revision because something farther on seems to tickle an ld crash, but I'd like to get the rest of this CL in.) Also pass --disable-threads and --disable-pthreads to configure, for goma. Also modify the script to try to download prebuilt binaries first. This is faster, and makes sure the bots use the exact same binary as goma. The binaries are downloaded from http://commondatastorage.googleapis.com/chromium-browser-clang/index.html Also add a script that packages a clang build up into a tgz for uploading with gsutil, based on code by ukai@. Finally, if the svn checkout fails, remove the destination directory and try again (for bots that have a checkout from before we had an internal llvm svn mirror). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98416 Review URL: http://codereview.chromium.org/7741039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98541 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
It saves the stack trace where initial deletion happened from. In the case where the deletion was initiated by DeleteSoon(), we will show the stacktrace for the caller of that function (rather than the actual deletion stacktrace from running the task). BUG=94179 Review URL: http://codereview.chromium.org/7748024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98540 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
the visibility state of prerendered RenderViews in the process. Also add some more visibility API tests that would have reliably failed when losing the fixed race. BUG=93081 TEST=PrerenderBrowserTest.PrerenderExcessiveMemory. PrerenderBrowserTest.PrerenderInfiniteLoop Review URL: http://codereview.chromium.org/7693029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98539 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98538 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
TBR=podivilov@chromium.org Review URL: http://codereview.chromium.org/7766011 TBR=levin@chromium.org Review URL: http://codereview.chromium.org/7764015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98537 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
Revert 98511 - Don't send DidChangeView to the plugin unless the parameters have actually changed. Apparently WebKit sends the update for every layout, even if nothing has changed. Review URL: http://codereview.chromium.org/7761005 TBR=brettw@google.com Review URL: http://codereview.chromium.org/7762014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98531 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98530 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
TBR=podivilov@chromium.org Review URL: http://codereview.chromium.org/7766011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98529 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@google.com authored
TBR=satorux@chromium.org BUG=88863 TEST=none Review URL: http://codereview.chromium.org/7766015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98528 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
Before, it abused the noExtensions flag to determine to disable share groups for WebGL, which was awful. This patch is dependent on https://bugs.webkit.org/show_bug.cgi?id=66516. See also http://codereview.chromium.org/7669072 where I perpetrated the aforementioned hack. BUG=92356 Review URL: http://codereview.chromium.org/7669072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98527 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
the test suite implicitly provides global resources for each test, but they're re-initialized between each test. The performance overhead is negligible. We need that to continue moving tests from unit_tests to content_unittests. Because of shared test fixtures the test suites need to be compatible. BUG=90443 Review URL: http://codereview.chromium.org/7744039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@google.com authored
TBR=jam@chromium.org BUG=76354 TEST=none Review URL: http://codereview.chromium.org/7763010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98525 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Aug, 2011 23 commits
-
-
tony@chromium.org authored
frame) in the mini installer package. BUG=94362 TEST=In a chrome frame page, press ctrl+f. A find dialog should appear and it should be localized. Review URL: http://codereview.chromium.org/7761010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98524 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
BUG=none TEST=none (tested locally on Mac OS X) Review URL: http://codereview.chromium.org/7762012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98523 0039d316-1c4b-4281-b951-d872f2087c98
-
dgrogan@chromium.org authored
Incognito / SQLite's quota is now 50mb. We'll have to figure out what to do for quota for LevelDB's incognito mode when it's implemented. BUG=94187 TEST=llvm/Debug/browser_tests --gtest_filter=IndexedDB* Review URL: http://codereview.chromium.org/7745011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98522 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
BUG=93740 TEST=manual Review URL: http://codereview.chromium.org/7757008 TBR=bbudge@chromium.org Review URL: http://codereview.chromium.org/7765007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98520 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
TBR=timurrrr@chromium.org Review URL: http://codereview.chromium.org/7767009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98519 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
BUG=93740 TEST=manual Review URL: http://codereview.chromium.org/7757008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98518 0039d316-1c4b-4281-b951-d872f2087c98
-
dennisjeffrey@chromium.org authored
BUG=chromium-os:18185 TEST=None Review URL: http://codereview.chromium.org/7745007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98517 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@google.com authored
BUG=None TEST=Manual Review URL: http://codereview.chromium.org/7761009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98516 0039d316-1c4b-4281-b951-d872f2087c98
-
gideonwald@chromium.org authored
BUG=92510 TEST=Make sure that the text "End Process" isn't preceded by an ampersand on Windows and has the E underlined. Review URL: http://codereview.chromium.org/7723001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98515 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
TBR=dennisjeffrey@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7771002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98514 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
Chrome Frame needs 2 dialogs and an icon in the locale dlls. The rest of the strings and resources can be pulled from the locale pak files. This also removes the icon from the pak files and moves them into the dlls. BUG=94362 Review URL: http://codereview.chromium.org/7766007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98513 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
The in-browser thumbnailing does not work if --force-compositing-mode is supplied. I don't know what would be the right way to fix this. For now, we should just disable the in-browser thumbnailing, until we have the right fix. BUG=chromium-os:19731 The last valgrind error was fixed by r87590. BUG=65936 TEST=confirm that thumbnails in the new tab page are updated properly Review URL: http://codereview.chromium.org/6969091 TBR=satorux@chromium.org Review URL: http://codereview.chromium.org/7762006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98512 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@google.com authored
Apparently WebKit sends the update for every layout, even if nothing has changed. Review URL: http://codereview.chromium.org/7761005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98511 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
RenderWidgetHostViewWin::ReparentWindow should call RemovePropW if kNativeWindowClassFilterProp is set. BUG=94402 TEST=None. Review URL: http://codereview.chromium.org/7757004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98510 0039d316-1c4b-4281-b951-d872f2087c98
-
scottbyer@chromium.org authored
BUG=88954 Review URL: http://codereview.chromium.org/7744056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98509 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
This involves introducing the following macros: PPAPI_PROXY_EXPORT - for symbols exported from ppapi/proxy PPAPI_SHARED_EXPORT - for symbols exported from ppapi/shared_impl PPAPI_THUNK_EXPORT - for symbols exported from ppapi/thunk NOTE: shared_impl and thunk are still linked together, but I thought it was cleaner to give thunk its own macro. R=brettw@chromium.org Review URL: http://codereview.chromium.org/7687005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98508 0039d316-1c4b-4281-b951-d872f2087c98
-
polina@google.com authored
NaCl PPAPI Proxy: wrap up with crash detection. Clean-up handling code to skip remote shutdown calls when the nexe is known to be dead. Add a test for crashing on other than the main thread, which depending on thread timing might happen when the main thread is servicing a PPP call or waiting for the next one. Add another test that will fail on a CHECK for an unsupported Pepper call off the main thread. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1780, http://code.google.com/p/nativeclient/issues/detail?id=2105, http://code.google.com/p/nativeclient/issues/detail?id=1682 TEST=scons run_ppapi_crash_browser_test Review URL: http://codereview.chromium.org/7741036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98507 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98506 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
```--------------------------------------------------------------------- r828 | mark@chromium.org | 2011-08-26 18:29:33 -0400 (Fri, 26 Aug 2011) | 8 lines Fix a Breakpad crash during teardown when USE_PROTECTED_ALLOCATIONS is in effect. BUG=none TEST=Apple Crash Reporter logs from processes in which Breakpad handles the crash should point the finger at the actual crash source, not the Breakpad thread's attempt to write to unwritable memory. Review URL: http://breakpad.appspot.com/301001 ``` --------------------------------------------------------------------- r827 | mark@chromium.org | 2011-08-26 17:37:59 -0400 (Fri, 26 Aug 2011) | 5 lines Add missing (parentehses.) BUG=247, chromium:94107 TEST=Minidump file sizes should be manageable Review URL: http://breakpad.appspot.com/300002 ------------------------------------------------------------------------ This also enables USE_PROTECTED_ALLOCATIONS. This should have been on all along because we're using Breakpad through the Framework/Breakpad.mm interface, which requires it. Note that if we ought not have been using USE_PROTECTED_ALLOCATIONS, the build would fail. BUG=94107 TEST=Breakpad should upload reasonably-sized minidump files. Apple Crash Reporter logs from processes in which Breakpad handles the crash should point the finger at the actual crash source, not the Breakpad thread's attempt to write to unwritable memory. Review URL: http://codereview.chromium.org/7761007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98505 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
in the language pack and the other resources like dialogs in the dll. The latter part is done automatically by ATL. BUG=94362 TEST=No change in behavior. The resources should continue to load as before. Review URL: http://codereview.chromium.org/7763006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98502 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/7685019/cevans@chromium.org authored
Landing on behalf of Chris Palmer. BUG=93554 R=wtc,agl,kevers Review URL: http://codereview.chromium.org/7766004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98501 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
we're using. BUG=None TEST=None R=noelallen@google.com Review URL: http://codereview.chromium.org/7771001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98500 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
file. This makes the Native Client authors file a subset of the Chromium one so that we can update the copyright notices of the code we recently moved into the Chrome repo to be "Copyright the Chromium Authors." TEST=none BUG=none Review URL: http://codereview.chromium.org/7770001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98499 0039d316-1c4b-4281-b951-d872f2087c98
-