- 16 Oct, 2018 36 commits
- 
- 
Jun Mukai authoredThis is the final phase of tab-dragging with touch on Mash. This makes several changes to use the result of the previous phases and achieve tab-dragging with touch on Mash. BUG=867074 TEST=manually Change-Id: I53239efbdf567754d3e9322b334d0a4e6751fa52 Reviewed-on: https://chromium-review.googlesource.com/c/1247034 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#599820} 
- 
Giovanni Ortuño Urquidi authoredCurrently to use GetState we have to create a RunLoop, call GetState with a callback that saves the result in a class variable, run the loop and then access the class variable to get the result. This CL attemps to simplify this by wrapping GetState into a function that waits for the call to respond and returns the result directly. Bug: 870192 Change-Id: I9d8d2dfb654443f99d56fe6e676efe9bfb8d0717 Reviewed-on: https://chromium-review.googlesource.com/c/1278464 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599819} 
- 
Andrew Grieve authoredThis file does not actually exist for stable & beta channels. Change-Id: I0885a565933b7457c77c5c43eaf218175cbb04ad Reviewed-on: https://chromium-review.googlesource.com/c/1281282Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#599818} 
- 
Khushal authoredCurrently repaint only reports smoothness metrics so the data for thread time measurements is missed. Switch it to use rendering measurements, already used by rendering_ct, which includes both smoothness and thread times numbers. R=rmistry@chromium.org Change-Id: Ia39077827d9cda9a8840b0f85584f956edbcd649 Reviewed-on: https://chromium-review.googlesource.com/c/1281283Reviewed-by: Ravi Mistry <rmistry@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599817} 
- 
Tsuyoshi Horo authoredAfter crrev.com/c/1272419, all unittests which trigers navigation requires MockRenderProcessHost::url_loader_factory_ when ServiceWorkerServicification is enabled. This is causing many crashes in content_unittests. To fix this, this CL introduces NotImplementedNetworkURLLoaderFactory and use it as default of MockRenderProcessHost's url_loader_factory_. Bug: 895187 Change-Id: I8119845cf73d0a97297efc473db87b84021cf71d Reviewed-on: https://chromium-review.googlesource.com/c/1280072Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#599816} 
- 
Tsuyoshi Horo authoredCurrently when both service-worker-servicification and network-service are not enabled, the internally redirected request doesn't go to the service worker. But when service-worker-servicification or network-service is enabled, the internally redirected request goes to the service worker. We may support service worker integration, like FetchEvent's preloadResponse in future. But we don't have plan to support service worker integration without service-worker-servicification. To make this behavior consistent, this CL makes NavigationURLLoaderImpl::URLLoaderRequestController skip sending the redirected request of signed exchange to the service worker. Bug: 894755 Change-Id: I6f22819655169b4d3c30de0aa269911111c45586 Reviewed-on: https://chromium-review.googlesource.com/c/1278433Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#599815} 
- 
Morten Stenshorne authoredIt produces the same output as in legacy, except for space differences. Some syntax error is apparently expected these days, as of https://chromium-review.googlesource.com/c/1215512 TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5938cd5d53154f6b51ddd515144d8a0b727a0a0a Reviewed-on: https://chromium-review.googlesource.com/c/1281327 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599814} 
- 
Moe Ahmadi authoredBug: 881364 Change-Id: I89310a03a7afdcb4e1c38b1b22f0a1ca49722210 Reviewed-on: https://chromium-review.googlesource.com/c/1277575Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599813} 
- 
Nasko Oskov authoredKURL parsing uses known_ports.cc for supporting known ports for standard schemes. GURL uses its own version, which leads to mismatch in behavior. This CL adds gopher's default port to known_ports.cc, however a follow up patch should just remove gopher support in general. Bug: 894426 Change-Id: I9cde04bef34be39337cdb9f2a584de576d0b15ea Reviewed-on: https://chromium-review.googlesource.com/c/1279408Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599812} 
- 
Collin Baker authoredThe triggering conditions for our in-product help include closing a tab that has been active for at least some length of time. This adds a class that tracks when tabs are activated and notifies its client when an active tab is closed. Bug: 887991 Change-Id: I7b3ca7a8f069d24c1751df9e301854ca99b2ff17 Reviewed-on: https://chromium-review.googlesource.com/c/1277819 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#599811} 
- 
Alan Cutter authoredThis CL turns a NOTIMPLEMENTED into a TODO to reduce console spam on Mac. Bug: 415024 Change-Id: I6da61e2e942e5c8014aec2c412705ffeb2d1c9d9 Reviewed-on: https://chromium-review.googlesource.com/c/1280062Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#599810} 
- 
David Staessens authoredThe QueueInputBuffer function tries to print the queued buffer's data size. The data_size function contains a "DCHECK(!end_of_stream());" however, so when a EOS buffer is queued this check fails. TEST=ran VDA tests on eve BUG=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I278f87461d221d2638984abe3fe0241f9da71eac Reviewed-on: https://chromium-review.googlesource.com/c/1272755Reviewed-by: Pawel Osciak <posciak@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#599809} 
- 
John Budorick authoredBug: 878082 Change-Id: I4172f46931e09c5ba8bf85f0113e5f31df53e9c5 Reviewed-on: https://chromium-review.googlesource.com/c/1279409Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599808} 
- 
Noel Gordon authoredIn tablet mode, the extensions dialog has a fixed sized, and cannot be resized. However, non-client hit testing in Ash calls canResize(), and the current dialog code returns true: that causes Ash to show a resize cursor on the non-client window edges of the dialog for mouse users. Prevent that: when the dialog is active in Chrome OS tablet mode, deny canResize() requests to stop the resize cursor appearing at the dialog window edges. Bug: 453634 Change-Id: I551e145c169c9844d3ac090a4e99d9eb826e6e5a Reviewed-on: https://chromium-review.googlesource.com/c/1280383Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599807} 
- 
Annie Sullivan authoredThis is deprecated and will be replaced by load:tools:stackoverflow:2018 story. Disabling now because we are hitting CQ capacity. Bug: 893615 Change-Id: I29b839a0d8bfd007f36a1d09ca1e52a4620735cf TBR: nednguyen@google.com Reviewed-on: https://chromium-review.googlesource.com/c/1280617 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599806} 
- 
Albert J. Wong authoredThis CL moves the final 4 messages that are sent to the RenderWidgetHost's routing ID, but which were handled by RenderViewHost or an object within RVH's delegate/subdelegate tangle. Specifically, WidgetHostMsg_Close, ViewHostMsg_RouteCloseEvent, WidgetHostMsg_DidFirstVisuallyNonEmptyPaint, and WidgetHostMsg_DidCommitAndDrawCompositorFrame now terminate in the RenderWidgetHost and are sent down via explicit methods on the delegates interfaces. After this CL, any messages sent to RenderWidgetHost no longer pass into the RenderViewHost. RenderWidgetHostView*::OnMessageReceived...I'm coming for ya next. You're a marked object and ima gonna sweep your methods clean. Bug: 419087 Change-Id: Ic104aaf785983159ae4a7f1a65781d89b98dfabe Reviewed-on: https://chromium-review.googlesource.com/c/1278285Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#599805} 
- 
Justin Cohen authoredCq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie5bdc140b82f49151ca891b39f65112bf6210eac Reviewed-on: https://chromium-review.googlesource.com/c/1278332Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599804} 
- 
John Budorick authoredRevert "[testing/scripts] Add base adapter class that enables more code reuse for all isolated script test" This reverts commit 18e40bdc. Reason for revert: Spec revert for https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/84707 etc Original change's description: > [testing/scripts] Add base adapter class that enables more code reuse for all isolated script test > > BUG: 894261 > Change-Id: Id707ba8a8782a23a41a7dc4680cbc2538e1d3df1 > Reviewed-on: https://chromium-review.googlesource.com/c/1278156 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#599669} TBR=nyquist@chromium.org,dpranke@chromium.org,kbr@chromium.org,dtrainor@chromium.org,nednguyen@google.com,martiniss@chromium.org Change-Id: Ib67b3565568dec728a78fd7d95342d4762a8ecbb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1282215Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599803} 
- 
Tommy C. Li authoredAfter deduplicating 100 filenames, i.e. foo.jpg, foo (1).jpg, ... foo (100).jpg, Chrome will stop trying. On Desktop this is acceptable, as the user gets a prompt to choose a filename. On Android, this is really bad, because there is no prompt to choose an alternate filename, and the download just silently fails. This CL starts using a timestamp after 100, and creates filenames in the ISO 8601 format, like: foo - 2018-10-11T21:55:47.392Z.jpg Bug: 135428 Change-Id: I13748110171f799f58c8ddf27f22eebc97149c09 Reviewed-on: https://chromium-review.googlesource.com/c/1278137Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599802} 
- 
chromium-internal-autoroll authoredhttps://chrome-internal.googlesource.com/chrome/src-internal.git/+log/482b936f1be1..b4ed4fd40624 Created with: gclient setdep -r src-internal@b4ed4fd40624 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6933c47aec925a0a34504be2e50b457d94239765 Reviewed-on: https://chromium-review.googlesource.com/c/1281267Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599801} 
- 
Nick Harper authoredBug: 875053 Change-Id: I10e419f9e15d004d8da115ed9b18734d47b0a442 Reviewed-on: https://chromium-review.googlesource.com/c/1279294 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#599800} 
- 
Abhishek Bhardwaj authoredThis change adds AddWakeOnWifiPacketTypes and RemoveWakeOnWifiPacketTypes to the shill D-Bus API. These APIs program what type of packets the NIC should wake the system on. BUG=891143 TEST=chromeos_unittests. Change-Id: I21d779ed450ae8f682d2dd5d9f90aef0ee0a2360 Reviewed-on: https://chromium-review.googlesource.com/c/1269114Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599799} 
- 
chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/5aac72d05c7e..2be20fdd2d70 git log 5aac72d05c7e..2be20fdd2d70 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 nednguyen@google.com Remove --exact-test-filter flag Created with: gclient setdep -r src/third_party/catapult@2be20fdd2d70 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894261 TBR=sullivan@chromium.org Change-Id: I618e12507c58e9a214232aa3866780f6b13ef8bf Reviewed-on: https://chromium-review.googlesource.com/c/1281264Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599798} 
- 
Ken Rockot authoredThis pulls EmbeddedInstanceManager, EmbeddedServiceRunner, and EmbeddedServiceInfo out of the //services/service_manager/embedder target and into the client library, where they belong. These types are used only by client code to facilitate embedding services within other services and they require no linkage to the Service Manager implementation. Bug: 895022 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I180d9eff440c2b3a06e62b8784bdd2747822842d Reviewed-on: https://chromium-review.googlesource.com/c/1279327Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599797} 
- 
Tom Anderson authoredBUG=881371 R=pkasting Change-Id: I7a351ed115da2a265e74bfd8557c845b7faa3a60 Reviewed-on: https://chromium-review.googlesource.com/c/1281325 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#599796} 
- 
Collin Baker authoredThis allows tabs to be reached by the keyboard. Only tabs are made focusable, not the tab close buttons since tabs can be easily closed from the context menu. This also makes the tabstrip as an accessible pane so it can be reached by F6 and SHIFT+F6. Follow-up changes: - Look into having CTRL+W close the focused tab rather than the active tab when in keyboard accessibility mode. - Make keyboard focus advance to the next tab when closing the focused tab (rather than disappearing as it does now). Bug: 702414 Change-Id: I052ac56a6adfbc317a67c00314fd9259ab83fc2e Reviewed-on: https://chromium-review.googlesource.com/c/1241845 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#599795} 
- 
Chan Li authoredThis reverts commit ba8218bf. Reason for revert: Suspecting this breaks GcpReauthCredentialTest.OnUserAuthenticated on win-asan. Findit analysis: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/win-asan/builds/1834 Original change's description: > Add credential provider unit tests run on the buildbots. > > Fix up the tests so that they run correctly with base::LaunchUnitTests(). > Add the unit test exe to the buildbot configs. > > Bug: 789588 > Change-Id: Ib0ccf2bf965071e6afe2638db1fe3e565799c3e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1274456 > Commit-Queue: Roger Tawa <rogerta@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599656} TBR=rogerta@chromium.org,zmin@chromium.org,jbudorick@chromium.org,tienmai@chromium.org Change-Id: I33b666181bbe4234da257b567229c51c9bdf7ee7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789588 Reviewed-on: https://chromium-review.googlesource.com/c/1281880Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599794} 
- 
John Budorick authoredThis reverts commit 382f3853. Reason for revert: crbug.com/895592 Original change's description: > Add Dawn, SPIRV-Cross and GLFW to //third_party > > Dawn is a library implementing WebGPU in native. It uses SPIRV-Cross to > translate shaders from SPIRV to other shading languages, and requires > glfw for testing. > > Adds the Zlib license to the list of allowed license for Android. > > This also adds back shaderc that was very recently removed. So hopefully > a new third_party review isn't required. > > BUG=chromium:870747 > > Change-Id: I506156072f34e70e12797f922a979aa8c743bd6e > Reviewed-on: https://chromium-review.googlesource.com/c/1244817 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: dsinclair <dsinclair@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599740} TBR=dsinclair@chromium.org,cwallez@chromium.org,wfh@chromium.org,kainino@chromium.org,jochen@chromium.org,dominic@google.com Change-Id: I861d000856773e66a6a2c060ae737599b3be3e4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:870747 Reviewed-on: https://chromium-review.googlesource.com/c/1281879Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599793} 
- 
Jeremy Klein authoredBug: 881664 Change-Id: If8bc6ea2368c32a4a76d474ed625a0db5da0492d Reviewed-on: https://chromium-review.googlesource.com/c/1279426Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#599792} 
- 
David Trainor authoredRemove date and filter type separators from the new downloads home UI. BUG=893918 Change-Id: Ie52e136d056c6b89f34830de90d4f3701535fa59 Reviewed-on: https://chromium-review.googlesource.com/c/1277967 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599791} 
- 
Kurt Horimoto authoredThis coordinator manages a stack of optionally collapsible toolbars. It manages laying out these toolbars in a top-to-bottom or bottom-to- top order and interpolating the toolbars' heights based on the fullscreen progress. Ultimately, toolbar layout management will be moved from BVC to this coordinator. Bug: 880672 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2b143895d30ce1ec68f58141d7364f1d32ef3f39 Reviewed-on: https://chromium-review.googlesource.com/c/1220722 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#599790} 
- 
Bugs Nash authoredChange-Id: I0f8b8e40e39a9f05c58d410a724a5161aae0101b Reviewed-on: https://chromium-review.googlesource.com/c/1256324 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by: Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#599789} 
- 
Justin Donnelly authoredTextfield creates partial selections from the point of the cursor on shift-up/down. Bug: 892216 Change-Id: I3196972dea1abeb5ffbf2d4381d27ca067e41bc6 Reviewed-on: https://chromium-review.googlesource.com/c/1276849Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#599788} 
- 
Chan authoredTBR=wjmaclean@chromium.org Bug: 891155 Change-Id: I27212eee19d0f7f67b4ee5caba3df4562edb30d2 Reviewed-on: https://chromium-review.googlesource.com/c/1281225Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599787} 
- 
Xianzhu Wang authoredRebaseline two tests that no longer produce a blank line. Tolerate failures under fast/events/touch and virtual/paint-touchaction-rects/fast/events/touch because many of the tests are failing or crashing and the tests change very fast. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6d0ad19f419b30059414a0c75b4495d03425633a Reviewed-on: https://chromium-review.googlesource.com/c/1282030Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599786} 
- 
Peter Boström authoredRemoves the need for custom ink-drop highlights. This change (as tested locally) should have no visual impact. It only reduces custom ink-drop usage. Bug: chromium:888204 Change-Id: Iefb2c6adf9f95a6d1265fb1dbd95ff0f0e7ecf97 Reviewed-on: https://chromium-review.googlesource.com/c/1279169Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#599785} 
 
- 
- 15 Oct, 2018 4 commits
- 
- 
Tarun Bansal authoredRemove ShouldBypassMissingViaHeader feature which has never been enabled in DRP, and there are no plans to enable it. Change-Id: Ife6b09da141468a44718e3b6cb43f4515c82ea29 Bug: 806114 Reviewed-on: https://chromium-review.googlesource.com/c/1279124Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599784} 
- 
Ahmed Fakhry authoredMany media and creative suite applications make use of Alt+Click actions, but we always rewrite it to Right-Click without giving the users a way to turn this behavior off. Users of such applications often use external mice, which already have an independent right click button. This CL limits this behavior to events coming from touchpad devices. BUG=890648 TEST=Expanded tests. Change-Id: I1b72eb4d9986e9139d7c6193cc2f808a6d9cad06 Reviewed-on: https://chromium-review.googlesource.com/c/1255605Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#599783} 
- 
Joel Einbinder authoredWithout this, taking a coverage report could be flaky if nothing forced a style recalc. This can happen very often in headless mode. Change-Id: If2bb596736f274d0aeceabec9ff7cf6076886eae Reviewed-on: https://chromium-review.googlesource.com/c/1279293 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#599782} 
- 
Sahel Sharify authoredThis cl relands the following cl after excluding the added tests. https://chromium-review.googlesource.com/c/chromium/src/+/1278963 This gives the solution more time to bake on ToT without getting reverted due to flaky tests. Meanwhile I will work on the tests to deflake them. TBR=mcnee@chromium.org,creis@chromium.org Bug: 884728, 249063 Change-Id: Icc1e32ffe493f85d0ee74b0aff37ccdf078d0e8f Reviewed-on: https://chromium-review.googlesource.com/c/1281687 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599781} 
 
-