- 21 May, 2018 40 commits
-
-
Ken Rockot authored
Ensures no EDK dependencies get introduced into mojo/public (non-test), and cleans up some other incorrect DEPS allowances. TBR=jcivelli@chromium.org Bug: None Change-Id: I60030b0734ff73869442d5880b50d1b2289721af Reviewed-on: https://chromium-review.googlesource.com/1067489Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560301}
-
Fredrik Söderquist authored
Since we reassociate the SVGResource synchronously, we need to also make sure that the associated SVGResources object is updated, else it could end up pointing to the old <pattern> LayoutObject. Bug: 845040 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I026b46abcd510485ddfe33622cb5f5aa1bab9610 Reviewed-on: https://chromium-review.googlesource.com/1065779Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#560300}
-
Ted Choc authored
BUG=844787 Change-Id: I966b385a928075c25eebdb7abfbdbbfb0ab2db95 Reviewed-on: https://chromium-review.googlesource.com/1067477Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#560299}
-
James Cook authored
Preparation for turning the new mojo app implementation on by default. Change the switch to a base::Feature so we can trivially change the default (or turn it off via Finch) if necessary. Bug: 840380 Test: ash_unittests, unit_tests for about:flags Change-Id: Ia1c2cf5d3bb2ae77dc01e9c26c5941e1643b54cb Reviewed-on: https://chromium-review.googlesource.com/1066826Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#560298}
-
Lindsay Pasricha authored
Bug: 830810 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9abf680f5ac7007654ec8054150a85b49ce10a6d Reviewed-on: https://chromium-review.googlesource.com/1066308 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#560297}
-
Devlin Cronin authored
Update the ManifestTest class to use the new base::Value API and movable types, rather than base::DictionaryValues and unique_ptrs. Bug: None Change-Id: Id1cd42dc1842957db5600e36e0bae75b10b71247 Reviewed-on: https://chromium-review.googlesource.com/1039780 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#560296}
-
Nico Weber authored
merge aura_non_clang_gtests into aura_gtests, run linux_and_mac_specific_chromium_gtests on asan bots too This adds keyboard_unittests and snapshot_unittests to the *san bots, where they were omitted unintentionally. It also adds keyboard_unittests to the clang and fyi bots. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511 Change-Id: I11d8982c26888d56834c18a5f83ad57c4c29126c Reviewed-on: https://chromium-review.googlesource.com/1067167 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#560295}
-
Scott Violet authored
BUG=837684 TEST=test only changes Change-Id: I34a2d9327d9a3771bfc953383e3551ebbcba33aa Reviewed-on: https://chromium-review.googlesource.com/1067437 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#560294}
-
Robert Liao authored
The Cocoa global pasteboard behavior only updated the find bar if the find bar was empty and there was new find text. This change copies the similar behavior to the views find bar by ignoring empty find text. This fixes browser_tests FindInPageControllerTest.NavigateClearsOrdinal FindInPageControllerTest.IncognitoFindNextShared BUG=844305 Change-Id: Idd50476a7368079ec54221513a76bdfa0a272559 Reviewed-on: https://chromium-review.googlesource.com/1065500Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#560293}
-
Malay Keshav authored
This patch removes the force stacking of tabs when touch optimized chrome is enabled and restores the old approach. Bug: 844193 Change-Id: Icf591860d06afe4698817291f70d619343237a82 Component: Touchable chrome, tabstrip, tab stacking Reviewed-on: https://chromium-review.googlesource.com/1066864 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#560292}
-
Ahmed Fakhry authored
Due to ink drop effects on the caption buttons, they're painted to layers. This doesn't work in immersive fullscreen mode and causes the buttons to disappear. This CL fixes them by adding them temporarily as children of the TopContainerView which is already painting to layer in immersive mode, and is resposible for painting its sibling BrowserNonClientFrameViewAsh. BUG=840242,787640 TEST=Added two new browser tests Change-Id: Ia953fa0d742366540855b6e4b0655b76b3c823cd Reviewed-on: https://chromium-review.googlesource.com/1065020 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Hongchan Choi authored
This is a speculative fix for the bug associated. The following is the scenario of potential NULL-deference: 1. BaseAudioContext.audioWorklet.addModule('some.url'); 2. BaseAudioContext is destroyed. 3. The callback originated from the module loading arrives, but the associated context is already gone. 4. Crash with NULL deference, because the callback touches the destination node of the AudioContext. This CL fixes the issue by keeping track of WorkletPendingTasks until module loading tasks are resolved. Bug: 839642 Change-Id: I154bb8c56f0fa95d6708c642047c7b05acf83eb2 Reviewed-on: https://chromium-review.googlesource.com/1062795Reviewed-by:Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560290}
-
Daniel Park authored
Bug: 843639 Change-Id: I71a393ecf295958a14e5bbae4ca52025b3c153a5 Reviewed-on: https://chromium-review.googlesource.com/1064555 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/037be4e032ef..435282162ed6 $ git log 037be4e03..435282162 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 skia-recreate-skps Update SKP version 2018-05-21 herb Add SkMakeUnique to gn 2018-05-21 jvanverth Disable perspective for emoji fallback 2018-05-21 fmalita Roll third_party/rapidjson to af223d44f4e8d3772cb1ac0ce8bc2a132b51717f Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I43517e46b8f089284cbe707b03b967b3a62e2ea0 Reviewed-on: https://chromium-review.googlesource.com/1066081Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560288}
-
Tsuyoshi Horo authored
This incorporats with dgozman's comments in crrev.com/c/1004890 - Change "from SignedExchange" to "from signed-exchange" in NetworkRequestNode. - Show the signed exchagne url as the initiator of certificate request. - Show "from signed-exchange" in the headers tab of the inner request. - Add "View request" link in the preview tab of signed exchange to show the inner request. - Add "Learn more" link in the preview tab of signed exchange. Bug: 830505 Change-Id: Ica7ae52e563efb283c600c812be196951a12a336 Reviewed-on: https://chromium-review.googlesource.com/1065558 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#560287}
-
Philip Rogers authored
The viewport scrollbars can be hoisted above the layout view's graphics layer so they are not affected by page scale or overflow elasticity. To ensure all layers are collected, we start from the paint root which is an ancestor layer of both the content and the scrollbars. This fixes a bug where non-hoisted scrollbars were collected twice: once through the main recursive walk, and a second time for just the scrollbars. With this change, overlay scrollbar layers are now collected which requires a property tree state. VisualViewport::InitializeScrollbars has been temporarily updated to initialize the property tree state. Making all painting (not just BlinkGenPropertyTrees) go through this codepath is difficult because WebViewImpl manages special layers (e.g., devtools page overlay, popup layers) which are painted and updated separately. With BlinkGenPropertyTrees, all painting will start at the root. Bug: 841423 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I97bcb40a0242b3f07ce2ca93d432c81dcf3220b6 Reviewed-on: https://chromium-review.googlesource.com/1054777Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#560286}
-
Rintaro Kuroiwa authored
- Added codec_picture.cc because the constructor and destructor are now "complex". - The DecryptConfig describes the decryption config of the input stream for this picture Bug: 838673 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I84f202faae6a1dde2e3fec5f0535d349c2ec3d96 Reviewed-on: https://chromium-review.googlesource.com/1038157Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#560285}
-
Abhishek Arya authored
- Add -wt/--web-tests argument for running run_web_tests.py with custom arguments. Special configuration is needed such as --no-sandbox, etc, so this automatically does that. - Add assert to prevent users from incorrectly running run_web_tests.py. - Add _GetFullPath helper that resolves symbolic links. This prevent infinite loop with 'parent_dir == SRC_ROOT_PATH'. - Make _ExecuteCommand, _ExecuteIOSCommand write stdout, stderr to file, so that execution can be monitored. R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: 842851 Change-Id: I2eb1744cee34c3d367ec1ddf418879417064c808 Reviewed-on: https://chromium-review.googlesource.com/1067021 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#560284}
-
Steve Kobes authored
This is a rough prototype of the proposal described at go/layoutjank. Bug: 581518 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id212437c0f187c54ad4725cf0b71ddee28288dac Reviewed-on: https://chromium-review.googlesource.com/1046155 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#560283}
-
Eugene But authored
This histogram will help us to understand if Chrome for iOS should support application/x-apple-aspen-config downloads. Bug: 781770 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4507c19ea7a11aa6bcb014228c7ed94781393acd Reviewed-on: https://chromium-review.googlesource.com/1058276 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#560282}
-
Scott Violet authored
BUG=837684 TEST=test only change Change-Id: I206ed5e1bae668285638fde7aff56f70c75c3cec Reviewed-on: https://chromium-review.googlesource.com/1066786Reviewed-by:
-
Tarun Bansal authored
This change is guarded behind a finch trial. This CL would need to be merged back to M-67, and makes it possible for third-party origins to receive the DPR, Device-Memory and viewport-width client hints. The plan is to enable the finch trial only on Android. Change-Id: I67596e3f210e623464721210dec85d3e22497bd0 Bug: 845074 Reviewed-on: https://chromium-review.googlesource.com/1066776Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#560280}
-
Emilio Cobos Álvarez authored
I forgot to do this in the previous patch for issue 782407. Looks like the only caller that passed it really wants the new behavior, plus before the original patch for issue 782407 it was already kinda broken with custom properties... No new tests, since there's no behavior change. Bug: 782407 Change-Id: I410ed1481256b18886c5804f4cbecde9846f2a26 Reviewed-on: https://chromium-review.googlesource.com/1066062Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#560279}
-
Elly Fong-Jones authored
This change adds support for Mac-style "focus ring paths" to Views, which means that a given View can (via FocusRing::Delegate) supply an arbitrary path for its focus ring to be drawn around when it has a focus ring. This removes the need for Checkbox and RadioButton to have their own focus ring implementations. It will also be necessary as the MD refresh work adds more circular/oval controls in top chrome. This work leads into a longer-term effort to make FocusRing not be a View; see https://crbug.com/840796 for details about that. Bug: 836946,835376 Change-Id: I433dc370e5fbc2ff30b53b070d84255199b6ec29 Reviewed-on: https://chromium-review.googlesource.com/1050185 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32a4910e57b1..037be4e032ef $ git log 32a4910e5..037be4e03 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 egdaniel Reland "Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter." Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I92e30c35ce2237658a087face8388d8a50892ea4 Reviewed-on: https://chromium-review.googlesource.com/1067019Reviewed-by:
-
Nico Weber authored
LUCI bots apparently need -B instead of -m. While here, also remove \ after && (the latter already tells the shell that the command is continuing) and fix indentation. TBR=hans Bug: 844392 Change-Id: I9af96be984264e240257a5fa55e8b84c65f0602d Reviewed-on: https://chromium-review.googlesource.com/1067417Reviewed-by:
-
Elly Fong-Jones authored
Context menus and combobox menus are both "auxiliary" in the UI sense, so they have a reduced corner radius to fit better with their parent controls. Bug: 829347 Change-Id: Ie0ecfcbab5161071d5cf61cc8e7647172122dad5 Reviewed-on: https://chromium-review.googlesource.com/1066470 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Misha Efimov authored
Bug: 844176 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I24afd90a60a00ed7bd4700f13de78217cf4953e7 Reviewed-on: https://chromium-review.googlesource.com/1066751Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#560274}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5ee9829622bc..7ca7a59f0202 $ git log 5ee982962..7ca7a59f0 --date=short --no-merges --format='%ad %ae %s' 2018-05-18 maxlg Shared_page_state: fix exception message Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I395e7401c889df0079592cf86d849df4f4db980a Reviewed-on: https://chromium-review.googlesource.com/1067022 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560273}
-
Bernhard Bauer authored
Even though @Manual was added more than three years ago, it appears that it never prevented any tests from running. Introduce a ManualSkipCheck that skips such tests. Also, add a unit test that instantiates and runs a ClassRunner, to verify that the check is properly executed. The test infrastructure for that could also be reused in other tests. TBR: jbudorick@chromium.org Bug: 831589 Change-Id: I2e2c105cdc4308fedee3f8f330feda5f055a4310 Reviewed-on: https://chromium-review.googlesource.com/1066092Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#560272}
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/1067164 added angle_unittests to chromium_gtests, so it now runs on the regular non-gpu android bots. At the moment, this means than angle_unittests runs twice on android_n5x_swarming_rel, e.g. on https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/426449 This used to be an error when I worked on https://chromium-review.googlesource.com/c/chromium/src/+/1061795 last week (where this change was already reviewed), but apparently isn't an error anymore this week, so I forgot to move this part over. This should have been part of https://chromium-review.googlesource.com/c/chromium/src/+/1067164 TBR=kbr@chromium.org Bug: 843511 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic0cd9986fff0415593190350aa5222255771c462 Reviewed-on: https://chromium-review.googlesource.com/1067361 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
Previously, they ran on the the clang and fyi android bots. cast_unittests also ran on almost all desktop bots via non_android_and_clang_win_chromium_gtests. gcm_unit_tests ran on almost all desktop bots via non_android_and_cast_chromium_gtests. Effectively this adds the two binaries to the main waterfall android bots. It also adds cast_unittests to the win/clang/tot and win/fyi bots, and gcm_unit_tests to the linux cast audio bots. Also unconditionally disable one cast_unittests test on Android since it doesn't pass there (it was already disabled under android cfi). This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr@chromium.org Bug: 843511,831999 Change-Id: If4466d25664f8be72336b0da987732563fa049b3 Reviewed-on: https://chromium-review.googlesource.com/1067166 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
run boringssl_crypto_tests, boringssl_ssl_tests, libjingle_xmpp_unittests, storage_unittests everywhere Adds these suites to some memory bots, the clang tot bots, and fyi bots. Also disable one libjingle_xmpp_unittests under asan since it fails there. This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr Bug: 843511,843731 Change-Id: I03f1117bba3dffe970caaca468cf28723f45c005 Reviewed-on: https://chromium-review.googlesource.com/1067360 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Philip Jägenstedt authored
Problem uncovered by a recent change in WPT, see: https://bugs.chromium.org/p/chromium/issues/detail?id=844781#c5 Bug: 844781 Change-Id: I6d3a51e7673ef28128b0ede4cbb0450a299730b5 Reviewed-on: https://chromium-review.googlesource.com/1065991Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#560268}
-
Tetsui Ohkubo authored
As described in the design doc, old SystemTray class is going to be replaced by UnifiedSystemTray class. Tray icons will be implemented in UnifiedSystemTray. This CL adds notification counter and do-not-disturb icon to UnifiedSystemTray button. Screenshot: * Counter: http://screen/cgktiihNYDo * Mute icon: http://screen/613vrQB3suz UX spec: http://shortn/_4BzEvhLxJ5 Design doc: go/cros-qs-restyling TEST=manual BUG=836134 Change-Id: Ia8c75290afe6c63a70125808d6ebd9bc7b0c37b9 Reviewed-on: https://chromium-review.googlesource.com/1060779Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#560267}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/41a6376d..d87aec04 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic7b8417fe5ea240368cba08bdd1af51d73d8892f Reviewed-on: https://chromium-review.googlesource.com/1067357Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#560266}
-
Steve Kobes authored
This will be used to measure layout jank regions. Also add some documentation of Region::Shape, and move comments about Region into the header. Bug: 581518 Change-Id: I54365b4fa544210060cc8fa59f4d4af820bfcb09 Reviewed-on: https://chromium-review.googlesource.com/1055597Reviewed-by:
-
Findit authored
This reverts commit cdc3f283. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 560257 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2NkYzNmMjgzNzMyNmQxMmM2YjVjNDlkZjNlNGRmMmFiZDRjMzU3YWMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Win%20x64/22691 Sample Failed Step: compile Original change's description: > Roll src/third_party/webrtc/ a832019f4..6633d41bb (3 commits) > > https://webrtc.googlesource.com/src.git/+log/a832019f4e3a..6633d41bb0ee > > $ git log a832019f4..6633d41bb --date=short --no-merges --format='%ad %ae %s' > > Created with: > roll-dep src/third_party/webrtc > > > The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: I011fe3205d4b516b19df66bedac18861166e1ee7 > Reviewed-on: https://chromium-review.googlesource.com/1067014 > Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#560257} No-Presubmit: true No-Tree-Checks: true No-Try: true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Change-Id: Ia05b0f4b36b30ff64176cadf444223d508a9af7f Reviewed-on: https://chromium-review.googlesource.com/1067054 Cr-Commit-Position: refs/heads/master@{#560264}
-
Bernhard Bauer authored
Different channel builds on Android must have identical .so files. Previously ARCore was only enabled on the default channel but disabled on Canary, Dev, Beta, and Stable, which broke channel builds. Replacing the channel check with an official build check is the closest approximation that avoids reverting https://crrev.com/559923 completely. TBR: mthiesse@chromium.org Bug: 845080 Change-Id: Id75d793827db0a489523f1fe3ced094b0821d35d Reviewed-on: https://chromium-review.googlesource.com/1065917 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#560263}
-
Nico Weber authored
chromium_android_clang_and_gl_gtests already includes all the tests in chromium_swarm_android_gtests, but chromium_swarm_android_gtests has different swarming parameters, and they overwrite some of the other tests. Remove chromium_swarm_android_gtests to give the clang, fyi, and memmory bots the same swarming parameters as the main android bots. (Hopefully we can delete all the chromium_swarm_*_gtests config and remove the chromium.swarm waterfall.) Also see the discussion at https://chromium-review.googlesource.com/c/chromium/src/+/1061795/27/testing/buildbot/chromium.android.json#882 This is part of an effort to reduce the number of test configurations. Originally reviewed as part of https://chromium-review.googlesource.com/1061795, which I'm now landing in smaller pieces. TBR=kbr@chromium.org Bug: 843511 Change-Id: I9e455cc3fc3ec69e813e4c72a9e1c2e7528dbf76 Reviewed-on: https://chromium-review.googlesource.com/1067109 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
