GitLab

The catapult CL [1] will introduce a change where running adb commands
may now raise device_errors.DeviceUnreachableError if the device is
no longer found.

This change adjusts clients that were hoping to catch this kind of
error as a device_errors.[Adb]CommandFailedError.

[1]: https://codereview.chromium.org/2808763004/

BUG=https://github.com/catapult-project/catapult/issues/3476

Review-Url: https://codereview.chromium.org/2811993002
Cr-Commit-Position: refs/heads/master@{#464383}

The old Delegate API made it rather awkward to get at the full details of
the request.  This new API fixes that, whilst allowing more flexible
request modification.

BUG=546953

Review-Url: https://codereview.chromium.org/2815003003
Cr-Commit-Position: refs/heads/master@{#464382}

This CL switches the content/browser/ part of offscreen canvas to use
FrameSinkManagerHost instead of directly accessing SurfaceMananger.

OffscreenCanvasProvider(Impl) exists for the renderer to request other
interfaces from the browser. The renderer uses it create both a
OffscreenCanvasSurface and MojoCompositorFrameSink. This is a
simplification of OffscreenCanvasCompositorFrameSinkProvider and
OffscreenCanvasSurfaceFactory interfaces.

RenderProcessHostImpl creates a single OffscreenCanvasProviderImpl on
demand and uses it for all offscreen canvas requests from the renderer.

The renderer will first request a OffscreenCanvasSurface and specify the
FrameSinkId. This always happens from the main renderer thread. A
OffscreenCanvasSurfaceImpl will be created for the browser side of this
connection.

The renderer will then likely request MojoCompositorFrameSink for the
FrameSinkId, from either the main thread or a worker thread. This
request is forwarded to MojoFrameSinkManager. This sets up two
connections. There is a MojoCompositorFrameSink from
MojoFrameSinkManager to the renderer. This is used to submit
CompositorFrames. There is MojoCompositorFrameSinkPrivate from
OffscreenCanvasSurfaceImpl to MojoFrameSinkManager. This gives the
browser control over the CompositorFrameSink created in
MojoFrameSinkManager.

The render can close the OffscreenCanvasSurface and
MojoCompositorFrameSink connections in any order. The assumption is they
will both be closed at approximately the same time.

The remaining direct access to SurfaceManager by offscreen canvas code
is blocked on other features being completed.

BUG=664547,686861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2789753002
Cr-Commit-Position: refs/heads/master@{#464381}

Skipping tasks when destroying ScopedTaskEnvironment or
ScopedAsyncTaskScheduler means that DeleteSoon() tasks
can be skipped, resulting in memory leaks.

BUG=708584, 709095

Review-Url: https://codereview.chromium.org/2812293002
Cr-Commit-Position: refs/heads/master@{#464380}

BUG=710896
TEST=Run components_unittests

Review-Url: https://codereview.chromium.org/2811303003
Cr-Commit-Position: refs/heads/master@{#464379}

BUG=703559

Review-Url: https://codereview.chromium.org/2803603003
Cr-Commit-Position: refs/heads/master@{#464378}

This CL fixes crashes caused by calls to Profile.getLastUsedProfile()
before browser initialization is completed.
In such a case ProfileManager will try to create new Profile
and that will eventually crash Chrome, because Prefs are not registered yet
(Profile-related Prefs are registered during browser initialization by
ChromeBrowserMainExtraPartsProfiles::EnsureBrowserContextKeyedServiceFactoriesBuilt).

BUG=704025,710968

Review-Url: https://codereview.chromium.org/2809223003
Cr-Commit-Position: refs/heads/master@{#464377}

Reland of Move ScriptState::GetExecutionContext (Part 5) (patchset #2 id:300001 of https://codereview.chromium.org/2821443002/ )

Reason for revert:
Broke Build

Original issue's description:
> Revert of Move ScriptState::GetExecutionContext (Part 5) (patchset #3 id:40001 of https://codereview.chromium.org/2816543002/ )
>
> Reason for revert:
> Suspected culprit of webkit_tests failing on chromium.webkit/WebKit Linux Trusty MSAN.
>
> BUG=711250
>
> Original issue's description:
> > Move ScriptState::GetExecutionContext (Part 5)
> >
> > This CL replaces all uses of ScriptState::GetExecutionContext in Source/modules with ExecutionContext::From.
> >
> > BUG=682322
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Review-Url: https://codereview.chromium.org/2816543002
> > Cr-Commit-Position: refs/heads/master@{#464056}
> > Committed: https://chromium.googlesource.com/chromium/src/+/d2d9a34e2fd74fd45026a8fed6f4715de18df747
>
> TBR=jbroman@chromium.org,haraken@chromium.org,adithyas@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=682322
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>

TBR=jbroman@chromium.org,haraken@chromium.org,adithyas@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=711250
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2815313002
Cr-Commit-Position: refs/heads/master@{#464376}

This CL adds a number of JUnit tests for testing
MediaNotificationManager in the following aspects:

* Check if MediaNotificationManager handles the ListenerService correctly.
* Check if ListenerService can correctly process Intents.
* Check if the Notification presrented to Android NotificationManager is
  correct.

Many MediaNotificationManager members are changed to package scope access
to avoid too many "ForTesting" names.

BUG=705919

Review-Url: https://codereview.chromium.org/2816603002
Cr-Commit-Position: refs/heads/master@{#464375}

Currently, the sync socket in MojoAudioOutputStream is closed by both
Mojo and the SyncSocket destructor. This causes problems if a handle
happens to be reused.

BUG=709394
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2809673002
Cr-Commit-Position: refs/heads/master@{#464374}

Revert of Move ScriptState::GetExecutionContext (Part 5) (patchset #3 id:40001 of https://codereview.chromium.org/2816543002/ )

Reason for revert:
Suspected culprit of webkit_tests failing on chromium.webkit/WebKit Linux Trusty MSAN.

BUG=711250

Original issue's description:
> Move ScriptState::GetExecutionContext (Part 5)
>
> This CL replaces all uses of ScriptState::GetExecutionContext in Source/modules with ExecutionContext::From.
>
> BUG=682322
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2816543002
> Cr-Commit-Position: refs/heads/master@{#464056}
> Committed: https://chromium.googlesource.com/chromium/src/+/d2d9a34e2fd74fd45026a8fed6f4715de18df747

TBR=jbroman@chromium.org,haraken@chromium.org,adithyas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2821443002
Cr-Commit-Position: refs/heads/master@{#464373}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/98d73506..2e896f6f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2810223004
Cr-Commit-Position: refs/heads/master@{#464372}

https://swiftshader.googlesource.com/SwiftShader.git/+log/2ed3149..400667e

BUG=

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2817783002
Cr-Commit-Position: refs/heads/master@{#464371}

BUG=707298
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I171c9b733d735f8a035640fd96b8fda5dd7686ec

Review-Url: https://codereview.chromium.org/2812963003
Cr-Commit-Position: refs/heads/master@{#464370}

Review-Url: https://codereview.chromium.org/2819533002
Cr-Commit-Position: refs/heads/master@{#464369}

This patch changes DocumentMarkerController::RenderedRectsForMarkers()
to ignore disconnected nodes.
and it is first step to use EphemeralRange in updateMarkerRenderedRect().

we will progress three steps.
[1/3] Make RenderedRectsForMarkers() to ignore disconnected nodes.
[2/3] In-place change of Range::textRects() and boundingBox()
 to EphemeralRange version in "Range.cpp"
[3/3] Rewrite  updateMarkerRenderedRect() to use
 EphemeralRange instead of Range

BUG=691202

Review-Url: https://codereview.chromium.org/2776103002
Cr-Commit-Position: refs/heads/master@{#464368}

These tests have been failing for a little while, but since I
just moved the builder onto the chromium.memory waterfall, they
will now be reported to the sheriffs, and so it's better to
disable them until they can be triaged.

TBR=thakis@chromium.org, danakj@chromium.org, fsamuel@chromium.org, dalecurtis@chromium.org
BUG=697171
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

Review-Url: https://codereview.chromium.org/2817443004
Cr-Commit-Position: refs/heads/master@{#464367}

And rename files
gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.{cc,h} =>
gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.{cc,h}

From this CL the 2 files above are now also build on linux. But for now
GpuMemoryBufferFactoryNativePixmap::CreateImageForGpuMemoryBuffer is only
implemented on ozone as it was previsouly. A follow-up CL will implements
it for linux.

This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux.

BUG=584248
R=reveman@chromium.org
TBR=kbr@chromium.org, piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2709163004
Cr-Commit-Position: refs/heads/master@{#464366}

BUG=699080

Review-Url: https://codereview.chromium.org/2815103002
Cr-Commit-Position: refs/heads/master@{#464365}

https://pdfium.googlesource.com/pdfium.git/+log/d20e3880234a..e0b592236db9

$ git log d20e38802..e0b592236 --date=short --no-merges --format='%ad %ae %s'
2017-04-12 tsepez Refcount CPDF_CryptoHandler

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ia64c6d854cee8cacedd8af7c77e1e6016bd95045
Reviewed-on: https://chromium-review.googlesource.com/476027
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464364}

This CL adds UMA metrics for sizes of favicons from which fallback style
was generated (because large enough icon is missing). This is important
for evaluating if changing the minimum size limit / using more advanced
method for upscaling would help.

BUG=709498

Review-Url: https://codereview.chromium.org/2809783003
Cr-Commit-Position: refs/heads/master@{#464363}

This CL removes workaround for the bug that was fixed long time ago.

BUG=none

Review-Url: https://codereview.chromium.org/2816713002
Cr-Commit-Position: refs/heads/master@{#464362}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a478c171..98d73506

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2816963002
Cr-Commit-Position: refs/heads/master@{#464361}

This is essentially the result of the following shell command followed by
git cl format:

    find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \;

DEPS is updated in order to prevent further introduction of "wtf/".

BUG=691465
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2813413002
Cr-Commit-Position: refs/heads/master@{#464360}

If a collection backing is reallocated during pre finalization, the backing containing stale pointers ends up uncollected for one cycle. If conservative GC ends up tracing this buffer by accident, the stale pointers gets traced.

This CL disallows collection backing reallocation during pre finalizers. The backing size will end up being adjusted later.

BUG=709201

Review-Url: https://codereview.chromium.org/2815663002
Cr-Commit-Position: refs/heads/master@{#464359}

 NodeAsRangePastLastNode() as Range::PastLastNode().

This was introduced once 2 years ago:
https://codereview.chromium.org/1000533004

but reverted of crash:
https://codereview.chromium.org/1121633004

Now original code won't crash because {start/end}Position() doesn't return
 Null Position since:
https://codereview.chromium.org/2812733003

TEST=LayoutTests/fast/dom/Range/range-toString-non-anchor-no-crash.html

Review-Url: https://codereview.chromium.org/2818643003
Cr-Commit-Position: refs/heads/master@{#464358}

f425c1c cryptohome: Add a new mount argument for migration

BUG=702526
TEST=build

Review-Url: https://codereview.chromium.org/2815163004
Cr-Commit-Position: refs/heads/master@{#464357}

This line was introduced before 2011 splitting DragCaretController from
 FrameSelection:
https://chromium.googlesource.com/chromium/src/+/fa14cd2b25316fb358f7f5ebc16f752ebcb4093a

Now DragCaret doesn't touch Selection Layout and this is unnecessary call.

BUG=708453

Review-Url: https://codereview.chromium.org/2813883005
Cr-Commit-Position: refs/heads/master@{#464356}

This is essentially the result of the following shell command followed by
git cl format:

    find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \;

DEPS is added in order to prevent further introduction of "wtf/".

BUG=691465
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2815193003
Cr-Commit-Position: refs/heads/master@{#464355}

This is essentially the result of the following shell command followed by
git cl format:

    find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \;

DEPS is added in order to prevent further introduction of "wtf/".

BUG=691465
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2817863002
Cr-Commit-Position: refs/heads/master@{#464354}

This is essentially the result of the following shell command followed by
git cl format:

    find . -type f -exec sed -i 's/"wtf\//"platform\/wtf\//g' {} \;

DEPS restriction is lifted to platform/ level. Duplicated entries in
the subdirectories are removed.

BUG=691465
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2810413002
Cr-Commit-Position: refs/heads/master@{#464353}

LayoutView::ClearSelection was originally introduced at 2004 to assure no
 crash:
https://chromium.googlesource.com/chromium/src/+/10f7ac6ea6784e33161c7979e9a59c5e2cae14b5

Even now that code doesn't make sense because we update LayoutSelection after
layout in following sequence:
1. FrameView::PerformPostLayoutTasks() checks
 LayoutSelection::SetHasPendingSelection()
2. PaintLayerCompositor::UpdateIfNeededRecursiveInternal() calls
 LayoutSelection::Commit() and it updates layout selection.

BUG=708453

Review-Url: https://codereview.chromium.org/2811333003
Cr-Commit-Position: refs/heads/master@{#464352}

This allows observers that might outlive the service to unregister
themselves, and to clear out any raw pointers to the service they might
have.
In the same spirit, verify that there are no observers left during
TemplateURLService destruction.

BUG=704518

Review-Url: https://codereview.chromium.org/2815643007
Cr-Commit-Position: refs/heads/master@{#464351}

BUG=709964

Review-Url: https://codereview.chromium.org/2806273002
Cr-Commit-Position: refs/heads/master@{#464350}

Add the libjingle_xmpp_unittests test to the following bots:
Cast Audio Linux
Cast Linux
Android Tests
Android Tests (dbg)
Linux Tests
Linux Tests (dbg)(1)
Linux Tests (dbg)(1)(32)
Mac10.10 Tests
Mac10.11 Tests
Mac10.9 Tests
Mac10.9 Tests (dbg)
Win 7 Tests x64 (1)
Win10 Tests x64
Win7 Tests (1)
Win7 Tests (dbg)(1)

BUG=708983
TESTED=Local execution and a run in Swarming using:
tools/mb/mb.py isolate //out/Release libjingle_xmpp_unittests
tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com   -i out/Release/libjingle_xmpp_unittests.isolate -s out/Release/libjingle_xmpp_unittests.isolated
tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d pool Chrome -d os Linux -d cpu x86-64 out/Release/libjingle_xmpp_unittests.isolated

Review-Url: https://codereview.chromium.org/2803333002
Cr-Commit-Position: refs/heads/master@{#464349}

Revert of Don't set a default value for the NTPContentSuggestionsEnabled policy if ChromeHome is enabled (patchset #3 id:40001 of https://codereview.chromium.org/2806453002/ )

Reason for revert:
The hack isn't required anymore, let's get it removed before branch point :)

Original issue's description:
> Don't set a default value for the NTPContentSuggestionsEnabled policy if ChromeHome is enabled
>
> This is a temporary hack to allow dogfooding of ChromeHome.
>
> BUG=708191
>
> Review-Url: https://codereview.chromium.org/2806453002
> Cr-Commit-Position: refs/heads/master@{#462451}
> Committed: https://chromium.googlesource.com/chromium/src/+/d4b92153f875c211e8c6f01603ed510962200747

TBR=atwilson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=708191

Review-Url: https://codereview.chromium.org/2813423002
Cr-Commit-Position: refs/heads/master@{#464348}

As per spec Pageshow event must be fired asynchonously all the time, but to be compatible with other browsers blink used to fire Pageshow synchronously.
And thus Pageshow event was able to modify nodes when it should not.

This CL makes Pageshow fired asynchronously when it is in EventQueueScope to solve the problem.
BUG=660269,543424

Review-Url: https://codereview.chromium.org/2815803003
Cr-Commit-Position: refs/heads/master@{#464347}

This is just moving:
https://codereview.chromium.org/2800813006/

TEST=No change in behavior.
BUG=708453

Review-Url: https://codereview.chromium.org/2813403002
Cr-Commit-Position: refs/heads/master@{#464346}

core/html/forms/OWNERS should be responsible for these files.
This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2815263002
Cr-Commit-Position: refs/heads/master@{#464345}

{EventHandler,MouseEventManager} is storing a {clicked,tapped} node as Node*,
instead of Element*, that would be a bad practice. Actually, that has been the
cause of several wrong behaviors in Blink, such as:

1. Blink does NOT fire a click event when a clicked text node has been removed
   in mouseup.  This is wrong because a click event should be fired on an
   element node.  See [1] for details. This bug was just tentatively fixed at
   another CL [2].

2. Blink DOES fire a touch event on a non-element node.  This is wrong because
   TouchEvent specification says all kinds of touch events' event target types
  are limited to Document and Element [3].

To prevent these wrong behaviors, this CL does:
- Have EventHandlingUtil::ParentElementIfNeeded and use it everywhere so that
  we surely adjust a node to the appropriate element, at which an event should be
  fired.
- Replaces the usage of Node* to Element* as much as possible so that it rejects
  the wrong code at type level check.

- [1]: topmost event target;
  https://www.w3.org/TR/uievents/#topmost-event-target
- [2] https://codereview.chromium.org/2812613004
- [3]: Trusted proximal event target types are: Document and Element;
  https://w3c.github.io/touch-events/#list-of-touchevent-types

BUG=708394,710425

Review-Url: https://codereview.chromium.org/2807123002
Cr-Commit-Position: refs/heads/master@{#464344}