GitLab

Track attribute uses object type, but we should use
(VideoTrack or AudioTrack or TextTrak)? as the spec says[1].

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-trackevent-interface

BUG=430337

Review URL: https://codereview.chromium.org/690923004

git-svn-id: svn://svn.chromium.org/blink/trunk@185104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431996
TBR=senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/692283003

git-svn-id: svn://svn.chromium.org/blink/trunk@185103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Delete mac result, rebaseline to grab any new mac result, which should
match the windows result and be optimized out if things are working as
expected per issue 405803 and issue 409435.

BUG=405803
TBR=dstockwell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/697843005

git-svn-id: svn://svn.chromium.org/blink/trunk@185102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function was removed from the spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#install-event-section

BUG=423600
TEST=n/a

Review URL: https://codereview.chromium.org/690393003

git-svn-id: svn://svn.chromium.org/blink/trunk@185101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Remove PreloadRequest::defer()
- Remove ResourceFetcher::requestPreload(). The only user is preload()
  and is just calling requestPreload().
- Move setDefer() call in HTMLResourcePreloader::preload() into
  resourceRequest() call
- Make HTMLResourcePreloader::preload() private

R=japhet
BUG=none

Review URL: https://codereview.chromium.org/717453002

git-svn-id: svn://svn.chromium.org/blink/trunk@185100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/711053002

git-svn-id: svn://svn.chromium.org/blink/trunk@185099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up CL of https://codereview.chromium.org/661453004/.

I don't see why the call sites of getOwnPropertyNames() can't use
getPropertyNames() instead. The reason why they need property names
is that we don't support OpenEndedDictionary and IDL dictionary
which contains an union type at this point. In both cases we should
be able to use getPropertyNames().

Review URL: https://codereview.chromium.org/715583008

git-svn-id: svn://svn.chromium.org/blink/trunk@185098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test was flaky because the iframe sent a postMessage to the parent
frame in its load handler. However, the parent frame may or may not have
run its load handler. If the parent frame's load handler hadn't run yet,
then there would be no handler for a postMessage. To prevent this race,
don't load the iframe until the parent frame is fully initialized.

BUG=409579

Review URL: https://codereview.chromium.org/713013005

git-svn-id: svn://svn.chromium.org/blink/trunk@185097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

toImplArray() template can convert arrays (or sequences) of T to
Vector<T> when T has NativeValueTraits. Generate them for union type
containers so that we can use (A or B)[] (or sequence<(A or B)>)
in method arguments.

Note that we can't use union type arrays and sequences for
return values yet. Follow-up CLs will support return values.

BUG=240176

Review URL: https://codereview.chromium.org/700733003

git-svn-id: svn://svn.chromium.org/blink/trunk@185096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431996
TBR=senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/716693002

git-svn-id: svn://svn.chromium.org/blink/trunk@185095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Ran ./Tools/Scripts/webkit-patch optimize-baselines <this-test> locally
to check optimization.

BUG=409435

Review URL: https://codereview.chromium.org/699083009

git-svn-id: svn://svn.chromium.org/blink/trunk@185094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

During uninitialize a destination node, audio thread can be entered
AudioIOCallback's render() or OfflineAudioContext's offlinerender.

Although the destination node already destroyed, audio thread can be run for while
since it is running on separated thread.

To block meeting this condition, the context()->isInitialized() must be quarantee,
if Audio destination is uninitializing, alwasy false.

BUG=420814, 417193, 428233,431109

Review URL: https://codereview.chromium.org/694993003

git-svn-id: svn://svn.chromium.org/blink/trunk@185093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

according to http://www.w3.org/WAI/PF/aria/roles#listitem.

BUG=347865

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184795

Review URL: https://codereview.chromium.org/696953002

git-svn-id: svn://svn.chromium.org/blink/trunk@185092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185075

BUG=415513
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/707973008

git-svn-id: svn://svn.chromium.org/blink/trunk@185091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't expose ServiceWorker in WorkerNavigator yet, and creating
a provider for workers could cause data-race with the current code.
(See https://code.google.com/p/chromium/issues/detail?id=423107#c8 for
more details)

BUG=423107,371690
R=michaeln

Review URL: https://codereview.chromium.org/717553003

git-svn-id: svn://svn.chromium.org/blink/trunk@185090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

getPropertyCSSValue, CSSValue, etc. are no longer web-exposed and about
to be deleted as soon as tests no longer depend on them.

BUG=428595

Review URL: https://codereview.chromium.org/682833005

git-svn-id: svn://svn.chromium.org/blink/trunk@185089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a re-work of https://codereview.chromium.org/238313003/

Review URL: https://codereview.chromium.org/712143003

git-svn-id: svn://svn.chromium.org/blink/trunk@185088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://codereview.chromium.org/683013002 changed the impl name of
Window from LocalDOMWindow to DOMWindow. This affects the results
of run-bindings-tests.

Review URL: https://codereview.chromium.org/718563002

git-svn-id: svn://svn.chromium.org/blink/trunk@185087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was only used to check if there was a radius involved, which is easy
enough, and even sensible (since we can then avoid calling this method
at all in most cases - after all, it's not like border radius is
something you set on every other element), to check before calling the
method.

Additionally, this made it pretty obvious that calling this from
paintTransformedLayerIntoFragments() was rather useless, since clipRect
there wasn't a ClipRect but a LayoutRect (which knows nothing about
radii).

R=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/705303004

git-svn-id: svn://svn.chromium.org/blink/trunk@185086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=352464,372428,374282

Review URL: https://codereview.chromium.org/717533004

git-svn-id: svn://svn.chromium.org/blink/trunk@185085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/692433003

git-svn-id: svn://svn.chromium.org/blink/trunk@185084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Similarly to the non-blob code path, we should pass a Font arg to
setupPaint() for Mac hinting heuristics.

(See https://codereview.chromium.org/692643006)

BUG=421412
R=eae@chromium.org,jbroman@chromium.org,bungeman@chromium.org

Review URL: https://codereview.chromium.org/692643007

git-svn-id: svn://svn.chromium.org/blink/trunk@185082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/eeGNNCIBkX8/5KzPyK2caoUJ

BUG=428348

Review URL: https://codereview.chromium.org/681113006

git-svn-id: svn://svn.chromium.org/blink/trunk@185081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/700843006

git-svn-id: svn://svn.chromium.org/blink/trunk@185080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue is no longer web-exposed we shouldn't require it
in tests so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/684293004

git-svn-id: svn://svn.chromium.org/blink/trunk@185078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185065

BUG=421412
TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/711193002

git-svn-id: svn://svn.chromium.org/blink/trunk@185077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185065

BUG=421412
TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/710973006

git-svn-id: svn://svn.chromium.org/blink/trunk@185076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL reverts
https://codereview.chromium.org/414503002

The RenderLayer change was wrong and is the cause of the regression.
Unfortunately it's unclear what the path forward is: the ASSERT is
triggering, which means there are some bugs in the code, but it is
caused by having several definitions of paint invalidation container.
Fixing it will require aligning these definitions and it's unclear
which one is right.

BUG=415513

Review URL: https://codereview.chromium.org/706353002

git-svn-id: svn://svn.chromium.org/blink/trunk@185075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=416907

Review URL: https://codereview.chromium.org/710443002

git-svn-id: svn://svn.chromium.org/blink/trunk@185074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No more overloads! The method/methodImpl pattern could be further
collapsed, but this seems like a good start while we work out kinks.

The 'RequestInfo' typedef is from the fetch spec[1], also used in the
ServiceWorker spec[2] to improve readability.

[1] https://fetch.spec.whatwg.org/
[2] https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html

BUG=240176
R=bashi@chromium.org,jkarlin@chromium.org

Review URL: https://codereview.chromium.org/700323003

git-svn-id: svn://svn.chromium.org/blink/trunk@185073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431625

Review URL: https://codereview.chromium.org/694773005

git-svn-id: svn://svn.chromium.org/blink/trunk@185072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As CSSValue is no longer web-exposed there's no point testing it.
Removing testing of it will allow us to delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/711043004

git-svn-id: svn://svn.chromium.org/blink/trunk@185071 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The WebAudio spec removed these methods a year ago in favor of start
and stop.  Chrome had removed these methods for
AudioBuffserSourceNodes, but not OscillatorNodes.

BUG=430995
TESTS=dom-exceptions updated

Review URL: https://codereview.chromium.org/707753006

git-svn-id: svn://svn.chromium.org/blink/trunk@185070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It appears that in some cases if an extension object outlives the context it was
created with that context could be GCed out from under it mid-function. This new
pattern enforces a scoped ref count of the associated canvas any time the
context is used by an extension.

BUG=429478

Review URL: https://codereview.chromium.org/687533005

git-svn-id: svn://svn.chromium.org/blink/trunk@185069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This bit is useful for better understanding how the touch sequence that
gave rise to a given scroll sequence was handled by the page. In
particular, this affords the gesture consumer an opportunity to limit
itself if part of the gesture was consumed by the page's touch handler,
e.g., disabling a pull-to-refresh styled overscroll effect if the
initial motion was preventDefault'ed,
https://codereview.chromium.org/679493002.

Chromium-side wiring for this data will be added in
https://codereview.chromium.org/712133003.

BUG=428429

Review URL: https://codereview.chromium.org/690173002

git-svn-id: svn://svn.chromium.org/blink/trunk@185068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch switches the bindings code from using LocalDOMWindow to using
the DOMWindow interface. This will allow OOPIF to add a RemoteDOMWindow
class that remote frames can expose to web content.

BUG=425623

Review URL: https://codereview.chromium.org/683013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Column styling is not used on SVG elements so don't allow it to apply when parsing 
the style.

BUG=399603

Review URL: https://codereview.chromium.org/695423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With https://codereview.chromium.org/175253002 (Blink r182920)
webkit-font-smoothing was broken on Mac. This restores
the previous behavior.

BUG=chromium:421412

Review URL: https://codereview.chromium.org/692643006

git-svn-id: svn://svn.chromium.org/blink/trunk@185065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the same HTMLMediaElement, the WebMediaPlayer can get recreated if src changes.
However, the fullscreen status of the media element will remain unchanged.
On android, we need to know whether the newly created WebMediaPlayer is fullscreen or not.
This is because we need to pass the surface view to the new WebMediaPlayer.
This change calls the enterfullscreen() function to let the WebMediaPlayer to pass the surface.


New layout test will be added once this CL goes in, and the chromium side change is submitted

BUG=428209

Review URL: https://codereview.chromium.org/644153005

git-svn-id: svn://svn.chromium.org/blink/trunk@185064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added blink::WebView::hitTestResultForTap to do so.
blink::WebView::hitTestResultAt will be removed in a follow up patch.

See also https://codereview.chromium.org/475633002/ on how chromium uses it.

BUG=403865

Review URL: https://codereview.chromium.org/470833002

git-svn-id: svn://svn.chromium.org/blink/trunk@185063 bbb929c8-8fbe-4397-9dbb-9b2b20218538