- 29 Jul, 2016 40 commits
-
-
mmenke authored
In particular, the code was being run on non-data URLs, which caused it to do weird and exciting things, and it had an incorrect DCHECK. BUG=632605 Review-Url: https://codereview.chromium.org/2191323005 Cr-Commit-Position: refs/heads/master@{#408737}
-
tommycli authored
This mostly cleans up some routing code in Quick Unlock. It also has a few small fixes in People. BUG=608115 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2154213008 Cr-Commit-Position: refs/heads/master@{#408736}
-
kolos authored
The similar CL for IPC https://codereview.chromium.org/2148303005/ BUG=582434 Review-Url: https://codereview.chromium.org/2189543004 Cr-Commit-Position: refs/heads/master@{#408735}
-
sammiequon authored
BUG=616536 Review-Url: https://codereview.chromium.org/2129253002 Cr-Commit-Position: refs/heads/master@{#408734}
-
pavely authored
Revert of Linux: Support the --class argument (patchset #4 id:60001 of https://codereview.chromium.org/2186813002/ ) Reason for revert: Change breaks compile on Linux x64: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/12770 Original issue's description: > Linux: Support the --class argument > > It appears we lost support for --class when we stopped using gtk for our > windowing. This CL adds that feature back. > > BUG=118613 > > Committed: https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520 > Cr-Commit-Position: refs/heads/master@{#408709} TBR=thestig@chromium.org,benwells@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=118613 Review-Url: https://codereview.chromium.org/2193393002 Cr-Commit-Position: refs/heads/master@{#408733}
-
dglazkov authored
The existing doc (https://sites.google.com/a/chromium.org/dev/developers/design-documents/idl-compiler) looks old, but it's probably better to keep it next to the code. R=haraken,yukishiino BUG= Review-Url: https://codereview.chromium.org/2195743003 Cr-Commit-Position: refs/heads/master@{#408732}
-
simonhatch authored
TBR=sullivan@chromium.org BUG=630854 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq; Review-Url: https://codereview.chromium.org/2189383002 Cr-Commit-Position: refs/heads/master@{#408731}
-
romax authored
Add expired as a logged event in offline-internal page. BUG=NONE Review-Url: https://codereview.chromium.org/2191183002 Cr-Commit-Position: refs/heads/master@{#408730}
-
ortuno authored
First of three patches to reject promises if the frame is not connected or the frame disconnected while the promise was not fulfilled. Implements: 1. The ActiveAlgorithm set[1] as m_activeAlgorithms in BluetoothRemoteGATTServer 2. gattServer-connection-checking wrapper[2] as GetPrimaryServicesCallback in BluetoothRemoteGattServer.cpp 3. Connection check of query bluetooth cache[3] in getPrimaryServicesImpl. [1] https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver-activealgorithms-slot [2] https://webbluetoothcg.github.io/web-bluetooth/#connection-checking-wrapper [3] https://webbluetoothcg.github.io/web-bluetooth/#query-the-bluetooth-cache BUG=608538 Review-Url: https://codereview.chromium.org/2183903002 Cr-Commit-Position: refs/heads/master@{#408729}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=mattm@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2194613002 Cr-Commit-Position: refs/heads/master@{#408728}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=avi@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2195483004 Cr-Commit-Position: refs/heads/master@{#408727}
-
skvlad authored
A helper function that determines whether an IP address is loopback was checking for a "::1" substring in the IP address. Non-loopback IPv6 addresses can have that substring - e.g. "1234::1234:1234". If the test runs on a machine with one of these addresses, it would fail erroneously. The fix simply adds spaces on both sides of the pattern, so that it only matches complete IP addresses (always surrounded by spaces in an ICE candidate line). BUG=629705 Review-Url: https://codereview.chromium.org/2185533007 Cr-Commit-Position: refs/heads/master@{#408726}
-
chrishtr authored
BUG=628831 Review-Url: https://codereview.chromium.org/2186643002 Cr-Commit-Position: refs/heads/master@{#408725}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=creis@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2188393002 Cr-Commit-Position: refs/heads/master@{#408724}
-
jaydasika authored
In ComputeTransformToTarget and ComputeTransformFromTarget. This is turned on only when verify_transform_tree_calculations is true (only cc_unittests as of now) and when target is an ancestor (as that's the only case dynamically calculated target space transforms support right now) This CL also sets verify_transform_tree_calculations and verify_clip_tree_calculations in some tests. BUG=622372 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2191983002 Cr-Commit-Position: refs/heads/master@{#408723}
-
rouslan authored
BUG=632468 Review-Url: https://codereview.chromium.org/2193293003 Cr-Commit-Position: refs/heads/master@{#408722}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=anthonyvd@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2192033002 Cr-Commit-Position: refs/heads/master@{#408721}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=mattm@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2194653002 Cr-Commit-Position: refs/heads/master@{#408720}
-
halcanary authored
shows up in chrome://gpu makes use of build/util/lastchange.py BUG=235455 Review-Url: https://codereview.chromium.org/2187533002 Cr-Commit-Position: refs/heads/master@{#408719}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=dsinclair, jochen BUG=554600 Review-Url: https://codereview.chromium.org/2184913006 Cr-Commit-Position: refs/heads/master@{#408718}
-
kylechar authored
When running "./chrome --mash" most child processes no longer have the mojo application name as part of the command string. This makes it difficult to figure out what part of mus+ash LOG statements or CHECK failures come from. Add a DVLOG(0) that prints out the name and pid when a child process is successfully launched. Using verbosity level 0 since it is important information for debugging and should occur rarely. BUG=none Review-Url: https://codereview.chromium.org/2194943002 Cr-Commit-Position: refs/heads/master@{#408717}
-
dbeam authored
R=tommycli@chromium.org BUG=629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2178303003 Cr-Commit-Position: refs/heads/master@{#408716}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=sergeyu@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2194673002 Cr-Commit-Position: refs/heads/master@{#408715}
-
nzolghadr authored
This reverts commit 7d314cf3 as a follow up to the decision about delayed capturing https://github.com/w3c/pointerevents/issues/32 This also gets rid of the need to make PointerEventManager a GC object. BUG=627192, 629935 Review-Url: https://codereview.chromium.org/2193473002 Cr-Commit-Position: refs/heads/master@{#408714}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=dewittj@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2193653002 Cr-Commit-Position: refs/heads/master@{#408713}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=alekseys@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2194643003 Cr-Commit-Position: refs/heads/master@{#408712}
-
mgersh authored
RequestFinishedListener originally depended on NetworkQualityEstimator's executor. These are separate features which should not depend on each other, and as of recently the NQE listeners also provide their own executors. Also move RequestFinishedListener out of CronetEngine into its own file, and move its tests into their own file. BUG=618034 Review-Url: https://codereview.chromium.org/2178053002 Cr-Commit-Position: refs/heads/master@{#408711}
-
sadrul authored
Revert of services/ui: Revert CLs that broke Windows. (patchset #2 id:20001 of https://codereview.chromium.org/2194893002/ ) Reason for revert: crrev.com/408695 fixes the issue. So we can reland these CLs. Original issue's description: > services/ui: Revert CLs that broke Windows. > > The new GPU code path does not seem to work correctly on Windows yet > (everything is black). So restore the deprecated path. > > Revert "services/ui: Remove deprecated gpu code" crrev.com/408207 > Revert "services/ui: Remove unused connector argument" crrev.com/408230 > > BUG=623157, 630893 > TBR=ben@, piman@, penghuang@ > > Committed: https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d > Cr-Commit-Position: refs/heads/master@{#408648} TBR=ben@chromium.org,piman@chromium.org,penghuang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623157, 630893 Review-Url: https://codereview.chromium.org/2196503003 Cr-Commit-Position: refs/heads/master@{#408710}
-
thomasanderson authored
It appears we lost support for --class when we stopped using gtk for our windowing. This CL adds that feature back. BUG=118613 Review-Url: https://codereview.chromium.org/2186813002 Cr-Commit-Position: refs/heads/master@{#408709}
-
baxley authored
They inherit from XCTestCase, so TestCase suffix makes it a bit more clear. BUG= Review-Url: https://codereview.chromium.org/2195773002 Cr-Commit-Position: refs/heads/master@{#408708}
-
ben authored
This has been done in the C++ layer already, and I'd like to do this on the Java side as well since a single object doesn't always want to hold both the registry and the provider objects. R=sievers@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2191033002 Cr-Commit-Position: refs/heads/master@{#408707}
-
dgozman authored
BUG=631162 Review-Url: https://codereview.chromium.org/2197723002 Cr-Commit-Position: refs/heads/master@{#408706}
-
estade authored
Testable with: chrome --ash-md=experimental --shill-stub=ethernet=off BUG=617304 Review-Url: https://codereview.chromium.org/2186353002 Cr-Commit-Position: refs/heads/master@{#408705}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/381147c5..8d5d2145 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2198443002 Cr-Commit-Position: refs/heads/master@{#408704}
-
davidben authored
This was left in here while debugging. I forgot to remove it. BUG=none Review-Url: https://codereview.chromium.org/2189373002 Cr-Commit-Position: refs/heads/master@{#408703}
-
sebastienlc authored
BUG=606687, 606686, 606685 TBR=grt@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2194963002 Cr-Commit-Position: refs/heads/master@{#408702}
-
aelias authored
This early return is meant to avoid storing the last ID for a tab which is about to be destroyed. The behavior should logically apply equally to FROM_CLOSE and FROM_EXIT, but by an oversight, only FROM_CLOSE was checked. BUG=629080 Review-Url: https://codereview.chromium.org/2195543002 Cr-Commit-Position: refs/heads/master@{#408701}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/1e8761809d76..5db44aa2aa4a $ git log 1e8761809..5db44aa2a --date=short --no-merges --format='%ad %ae %s' 2016-07-29 mtklein GN: components as static library instead of source set 2016-07-29 msarett Fix various SkColorSpace bugs 2016-07-29 egdaniel Use HashSet instead of Dynamic hash for tracking vulkan resources 2016-07-29 fmalita [SVGDom] Parse style attributes 2016-07-29 halcanary SkPDF: flip saveLayer rightside up 2016-07-29 mtklein GN: quick doc BUG=632574 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=tomhudson@google.com Review-Url: https://codereview.chromium.org/2193593004 Cr-Commit-Position: refs/heads/master@{#408700}
-
sunxd authored
When we scroll on impl thread, we do scroll snapping in transform trees if the transform node has a non-integer screen space transform. However, the main thread logic also do snapping. When updating source to parent transforms on main thread, it is possible that the scroll snaps are used to compute the to_parent transform. It becomes a problem if the node is created due to a fixed pos layer, the snapping will add a small translation to the to_parent transform and result in the unstable position. This CL undoes the snapping in this case. It is notable that scroll_parent might also be influenced by this change. BUG=584598 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2183923002 Cr-Commit-Position: refs/heads/master@{#408699}
-
nasko authored
When a PageState update is received from the renderer process, it must be for the current session history entry. This means that the sequence numbers associated with the FrameNavigationEntry should match the ones coming from the renderer process. This CL adds a check for this case and drops the update if mismatch is found. BUG=628677 Review-Url: https://codereview.chromium.org/2196623003 Cr-Commit-Position: refs/heads/master@{#408698}
-