- 30 Jul, 2019 40 commits
-
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //ui/gfx/range. *_struct_traits.* => *_mojom_traits.* ui/gfx/range/mojo => ui/gfx/range/mojom Bug: 806965 Change-Id: Iba3f3c48cd5bfe48fa2064f29db3c4f4837321a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722364 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#682150}
-
Maksim Sisov authored
PlatformWindow has already had SetTitle API. Thus, just plumb it and make setting a title of platform windows work in ozone builds. Bug: 988397, 988396 Change-Id: I225ff1d3def90bb0eb37b63af4d37353f344906d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722936Reviewed-by:
-
huangs authored
The chrome://usb-internals page in //chrome/browser/resources/usb_internals suffered from the following: 1. BUILD.gn is unused by build due to lack of linkage, thereby causing the subsequent problems to be hidden. 2. BUILD.gn has target name inconsistencies (re. "device_pages"), and missing dependencies. 3. The JS files missed Closure compilation, and accumulated many errors (~130, half of which are from missing dependencies). This CL fixes the above problems, thereby unblocking resource refactoring to enable chrome://usb-internals page's inclusion into the DevUI DFM for Chrome on Android. Bug: 987642, 927131 Change-Id: I4f352445d20598052f7eae5401f1e8ec10faf9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719649 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#682148}
-
Anders Hartvoll Ruud authored
This CL refactors CSSBorderImageLengthBoxInterpolationType such that the non-interpolable part is a NonInterpolableList. This allows us to re-use the code for list creation and composition in ListInterpolationFunctions. Bug: 981024 Change-Id: I70b5e440778cdfd0e64d2bfe3a2993e281f60ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722546 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#682147}
-
Kenichi Ishibashi authored
IndexedDBClient was a WorkerClient and it provided AllowIndexedDB(). IDBFactory extracted an IndexedDBClient from execution context to call AllowIndexedDB(). However this was an unnecessary abstraction and we can directly implement AllowIndexedDB() in IDBFactory. This CL removes IndexedDBClient to remove the abstraction. This eliminates creating a GarbageCollection object. This CL doesn't have behavioral changes. Bug: 988335 Change-Id: Ia6948cf195abf53335609d2ddb2a02bd7c7faa84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722276Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682146}
-
Khushal authored
When using the SurfaceControl API, the damage rect specified for doing partial invalidations of a Surface should be in the content space (including pre-transform for rotations). Since we were currently setting it in screen space, this caused a rendering bug on devices using the damage rect. For now, avoid setting any damage rect on the Surface. This will result in full invalidation of the Surface for each draw. While its not ideal, its consistent with SurfaceView based rendering path. We can attempt to use partial damage going forward, with some benchmarking, once SurfaceControl is launched/stable. Note that we still take advantage of only compositing the damaged region in chrome's display compositor. This change only makes it so this region is not forwarded to the system compositor. R=zmo@chromium.org Bug: 988857 Change-Id: I625dcda578e90aa81324c4e35f739bd44b83c3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725416 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682145}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: I35e6ef2d8cbf7e3c7ace06d7d80bf382605405fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725269 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682144}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd0b0262..bfd47a6a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2348706e083bd9cbf7fc4fe349fa2d37c6489809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724560Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682143}
-
Istiaque Ahmed authored
It is unsafe to deal with an Extension* after the underlying extension is uninstalled or unloaded. So make TestExtensionRegistryObserver::WaitForExtensionUninstalled return scoped_refptr<const Extension> to avoid UaF possibilities. Bug: 987775 Change-Id: Iccb9929b004d9aa4988f7ea32aae48f775e8d651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721019 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682142}
-
Christopher Lam authored
Bug: 980846 Change-Id: I143a064686771bc1fe8a14ed5258208ba77ece13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720429Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#682141}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84cf6f97b5e9..a0fe3506d1a8 Created with: gclient setdep -r src-internal@a0fe3506d1a8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I0828ef30583eb83c3c89d2cba1693a7664cd0751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725274Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682140}
-
Sadrul Habib Chowdhury authored
Merge some of the impelmentations between rendering.desktop and rendering.mobile benchmarks, to avoid duplicating code and the list of UMA metrics to monitor. BUG=790761 Change-Id: I2f93a96beb70a1c33ba1543430be5727c32f9ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724813 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#682139}
-
Yuki Shiino authored
- rename common.py to composition_parts.py - make Identifier and Component own classes - remove non-informative comments Bug: 839389 Change-Id: Ia7b5d17810bb6ad39873effa3a7e2fc8ffeda348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724270Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#682138}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7448af3ab35ae8169b86defbb6f4fa56eae1ce15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719025 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682137}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0395e7c66a5f..2f01e42cf4f3 git log 0395e7c66a5f..2f01e42cf4f3 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 eashanbhatt@google.com cros_build_lib: Add strict to GetBoard() 2019-07-30 eashanbhatt@google.com cros_chrome_sdk: Sets fallback-versions parser type to int. Created with: gclient setdep -r src/third_party/chromite@2f01e42cf4f3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7c0e7e888aa69f0ceb3291f69b35f1ba6fc627d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725239Reviewed-by:
-
Peter Boström authored
Bug: None Change-Id: Ic53917460d7cc0e68868e5c37a94df42ee930a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725007Reviewed-by:
-
Aaron Leventhal authored
Bug: none Change-Id: Idb194b7aa4735b1fcfaf43906037d058a8cdd3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695969 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682134}
-
Clark DuVall authored
We will now get the frame data from the RenderFrameHost when needed. We still need the map singleton to store the deleted frame info for beacon requests. Bug: 980774 Change-Id: I3bee8834b00897119f7493981a5080df26794bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721933Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682133}
-
Wez authored
Since we currently run all test suites in a "headless" environment, and use the Ozone "headless" platform for tests which need Ozone, we don't (and can't) have tests make use of Scenic nor Vulkan services. Removing these services from the sandbox ensures that no dependencies on them creep in to our test suites, which is important since requesting a service provided by Scenic may actually cause Scenic to be (re)launched, potentially leading to hard to diagnose flakiness. Bug: DX-1801 Change-Id: Id26fa23664d4b693dab8514ae8957229432c6034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716339 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682132}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It removes ClearCache from PO2TS since it's only used by PO2TS and it could call ClearCache through |token_manager_| instead of having a helper method and it moves UpdateClearsCache from ProfileOAuth2TokenServiceTest to OAuth2AccessTokenManagerTest. It removes GetTokenCacheCountForTesting from PO2TS because UpdateClearsCache which needs a cache size is moved to OAuth2AccessTokenManagerTest and it gets the size from |token_manager_| directly. The test name, 'UpdateClearsCache', is also renamed to 'ClearCache' in OAuth2AccessTokenManagerTest. Bug: 967598 Change-Id: Icf700cd3709a3749df13e556bd6ca9107d615900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719112 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682131}
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //ui/gfx. *_struct_traits.* => *_mojom_traits.* ui/gfx/mojo => ui/gfx/mojom Bug: 806965 Change-Id: I26ddff47ccb37edafde1fe15d66214afb84b3537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722465 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ff7e2ebc5e4d..7c54fa2d4559 git log ff7e2ebc5e4d..7c54fa2d4559 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 crouleau@chromium.org [Telemetry] CreateResults in only one place. Created with: gclient setdep -r src/third_party/catapult@7c54fa2d4559 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:985103 Change-Id: I6141bc29472de7ae7620928498110f3a6e96d9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725238Reviewed-by:
-
Rakina Zata Amni authored
TBR=achuith@chromium.org No-try: true No-presubmit: true No-Tree-Checks: true Bug: 988918 Change-Id: I1a0bf6d7f99cc3ccc97d5111fa10bdacd8a105e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724561Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#682128}
-
Koji Ishii authored
This patch changes ResourceResponse::HttpContentType() to use LowerASCII instead of DeprecatedLower. DeprecatedLower has partial Unicode conversions, such as converting U+212A to 'k', but lowering only ASCII should be sufficient for most web platform usages. For MIME type, [parse a MIME type] uses [ASCII lowercase]. Currently, there are 6 usages of AtomicString::DeprecatedLower and 37 usages of String::DeprecatedLower. This patch reduces one of the 6 usages. [ASCII lowercase]: https://infra.spec.whatwg.org/#ascii-lowercase [parse a MIME type]: https://mimesniff.spec.whatwg.org/#parse-a-mime-type Bug: 627682 Change-Id: I9f44fbe1583618c3f1250af8e417dedf6cd41563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720994 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#682127}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Ia613dc3366287bce6313ec8405a0c459adeb0fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725255 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia504baed1d1a613fb58b06c2655093beb3115c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724836Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#682125}
-
Noel Gordon authored
This test is a consistent [ Pass Timeout ] flake on the MSAN bots. Tbr: rakina@ No-try: true No-presubmit: true Bug: 856601 Change-Id: If4d75e81bb8075e3a314e429f24a84dfc7157cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725242 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#682124}
-
rajendrant authored
This CL adds tests for base URL, referrer-policy and crossorigin state at parse time are retained when the deferred frame is loaded-in. Bug: 984983 Change-Id: Ifab76a15a4addf750251cbfd0e6849c535b95531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719445 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#682123}
-
liberato@chromium.org authored
This CL introduces the feature flag kUseOutputLatencyFromHAL, which causes OpenSLES audio output to query the Android AudioManager for its output latency, and include that in the computed latency. Note that AudioManager.getOutputLatency is hidden in the SDK; it should not be used normally. It's only used here as a hack to fix some AndroidTV audio synchronization issues on some devices. In the future, OBOE support will switch us to AAudio, which uses the correct latency from HAL automatically. Change-Id: If6a1d46ef2f4eab98a99e53080a6b96a70d749ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722971Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#682122}
-
Mei Liang authored
Change-Id: I20e36b47a4e4111269e660142819a9e22bc2f544 Bug: 987206, 970266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719614 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682121}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/385f490b054e..84cf6f97b5e9 Created with: gclient setdep -r src-internal@84cf6f97b5e9 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I27eb0f753cc0fb06cf7edb49a9e96c2cee95d666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725569Reviewed-by:
-
Jinsuk Kim authored
The reverted CL had a regression caught by assertion in BottomSheet.getSheetState. This CL attempts to address the issue while still ensuring the animation from hidden to peek state works as expected. This reverts commit 9ae8477c. Bug: 937946 Change-Id: Iecec38cceafd2228ac7e6bebc51b3d12c5cedf1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715168 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#682119}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d31c667503bc..e858d1fb244d git log d31c667503bc..e858d1fb244d --date=short --no-merges --format='%ad %ae %s' 2019-07-29 thestig@chromium.org Rename XFA version of CPDFSDK_Widget::ResetAppearance(). 2019-07-29 thestig@chromium.org Remove a parameter to CPDFSDK_InteractiveForm::ResetFieldAppearance(). 2019-07-29 thestig@chromium.org Remove parameter to CPDFSDK_Widget::ResetFieldAppearance(). Created with: gclient setdep -r src/third_party/pdfium@e858d1fb244d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I59d9f758c508a47379d7089edade9faaa93e1e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725237Reviewed-by:
-
Ahmed Mehfooz authored
We do not currently flip the canvas for focus rings when RTL is enabled. This can cause certain focus rings to be drawn incorrectly for their corresponding buttons. Some views change their canvas flipping on RTL behavior after installing focus rings. This can cause a recently added DCHECK to fail. Bug: 986571, 960284 Change-Id: Ic24db27c1faee1c62bafbb0de1db3426bf5c23e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719673 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#682117}
-
Gayane Petrosyan authored
Bug: 988880 Change-Id: I7107fb8c3399ae1ce561d8971e40e42e112371e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725006 Auto-Submit: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682116}
-
Akihiro Ota authored
Implement AutofillPopupViewNativeViews::GetAccessibleNodeData to set the role of the autofill suggestions container to kMenu. This method was previously unimplemented, which was causing issues with PosInSet and SetSize calculations of the enclosed AutofillPopupItemViews. This change also adds robustness to the accessibility posinset and setsize calculation code by continuing over nodes with role of kUnknown. This way, containers do not have to be immediate parents of their items, which is common on the web. Lastly, this change adds a test in accessibility code to verify the new behavior. Bug: 985987 Change-Id: I3078ff4ddfcb31224af07523da8b385267644bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709660 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
* Add the host chromedriver binary as part of the Fuchsia build. * Add a CIPD package to upload a stripped chromedriver binary. Bug: IN-1321 (Fuchsia internal) Change-Id: Ia414914304ede7a54ff097365bb72cba6674e5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719377 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#682114}
-
Cliff Smolinsky authored
Add wtsapi32 to delayloads list and remove it from the allowed list for chrome_child.dll. This dll is used in the browser process and with the remoting feature, neither of which requires immediate loading in chrome_child.dll. Bug: 987672 Change-Id: Ib3ddbb27578f76d854e1966a12eb1fc6cd30e9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719304Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff3f2082..bd0b0262 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d219f23380b788615a877510beb8a61f80280cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725130Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6c73c7e11dbb..0395e7c66a5f git log 6c73c7e11dbb..0395e7c66a5f --date=short --no-merges --format='%ad %ae %s' 2019-07-29 moragues@google.com Atlas: Remove deprecated firmware-atlas-11827.12.B from build config Created with: gclient setdep -r src/third_party/chromite@0395e7c66a5f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1c8eaefc22db8e05f207e2e64944a736ae91a2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725293Reviewed-by:
-
