- 13 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7faa362ea9c2..111ba65a5e3d 2021-01-13 cwallez@chromium.org D3D12: Use Texture::Create pattern for swapchain textures 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 987376cd21a8 to 1c200cffd051 (13 revisions) 2021-01-13 marksibly@gmail.com Reset scissor reset before presenting in opengl 2021-01-13 enga@chromium.org Update DepthStencilStateTests to use WGSL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ibb045064f561ef91f34164911d6f000f1d341650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842966}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610495996-5598384ad8a00037e18a56fd00981ea765e31cd1.profdata to chrome-win32-master-1610517435-6cb290631927ae5ce3c51d7b67446e43eb76cc98.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3d2c5a161f10c5c42e5b05e6c54a634d712b1adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627016Reviewed-by:
-
Yutaka Hirano authored
network.mojom.DataElement represents part of a request body. It is a union of several types, and that applies to its typemapped class, network::DataElement. Up until now we had flat members (e.g., offset(), length(), bytes()) with various DCHECKs on network::DataElement. This led to several issues: 1) The code author can be confused. Some members (e.g., length(), bytes()) seems to have a meaning in a wrong context, and that can lead to security issues. See https://crbug.com/1151865 for example. 2) It is hard to maintain the DCHECKs in a consistent way. For example, at this moment we have a DCHECK at chunked_data_pipe_getter(), but we don't have a DCHECK at length(). We have a similar difficulty on mojo deserialization. This CL makes network::DataElement a simple wrapper of absl::variant. network::DataElement has only one member: absl::variant<absl::monostate, DataElementBytes, DataElementDataPipe, DataElementChunkedDataPipe, DataElementFile> variant_; A user needs to check the type and explicitly cast the element to the correct class, to access any information (other than `type`). We rely on checks implemented in absl::variant, so we don't need to have many DCHECKs. This CL also contains the following changes: A) DataElementType.kReadOnceStream is gone, as having two members sharing the same type makes the use of absl::variant difficult. This merges the type to DataElementType.kChunkedDataPipe, and introduced a boolean `read_only_once` in DataElement to distinguish them. B) Removed FetchAPIDataElement, as it seems identical to network.mojom.DataElement. C) Deserialization logic gets more strict. Invalid mojo::pending_remote for kDataPipe and kChunkedDataPipe are now treated as errors. D) Made network.mojom.DataElement a union. E) Added some deserialization tests for network::DataElement. Change-Id: I2c646ead57bc19bee661b711c9c863ce1a5e9c94 Bug: 1156550, 1151865, 1152664 Tbr: koerber@google.com, alexchau@chromium.org, yfriedman@chromium.org, evliu@google.com, ianli@chromium.org, tbansal@chromium.org, karandeepb@chromium.org, alexilin@chromium.org, garykac@chromium.org, charleszhao@chromium.org, inferno@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599731Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#842964}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I467dbaf29f7474550e2fc17b82c6fc7195c4f84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627149 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842963}
-
Tanmoy Mollik authored
Method OnPrimaryAccountCleared is deprecated. So this cl changes these calls to OnPrimaryAccountChanged() Bug: 1158855 Change-Id: I56ea44e66fdd91f9cf81eae822233d792e6927c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622532Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ecb2f5fc58f..0ebc1e8f4c65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Ie0d5c7ad00b0b08cbb6740ee2649a925c5d023db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842961}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610505994-ce0c95957b1d27284e834682f26210d976ec22d1.profdata to chrome-win64-master-1610517435-1554e99a291ef2bcb6f5a0139dcc2bec362b747b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7e851c6840f380e74bb2218345f4de1bcc922afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627069Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 61d100cd. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, smcgruer@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I7aa1a2c05dd2597f4ea0bb3b698349eb0bd1d7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626733Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842959}
-
Hidehiko Abe authored
crrev.com/c/2616981 started to exclude system page from Lacros, but there seems a missing check in the CL. This CL is its follow up. Bug: 1166000 Test: Built locally. Change-Id: Ic3d6b4b49f2a3673abf6efe6202716e7c8592631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626850 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#842958}
-
Jack Franklin authored
It's being removed in https://crrev.com/c/2627267. Bug: chromium:1050549 Change-Id: I686d66c0fdbc00b742f6a05b6d839138954a82d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627407 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#842957}
-
Jérôme Lebel authored
The goal of this series of patches is to propagate the keychain reload flag that comes with the identity list update notification from GCRSSOService. This flag will be used by AuthenticationService to have a better signal when the identity list is updated by another Google app (when the flag is YES), or if the update comes from Chrome user actions. * crrev.com/i/3513584: Receive the flag from GCRSSOService notification * crrev.com/c/2615421: Add support for the keychain reload flag * crrev.com/i/3470951: Switching FireIdentityListChanged(bool) method =>crrev.com/c/2615538: FireIdentityListChanged() cleanup Bug: 1097080 Change-Id: I7e18bf7747899acde98176ca2ec8e2db347cac67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615538 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#842956}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d98dd8de..03dbe217 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If355faa78be1835cdb9158dbe6563c04e47a0575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626462Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842955}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/09efc26aff79..518d81558c79 $ git log 09efc26af..518d81558 --date=short --no-merges --format='%ad %ae %s' 2021-01-12 jonathan.wright Cherry-pick Arm CLZ fixes from upstream Created with: roll-dep src/third_party/libjpeg_turbo Bug: 1160249 Change-Id: Ifb5e6dfbd164098cc8853a4c1b56d25ea506d786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624669Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#842954}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/26ac0bee0167..cc988a955f26 2021-01-13 jacktfranklin@chromium.org Move binaryIndexOf into ArrayUtilities If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I877bad815ab6df1d9fcf6cea746e9cc3a6efe787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627036Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 9ca977e3. Reason for revert: I suspect this CL caused a failure https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome Two builds: https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/11124/overview Test 'arc.DragDrop' completed with the following status(es): 'FAILURE' Test 'arc.DragDrop' had the following logs when run: ================================================================================ Failed initializing UI Automator at chromiumos/tast/local/bundles/cros/arc.DragDrop (drag_drop.go:93) at chromiumos/tast/internal/planner.runTestWithRoot.func3 (run.go:755) at chromiumos/tast/internal/planner.safeCall.func2 (safe.go:92) at runtime.goexit (asm_amd64.s:1357) failed installing /usr/local/share/android-uiautomator-server/app-uiautomator.apk at chromiumos/tast/local/android/ui.installServer (device.go:119) at chromiumos/tast/local/android/ui.NewDevice (device.go:91) at chromiumos/tast/local/arc.(*ARC).NewUIDevice (ui.go:16) at chromiumos/tast/local/bundles/cros/arc.DragDrop (drag_drop.go:91) at chromiumos/tast/internal/planner.runTestWithRoot.func3 (run.go:755) at chromiumos/tast/internal/planner.safeCall.func2 (safe.go:92) at runtime.goexit (asm_amd64.s:1357) context deadline exceeded at ??? https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/11125/overview Test 'chrome_all_tast_tests' completed with the following status(es): 'FAILURE' Test 'chrome_all_tast_tests' had the following logs when run: Original change's description: > [CrOS cellular] Respond to cellular route params in internet page > > Bug: 1163556 > Change-Id: I196b9c9f73fecb169b53ac3d3ed5635a799b7138 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625275 > Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> > Reviewed-by: Azeem Arshad <azeemarshad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842903} TBR=azeemarshad@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,tjohnsonkanu@google.com Change-Id: Icd511320cc5b1df0ad54057e372b4d353fc90778 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626432Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842952}
-
Takashi Sakamoto authored
Inside RmoveEntryByURLImpl, ReadingListWillRemoveEntry invokes ReadingListManagerImpl::RemoveBookmark. The method removes the node which own the URL. So when invoking entries_-erase(url), url is not available. BookmarkBridge: :DeleteBookmark deletes a reading list item b using url when the bookmark type is BOOKMARK_TYPE_READING_LIST (i.e. node->url()). The deletion invokes ReadingListModelImpl::RemoveEntryByURLImpl with the URL (as const GURL&). Change-Id: I69d6afba8ca8ea72985dd2317db9f6a3a92fefc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616641 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842951}
-
Michael Martis authored
Format is based on services/device/generic_sensor and services/device/usb. Change-Id: Ib21174e9b30ca9f53da90752ff3c423b31d9b57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620739 Auto-Submit: Michael Martis <martis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#842950}
-
Jason Lin authored
... according to the comment from the UX deck: https://docs.google.com/presentation/d/1MWWejK-y2vnBN3Wg__Kd_LIiAcIF3VctzMowMI3wM4w/edit?disco=AAAAKz06f_U For each VM, there are actually 3 types of notifications: "camera (only)", "mic (only)", and "camera and mic". We have two types of tray items: "camera", and "mic". The "camera" tray item is displayed when there is a "camera" and/or "camera and mic" notifications. The non-trivial part of this cl is that the "camera" tray item now used a different message depending on whether there is a "camera and mic" notification or not. To do this, VmCameraMicManager now exposes the exact type of the notification, and ash will pass this information down to CameraMicTrayItemView. Bug: b/167491603 Change-Id: I7acd1aa87d463930406b917da7dfd0ddbacf799b Fixed: b/177270109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622361 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842949}
-
Finnur Thorarinsson authored
Video support for the photo picker is currently behind an (off by default) feature flag. We'd like to run an experiment in 89 to see how well it works, but what has been blocking us is that we still have some work to do to find the best way of producing animated tiles for video clips. Video support is going to be a big improvement in the user experience for uploading media to the web and we shouldn't hold off on experimenting with it just because we haven't finalised if/how to produce animated thumbnails for the video tiles. Furthermore, it is increasingly likely that animated tiles will only be available using APIs that were added to later versions of Android, so users on older versions would never enjoy the benefits of animated tiles anyway (hence don't need to wait for them). The purpose of this change is therefore to make sure that when we turn on video support (as an experiment), we don't have to turn on animated tiles as well (it is off-by-default). Bug: 895776, 656015 Change-Id: Id5b4d422136ea1945d47bbd7fb672a56706d3b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616225 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#842948}
-
Yuki Shiino authored
This reverts commit 201f15f1. Reason for revert: Suspicious about causing a test breakage of WindowOpenApiTest.PopupBlockingExtension. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview Original change's description: > Create standard icons on shelf for non-app icons. > > AppService creates standard circle icons for all apps. However, there > are a few cases that icons on shelf are not app icons, e.g.: > 1. Task manager > 2. A few extensions show icons when open a new window, e.g. google > hangouts. > > This CL create standard circle icons for them when they are shown on > shelf. > > Modify TaskManagerView to create standard icon when running in Chrome > OS. > > Modify ChromeLauncherController::OnAppImageUpdated. If the icon is not > loaded by AppServiceAppIconLoader (which loads the standard circle > icons), create standard icons. > > BUG=1162514 > BUG=1142373 > > Change-Id: Ibfe40c33944a1120ca9c991c4953d0da906ee2e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624273 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842874} TBR=xiyuan@chromium.org,sky@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,nancylingwang@chromium.org Change-Id: I6e0dbef6a173a179d79e39cebbd4a4f78f15bcfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1162514 Bug: 1142373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626821Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#842947}
-
Sigurd Schneider authored
DevTools front-end CL: https://crrev.com/c/2622195 Bug: chromium:1069378 Change-Id: I51a66ebe85e2036a0939364e0c1e4cb9d525429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622114 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842946}
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2584978 Disable tests CLs: https://crrev.com/c/2584848 https://crrev.com/c/2592797 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k Change-Id: I200074600b3e82404bc42694defa6a407ded6e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587035 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#842945}
-
Richard Knoll authored
These metrics are no longer useful for us and have expired in M87: - Sharing.DeviceInfoAvailable - Sharing.DeviceLastUpdatedAge.* - Sharing.DeviceLastUpdatedAgeWithResult.* - Sharing.MajorVersionComparison.* - Sharing.SharedClipboardRetries.* Bug: 1125773, 1125771, 1125770 Change-Id: I34261e33f5789b1d3b864bf8a960ce3b1f7bd346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621815Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842944}
-
Maxim Kolosovskiy authored
This reverts commit 8aca3b4d. Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview [ RUN ] WindowOpenApiTest.PopupBlockingExtension 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure Expected equality of these values: num_browsers Which is: 4 chrome::GetBrowserCount(browser->profile()) Which is: 2 Google Test trace: ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 Stack trace: #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #6 0x563646f2068c base::internal::Invoker<>::RunOnce() #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() #20 0x7fb5dc82a804 content::BrowserMain() #21 0x7fb5de9aae56 content::RunBrowserProcessMain() #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() #24 0x7fb5de9a9106 content::RunContentProcess() #25 0x7fb5de9a9a3d content::ContentMain() #26 0x563646f1cb13 content::BrowserTestBase::SetUp() #27 0x563645acb283 InProcessBrowserTest::SetUp() #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() Original change's description: > Support multiple receivers for Cros APIs. > > With this CL, most of Cros API starts to support multiple receivers. > AshChromeService and LacrosChromeService are exceptions. > > Bug: 1148448 > Test: Build and run Lacros on a DUT. > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842869} TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229Reviewed-by:
-
Colin Blundell authored
This CL continues with the abstraction of dependencies on signin and sync from //components/safe_browsing's access token fetching flow in order to enable reuse by WebLayer. The concrete step taken here is to abstract the dependencies on //components/safe_browsing/core/browser/sync from RealTimeUrlLookupService, passing these dependencies in via the constructor. There are no behavioral changes in this CL: - //chrome and //ios/chrome's factories glue the relevant parameters from //components/safe_browsing/core/browser/sync - //weblayer's factory passes in values for the parameters such that access token fetching for URL lookups continues to be disabled in WebLayer Followup work will bring up support for access token fetching in WebLayer. Bug: 1080748 Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#842942}
-
Gauthier Ambard authored
This CL makes sure that the constraints of the fakebox are correctly updated when there is only one toolbar. In particular, those constraints were broken when rotating from portrait to landscape. Fixed: 1161448 Change-Id: I80dbfc524010915e381a4129208471b9e142b351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623013 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
arthursonzogni authored
Instead of trying to forward fix, dumbly revert the cause of crashes. Hopefully, just in time before M89 branch cut. This revert will fix: - https://crbug.com/1153966 - https://crbug.com/1153961 This revert part of: https://chromium-review.googlesource.com/c/chromium/src/+/2548022 ``` Retire ScopedObserver in /chrome/browser/ui/views. ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bsep@chromium.org Bug: 1145565 ``` There was an existing bug. Unexpectedly, HungPagesTableModel:: InitForWebContents() can be called twice. See https://crbug.com/1165917. For some reasons, this didn't resulted in any crashes... ...until the reverted patch cames in. The old base::ScopedObserver was supporting multiple observations. The new one: base::ScopedObservation doesn't. As a result, if base::ScopedObservation::Observe is called twice, then RemoveObserver will be called only once instead of two, causing the issue. Bug: 1153966,1153961 Change-Id: Iecc8e8e0e9fa387795ce55b4414d1d871cc4c9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625867Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842940}
-
Aya ElAttar authored
Changed DragDropController to: - Cancel drop if not allowed by policy rules. - Show CursorType::NoDrop while dragging if the policy rules disallow the data from being dropped. Bug: 1139886 Change-Id: I8a12f1f4af2fa0f21d4d562d393d9f64cec39f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595382Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842939}
-
Reid Kleckner authored
Disable TwoClientSendTabToSelfSyncTestWithSendTabToSelfWhenSignedIn.SignedInClientCanReceive in component builds This test times out in optimized (is_debug=false) component builds. It passes in is_debug=true component builds. I can't explain that behavior, but disable it in all component configs to be on the safe side. R=victorvianna@google.com Bug: 1166032 Change-Id: Ie39ffcfe06531c5a2039b22c8c3fbcd306fbe510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626761 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#842938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08b9eb7a896f..4ecb2f5fc58f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I38468bfcfa572f453226e5ee270ba2da7a86a2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627128Reviewed-by:
-
Lingqi Chi authored
https://chromium-review.googlesource.com/c/chromium/src/+/2583677 only set the prerendering state for main-frame navigation. This CL shares parents' prerendering states with their children, so that sub-frames can also know the correct prerendering state. Bug: 1142658 Change-Id: I70552d4dc6380f91536e062ad2ea3ec8d0719b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603660Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#842936}
-
Song Fangzhen authored
This CL builds on https://chromium-review.googlesource.com/c/chromium/src/+/2606873 We update the MockNetworkContext and MockHostResolver to make them behave the same as in network when resolving hostnames. And the tests should all pass whithout special machines' failures. Bug: 1141241 Change-Id: Iffeec31910faafe7e42dd42d15ee4ce63ec9a33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624316 Commit-Queue: Ke He <kehe@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#842935}
-
Yoshifumi Inoue authored
This patch changes |CachedTextInputInfo::GetPlainTextRange()| to return empty |PlainTextRange| when passed range is outside of cached text to avoid crash when selection moved during IME text composition. This case is happend with following scenario: 1. Start IME text composition 2. Move selection to another content editable 3. |InputMethodController::TextInputInfo()| in |FrameSelection::SetSelection()|. 4. |InputMethodController::WillChangeFocus()| is called to clear IME text composition from |FocusController|. Bug: 1157910, 1161562 Change-Id: I38ed328558a572388d9e715dd6f6cae481b868e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626624 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842934}
-
Hayato Ito authored
It looks generate-test-wbns.sh fails with two errors: 1. nested/resource.js is missing 2. cors/resource.json is wrong. It should be cors/resource.cors.json BUG=1082020 Change-Id: I18a87f59784d6c36e050a64567c1ba671af0468a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627209Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842933}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610495996-ac73e18e1b2efb1cd1bfbf2a2aaf90e9e3476b5a.profdata to chrome-linux-master-1610517435-75fc59b03a49bc3203d88e1f39423cb5de4c8383.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib11113d54ddcdc8bcf3a36c13ce683e3af1f0092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627035Reviewed-by:
-
Peter E Conn authored
This is a temporary class that will allow us to move things around more easily without breaking downstream. Change-Id: Ifc36c7d582ed9d2dea512a000bcb9d85fcbdd6ab Bug: 1164866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623290Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842931}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - naming_controller.js In //ui/file_manager/file_manager/foreground/js/ui/: - search_box.js - autocomplete_list.js Bug: 1133186 Change-Id: Ie31eb3bb909b274636bd28400fc6b6add9c94d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626699 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842930}
-
Mihai Sardarescu authored
The method OnUnconsentedPrimaryAccount() is obsolete now (as all observers were converted to use OnPrimaryAccountChanged()) so this CL removes it. Bug: 1158855 Change-Id: Ice0ffc2b2f19597602837371ee05a71d27ee697f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624668 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842929}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610495996-38f3d5c57ab4be3d52eaefe38d45ce16ec0addd8.profdata to chrome-mac-master-1610517435-0b7576a8f42d1cf58a978eb4b1fa934cc5ba313f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I91347340172b8185305362e099f59ec0b9107eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627129Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e60bce4..d98dd8de Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d7c951d033bea3733bb10c5d27290d35985319c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627047Reviewed-by:
-
