- 17 Aug, 2018 40 commits
-
-
Egor Pasko authored
Trivial cleanup: removing parameters/functions that are not used in producing startup metrics (The RecordMainEntryPointTime() used to take wall clock time into account, but now on all platforms wallclock time is not needed except for executable start time). Bug: 797762 Change-Id: I1242246ad6af2b4b3e955b0225144154084e568f Reviewed-on: https://chromium-review.googlesource.com/1174548Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584015}
-
Mark Cogan authored
This CL adds corner roundedness matching for the reduced motion tab grid transition animation (which is also used when exiting the tab grid from a tab that isn't visible). The free function that exposes the device's (approximate) corner radius is facored into a ui_utils method. Bug: 870659 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5abdd190140f2a4a4fd3b0b18f0d300a6d0dd5ea Reviewed-on: https://chromium-review.googlesource.com/1177606Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#584014}
-
Friedrich Horschig authored
Disabling AutoCloseAfterOpenWithMouseOffShelf which wasn't for some reason disabled yet although it's similar flaky as all others. Latest recorded failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4744 The flakiness dashboard supports this action: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=unit_tests&tests=DownloadShelfControllerTest.AutoCloseAfterOpenWithMouseOffShelf TBR=sdy@chromium.org,benwells@chromium.org Bug: 849477 Change-Id: Ic793f6f0139c5d56148383caf9ff2890cdfe2420 Reviewed-on: https://chromium-review.googlesource.com/1179674Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584013}
-
Sergio Villar Senin authored
There was some leftover code from https://crrev.com/c/1143261 BUG=865350 Change-Id: Ibe6561d4da605b4b8802e8f3862a023155c4f051 Reviewed-on: https://chromium-review.googlesource.com/1175122Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#584012}
-
Vadym Doroshenko authored
No need to wait a navigation since NavigateToURL waits for navigation completed (it eventually calls NavigateToURLWithDispositionBlockUntilNavigationsComplete). Bug: 875052 Change-Id: I96ebd7d5ec4ce0f676a82f6714816a7ddefb2b08 Reviewed-on: https://chromium-review.googlesource.com/1179160Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584011}
-
Friedrich Horschig authored
Theses tests were known to be flaky for a while and this is not the first time they are disabled for unknown reasons. Reopened and linked bugs with details. TBR=dskiba@chromium.org, tedchoc@chromium.org Bug: 668217, 875130, 875129, 875092 Change-Id: Ifee7d29bbdf28349aea3837a6b1a2525484c6e9a Reviewed-on: https://chromium-review.googlesource.com/1179665Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584010}
-
Trent Apted authored
Bug: 867700 Change-Id: I42172daa50afe7a88b4ae2913371884504d46763 Reviewed-on: https://chromium-review.googlesource.com/1179117 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584009}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/091d6f21..b44fe61d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1c6f9d1bcf4984c5a5437c7e1d49d34dead6b2ae Reviewed-on: https://chromium-review.googlesource.com/1179470Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584008}
-
Tetsui Ohkubo authored
This CL adjusts (mainly network) detailed view styles. If fixes the following items. See the bug for detail. - Align sub-section labels even if the row doesn't have an icon. - Change Sub-section label (when single-line) size to 16pt. - Change style of Add Wifi button icon. - Change Sub-section label line heights for double-line row to 20px. - Change "Connected" color to Dark Green 600. Screenshot: http://screen/aNoY7W8uGQn TEST=manual BUG=863618 Change-Id: I2b1e13e53f7c7fc79b57a4f1e64110d7136f0623 Reviewed-on: https://chromium-review.googlesource.com/1175658 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#584007}
-
David Davidović authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1145066, which adds an STL-compatible interface to EnumSet and EnumSet::Iterator, replace all uses of the previous iteration interface with a range-based for loop. This allows eventual removal of the old interface altogether. Also, replace existing usage of |arraysize| with |base::Size|, since the former was deprecated. This is CL part 2 of 2. TBR=dschuyler@chromium.org Bug: 860435 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7839362e3b103e9a1d309f21c7b1bef17da7b8e1 Reviewed-on: https://chromium-review.googlesource.com/1146925 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584006}
-
Egor Pasko authored
Comparing benchmark results between experimental.startup.android.coldish and experimental.startup.mobile revealed that the latter is a bit more noisy (and reports slower startup). One difference visible in the log is the lack of scaling governor adjustment. We do the scaling governor adjustment for all other benchmarks I know of, hence correcting the behavior of _MobileStartupSharedState to match it. In my local testing this tweak did not bring the noise levels to match. Looking further. Bug: 760498 Change-Id: Ifb12f227a135d652fd068a28329887dcae35233a Reviewed-on: https://chromium-review.googlesource.com/1178054Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584005}
-
Friedrich Horschig authored
This reverts commit a84f590c. Reason for revert: the introduced test JavaScriptDialogTest.DismissalCausePromptTabClosedByUser fails more often than it passes (e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/4745) This test seems to be fairly essential given that this CL mainly affects the log. If it's not, feel free to disable on Mac and reland. Original change's description: > Fix the JS dialog dismissal cause > > Previously on a non-Mac platform when JS dialog is dismissed by user > closing the tab, |DIALOG_BUTTON_CLICKED| is logged. This change > separates the case of the user replying to the dialog with the buttons > vs rejecting it. > > Bug: 872795 > Change-Id: I4b8781daeb3cead5ee4e975a67f79f94b7fa84e5 > Reviewed-on: https://chromium-review.googlesource.com/1164647 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583885} TBR=avi@chromium.org,csharrison@chromium.org,huayinz@chromium.org,yaoxia@chromium.org Change-Id: I0de2f8e0ded623c121325a80975d131681aaa493 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872795 Reviewed-on: https://chromium-review.googlesource.com/1179701Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584004}
-
Hiroshige Hayashizaki authored
This CL changes worker global scope's URL if the request of the worker top-level script is intercepted by ServiceWorker and Response with a different URL is supplied to respondWith(). Test: external/wpt/service-workers/service-worker/worker-interception-redirect.https.html Bug: 861564 Change-Id: I4b91777abd6fa42583ae853330ee2c7bbccf61cb Reviewed-on: https://chromium-review.googlesource.com/1153598Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#584003}
-
Gauthier Ambard authored
This is a reland of 76c127f6 Original change's description: > [iOS] ActivityService cleanup > > Cleanup for the ActivityService. > > Bug: none > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I7feb4acc2711172dfb9829c2b223e6f2c724fa33 > Reviewed-on: https://chromium-review.googlesource.com/1172289 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582599} TBR: pkl@chromium.org Bug: none Change-Id: I09350b72628af244844353b37f52b38f9bc8d62e Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1179621Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#584002}
-
Kyoko Muto authored
In this CL, the design for "Imperative Shadow DOM Distribution API" is changed as nodes choose first slot in shadow tree in tree-order. This CL also delete Hashmap in shadow tree because it is already unused. BUG=869308 Change-Id: I1e95919b22e2aba26ef52a97059442770e9778ea Reviewed-on: https://chromium-review.googlesource.com/1176890Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kyoko Muto <kymuto@google.com> Cr-Commit-Position: refs/heads/master@{#584001}
-
Kent Tamura authored
Update them to |FooEvent&| or |const FooEvent&|. This CL has no behavior changes. Bug: 874385 Change-Id: I656a03f466b70defd0769db78c9b3946ef515a08 Reviewed-on: https://chromium-review.googlesource.com/1179545Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#584000}
-
Friedrich Horschig authored
This test is flaky on multiple Android builders. See linked bug for details. TBR=kenrb@chromium.org, yhirano@chromium.org Bug: 875179 Change-Id: I4a87619a4c1a8d3ceef82a63e3c56e21f18f5112 Reviewed-on: https://chromium-review.googlesource.com/1179158 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583999}
-
Pavel Shmakov authored
1) A listener of sync state changes was not always removed in ChromeActivity. 2) A static variable sCleanupTask in TabPersistensePolicy implementations held a reference to activity and was never nulled after completion/cancellation of the task. 3) ToolbarModel was never destroy()-ed. Note that none of these issues are specific to Custom Tabs. They manifest themselves more severely with Custom Tabs since the CustomTabActivity gets destroyed when the tab is closed, whereas ChromeTabbedActivity is only stopped when the app is minimized. However, with "don't keep activities" turned on, the same leakage is seen when opening and closing Chrome in ordinary way. Bug: 872661 Change-Id: I5802690eb9d7a733426a7ea7ac3fd969c8514810 Reviewed-on: https://chromium-review.googlesource.com/1172425Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#583998}
-
Koji Ishii authored
This patch changes NGBlockNode::CopyFragmentDataToLayoutBoxForInlineChildren to a private member function from an anonymous function, so that the planned changes to the function is easier to review. No changes other than moving within the same .cc file. TBR=eae@chromium.org Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8af2cd1872e9f6c66156368c508ea4f209fc3255 Reviewed-on: https://chromium-review.googlesource.com/1179491 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583997}
-
Gauthier Ambard authored
This CL updates the existing ActivityService icons. It also removes the default copy action to add a custom one, allowing to change its icon. Bug: 868104 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I16da49521bde80e1a0b41859843e257d7beb50e3 Reviewed-on: https://chromium-review.googlesource.com/1172624 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#583996}
-
Leszek Swirski authored
This reverts commit 5912b768. Reason for revert: Seems to cause Scanner crashes Original change's description: > [v8] Re-post non-blocking ScriptStreamer tasks > > Posted blocking ScriptStreamer tasks can end up in a queue, and have > their Resource complete loading before the task even starts. When this > happens, these tasks will no longer block on network input, but they > will still be posted to the blocking task runner, which does not spin up > new threads if the running task is not blocked. When there are a lot of > small functions posted for streaming, this results in a slightly > paradoxical starvation, where the blocking task runner is processing > lots of no-longer-blocking tasks all in one thread, as it has no reason > to spin up new threads. > > To avoid this, if a streaming task isn't started before the resource > finishes loading, we can cancel this posted task, and instead post a new > non-blocking task to the non-blocking thread pool. This frees up the > blocking task runner to process only blocking tasks (and thus allows it > to spin up new threads for them). > > Bug: chromium:865098 > Bug: chromium:866868 > Change-Id: Iceb282582781109ade233366d1009c3be50db3a5 > Reviewed-on: https://chromium-review.googlesource.com/1174380 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583649} TBR=skyostil@google.com,gab@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,kouhei@chromium.org,skyostil@chromium.org,altimin@chromium.org,leszeks@chromium.org Change-Id: Iffbab7a8994d12ffce53c6b5b76d19f4db79df0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:865098, chromium:866868, chromium:875162 Reviewed-on: https://chromium-review.googlesource.com/1179641Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#583995}
-
Yutaka Hirano authored
There are three ("follow", "error" and "manual") redirect modes, but among ThreadableLoader clients only FetchManager sends requests with a non-"follow" mode, so move logic for such requests to FetchManager from ThreadableLoader. This is good because this change removes logic effective even when out of blink CORS is enabled from ThreadableLoader. Change-Id: I808826c59db2db61e68051d85e5fec8e4ace91e7 Reviewed-on: https://chromium-review.googlesource.com/1175703 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#583994}
-
Tetsui Ohkubo authored
This CL disables date time settings button when WebUI settings and date time dialog are unavailable. For example, it will not be included in focus traversal on lock screen. TEST=manual BUG=860222 Change-Id: I54e4f1188596413fdfe0a4d826fbcec8cae85b6a Reviewed-on: https://chromium-review.googlesource.com/1177463Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#583993}
-
Alex Clarke authored
Updates the documentation as requested. Bug: 873317 Change-Id: Id1deb86475f93896935e7962350af7033b0246e9 TBR: pfeldman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1177397 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#583992}
-
Tanja Gornak authored
This CL implements routines for serializing and deserializing object ids, which simplifies the logic for storing topics which were already registered for. TBR: pavely@chromium.org Bug: 867402, 801985 Change-Id: Ie859cc87b8e9b3cff54ae2af0eeed68467af09af Reviewed-on: https://chromium-review.googlesource.com/1154921Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#583991}
-
Trent Apted authored
Bug: 867700 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7e0fbb902d969ded9c4713be217c5bff4cba3281 Reviewed-on: https://chromium-review.googlesource.com/1177210 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#583990}
-
Jan Wilken Doerrie authored
This change implements skeletons required for WinRT's pairing logic. No actual functionality is added, this will be provided in a later CL. Furthermore, it moves the TestPairingDelegate class from BlueZ's tests into a standalone file. It also wraps the TestPairingDelegate in bluetooth_adapter_unittest.cc in an anonymous namespace to avoid ODR violations. Bug: 821766 Change-Id: If440153dff46476223a1b24dfab1a630fb2451a3 Reviewed-on: https://chromium-review.googlesource.com/1177715Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#583989}
-
David Roger authored
Bug: 807826 Change-Id: I77fc0e169536f86637f7501a6100566a50630f55 Reviewed-on: https://chromium-review.googlesource.com/1177708Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#583988}
-
Friedrich Horschig authored
With this CL, the view stubs (and the views) are moved out of the bottom container, which makes it possible (and necessary) to push up all visible content. This fixes: - the accessory overlaying page contents (esp. bad for fullscreen) - the accessory being pushed up by the keyboard (visual flickering) - clicking through the accessory This changes: - the bar isn't pushed up by bottom sheets (like download) anymore BUT instead pushes them up when the bottom sheet is opened Bug: 874257, 873591, 704070, 853745, 865964 Change-Id: I8185b1ac21aaaed3d7123855b8964a3f86c9845a Reviewed-on: https://chromium-review.googlesource.com/1177361Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#583987}
-
Achuith Bhandarkar authored
Disable NetworkQualityEstimatorTest.TestTCPSocketRTT Bug: 875104 Change-Id: Ia7b691d7dbc66621e0df94447ac7d21969eecce7 Reviewed-on: https://chromium-review.googlesource.com/1179227Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#583986}
-
Mounir Lamouri authored
Bug: None Change-Id: Ibad2049d1d75c355ec695e4df4bcc9fe0adb7927 Reviewed-on: https://chromium-review.googlesource.com/1179000 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#583985}
-
Hwanseung Lee authored
When RemovedFrom called, ContainerNode object was passed as a parameter. and it is never nullptr. so it can be changed to reference instead of pointer. Bug: 874385 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I91a80d4f49c80730791fe2dfa5f9977404b5bd48 Reviewed-on: https://chromium-review.googlesource.com/1179481Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#583984}
-
Koji Ishii authored
This is a reland of 902e5475 The original patch discovered where NGPaintFragment still in-use are destructed unintentionally. The problem has been there when LayoutNGBlockFragmentation runtime flag was enabled, but it did not cause many crashes fortunately. Re-landing after keeping all NGPaintFragment in use in r583980 (CL:1178081). Original change's description: > [LayoutNG] Store NGPaintFragment in LayoutObject > > This patch stores a one-way linked list of NGPaintFragment to > their source LayoutObject. Looking up the HashMap consumes > non-ignorable time during paint. > > This patch adds IsInLayoutNGInlineFormattingContext flag to > LayoutObject. This flag represents whether the object is in > LayoutNG inline formatting context, even if the object itself > is laid out by legacy. > > With the flag, the storage used for storing InlineBox in > LayoutText, LayoutInline, and LayoutBox are changed to union > to store the first NGPaintFramgent. > > Bug: 714962 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7dfd11fafa9b1527b8d77e1fa3a24abf0e7f551e > Reviewed-on: https://chromium-review.googlesource.com/1170726 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583633} TBR=eae@chromium.org, mstensho@chromium.org Bug: 714962 Change-Id: Ie7c000c918e22e24f378eb14ca68243ed0e7bfa8 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1178441Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583983}
-
Keiichi Watanabe authored
This reverts commit 3227909e. Reason for revert: This commit is originally a hack that should be reverted after CL:1134934 and other 3 related CLs are merged. See chromium:819930 for details. Original change's description: > V4L2SVDA: Add hack for shifting ChromeOS-specific control IDs > > This patch makes Chrome work before/after https://crrev.com/c/1134934 > (for chromiumos-overlay), https://crrev.com/c/1136336 (for v3.14) and > http://crrev.com/c/1134929 (for v4.4) are merged, which change > ChromeOS-specific controls' IDs to avoid cofliction with upstream. > > By calling QUERY_CTRL for new IDs, Chrome can detect whether the CLs are > already merged at run-time. If they are not merged yet, Chrome will use old > control IDs instead. > > This patch is needed because we cannot land the kernel change at the > same time as new Chrome build. After new ChromeOS build contains these CLs, > this patch should be reverted. > > Bug: 819930 > Test: Play VP8/VP9 video on veyron_jerry w/o CL:1134934 and CL:1136336 > Test: Play VP8/VP9 video on veyron_jerry w/ CL:1134934 and CL:1136336 > Test: Play VP8/VP9 video on kevin w/o CL:1134934 and CL:1134929 > Test: Play VP8/VP9 video on kevin w/ CL:1134934 and CL:1134929 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I293464d85c4ca28fd3413b89e77e242c0a7648c0 > Reviewed-on: https://chromium-review.googlesource.com/1134933 > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578981} TEST=Play VP8/VP9 video on veyron_jerry TEST=Play VP8/VP9 video on kevin Bug: 819930 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I108024ef0c0e78f18efb43fdc389659a19cd63d7 Reviewed-on: https://chromium-review.googlesource.com/1154772Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#583982}
-
Ned Nguyen authored
NOTRY=true TBR=mythria@chromium.org,ulan@chromium.org Bug: 875159 Change-Id: I63d955c029460e138988fa7137c25ecc10d5335f Reviewed-on: https://chromium-review.googlesource.com/1179100Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583981}
-
Koji Ishii authored
This patch stores fragmented NGPaintFragment as a list linked from LayoutNGMixin. The code path doesn't run (break_token is always nullptr) in phase 1. But without keeping them, virtual/layout_ng_experimental will crash randomly when CL:1170726 caches NGPaintFragment in LayoutObject. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c7e4934dcb366d7dcb39412bf1aac40ebad7429 Reviewed-on: https://chromium-review.googlesource.com/1178081 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583980}
-
Donna Wu authored
This CL moves permission checking from device/usb/mojo directory to chrome/browser/usb. This is a preparation step for moving device/usb to service/device. BUG=699790 Change-Id: Ic30d6ff94b670950fcb2571d7036dd7c0f39a24b Reviewed-on: https://chromium-review.googlesource.com/1172154 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583979}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/40adb3c41f2a..bc414ed5dec5 git log 40adb3c41f2a..bc414ed5dec5 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 reed@google.com clean up to more modeern conventions Created with: gclient setdep -r src/third_party/skia@bc414ed5dec5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I6aa7125b7ec8c761da758c1acd966a01d6aa1e44 Reviewed-on: https://chromium-review.googlesource.com/1179328Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583978}
-
Sam McNally authored
Bug: b:110464348 Change-Id: I356c9411d76cbbc5d0cad51a4aad65eadd600c6b Reviewed-on: https://chromium-review.googlesource.com/1179118Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#583977}
-
Toni Barzic authored
Introduces a class that will handle removing pre-installed demo mode resources when needed. First incarnation observes low disk space signal from cryptohome service, and removes pre-installed resources when low space is detected (provided that the device is not in demo mode). When demo mode resources get removed from disk, this is recorded in local state, to avoid future attempts to remove these resources. More logic for requesting demo mode resources removal to come. BUG=827368 Change-Id: I721d1995fa818fc2fc1d056e33ba513380bf441e Reviewed-on: https://chromium-review.googlesource.com/1173670 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583976}
-