- 08 Apr, 2015 40 commits
-
-
ginkage authored
and if not, what disabled them: the local setting or domain policy. BUG=470383 Review URL: https://codereview.chromium.org/1064843003 Cr-Commit-Position: refs/heads/master@{#324206}
-
treib authored
BUG=470070 Review URL: https://codereview.chromium.org/1060333002 Cr-Commit-Position: refs/heads/master@{#324205}
-
mtomasz authored
TEST=Tested manually. BUG=440674 Review URL: https://codereview.chromium.org/1070643002 Cr-Commit-Position: refs/heads/master@{#324204}
-
machenbach authored
Revert of Roll src/third_party/WebKit e0eac24:489c548 (svn 193311:193320) (patchset #1 id:1 of https://codereview.chromium.org/1063333002/) Reason for revert: [Sheriff] Breaks gpu tests, e.g.: http://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA%29/builds/31123 Original issue's description: > Roll src/third_party/WebKit e0eac24:489c548 (svn 193311:193320) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/e0eac24..489c548 > > TBR=falken@chromium.org,cbiesinger@chromium.org > > Committed: https://crrev.com/1b068129efeae948ad211217c3e2f1685d2e4078 > Cr-Commit-Position: refs/heads/master@{#324191} TBR=cbiesinger@chromium.org,falken@chromium.org,blink-deps-roller@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1063423002 Cr-Commit-Position: refs/heads/master@{#324203}
-
jochen authored
BUG=474552 R=mkwst@chromium.org Review URL: https://codereview.chromium.org/1063383002 Cr-Commit-Position: refs/heads/master@{#324202}
-
sdefresne authored
Change notification NOTIFICATION_FAVICON_UPDATED into an event sent to FaviconDriverObserver and change client code to be observers instead. Pass the FaviconDriver to OnFaviconUpdated() event so that listeners can find the content::WebContents corresponding to the event (as some of the client code did listen to multiple content::WebContents). BUG=362072 Review URL: https://codereview.chromium.org/1059743003 Cr-Commit-Position: refs/heads/master@{#324201}
-
melandory authored
Bubble shouldn't be popped up if user has blacklisted the site or password management is disabled for the page. BUG=450583 Review URL: https://codereview.chromium.org/1031153002 Cr-Commit-Position: refs/heads/master@{#324200}
-
jochen authored
Now that we reuse devtools processes during layout tests, it can happen that there are multiple processes during session history tests. Remove the now spurious NOTREACHED() BUG=474162 R=mkwst@chromium.org Review URL: https://codereview.chromium.org/1069293002 Cr-Commit-Position: refs/heads/master@{#324199}
-
benwells authored
This change fixes a bug in 42 which is triggered if the start URL from the manifest is not the same as the current page. In this case, the fact that the shortcut was added is not remembered, causing the banner to come up in future. BUG=474631 Review URL: https://codereview.chromium.org/1065153002 Cr-Commit-Position: refs/heads/master@{#324198}
-
hirono authored
To generate batch request from each request instance, batachable request class must publish several methods to BatchRequestClass. BUG=451917 TEST=None Review URL: https://codereview.chromium.org/1053123004 Cr-Commit-Position: refs/heads/master@{#324197}
-
rch authored
to not take a request_url, since this is confusing for Alternate-Protocol and Alt-Svc requests. Instead, take an enum which describes the type of socket to be requested (FTP, SSL, or normal) and endpoint to which the socket is to be connected. Review URL: https://codereview.chromium.org/1051023003 Cr-Commit-Position: refs/heads/master@{#324196}
-
machenbach authored
Revert of Copy Widevine files for swarming tests (patchset #5 id:80001 of https://codereview.chromium.org/1063453004/) Reason for revert: [Sheriff] Breaks chrome mac compilation: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/355 Original issue's description: > Copy Widevine files for swarming tests > > BUG=474674 > > Committed: https://crrev.com/f584802a283f812bdeb9d3704c021a266486ab00 > Cr-Commit-Position: refs/heads/master@{#324170} TBR=thakis@chromium.org,xhwang@chromium.org,maruel@chromium.org,jrummell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474674 Review URL: https://codereview.chromium.org/1069273002 Cr-Commit-Position: refs/heads/master@{#324195}
-
hidehiko authored
Some toolchain (especially PNaCl for Non-SFI build) does not provide the linux/filter.h system header. This CL defines all necessary structs and macros for sandbox, and replace linux/filter.h with the new header. This CL is preparation to enable seccomp-bpf sandbox on nacl_helper_nonsfi. TEST=Ran bots. BUG=358465 Review URL: https://codereview.chromium.org/1053603002 Cr-Commit-Position: refs/heads/master@{#324194}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#324193}
-
nednguyen authored
Modify tracing_ui.cc to add record-as-much-as-possible mode for about://tracing. This time, the roll should decrease trace-viewer size from 1.6 M -> 1.4 M with minification using rjsmin. Verified that the size of resources.pak reduces from 17278967 to 16888789. BUG=396081, 471610, 469646 Review URL: https://codereview.chromium.org/1066903002 Cr-Commit-Position: refs/heads/master@{#324192}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/e0eac24..489c548 TBR=falken@chromium.org,cbiesinger@chromium.org Review URL: https://codereview.chromium.org/1063333002 Cr-Commit-Position: refs/heads/master@{#324191}
-
emircan authored
[0] https://codereview.chromium.org/1024113003/#ps200001 In this CL: - I added a new format gfx::GpuMemoryBuffer::YUV_420 - Implemented helper functions to use with it on GpuMemoryBufferImpl. - I added support in GpuMemoryBufferImplSharedMemory and GpuMemoryBufferFactorySharedMemory - I added { gfx::GpuMemoryBuffer::YUV_420, gfx::GpuMemoryBuffer::MAP } as a supported config for testing - I added support for multi plane in test implementations: test_gpu_memory_buffer_manager, gl_manager, gpu_memory_buffer_impl_unittest The future steps are: - Add a new GL_* internalformat corresponding to YUV_420 - Implement support for YUV_420 in GpuMemoryBufferFactoryOzoneNativeBuffer, GLImageLinuxDMABuffer and SurfaceFactoryOzone - Expose file descriptors for gfx::GpuMemoryBuffer::YUV_420 via Map() or GpuMemoryBufferHandle struct Check usage of gbm_bo_get_fd() at the lowest gbmbuffer level - Add support in GLImageSharedMemory and GLImageMemory through Bind functions - Look for possible use cases of multiple buffers on Android, Mac, and Win platforms BUG=439520 TEST=content_unittests --gtest_filter=GpuMemoryBufferImplTests.* content_unittests --gtest_filter=GpuMemoryBufferFactoryTest.* gl_tests --gtest_filter=GpuMemoryBufferTest* Review URL: https://codereview.chromium.org/1062853002 Cr-Commit-Position: refs/heads/master@{#324190}
-
shreeram.k authored
This CL use the multiline attribute only to see if it's multiline or not and Changes Chromium to treat TextField and TextArea identically. BUG=471152 Review URL: https://codereview.chromium.org/1046883002 Cr-Commit-Position: refs/heads/master@{#324189}
-
aiolos authored
BUG=471786 Review URL: https://codereview.chromium.org/1067193002 Cr-Commit-Position: refs/heads/master@{#324188}
-
deepak.m1 authored
Earlier we are checking whether a extension with url that have mime type should be intercepted as stream by checking plugin availablity. Now we are passing plugin path and then checking whether their is MimehandlerView Plugin available with that path and then we are allowing intercepted as stream. So now interception is not depends upon mimetype. BUG=443466 Review URL: https://codereview.chromium.org/953793003 Cr-Commit-Position: refs/heads/master@{#324187}
-
tfarina authored
It seems better to use a specific MD5 API for this kind of thing. The result should be the same with the difference that the alpha chars used in MD5DigestToBase16() are lowercase. BUG=None TEST=components_browsertests --gtest_filter=PrintWebViewHelperTest.PrintLayoutTest R=vitalybuka@chromium.org Review URL: https://codereview.chromium.org/1068593002 Cr-Commit-Position: refs/heads/master@{#324186}
-
pkasting authored
BUG=437890,436671,455423,424386,436634,422516 TEST=none TBR=jochen,cbentzel,jyasskin Review URL: https://codereview.chromium.org/1062413002 Cr-Commit-Position: refs/heads/master@{#324185}
-
bnc authored
unnecessarily frequent WINDOW_UPDATEs to be sent. * Update SpdyNetworkTransactionTest.WindowUpdateSent to test for this fix and verify locally that it fails without the fix. * Add spdy_session_max_recv_window_size member and plumb it through HttpNetworkSession::Params, SpdySessionPool, and SpdySession. * Rename stream_initial_recv_window_size to stream_max_recv_window_size members and corresponding methods. * Set default values in HttpNetworkSession instead of SpdySession, have two separate constants instead of one. * Set this member in SpdySessionDependencies to specification-prescribed default initial window size for tests. * Use this default to simplify SpdyNetworkTransactionTest.SettingsPlayback and SpdySessionTest.SendInitialDataOnNewSession tests. * Add SpdySessionPoolPeer methods to modify session and stream level maximum window size. BUG=474208 Review URL: https://codereview.chromium.org/1061853002 Cr-Commit-Position: refs/heads/master@{#324184}
-
benwells authored
The Windows system automatically adds a tooltip to these buttons as the button returns HTCLOSE when nc hit tested. If we add the aura tooltip as well there are two tooltips shown. BUG=471981 Review URL: https://codereview.chromium.org/1044043004 Cr-Commit-Position: refs/heads/master@{#324183}
-
abhijeet.k authored
Review URL: https://codereview.chromium.org/1053563003 Cr-Commit-Position: refs/heads/master@{#324182}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/68b67cd..e0eac24 TBR=falken@chromium.org,cbiesinger@chromium.org Review URL: https://codereview.chromium.org/1065093004 Cr-Commit-Position: refs/heads/master@{#324181}
-
horo authored
This cl introduces three UMAs. - ServiceWorker.ScriptCount - ServiceWorker.ScriptTotalSize - ServiceWorker.ScriptCachedMetadataTotalSize 1/2 blink: https://codereview.chromium.org/1059193002/ 2/2 chromium: This cl. BUG=408451 Review URL: https://codereview.chromium.org/1055423002 Cr-Commit-Position: refs/heads/master@{#324180}
-
khorimoto authored
This fixes an issue where Chrome on iOS failed to translate interstitial pages due to use of this selector (on iOS, Chrome uses UIWebView which does not have native support for shadow DOM). Note that Polymer-based pages will still work in iOS WebUI pages because /deep/ will be polyfilled. BUG=474360 Review URL: https://codereview.chromium.org/1062813007 Cr-Commit-Position: refs/heads/master@{#324179}
-
thakis authored
Revert of Add the ability to build Chrome tools to the Win Clang build script. (patchset #3 id:40001 of https://codereview.chromium.org/1068603002/) Reason for revert: Still breaks clang/win bots: http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/279 Original issue's description: > Add the ability to build Chrome tools to the Win Clang build script. > > BUG=424436,467287 > > Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b > Cr-Commit-Position: refs/heads/master@{#324089} > > Committed: https://crrev.com/8caa594c291b6dd3e35d60a886ef33b36ae78e97 > Cr-Commit-Position: refs/heads/master@{#324164} TBR=hans@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=424436,467287 Review URL: https://codereview.chromium.org/1070523002 Cr-Commit-Position: refs/heads/master@{#324178}
-
mfoltz authored
BUG=461815 Review URL: https://codereview.chromium.org/1069063002 Cr-Commit-Position: refs/heads/master@{#324177}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/6c27535..c654e90 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1070463002 Cr-Commit-Position: refs/heads/master@{#324176}
-
wittman authored
Collects stack samples at 10 Hz for 30 seconds at startup. Uploading of samples to UMA is controlled by a Finch experiment. This change moves to a callback-based mechanism for communicating completed profiles to the metrics provider to avoid profiles lingering in memory when reporting is disabled. BUG=464929 Review URL: https://codereview.chromium.org/1029653002 Cr-Commit-Position: refs/heads/master@{#324175}
-
justincohen authored
Clients that already set the async parameter (in this case, with 'cta:1'), will end up with query strings with two differeny async parameters, instead of a comma delimited async param. E.g. converts ?async=cta:1&async=es_dfp:123 -> ?async=cta:1,es_dfp:123 BUG=414528 Review URL: https://codereview.chromium.org/1066923002 Cr-Commit-Position: refs/heads/master@{#324174}
-
danakj authored
Don't use the canvas() from the PaintContext so that we can have the PaintContext be backed by a DisplayItemList instead in the future. Access to the Canvas should be done through a PaintRecorder. For compositing effects (opacity) we use a CompositingRecorder to provide a scoped opacity change. R=pkasting BUG=466426 Review URL: https://codereview.chromium.org/1062293003 Cr-Commit-Position: refs/heads/master@{#324173}
-
dalecurtis authored
The upcoming VideoRenderer needs a way to know when time starts and stops moving; this extends the RendererImpl to let the VideoRenderer know about time changes. I considered introducing a TimeSourceDependent observer-like interface for TimeSources, but it ended up being way more complicated. I also considered a proxy TimeSource, but again it was way more complicated. The approach here is quite simple and small in complexity. BUG=439548 TEST=new unittest. Review URL: https://codereview.chromium.org/1068593003 Cr-Commit-Position: refs/heads/master@{#324172}
-
tfarina authored
With this tricky we don't need this strange 'j' variable laying around outside the loop, even better, since that variable is not even used outside of the for loop. The iteration using this tricky goes like the following: The old tricky using just 'i': For i = 0: 0 * 2 = 0 0 * 2 + 1 = 1 For i = 1: 1 * 2 = 2 1 * 2 + 1 = 3 For i = 2: 2 * 2 = 4 2 * 2 + 1 = 5 The new tricky using 'j': For i = 0: j = 0 0 = 0 0 + 1 = 1 For i = 1: j = 2 2 = 2 2 + 1 = 3 For i = 2: j = 4 4 = 4 4 + 1 = 5 So the new code does the same thing as the old but with the advantage of not having to use a temporary variable outside the loop. And the tricky with 'j' has also the benefit of avoid a multiplication and the rules of operator precedence. BUG=None TEST=base_unittests --gtest_filter=MD5* R=thestig@chromium.org Review URL: https://codereview.chromium.org/1065733005 Cr-Commit-Position: refs/heads/master@{#324171}
-
jrummell authored
BUG=474674 Review URL: https://codereview.chromium.org/1063453004 Cr-Commit-Position: refs/heads/master@{#324170}
-
mtomasz authored
For auto-launched kiosk apps permissions are granted automatically, without a user consent. In such case a notification will be shown though. TEST=unit_tests: *FileSystemApiConsentProviderTest* BUG=440674 Review URL: https://codereview.chromium.org/1032313002 Cr-Commit-Position: refs/heads/master@{#324169}
-
dhaddock authored
This adds a test to check that clicking the columns headers in Files resorts the columns in the correct order. It checks for ascending and descending. TEST=browser_tests -gtest_filter="*SortColumns/FileManagerBrowserTest*" BUG=None Review URL: https://codereview.chromium.org/1063453003 Cr-Commit-Position: refs/heads/master@{#324168}
-
kelvinp authored
This CL moves protocolExtensionManager from SessionConnector into its own class. The ProtcolExtensionManager will be exposed via the ClientPlugin. The higher level goal is to remove functionality from the SessionConnecctor so that it can be removed altogether in a future CL. BUG=474766 Review URL: https://codereview.chromium.org/1067133002 Cr-Commit-Position: refs/heads/master@{#324167}
-