GitLab

The tests went flaky when we replaced the bot and get VIDIOC_STREAMON
errors about 25% of the builds. I have no idea to fix that; we tried
replacing the webcam and moving it around in the USB ports and that
didn't help. See http://crbug.com/828568 for discussion.

Bug: chromium:831514
Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9
Reviewed-on: https://chromium-review.googlesource.com/1016301Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552165}

Bug: 834131
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7a3bb44da51bdd3aac19ff8da559d4178e0fe168
Reviewed-on: https://chromium-review.googlesource.com/1017231
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552164}

This CL moves writing/reading logic out of tcp_connected_socket.cc into a
separate class, socket_data_pump.h/cc. This separate class will be re-used by
tls socket implementation.

Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5d5b723d52c10a653f06b0f6e8eed9fb5b895899
Reviewed-on: https://chromium-review.googlesource.com/1005535
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552163}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1b573fbc..c7c22c11

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I217912a30f550bf256d2b5594216a01d69ba4f7d
Reviewed-on: https://chromium-review.googlesource.com/1019845Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552162}

The previous attempt to fix the bug was in crrev.com/539166:
the patch allowed adding rules to the inspector style sheets.
However, it didn't take into account adding rules into the
already-existing style sheets.

This patch fixes CSS.addRule altogether, allowing CSSOM access
if the operation is happenning from-inside InspectorMutationScope.

Our tests didn't catch the regression since we run with
--allow-file-access-from-files flag.

BUG=818518
R=dgozman

Change-Id: Ic6b198a5ef7abbabcef671edbefb5a9b14fde531
Reviewed-on: https://chromium-review.googlesource.com/1018526
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552161}

Managing TaskTracker through TrackedRefs instead of raw pointers is the
final bandaid for issues like crbug.com/827615.

It will now be impossible for SchedulerWorkers to outlive their
TaskTracker. A test may hang if its shutdown logic is flawed (out of
order) but the blamed test will always be the one with the poor logic
(instead of a random test in whose context an errand SchedulerWorker makes
a use-after-free).

In fact, a few tests had to be fixed to land this change (while they
weren't necessarily flawed per se per being properly joined, the logic
is easier to grasp with TrackedRefs).

R=fdoray@chromium.org

Bug: 827615
Change-Id: I5bff8c55b4edb9fef8c5232bddf36da2afd33078
Reviewed-on: https://chromium-review.googlesource.com/1013597
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552160}

If the command line has both switches, the profile id in kNotificationLaunchId should
be chosen over that in kProfileDirectory.

Bug: 734095
Change-Id: Ifeb693414a50f7e865c808ba75ce99d3e7db4733
Reviewed-on: https://chromium-review.googlesource.com/1018100
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552159}

In case of disk/access error FileURLLoader called ContentVerifyJob::DoneReading twice:
(the first time from FileURLLoaderObserver::OnOpenComplete and the second
time from FileURLLoaderObserver::OnDoneReading).

This CL:
1. Move calling OnBytesRead+OnDoneReading for bad files to
   file_url_loader_factory;
2. Remove FileURLLoaderObserver::OnOpenComplete method;
3. Add DCHECKs in ContentVerifyJob so that we make sure OnDoneReading
   isn't called more than once. This also makes existing tests
   (e.g. ExtensionProtocolsTest.VerificationSeenForFileAccessErrors)
   serve as regression tests.


TEST=unit_tests.ExtensionProtocolsTest.VerificationSeenForFileAccessErrors

Change-Id: Ib91ecb7eaa5dad760068201903758df3f651dc5b
Reviewed-on: https://chromium-review.googlesource.com/999484Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Mikhail Atuchin <atuchin@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#552158}

SSH multiplexing makes SSH-based forwarding much more performant
and reliable versus using separately negotiated connection.

Connection overhead for runner_v2 SSH operations is also reduced.

* Fix deployment path used to push the test server configuration
  to the target device.
* Documentation fixes.

Bug: 798851
Change-Id: I4d97204b0e3420e0ae8ce0ca8bcf6ca137dce46f
Reviewed-on: https://chromium-review.googlesource.com/1018364
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552157}

Bug: 825705
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id73672e7614fcca0388119fdf8068b4a884dac2d
Reviewed-on: https://chromium-review.googlesource.com/1015899Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552156}

Also cleanup other tests' dependency on user activation.

Bug: 831331
Change-Id: Ic2268318336d64e0031fe782ec4c48b9d91ae36b
Reviewed-on: https://chromium-review.googlesource.com/1006047Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552155}

1. Added GN template for Fuchsia SDK packages,
2. Added targets for packages that are currently included in the SDK

Bug: 831384
Change-Id: I7fabeab0814a099006aaa16fd119b4cd15fe0633
Reviewed-on: https://chromium-review.googlesource.com/1013284
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: James Robinson <jamesr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552154}

Bug: 834921
Change-Id: I35b6f7f72fa1253adf41092eed47761bad31725a
Reviewed-on: https://chromium-review.googlesource.com/1020075Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552153}

This parameterizes AutofillPopupControllerBrowserTest to run with
the feature either enabled or disabled. The goal is to help us
ensure it's to enable the feature for Canary/Dev.

Other tests will be parameterized in follow up CLs.

This CL was initially landed as crrev.com/c/1004923 and reverted by
crrev.com/c/1014141 due to flaky tests on ChromeOS.

After investigation we found that the flakiness is caused by a behavior
in the underlying framework that should not happen during tests, even though
the behavior in the product is correct (crbug.com/834768, crbug.com/834369).

Chrome OS tests have been temporarily disabled by crrev.com/c/1019840 while
a proper fix is implemented, so this CL should not introduce new flakiness
on the waterfall.

Bug: 768881
Change-Id: Id285013e504ebf66cc58cc27b01adc20906f3c7a
Reviewed-on: https://chromium-review.googlesource.com/1019861
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552152}

If the compositor thread has released the resource in a TextureLayer
and posted that release to the main thread, but then the MessageLoop
on which the posted task sits shuts down, the TextureLayer's
TransferableResourceHolder will be destroyed. This is because the
holder is at that time singly owned by callback, as the resource is
being released due to being removed (and unowned) by the main thread
side.

In this case, there is a posted-but-not-run dereference sitting in
the MessageLoop which we can track, and avoid DCHECK-failing in the
TransferableResourceHolder destructor.

However, there is also the ReleaseCallback for the main thread in
the TransferableResourceHolder that will DCHECK if not run, so we
can run that SingleReleaseCallback from the TransferableResourceHolder
destructor. This is done on the assumption that the MessageLoop is
destroyed from the main thread (we can DCHECK this instead), and
that the only case we have a SingleReleaseCallback in the destructor
still is when all missing derefs have been posted but not run (we
can DCHECK this as well).

This fixes the flaky SoftwareTextureLayerMultipleRegisterTest,
which could be resolved by using DidReceiveCompositorFrameAck()
instead of DidCommitAndDrawFrame(), as that waits for the release
callback to be run. But also resolves production issues where
DCHECKs are hit during shutdown due to the MessageLoop being
destroyed in this scenario (809604).

R=piman@chromium.org

Bug: 834613, 809604
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3faa1cdcc58f1be99cf5f80732c63e51e9aff3d9
Reviewed-on: https://chromium-review.googlesource.com/1019614
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552151}

The test started flaking recently due to some refactoring I landed,
specifically: https://chromium-review.googlesource.com/c/chromium/src/+/1006096.

The only theory I have for how this could happen is if there's a
RenderProcessHostImpl that stays stalled in the uninitialized state. This CL
updates the waiting logic in the test to match the logic being tested - to only
look at initialized RenderProcessHostImpls.

Bug: 833590
Change-Id: Ia0d49f5c569625b3ccfc01c9dd17c8e7659f105d
Reviewed-on: https://chromium-review.googlesource.com/1020071Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552150}

Bug: 815009
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If3c93fa90def4d7332d077d54efe9a8ca2c51ea3
Reviewed-on: https://chromium-review.googlesource.com/988247
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552149}

Previously, we only ran FormattedStringWithEquivalentMeaning on the full
formatted URL, but not the display (elided) URL.

This function re-appends the '/' slash character on intranet hosts so
they are not mistaken for a search term.

We want to re-append this slash character on elided URLs as well, and
this CL effects this change -- as well as adds a test for this.

Bug: 797354
Change-Id: I29a6e8a4ce2986ec3eb0c024496b00c4e1dd4b79
Reviewed-on: https://chromium-review.googlesource.com/1014482Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552148}

https://github.com/google/error-prone/releases/tag/v2.3.0

BUG=834756

Change-Id: I518ccff734904320cd8c9cb3c42b41bc2c160bf2
Reviewed-on: https://chromium-review.googlesource.com/1019343
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552147}

This reverts commit b4990829.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek: https://crbug.com/834146
Bug: 834146


Original change's description:
> vaapi: minor cleanups in VaVDA (OutputPicture, mostly)
>
> This CL is a few cleanups to ease review of crrev.com/c/986353:
>
> - PictureById() is moved to the end of the cc file, following the
>  order of its declaration. Code untouched (except s/NULL/nullptr/).
>  A call to PictureById  is substituted with base::ContainsKey()
>  to better reflect intent.
>
> - OutputPicture() loses its last parameter, that is then calculated
>  on the spot (it's |available_picture_buffers_.front()|). This makes
>  OutputCB unnecessary, so it's made a Closure, and a OnceClosure at
>  that.
>
> Test: eve crosvideo vp9 cycling resolutions.
>
> Bug: 822346
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: Ie17f23f2fb20752463e9ebeacd1bf7a9b6150437
> Reviewed-on: https://chromium-review.googlesource.com/1000297
> Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549506}

TBR=mcasas@chromium.org,hoegsberg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822346
Change-Id: If0d162b5373c33c266268d9cd82e3de5fd4e4a7e
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020003
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552146}

The PageActionCrash25562 test has been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: I56c954aebb48a469cd7a9ab5c9f916d73498d5d5
Reviewed-on: https://chromium-review.googlesource.com/1018408
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552145}

Check if the frame is an ad frame before checking the filter list.

Bug: 807640
Change-Id: Ic8a3e1e4ceca3ed64ff39895c697205d3c1477b0
Reviewed-on: https://chromium-review.googlesource.com/1018426
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552144}

Use named fields in compound literal for readability and protection
against struct layout churn.

Roll SDK to 3a1662dfbcb.

Bug: 707030
Change-Id: I1da12494cad5cd781ed02a519d68ebf1bea016f8
Reviewed-on: https://chromium-review.googlesource.com/1017301
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552143}

These tests don't work in Views mode.

TBR=tapted@chromium.org

Bug: 834908
Change-Id: I5c0fdb9043511264d8d6e4b096a66be80eeaf8bd
Reviewed-on: https://chromium-review.googlesource.com/1020082Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552142}

I say attempts because there is a chance the setup flow may fail or not
be completed.

R=hansberry@chromium.org

Bug: 831371
Test: none
Change-Id: Iecc9255433761428e8529bddaaaed78feaa602b4
Reviewed-on: https://chromium-review.googlesource.com/1020063
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552141}

BUG=None

Change-Id: I202ff884297e0bf39da8b5303213cb80463ecbbd
Reviewed-on: https://chromium-review.googlesource.com/1019568
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552140}

https://pdfium.googlesource.com/pdfium.git/+log/f24afac5e17e..54e6da1ee793

$ git log f24afac5e..54e6da1ee --date=short --no-merges --format='%ad %ae %s'
2018-04-19 thestig Do validation earlier in CPDF_SampledFunc::v_Init().
2018-04-19 thestig Validate the Range key in Functions.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I4be0a495123c63ad2aa5d32b8621bad925fe1f41
Reviewed-on: https://chromium-review.googlesource.com/1019729
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552139}

https://skia.googlesource.com/skia.git/+log/e7fd7ff0eca8..c4e384e5ad85

$ git log e7fd7ff0e..c4e384e5a --date=short --no-merges --format='%ad %ae %s'
2018-04-19 reed check if we fail to eval the conic in pathmeasure
2018-04-19 bungeman Remove unused parameters from internalGetPath.
2018-04-19 egdaniel When creating testing backendTexture take colorspace into account.
2018-04-19 kjlubick Fix Chromecast bots
2018-04-19 borenet [infra] gen_tasks: Pass internal hardware ID as a property
2018-04-18 herb Untangle strike cache and glyph cache
2018-04-19 mtklein disallow negative setReserve() calls
2018-04-19 mtklein rm SkTDArray::select()
2018-04-19 mtklein clean up setReserve() rule-bending

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Idb3436611620515d22a8cc2f47c280647b6b5417
Reviewed-on: https://chromium-review.googlesource.com/1019724Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552138}

Bug: 678127
Change-Id: I44c0ac8fecfde34ecf67ad0f74fe1d84bf7b2594
Reviewed-on: https://chromium-review.googlesource.com/924248
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552137}

This change adds a `load_timing_info` to the list of fields
in SubresourceLoadInfo.  Notably, this is important for recording
page load metrics when the Network Service is enabled.

This change also removes `request_start`, since `load_timing_info`
contains the same field.

BUG=816684

Change-Id: I3b044c160f28155d81e99c6a84598e270ba78077
Reviewed-on: https://chromium-review.googlesource.com/1005963Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552136}

The file base/mac/bind_objc_block.h only expose base::BindBlock
(and base::BindBlockArc) templated method. If the method is not
used, then the include is unnecessary and can be removed.

Automated using the following command:

  for file in $(git grep -l base/mac/bind_objc_block.h); do
    if ! grep -q BindBlock $file; then
      sed -i '' -e '/base\/mac\/bind_objc_block.h/d' $file
    fi
  done

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I678caa36de71fe055585f7b344569419519cfdcb
Reviewed-on: https://chromium-review.googlesource.com/1018487Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552135}

This reverts commit e9ea7ba4.

Reason for revert: Needed to revert other CLs that caused a
regression in video_VideoSeek: https://crbug.com/834146
Bug: 834146


Original change's description:
> vaapi: add a log when running out available va surfaces, which causes decoding fail.
>
> There is GPU hang related to RTC decoding. I guess it's because there is not
> an available va surface. This CL will prove it.
>
> BUG=b/72676160
>
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
> Change-Id: I4349d9b00f46c03210498e13d30636b752078980
> Reviewed-on: https://chromium-review.googlesource.com/999101
> Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
> Cr-Commit-Position: refs/heads/master@{#548917}

TBR=dongseong.hwang@intel.com,dcastagna@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/72676160
Change-Id: Ib5ba7e753aebd2bfc0c248664381d08659528467
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1020004
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552134}

On chromeos, if one user performs a search and logs out before the
RLZ ping is sent, and then another user logs in, performs a search and
send the ping, make the sure the first user does not also send a ping.

Bug: 820783
Change-Id: Ic3ce70bada8734e260e066d4700b3d4fa7eda887
Reviewed-on: https://chromium-review.googlesource.com/1017962Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552133}

This was caused by an erroneous manual merge in
15bbc3bf.

Bug: 783855, 834604
Change-Id: I1f821b5c86d7c11478f4430f68bce58238c1d9bc
Reviewed-on: https://chromium-review.googlesource.com/1019980Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552132}

This CL updates oop_pixeltest.cc to test OOP-R on both GLES2Decoder
and RasterDecoder. Once --enable-raster-decoder is always enabled for
--enable-oop-rasterization we can simplify and only test RasterDecoder.

Bug: 789238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4a240d23805729607aaebf33a09e9b858b691bee
Reviewed-on: https://chromium-review.googlesource.com/1019357
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552131}

To be followed up with CL rendering cards in Mash.
See bug for before/after.

Codepath:
1) AssistantBubbleView receives card event.
2) AssistantBubbleView requests rendering from AshAssistantController.
3) AshAssitantController requests rendering from AssistantCardRenderer.
4) AssistantCardRenderer renders card and fires callback with token.
5) AssistantBubbleView uses token to embed the view.
6) When card is no longer needed, AssistantBubbleView requests release.

Note: There is some overlap between this CL and
https://chromium-review.googlesource.com/c/chromium/src/+/1012197 in
passing the controller to AssistantBubbleView.

Bug: b:78078693
Change-Id: I538b6c24fd72aba6ea2d263576c2ead9630cbc83
Reviewed-on: https://chromium-review.googlesource.com/1011460
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552130}

These tests appear to be flaky accross multiple configs. See the
crbug for more information.

Also merge these expectations with a Qualcomm expectation that can
be more general.

No-Try: True
Tbr: kbr@chromium.org
Bug: 834933, 752291
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If54639a060eec63efe99247b9fac5ee1a94eff65
Reviewed-on: https://chromium-review.googlesource.com/1019874
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552129}

Bug: 785009
Change-Id: I13688afdc6cfd7c433595e31eb971cd1b288589c
Reviewed-on: https://chromium-review.googlesource.com/1018110
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552128}

TAO parsing had two issues:
* It was splitting the host values on whitespace rather than a comma. This
used to be the specified behavior, but changed in
https://github.com/w3c/resource-timing/pull/68
* When it was checking the different hosts in the host list, it was not checking
for "*" as a possible value.

This CL fixes those two issues and aligns the test expectations accordingly.

Bug: 651861, 833032, 626703
Change-Id: I8a3b7e705ed7089719ad0f52607363392c7de934
Reviewed-on: https://chromium-review.googlesource.com/1013409Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#552127}

This change removes prefs that have been deprecated for over a year.

Change-Id: Icc01ff3a4cf48452a9235e5d4e2d460d9d498ad6
Reviewed-on: https://chromium-review.googlesource.com/1019886Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552126}