- 25 Sep, 2020 40 commits
-
-
chrome://managementTina Wang authored
Added EG test to chrome://management page. Updated omniboxContainingText: matcher to avoid crash when the element is not an UITextField. Bug: 1131052 Change-Id: Ia68ad5a6071867e8ae3cf4751ce1ef792cd741dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424546Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810645}
-
Matthias Körber authored
Bug: 1099202 Change-Id: I4f756f5a228f0fdc47fbda3d50d8c0078a97a31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363760 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#810644}
-
Andrew Grieve authored
Also updates SuperSize to track the signature block size as metadata rather than a symbol so that the symbol diffs match the normalized apk size. Bug: 1130754 Change-Id: I759616f54ba8c78f0a193aae075dc8ae9ba6190c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431764 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#810643}
-
Sylvain Defresne authored
With https://crrev.com/c/2418443, the files using the sources assignment filter setting explicitly set the value. The global initialisation from build/config/BUILDCONFIG.gn is no longer needed. Bug: 1018739 Change-Id: Ic5517b196213b7b3f14c902f57c8716c8e1beea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426564 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810642}
-
Maxim Kolosovskiy authored
PasswordScriptsFetching was a part of PasswordChangeInSettings. To collect metrics, we need to enable scripts fetching also if the password change feature is disabled. If PasswordChangeInSettings is on, PasswordScriptsFetching must be on too. In order to not break experimental groups where the feature is enabled, new flag will be introduced in 3 steps: 1. Intoduce a flag that doesn't affect anything. 2. Enable the new flag for experimental groups in the Finch config. 3. Implement how the new flag affects the feature. Bug: 1108692, 1095627, 1132230 Change-Id: I3d15425143590b7538fdcdc9b8a948d705674d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428963 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#810641}
-
Matthias Körber authored
This CL fixes personal data manager tests for structured addresses. For this, the retrieval of the Autofill profile from the database must be tweaked, since the |is_client_validity_states_updated| property of the profile relies on the order the values are written to the profile. Also, street addresses with new lines, meaning that they correspond to multiple address lines, get precedence over street addresses without newlines. Change-Id: I24a57d492552a46dba892c71e69bf1ca54abbecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425054Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#810640}
-
Danyao Wang authored
Shipping and contact information functionalities are being moved out of the payment sheet. So these metrics are no longer useful. Deprecate the expired metrics and removed obsolete code. Bug: 1128111 Change-Id: Ic79fe603eff8ce4c324742fa76040ab1972d1e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427543 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810639}
-
Jesse Schettler authored
Add strings for the scanning app title and the text to display in the scanner dropdown when there are no available scanners. Bug: 1059779 Change-Id: Iaa542235a8750e7f0c551aeabb675fdb48f8d28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429288 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#810638}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 87-4183.84-1598867895-benchmark-87.0.4247.0-r1 to 87-4258.0-1600689257-benchmark-87.0.4265.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I219eee4d1a9e55f904e1f30f155ed744dc4d0c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810637}
-
Michael Checo authored
Description: * These styles are subject to change and are only for the base template. - Adds container styles to diagnostics app - Adds some styling to diagnostics-card - displays cards vertically Screenshots: - Diagnostics Page (before) http://shortn/_2lCAX0PQSg - Diagnostics Page (after) http://shortn/_h8KubnXkcH Bug: 01125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Idb17a82cbb1ccca99042872057c2979e0480ebba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425199Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Adrian Taylor authored
This will result in Chrome security bugs being automatically reported by the Vomit infrastructure for any CVEs reported against usrsctp. The version number chosen is the latest version of usrsctp known by the CVE system, which is a bit imprecise but means we should get the benefit of any disclosures against the current version of usrsctp. See https://chromium.googlesource.com/chromium/src.git/+/master/docs/adding_to_third_party.md#add-a-readme_chromium for more details. Bug: 895969 Change-Id: I389af5824aa9b99c414f78d984aeea95956d692a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427291Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#810635}
-
Leonard Grey authored
content::GetContentClient()->browser() is null in the app shim, so we currently crash when trying to fetch a default download file name. A while ago, we discussed pumping the default name through Mojo, but my thinking is that this is a lot of complexity for little gain. This change uses a blank string as the default instead of trying to fetch one from the browser if the browser is null. Empirically, in an us/en locale on macOS 10.15.6, we end up with "download.png", which is (IMO) better than the default "download" anyway. If this ends up being a problem, we can always pipe through the default later, but let's fix the crash for now. Bug: 1019128 Change-Id: I5e941511b3c479841e172a30b72bf69c2c8782f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431546 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810634}
-
Jeff Yoon authored
This is a reland of 0d501f4f. Append the disable GN arg to official_goma_mac_pgo which is used by pgo Original change's description: > [pgo/mac] disable widevine signing for Mac PGO bots > > enable_widevine_cdm_host_verification = false was missing from > GN args for PGO Mac bots, which is causing build failures. > > Bug: 1128810 > Change-Id: I2ccd1db80e80fd983e5f4ef0bd63908281557a04 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425846 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809877} Bug: 1128810 Change-Id: I20ebdcecaf0e475abe7f91d02b0387383a7f5c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427208Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810633}
-
Jan Wilken Dörrie authored
TBR=myy Bug: 1132259 Change-Id: I0b26ee8ca04e1224983c9b0cfb9b9bede564a84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431224Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Collin Baker authored
Bug: 949535 Change-Id: Idc1674c633c873ef69c577915bba03b197dd4659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426345 Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
-
Josh Nohle authored
The following changes to //chrome/services/sharing/nearby/platform_v2/ were necessary to support this uprev: (1) BluetoothClassicMedium::FindRemoteDevice() was changed to BluetoothClassicMedium::GetRemoteDevice(). (2) The argument |fast_advertisement_service_uuid| was added to BleMedium::StartScanning() but was not used therein. Bug: 1132108 Change-Id: I54f7e508cecdf3f611f0ecbed22041c065fe73d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430293 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#810630}
-
Peter E Conn authored
This should make it easier for developers to figure out what is going wrong when their Trusted Web Activity isn't working. Change-Id: I55e4ee8c52ebf82f195a568c9f5ce8702ba1c8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429408Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#810629}
-
Mohamed Heikal authored
All proto source files listed in a java_proto_library gn target soon must explicitly specify a java package. Fix proto files in ToT before we enable enforcement. Bug: 1114836 Change-Id: I9453b9fbe94b3a65517708cdaef564daef4494c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427364Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#810628}
-
Ali Juma authored
This updates the expiry of three histograms: -IOS.WKWebViewClobberedHistory -IOS.CommittedURLMatchesCurrentItem -IOS.CommittedNavigationHasContext These bugs that these histograms watch for are still occurring in the wild. Once these bugs are fixed in WebKit, these histograms and associated workarounds can be removed. Bug: 1063892,1088880,1097825 Change-Id: I13f8cec87e1ed02bbc16e8653b3db7958d6a1f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430104Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#810627}
-
Peter Beverloo authored
** Histograms that have been removed as they weren't being used. GCM.DataMessageBurstReceivedInterval GCM.ReceivedDataMessageBurstSize ** Histograms extended to M90 because they continue to be relevant or otherwise important for (new) users of the feature. GCM.IncomingSendError InstanceID.GetToken.RequestStatus Notifications.Android.SitesChannel Notifications.Windows.ActivationStatus Notifications.Windows.DisplayStatus Notifications.Windows.GetSettingPolicy Notifications.Windows.SetReadyCallbackStatus2 Notifications.Windows.StartMenuShortcutStatus ** Histograms that have been moved to never expire, as they'll continue to be monitored and used for debugging in their area. GCM.Crypto.DecryptMessageResult GCM.PendingConnectionEventsAtShutdown Notifications.AppNotificationStatus Notifications.UsingNativeNotificationCenter ** Histograms that'll be extended to M90 as they are performance metrics, in an area where work is actively going on. Notifications.Database.ReadResult Notifications.Database.WriteResult Notifications.PersistentWebNotificationClickResult Notifications.PersistentWebNotificationCloseResult PushMessaging.DeliveryStatus.FindServiceWorker ** Histograms that'll be extended to M90 because this is an evolving area, particularly with on-going activity for Googlers. Notifications.Android.JobStartDelay Notifications.Freedesktop.Capabilities.ActionIcons Notifications.Freedesktop.Capabilities.Actions Notifications.Freedesktop.Capabilities.Body Notifications.Freedesktop.Capabilities.BodyHyperlinks Notifications.Freedesktop.Capabilities.BodyImages Notifications.Freedesktop.Capabilities.BodyMarkup Notifications.Freedesktop.Capabilities.IconMulti Notifications.Freedesktop.Capabilities.IconStatic Notifications.Freedesktop.Capabilities.Persistence Notifications.Freedesktop.Capabilities.Sound Notifications.PersistentNotificationActionCount Bug: 1089724, 1088802, 1088803, 1088868, 1089109 Bug: 1089110, 1089113, 1089114, 1089115, 1089116 Bug: 1089117, 1089335 Change-Id: I875333ef58cc60ca24d25b180efa2c62cf5d8994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421677Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#810626}
-
Jan Wilken Dörrie authored
This change replaces usages of autofill::PasswordForm with password_manager::PasswordForm in the file range password_[acc...list] in the //components/password_manager/core/browser directory. Bug: 1067347 Change-Id: I6e6a17cdc86a2291249be14cdfdd2453c2372e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429035 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#810625}
-
Jan Wilken Dörrie authored
TBR=johntlee Bug: 1132300 Change-Id: Ife089507d6c0e850f8cdfbcb11dcbebe4193f945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431964Reviewed-by:
-
Owen Min authored
In chrome.enterprisePrivate APIs, we use base::ThreadPool::PostTask in few places. Unlike PostTaskAndReply, the callback is not posted on the original thread. It causes CalledOnValidSequence check failure as we returns the extension APIs on a different thread. Fix the issue by remembering the original task runner to make sure the extension APIs are responded in the main thread. Change-Id: If3b69d56a0d8afc4c89da8104ddb24cceb07173e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429544 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#810623}
-
Stepan Khapugin authored
Removes the final method from main controller guts. Bug: 1045659 Change-Id: I4b04c70e49f8abbac0f3c933da301b21a11340aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421650 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#810622}
-
Titouan Rigoudy authored
This extracts various computations of the response address space spread out around third_party/blink/renderer to content/renderer/loader. It prepares for moving that computation to services/network, alongside the CORS-RFC1918 checks that compute the authoritative version of response's address space. This also enables easily extending the current UseCounters in MixedContentChecker to cover the private-embedded-in-public case. Bug: chromium:955213, chromium:1124358 Change-Id: I92642c2da8c062a51afd1fb6a783b164c4cd904b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424083 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#810621}
-
Nina Satragno authored
Disable ProfileProviderRealCollectionTest.OnJankStopped. It's flaky on chromeos-amd64-generic-rel. Bug: 1132045 Tbr: gmx@chromium.org Change-Id: I3a84cfb16083b1b7075e6e1d545e723e62475ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429607Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#810620}
-
David Bertoni authored
This test was disabled long ago as a result of a bad Webkit roll and should have been re-enabled once that was resolved. I fixed it and checked it for flakiness. Change-Id: Ib8beac45cb3cda804d5652936e84faac0d1f4b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414915Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810619}
-
Hidehiko Abe authored
This reverts commit 55942750. Reason for revert: The fix was submitted (crrev.com/2428265). Original change's description: > Revert "chromeos: Set is_linux to false." > > This reverts commit 3742fb2f. > > Reason for revert: builder failure crbug.com/1131947 > > Original change's description: > > chromeos: Set is_linux to false. > > > > Bug: 1110266 > > Test: Built locally. > > Change-Id: I291f594060beed19d8497c5d6b7689effbe3dc9c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413458 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#810162} > > TBR=thakis@chromium.org,hidehiko@chromium.org > > Change-Id: I710cbf3c96f26a1e5e9f22617443348ea249984c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1110266 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429364 > Reviewed-by: Dan H <harringtond@chromium.org> > Commit-Queue: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810231} TBR=thakis@chromium.org,hidehiko@chromium.org,harringtond@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1110266 Change-Id: Iabfbbb6da8b60c6057a95e25f472ee8c7a54b4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428493Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601013503-f7b4ef4ea11cbf75355e6e56711fd1614dd080c3.profdata to chrome-linux-master-1601034748-03f3a1d8372e4cec2560424c34442e7c7e8238b8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I6054d6e3b1824e99b065d1c10fa03f6240806149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431324Reviewed-by:
-
Sharon Yang authored
Change-Id: Ie3e45813d92bab7fba0a431a4c6110c35d2931c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427587 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810616}
-
Jan Wilken Dörrie authored
TBR=lushnikov Bug: 1132296 Change-Id: I916767c3d8d25f123805289f2e9efb2dfc9b2a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431884Reviewed-by:
-
Sahel Sharify authored
Bug: 1130343 Change-Id: I07031ec0347d86abcc2c0cd7cc10ba09627bd8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422783Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810614}
-
James Cook authored
This reverts commit 422d1749. Reason for revert: Broke Chrome OS code search bot https://ci.chromium.org/p/infra/builders/codesearch/codesearch-gen-chromium-chromiumos/8920 Log from good revision to bad one: https://chromium.googlesource.com/chromium/src/+log/efb1ca9d03b346aedf67f671dca657c6af147888..6e88c372eccc90ba2353773727e94e97dc9abc64 Original change's description: > lacros: Move lacros app id prefix to a shared constants file > > The ID prefix is shared between the Wayland client code in Lacros and > the Wayland server code in ash, so share the constant. > > Bug: none > Change-Id: If62550c447670e553a854ce1092cfd3d7d9aacff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427546 > Reviewed-by: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810277} TBR=jamescook@chromium.org,tonikitoo@igalia.com Change-Id: I227d6770b7f301cf22b10c242fcbfe490d130fe9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432084Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#810613}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601013503-1a040f21faaa1854749ef6dccdae69339bbb905f.profdata to chrome-mac-master-1601034748-5f32abe1706fc69f825acfb2aace1a93eeb5474f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: Ic24173049536e39ab8d622a32224e68f64f25a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431327Reviewed-by:
-
Prashant Nevase authored
Using blink side dark mode for images, it is hard to implement caching mechanism for partially loaded bitmap image content, as content id for the image frame being rendered gets decided during rastering only. So caching of dark mode result will be deferred until default frame is completely received. This will help get correct classification results for incremental content received for the given image. Bug: 944413 Change-Id: I19f1a604659e3d9f52458c334824838cfa862d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428297Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#810611}
-
Frédéric Wang authored
Experimental font-size: scriptlevel(...) syntax was implemented in [1]. This CL updates it to match what was agreed with the CSSWG [2] as well as new WPT tests [3]: - Split scriptlevel(...) into math-depth: ... and font-size: math. - Rename auto to auto-add This CL also updates the MathML UA stylesheet to use the new syntax. To compute font-size, one need the inherited math-style and the inherited/computed math-depth. So math-style does not need to be High priority. Additionally Blink computes the High priority alphabetically, so math-depth must be handled specially. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2184131 [2] https://github.com/w3c/csswg-drafts/issues/5389 [3] https://github.com/web-platform-tests/wpt/pull/25694 Bug: 6606, 1023292 Change-Id: I8a5bf245fa6158633261ed167800fc5feb0c3564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423843 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#810610}
-
Allen Bauer authored
Bug: 938501, 1130078 Change-Id: I04cf5751b0e3852ca02f456c2625a6b6bb815783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425106 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#810609}
-
Dylan Cutler authored
This API is suspected to leak cross-site entropy about users. This instrumentation reports digests of the values read using this API to UKM to determine the available entropy of the API for identifying users across sites. Bug: 973801 Change-Id: If16a73d332e07cdcf3067afb53017d08091bb9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424636 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#810608}
-
Asanka Herath authored
As a nice side-effect identifiable_surface.h becomes more portable. Bug: 973801 Change-Id: I4e7dbcc931e1f6ecd47f27a68ff0b8bc067f40ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430485 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#810607}
-
Chris Fredrickson authored
This reverts commit 542cedb8. Reason for revert: We'd prefer to instrument the navigator.enumerateDevices method, instead of each individual MediaDeviceInfo object. Original change's description: > Instrument access to MediaDeviceInfo data. > > This cl causes the bindings generator to automatically collect UKM when > these attributes are accessed. This will be used to analyze how much > entropy leaked by this API can be used for cross-site tracking. > > Bug: 973801 > Change-Id: I29ea7ee1796c8152cab9f004229282b1b728b173 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421638 > Commit-Queue: Chris Fredrickson <cfredric@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809847} TBR=kinuko@chromium.org,cfredric@google.com Change-Id: Ib165710d1b3f81cee6a4f803e0fb154323c97272 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427325Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#810606}
-
