GitLab

BUG=695635

Review-Url: https://codereview.chromium.org/2844133003
Cr-Commit-Position: refs/heads/master@{#468288}

The 'motion-offset' property has been replaced by 'offset-distance'.

'motion-offset' is among the properties disabled in M58.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ

BUG=711937

Review-Url: https://codereview.chromium.org/2841863005
Cr-Commit-Position: refs/heads/master@{#468287}

TBR=emaxx@chromium.org
BUG=716727

Review-Url: https://codereview.chromium.org/2852933002
Cr-Commit-Position: refs/heads/master@{#468286}

TBR=benwells@chromium.org
BUG=716726

Review-Url: https://codereview.chromium.org/2849073003
Cr-Commit-Position: refs/heads/master@{#468285}

Recently imported
external/wpt/WebCryptoAPI/generateKey/test_successes_RSA-OAEP.https.html
is occasionally timing out, so adding to TestExpectations.

TBR=eroman@chromium.org
BUG=716729

Review-Url: https://codereview.chromium.org/2852923002
Cr-Commit-Position: refs/heads/master@{#468284}

This adds tests to PermissionDialogTests that test Media requests with
the kUsePermissionManagerForMediaRequests feature enabled. When this
feature is enabled, media permissions can be requested in the same way
as other permissions.

Once the feature flag is removed, the old behavior that is being tested
can also be removed.

BUG=596786

Review-Url: https://codereview.chromium.org/2838873004
Cr-Commit-Position: refs/heads/master@{#468283}

IndexedDBBrowserTest.CursorTestIncognito is flaky on
linux_android_rel_ng.

TBR=jsbell@chromium.org
BUG=716728

Review-Url: https://codereview.chromium.org/2853753002
Cr-Commit-Position: refs/heads/master@{#468282}

This CL fixes an issue where drag and drop wouldn't work on Mac because
the drop data was being cleared by the bookmark manager API's drop
handler before the bookmark manager's handler had handled the drop. This
has been fixed by adding a setTimeout to clearing the data, which was
also in the old bookmark manager, giving the bookmark manager a chance
to deal with the drop.

BUG=716257
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2845243003
Cr-Commit-Position: refs/heads/master@{#468281}

added a headlessresourcedispatcherhostdelegate so that we do not crash when a website requests a client cert store

BUG=714534

Review-Url: https://codereview.chromium.org/2852633002
Cr-Commit-Position: refs/heads/master@{#468280}

When we generate ComputedStyle, we differentiate between properties
(which are meant to correspond to CSS properties) and nonproperties
(everything else). However, this terminology is confusing:

- Some nonproperties are derived from real CSS properties (e.g.
  hasSimpleUnderline).
- The generator code contains a lot of "for property_ in nonproperties"
  which is quite confusing.
- The name does not reveal the actual difference between properties
  and nonproperties in terms of code generation.

This patch removes the field role of 'nonproperty' in favour of the
parameter 'has_custom_compare_and_copy'. So there are only two field
roles: 'property' (which includes flags like 'unique' and 'emptyState')
and 'inherited_flag'.

BUG=628043

Review-Url: https://codereview.chromium.org/2830983003
Cr-Commit-Position: refs/heads/master@{#468279}

Clusterfuzz found a sample where
CompositeEditCommand::MoveParagraphWithClones() moves |before_paragraph|
out of the DOM tree after moving the paragraph. This patch uses
RelocatablePosition to track |before_paragraph| and |after_paragraph| so
that the positions we track are always connected.

Note: CompositeEditCommand::MoveParagraphs() is already using
RelocatablePosition to track positions before and after the moved
paragraphs.

BUG=712510
TEST=ApplyBlockElementCommandTest.IndentHeadingIntoBlockquote

Review-Url: https://codereview.chromium.org/2850773003
Cr-Commit-Position: refs/heads/master@{#468278}

This patch prunes some call sites of the deprecated function to improve
code health. The change is safe because layout has been updated a few
lines before each call site.

BUG=698633
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2847813005
Cr-Commit-Position: refs/heads/master@{#468277}

Add a reftest using an additional axis VM2B in the variabletest_box
font. The VM2B axis shifts the mark anchor to the left, leading to the
combining mark below box shifting right when the axis parameter is
adjusted from 0 to 1000. As the reference in the ref test, the font now
contains two additional glyphs N and O, which have fixed base anchors at
the middle and right position. A rendering of the M character showing
"m2b pos", followed by COMBINING SQUARE BELOW with VM2B 0, 500, 1000
applied must thus be equal to renderings of the N and O glyph with no
VM2B variation values applied.

BUG=693065
R=behdad, kojii

Review-Url: https://codereview.chromium.org/2850743002
Cr-Commit-Position: refs/heads/master@{#468276}

This CL resolves TODO(kouhei) in ScriptModuleResolverImpl to rethrow instantiation error when
resolved module has failed to instantiate.

TEST=ScriptModuleResolverImplTest.ResolveInstantiationFailedModule
BUG=594639

Review-Url: https://codereview.chromium.org/2837253002
Cr-Commit-Position: refs/heads/master@{#468275}

SharedWorkerRepositoryClientImpl implements classes defined in public/web/
(WebSharedWorkerConnectListener, WebSharedWorkerRepositoryClient) so it is being
moved to core/exported.

SharedWorkerRepositoryClientImpl.cpp did include WebLocalFrameImpl but luckily
enough didn't use it so we could just break this dependency.

BUG=708879

Review-Url: https://codereview.chromium.org/2833693002
Cr-Commit-Position: refs/heads/master@{#468274}

Add @RetryOnFailure annotation for
testVisualStateCallbackNotCalledAfterRendererGone

TBR=tobiasjs@chromium.org
BUG=716763

Review-Url: https://codereview.chromium.org/2851133002
Cr-Commit-Position: refs/heads/master@{#468273}

which are only called from one place:

  RecordAndCloseSessionOnError
  CloseSessionOnErrorInner

Review-Url: https://codereview.chromium.org/2849823005
Cr-Commit-Position: refs/heads/master@{#468272}

Cr-Commit-Position: refs/heads/master@{#468271}

When the Chrome installation has a brand code, the SettingsResetPromptModel may try to fetch default settings over the network. If the fetch fails, the ProfileResetter is passed a null pointer and any attempt to reset a setting will crash.

BUG=716372

Review-Url: https://codereview.chromium.org/2852883002
Cr-Commit-Position: refs/heads/master@{#468270}

TEST=run_compiler
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846783006
Cr-Commit-Position: refs/heads/master@{#468269}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937

Review-Url: https://codereview.chromium.org/2847353002
Cr-Commit-Position: refs/heads/master@{#468268}

- NSS/ClientCertStoreTest/CertAuthorityFiltering
- DeviceDescriptionServiceTest.TestCleanUpCacheEntries

BUG=716730,716810
TBR=mattm@chromium.org,zhaobin@chromium.org

Review-Url: https://codereview.chromium.org/2850083002
Cr-Commit-Position: refs/heads/master@{#468267}

This CL adds SwapMetricsObserver which records swap rates and reports
them as platform-specific metrics. The purpose of adding these metrics
is to measure the impact of actions we take to free up memory. If we
aggressively free up memory under high memory pressure, we may touch
pages which are already swapped out (or compressed). In such cases
thrashing could happen and we are making the situation worse.
Swap rates and page compression/decompression rate would be good
indicators of thrashing. Metrics will be recorded every 60 seconds.

This CL only adds metrics for Android/ChromeOS/Linux. Follow-up CLs
will add them for macOS.

BUG=617492

Review-Url: https://codereview.chromium.org/2824133002
Cr-Commit-Position: refs/heads/master@{#468266}

This CL adds a feature flag which, when enabled, causes media requests to call
into PermissionManager::RequestPermissions in order to display a permission
prompt (among other things). The feature flag is added because this results in
the UI changing, and also won't work on Android until we have unified the
permission request codepaths (see https://crbug.com/606138).

BUG=596786

Review-Url: https://codereview.chromium.org/2829123003
Cr-Commit-Position: refs/heads/master@{#468265}

This CL fixes a regression since r467828. It changed the working directory, but
it missed to update relative path in "git add" argument.

BUG=710535
TBR=jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2848183002
Cr-Commit-Position: refs/heads/master@{#468264}

Revert of Change ScopedFeatureList to overrides FeatureList not reset (patchset #6 id:140001 of https://codereview.chromium.org/2834583002/ )

Reason for revert:
Mac ASAN bots reporting use-after-free errors.

Original issue's description:
> Change ScopedFeatureList to overrides FeatureList not reset
>
> The current situation is that using ScopedFeatureList resets to an
> empty feature list and then enables/disables an explicit list of
> features.
>
> That's never what you want for browser tests (or other higher-level
> tests) since it effectively overrides higher-level test configurations
> (e.g. those in fieldtrial_testing_config.json, or a bot set up to
> specifically test a feature).
>
> In this patch:
>
> 1. Keep SFL::Init, SFL::InitWithFeatureList,
>    SFL::InitFromCommandLine reset to empty list but add warning to
>    remind developer should use them with care.
> 2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
>    SFL::InitWithFeatures to not reset but override current FeatureList
>    with given enables/disables.
>
> We also add unit tests for ScopedFeatureList.
>
> BUG=713390
>
> Review-Url: https://codereview.chromium.org/2834583002
> Cr-Commit-Position: refs/heads/master@{#468210}
> Committed: https://chromium.googlesource.com/chromium/src/+/9c04ed553bd7abe820a6a93c5e8981e6738881a9

TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,chaopeng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713390

Review-Url: https://codereview.chromium.org/2850073002
Cr-Commit-Position: refs/heads/master@{#468263}

1. A local variable |copied_files| is never read. Remove it.
2. So, copy_file() needs to return nothing.
3. Then, _webkit_root is removable.

Review-Url: https://codereview.chromium.org/2852673003
Cr-Commit-Position: refs/heads/master@{#468262}

BUG=710535

Review-Url: https://codereview.chromium.org/2848853002
Cr-Commit-Position: refs/heads/master@{#468261}

It can be replaced with path_from_tools_scripts().

BUG=710535

Review-Url: https://codereview.chromium.org/2849743003
Cr-Commit-Position: refs/heads/master@{#468260}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dabd7bd5..489561d2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2853703002
Cr-Commit-Position: refs/heads/master@{#468259}

The 'offset-rotation' property has been replaced by 'offset-rotate'.

'offset-rotation' is among the properties disabled in M58.

The runtime flag to conditionally enable 'offset-rotate' is also
being retired, as offset-rotate has shipped.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/FgU5o52yBAAJ

BUG=711937

Review-Url: https://codereview.chromium.org/2842933003
Cr-Commit-Position: refs/heads/master@{#468258}

See: https://github.com/KhronosGroup/WebGL/issues/2274

BUG=714240
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2821363003
Cr-Commit-Position: refs/heads/master@{#468257}

R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2851953003
Cr-Commit-Position: refs/heads/master@{#468256}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4aa32418..dabd7bd5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2851853005
Cr-Commit-Position: refs/heads/master@{#468255}

https://skia.googlesource.com/skia.git/+log/135c90881287..0c5cf5d7a260

$ git log 135c90881..0c5cf5d7a --date=short --no-merges --format='%ad %ae %s'
2017-04-30 update-skps Update SKP version

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I88d87a480e2ee4f590bfa952f3121b206e613ab7
Reviewed-on: https://chromium-review.googlesource.com/491069Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468254}

BUG=714672

Review-Url: https://codereview.chromium.org/2846703004
Cr-Commit-Position: refs/heads/master@{#468253}

BUG=714191

Review-Url: https://codereview.chromium.org/2831183004
Cr-Commit-Position: refs/heads/master@{#468252}

Discover process:
  DialMediaSinkService.Start() registers itself with DialRegistry
  DialMediaSinkService.OnDialDeviceEvent() gets invoked when device data comes back, and starts a 3s timer
  Start description fetches for each device
  DeviceDescriptionService.OnDeviceDescriptionFetchComplete() gets invoked when device description comes back.
  Starts an XML parser in utility process to parse device description XML
  DialMediaSinkService.OnDeviceDescriptionAvailable() gets invoked when parsing in utility process finishes
  Create MediaSinkInternal and store it in DialMediaSinkService's sink map
  Invoke DialMediaSinkService.FetchCompleted() when timer expires

Design doc:

https://docs.google.com/document/d/1lJbE4Oc9q1amkWEaD2ZL4mHEdRRlKHvwxUUcJmNC8b8/edit#heading=h.ur85je1upm9u

BUG=687375

Review-Url: https://codereview.chromium.org/2701633002
Cr-Commit-Position: refs/heads/master@{#468251}

Cr-Commit-Position: refs/heads/master@{#468250}

Revert of Reland "[Chromecast] Use base::FeatureList to control features." (patchset #4 id:60001 of https://codereview.chromium.org/2836263003/ )

Reason for revert:
Breaks ATV at runtime.

Original issue's description:
> Reland "[Chromecast] Use base::FeatureList to control features."
>
> This feature was reverted due to the new browsertest being flaky on
> internal Cast infrastructure: crrev.com/2838813003
>
> === Original Commit Message ===
> In Chromium, Finch-enabled features are controlled through base::FeatureList,
> a class which abstracts the experiment framework and developer overrides
> from client code. Though Chromecast's experiment framework is fundamentally
> different (in that it is server-driven) Cast builds can still make use of
> this class. Introduce some utilities to help.
>
> At boot-up, the pref store will be queried for experiment configs, which
> were cached to disk on the most recent config fetch from the last boot
> cycle. If a developer overrides these features from the command line,
> that value takes precedence. These features will be used to initialize
> base::FeatureList, which can then be statically queried from any client
> code that depends on //base.
>
> This patch does not actually introduce or convert any existing features
> to use this framework.
>
> BUG=714291
> BUG= internal b/35424335
>
> Review-Url: https://codereview.chromium.org/2836263003
> Cr-Commit-Position: refs/heads/master@{#467998}
> Committed: https://chromium.googlesource.com/chromium/src/+/aab6bf24d32d931359b2d0c25fb39b3ed51fbc86

TBR=maclellant@chromium.org,halliwell@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=714291

Review-Url: https://codereview.chromium.org/2847423002
Cr-Commit-Position: refs/heads/master@{#468249}