GitLab

ContextClient is more lightweight than ContextLifecycleObserver.
Classes that don't override contextDestroyed should use ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2607533002
Cr-Commit-Position: refs/heads/master@{#440822}

[SPInvalidation] Call layoutView->setNeedsPaintPropertyUpdate in FrameView::setNeedsPaintPropertyUpdate() when RLS is enabled

BUG=645667
TEST=Many test cases in webkit_unit_tests with RLS enabled with --enable-slimming-paint-invalidation

Review-Url: https://codereview.chromium.org/2603703002
Cr-Commit-Position: refs/heads/master@{#440821}

BUG=579229
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2600603002
Cr-Commit-Position: refs/heads/master@{#440820}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/70bee166..cf7481bd

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2603883002
Cr-Commit-Position: refs/heads/master@{#440819}

Update the interface for CTVerifier to use a base::StringPiece
for the OCSP and TLS SCT extension, rather than an std::string.
By allowing this to be zero-copy from the underlying SSL* that
stores this information, this allows pruning the ocsp_response_
member from SSLSocketImpl, which can save an extra 2K-12K per
socket for those that staple OCSP responses, and eliminate an
extra copy for the CT information.

As this required touching every CTVerifier-derived class, this
also fixes the API wart that crept in regarding
CTVerifier::Verify() having a return code. As the actual
verification of policy compliance is handled not by CTVerifier
but by CTPolicyEnforcer, there's no actual status code to return
from CTVerifier. To make future cleanups easier, and to align the
API and implementations for consistency, this also replaced the
various stub verifiers that grew with explicit
DoNothingCTVerifiers that skip all parsing entirely.

BUG=571203
TBR=sergeyu@chromium.org

Review-Url: https://codereview.chromium.org/2604513002
Cr-Commit-Position: refs/heads/master@{#440818}

cancel-and-start-new.html is now a testharness test.

We don't check the property value at a precise time, instead we verify
that a transition is occurring.

BUG=248938

Review-Url: https://codereview.chromium.org/2588313002
Cr-Commit-Position: refs/heads/master@{#440817}

Currently, the argument validation and and argument conversion happens
in a single step. This is good for the case when we need the JSON
serialized arguments, but in the case of custom JS hooks, the work is
unnecessary. However, we still need to match arguments to a signature
in that case.

Add another method to allow for matching, but not converting, the
arguments, and use it when we have a handle request JS hook.  This is
in line with what the curent JS implementation does, and thus what our
custom bindings expect.

We also need to add support for parsing arguments that are functions,
since we are now validating for requests with custom handlers (which
can have functions as arguments other than callbacks).

Add a test that invoking a method with a custom binding with an invalid
invocation throws an error.

BUG=653596

Review-Url: https://codereview.chromium.org/2583273002
Cr-Commit-Position: refs/heads/master@{#440816}

The sync (i) icon in the top-right of the page uses the iron-dropdown
Polymer element to display its content. This element was implicitly
imported by cr-shared-menu, meaning that after cr-shared-menu was
removed (in crrev.com/440308) from the history page, the dropdown
stopped working.

This CL restores the import of iron-dropdown, fixing the dropdown.

BUG=658821
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2594303002
Cr-Commit-Position: refs/heads/master@{#440815}

BUG=None
TBR=marq@chromium.org

Review-Url: https://codereview.chromium.org/2604853003
Cr-Commit-Position: refs/heads/master@{#440814}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/26758366..70bee166

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2604903002
Cr-Commit-Position: refs/heads/master@{#440813}

This will allow different schedulers to write to different histograms.

BUG=

Review-Url: https://codereview.chromium.org/2590013002
Cr-Commit-Position: refs/heads/master@{#440812}

BUG=655203

Review-Url: https://codereview.chromium.org/2562193002
Cr-Commit-Position: refs/heads/master@{#440811}

Revert of Tab (and AuraWindow) Capture: Capture refresh frame after Resume() (patchset #2 id:20001 of https://codereview.chromium.org/2603533002/ )

Reason for revert:
Speculative revert because WebContentsVideoCaptureDeviceTest.StopWithRendererWorkToDo is crashing with media::ThreadSafeCaptureOracle calling CopyRGBToVideoFrame.

https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56009

Original issue's description:
> Tab (and AuraWindow) Capture: Capture refresh frame after Resume()
>
> Adds a refresh frame capture upon Resume(). This solves a problem where
> the tab capture device can be suspended for a significant length of time
> and then resumed; but if the content of the tab isn't changing when the
> resume takes place, no compositor events will be firing to cause any new
> frames to be captured. Thus, the content in the video stream could be
> very stale. Issuing a refresh frame capture guarantees the video stream
> will be up-to-date immediately after a resume.
>
> BUG=643964
>
> Review-Url: https://codereview.chromium.org/2603533002

TBR=xjz@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=643964

Review-Url: https://codereview.chromium.org/2604833003
Cr-Commit-Position: refs/heads/master@{#440810}

BUG=579229

Review-Url: https://codereview.chromium.org/2599153002
Cr-Commit-Position: refs/heads/master@{#440809}

GetIndexForOffset() should decrease resulting index by 1 for pending
transient items to allow going back from interstitials that were added
to the middle of the stack.

BUG=677190

Review-Url: https://codereview.chromium.org/2600263002
Cr-Commit-Position: refs/heads/master@{#440808}

BUG=

Review-Url: https://codereview.chromium.org/2582173002
Cr-Commit-Position: refs/heads/master@{#440807}

The animations potentially slow down shutdown, without providing positive
utility.

BUG=571908

Review-Url: https://codereview.chromium.org/2598393003
Cr-Commit-Position: refs/heads/master@{#440806}

BUG=615156
NOTRY=true

Review-Url: https://codereview.chromium.org/2607643002
Cr-Commit-Position: refs/heads/master@{#440805}

Debug builds of ipc_perftests on Windows take multiple minutes to run
which makes them unwieldy and complicates investigating debug-only test
failures.

BUG=677202

Review-Url: https://codereview.chromium.org/2603753004
Cr-Commit-Position: refs/heads/master@{#440804}

BUG=None

Review-Url: https://codereview.chromium.org/2600153003
Cr-Commit-Position: refs/heads/master@{#440803}

Does a few interesting things:

- Teaches Catalog how to load its data from a static dictionary in memory
- Adds GNI for generating catalog manifest JSON
- Adds a catalog of common mash services
- Deletes mojo_runner
- Introduces //mash/runner (executable "mash") which does the same thing
  mojo_runner did, but has baked-in knowledge of the mash catalog.

BUG=677194
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2573283002
Cr-Commit-Position: refs/heads/master@{#440802}

Revert of Fixed a bug where chrome crash omits crash time stamp after it's sent. (patchset #1 id:1 of https://codereview.chromium.org/2568953003/ )

Reason for revert:
See crbug.com/674249: This change broke things in two ways:
- The string format incorrectly uses the crash-time parameter twice, rather than the second parameter coming from upload-time.
- The string format assumes that all crashes have a valid crash-time, which is not the case for Breakpad reports.

Original issue's description:
> Fixed a bug where chrome crash omits crash time stamp after it's sent.
>
> This cl patches in the solution devised by phistuck@gmail.com. See bug 664430 for detail.
>
> BUG=664430
>
> Committed: https://crrev.com/d8027b2065994c2a5b8cbea2821971dc60b7c6f5
> Cr-Commit-Position: refs/heads/master@{#438333}

TBR=rsesek@chromium.org,jiameng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664430

Review-Url: https://codereview.chromium.org/2601853002
Cr-Commit-Position: refs/heads/master@{#440801}

BUG=579229

Review-Url: https://codereview.chromium.org/2606553002
Cr-Commit-Position: refs/heads/master@{#440800}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b8939070..26758366

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2598373003
Cr-Commit-Position: refs/heads/master@{#440799}

BUG=579229

Review-Url: https://codereview.chromium.org/2606563002
Cr-Commit-Position: refs/heads/master@{#440798}

Only AcceleratedStaticBitmapImages can be texture backed, and they
already override the method to return true.  No need for a default
baseclass impl beyond return false.

Also constify.

R=junov@chromium.org,ccameron@chromium.org

Review-Url: https://codereview.chromium.org/2588103002
Cr-Commit-Position: refs/heads/master@{#440797}

didCommitNavigation: crashes if NavigationManager is empty. This new
CHECK crashes if MN is empty and |didStartProvisionalNavigation| was
called.

If this CHECK is hit it means that |didStartProvisionalNavigation| was
called as expected but it did not call |registerLoadRequest|. If that's
the case then |didStartProvisionalNavigation| needs to be changed to
always call |registerLoadRequest| if MN is empty.

BUG=676458

Review-Url: https://codereview.chromium.org/2596243003
Cr-Commit-Position: refs/heads/master@{#440796}

Now check visualRect() instead of creating PaintInvalidationStates.

BUG=646176

Review-Url: https://codereview.chromium.org/2599363002
Cr-Commit-Position: refs/heads/master@{#440795}

This CL makes revalidation-related CHECK()s in RawResource::didAddClient()
cleaner and enables us to identify how revalidation is actually started as
the crash stack trace of Resource::setRevalidatingRequest().

BUG=640291, 648945

Review-Url: https://codereview.chromium.org/2607623002
Cr-Commit-Position: refs/heads/master@{#440794}

BUG=579229

Review-Url: https://codereview.chromium.org/2599373002
Cr-Commit-Position: refs/heads/master@{#440793}

Adds a refresh frame capture upon Resume(). This solves a problem where
the tab capture device can be suspended for a significant length of time
and then resumed; but if the content of the tab isn't changing when the
resume takes place, no compositor events will be firing to cause any new
frames to be captured. Thus, the content in the video stream could be
very stale. Issuing a refresh frame capture guarantees the video stream
will be up-to-date immediately after a resume.

BUG=643964

Review-Url: https://codereview.chromium.org/2603533002
Cr-Commit-Position: refs/heads/master@{#440792}

Walking inheritance chain of a type is not a reliable renaming decision
signal, because it depends too much on unrelated/fragile context.  For
example - walking the inheritance chain might not be possible if a class
is forward declared, but would be possible if full class definition is
available.  Consequently, walking the inheritance chain can lead to
making two different renaming decisions for the same file location (the
interesting "Framame" bug).

OTOH, finding the base method being overriden is 1) reliable and 2) is
required to avoiding generating 2 different renames of a method name in
base VS derived class.  Considering the method being overriden is the
approach that this CL switches to.

Known cases that 1) need a "Get" prefix and 2) would have regressed
after this CL are 3) covered by adding them to the hardcoded list in
ShouldPrefixFunctionName.

BUG=673031

Review-Url: https://codereview.chromium.org/2601513005
Cr-Commit-Position: refs/heads/master@{#440791}

We remove the following hidden elements that will never be visible
due to the fact that script execution is disable in MHTML loading:
1) Any DOM element has hidden attribute
2) Input element has hidden type

BUG=669325
TEST=new tests added

Review-Url: https://codereview.chromium.org/2538953002
Cr-Commit-Position: refs/heads/master@{#440790}

For the Web Bluetooth chooser string constants on Android,
IDS_BLUETOOTH_SEARCHING and IDS_BLUETOOTH_NOT_SEEING_IT are the same.
IDS_BLUETOOTH_NOT_SEEING_IT_IDLE_NONE_FOUND and
IDS_BLUETOOTH_NOT_SEEING_IT_IDLE_SOME_FOUND are the same.

This CL removes the duplicate strings.

BUG=675723

Review-Url: https://codereview.chromium.org/2590663002
Cr-Commit-Position: refs/heads/master@{#440789}

This CL is a follow up to crrev.com/2543523002. It routes certificate reports
through CertificateReportingService instead of SafeBrowsingPingManager.

Reporting code in SafeBrowsingPingManager isn't removed yet. This is done
in https://crrev.com/2578873003

Background:
The main feature is to retry uploads of invalid SSL certificate reports.
Currently, the reports are uploaded only once when the user sees an SSL error.
This isn't always sufficient though, as the user might be behind a captive
portal which blocks all connections to the internet. For that reason, this
feature queues failed uploads and retries them at a later time. All of this
logic is in CertificateReportingService.

However, CertificateReportingService doesn't do any scheduling of retries itself,
it relies on MetricsService instead. CertificateReportingServiceMetricsProvider retries
queued (pending) report uploads whenever it's asked to provide metrics. This logic is
very much like HttpsEngagementMetricsProvider which also relies on the metrics service
to do the scheduling.

BUG=554323
TEST=CertificateReportingServiceBrowserTest.*

Review-Url: https://codereview.chromium.org/2503243003
Cr-Commit-Position: refs/heads/master@{#440788}

Use QuicStrCat instead of strings::Substitute and strings::SubstituteAndAppend which do not exist in chrome.

Merge internal change: 142860653

Review-Url: https://codereview.chromium.org/2600833002
Cr-Commit-Position: refs/heads/master@{#440787}

This will be needed by new changes to some of the existing PaymentApp
implementations.

BUG=674369

Review-Url: https://codereview.chromium.org/2565143002
Cr-Commit-Position: refs/heads/master@{#440786}

This CL:
* Switches display.html to use cr-slider (was only use of paper-slider)
* Changes styling of cr-slider as follows:
** Slider bar is grey instead of active (left) portion being blue.
** Knob is always blue (even at leftmost position)
** Ticks are shown automatically if there are < 10
** Labels are shown as part of cr-slider and shown below the slider

See issue for screenshots.

BUG=598879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2587913007
Cr-Commit-Position: refs/heads/master@{#440785}

https://chromium.googlesource.com/chromium/src/+/7239114dd9ee5

BUG=668342
TBR=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2605723002 .
Cr-Commit-Position: refs/heads/master@{#440784}

The failures have been fixed by previous changes for bug 645667, but we
forgot to remove the failure expectations.

BUG=645667
TBR=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2601813002
Cr-Commit-Position: refs/heads/master@{#440783}