- 13 Nov, 2017 39 commits
-
-
stkhapugin@chromium.org authored
Uses autolayout in LocationBarView to position the omnibox textfield. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If9f0f9ec65624785617bb3820d56509845f97e5e Reviewed-on: https://chromium-review.googlesource.com/709215 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#515911}
-
deejay authored
This fixes a Null-dereference READ error in AXMenuList. It can get a issue while adding children in AXObject::UpdateChildrenIfNecessary. We check HasChildren() before accessing children to fix it. Bug: 780931 Change-Id: Ia8442643a7ba06114453084d8208d25393dab865 Reviewed-on: https://chromium-review.googlesource.com/753167 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#515910}
-
Vaclav Brozek authored
This adds a COMPONENT directive to //components/os_crypt/OWNERS, which points to the right crbug.com component for os_crypt. The COMPONENT directive has been added to OWNERS files recently (an example is //components/password_manager/OWNERS) and is useful for developers when filing bugs about known code locations. It is especially useful for os_crypt, because neither the crbug.com component name nor its description mentions "os_crypt", so it might be hard to find just by a query in crbug.com. Bug: None Change-Id: I56f1f8289db573118f41a622d09e69aed3029e42 Reviewed-on: https://chromium-review.googlesource.com/765450Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515909}
-
yoshiki iguchi authored
The clean-up code touched a profile after the profiles were destroyed. This patch fixes this issue. Bug: 783538 Test: none Change-Id: If010a424e0fbcac2188eb5546c1e4917214dcbc2 Reviewed-on: https://chromium-review.googlesource.com/765635Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#515908}
-
Takashi SAKAMOTO authored
BUG=784278 TBR=dgozman Change-Id: I79da59f309e7915b80f14cb882679f3788a245e3 Reviewed-on: https://chromium-review.googlesource.com/765640Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#515907}
-
yoshiki iguchi authored
We should not change the visibility of the message center during the notifications are being iterated. This patch makes the code of changing visibility executed asynchronously. Bug: 782384 Change-Id: I36233312fdd5b3690b9c2e40597e51d8f16128e7 Reviewed-on: https://chromium-review.googlesource.com/762910 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#515906}
-
John Abd-El-Malek authored
This is a reland of 4470f02c. The webkit_lint fix had landed in r515892 Original change's description: > Run network service trybot when its test filters are modified. > > Change-Id: I5d28f3512047871e436341f01b9bfd6e0baa2b8e > Reviewed-on: https://chromium-review.googlesource.com/765575 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515890} Change-Id: I73bd0931b2a1ef25db790dde6fa7e8e2fc4458ac Reviewed-on: https://chromium-review.googlesource.com/765644Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515905}
-
Eric Roman authored
Change-Id: I33ff7de2b8957516ce8d8b8dc0143264c8a2df69 Reviewed-on: https://chromium-review.googlesource.com/764519Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515904}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/388187b9746c..f4c21da08850 $ git log 388187b97..f4c21da08 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 benjhayden Fix more references to results2. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I6a0dfb2430652f6b98701e2c7f54a7a83e5f327d Reviewed-on: https://chromium-review.googlesource.com/765216 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515903}
-
Nick Harper authored
Bug: b/69008819 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2d7c9c77f19964227ba46c4e2c54b01c8124f346 Reviewed-on: https://chromium-review.googlesource.com/764795 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#515902}
-
Mostyn Bramley-Moore authored
content/browser/renderer_host/render_process_host_impl.cc also has a ForwardRequest function in the anonymous namespace, which can collide with the function in content/browser/renderer_interface_binders.cc TBR=jam@chromium.org Bug: 779444,746953 Change-Id: Iaa2c9f22ff0945b4a35fef689f2b60896d048fea Reviewed-on: https://chromium-review.googlesource.com/765489 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#515901}
-
Patti authored
r515443 swapped out the custom higlighting in the Profile Chooser for ink drops instead. However, this introduced a regression where the buttons would no longer highlight on focus. Fix by turning on highlight on focus mode for ink drops. Bug: 784235 Change-Id: Ib45cbbc82644279496bbab42e97406de96b4db7c Reviewed-on: https://chromium-review.googlesource.com/765612 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#515900}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/aee17a9d0e6d..388187b9746c $ git log aee17a9d0..388187b97 --date=short --no-merges --format='%ad %ae %s' 2017-11-10 benjhayden Move makeTestModel out of the global namespace in webview_startup_metric_test. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I74b33b34d0b574803ca09a74b8dc85972bdd4446 Reviewed-on: https://chromium-review.googlesource.com/764993 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515899}
-
Timothy Loh authored
Bug: 783587 Change-Id: I4ffd2a49e0b8f4ae93074b867b079b9562ecf80e Reviewed-on: https://chromium-review.googlesource.com/765609Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515898}
-
Takashi Toyoshima authored
This patch moves content::ResourceRequestCompletionStatus from content/public/common/ to services/network/public/cpp, and renames it to URLLoaderStatus so to be consistent with mojom mapped type name. TBR: jam@chromium.org, mkwst@chromium.org Bug: 736308, 748491 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7608eba2a3c0419b1cbc1cf08313ac71eeb2e9c3 Reviewed-on: https://chromium-review.googlesource.com/756822 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#515897}
-
Takashi Sakamoto authored
This reverts commit 4470f02c. Reason for revert: webkit_lint failing on multiple builders. e.g. https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/50152 Running ['/usr/bin/python', '/b/c/b/Mac10_9_Tests/src/third_party/WebKit/Tools/Scripts/lint-test-expectations', '--json', '/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/tmpOSCHu4'] in None (env: None) third_party/WebKit/LayoutTests/FlagExpectations/PRESUBMIT.py:4 expecting "[", "#", or end of line instead of "script" """Presubmit script for //third_party/WebKit/LayoutTests/FlagExpectations. third_party/WebKit/LayoutTests/FlagExpectations/PRESUBMIT.py:4 Missing expectations. """Presubmit script for //third_party/WebKit/LayoutTests/FlagExpectations. third_party/WebKit/LayoutTests/FlagExpectations/PRESUBMIT.py:4 Path does not exist. """Presubmit script for //third_party/WebKit/LayoutTests/FlagExpectations. Original change's description: > Run network service trybot when its test filters are modified. > > Change-Id: I5d28f3512047871e436341f01b9bfd6e0baa2b8e > Reviewed-on: https://chromium-review.googlesource.com/765575 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515890} TBR=jam@chromium.org,rockot@chromium.org Change-Id: I1203ce740e9260ba827fc7aeeba404d0ef76b88a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/765627Reviewed-by:
-
Lei Zhang authored
It should check BUILD.gn files instead of GYP files. Change-Id: I83c9d454dd876ce1808dc7c3439b8c6238d4ebf9 Reviewed-on: https://chromium-review.googlesource.com/762150 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515895}
-
Hwanseung Lee authored
Replace Element.styleMap with Element.attributeStyleMap. Element.sytleMap is still behind runtime feature of CSSTypedOM. so it does not need to notify at blink-dev groups. https://drafts.css-houdini.org/css-typed-om-1/#inline-stylepropertymap Bug: 774933 Change-Id: I25c3dd401702505981b77fe38aa4798ea8ea9bd6 Reviewed-on: https://chromium-review.googlesource.com/765553 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515894}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cec56100. With Chromium commits locally applied on WPT: 23705631 "service worker: Upstream sandboxed iframe test to WPT." Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5168 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md No-Export: true Change-Id: Ib1b33f618624a01d64a7899974152ec3d0461711 Reviewed-on: https://chromium-review.googlesource.com/764680 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#515893}
-
John Abd-El-Malek authored
This is a followup to r515890 Change-Id: Ib083a3f72e84728700fe88c439d93acdc43a9ef8 Reviewed-on: https://chromium-review.googlesource.com/765215 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#515892}
-
Darren Shen authored
This patch: - Moves CSSTranslation tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. Notably, the spec changed so that Z can be a percentage. Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of CSSTranslation will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#csstranslation WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html There are failing tests where we are passing in a CSSMathValue/calc value. We currently don't support CSSMathValues as arguments. Bug: 774887 Change-Id: I571d6dd529a60381c310df74fddead39c61e2cd9 Reviewed-on: https://chromium-review.googlesource.com/765552 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515891}
-
John Abd-El-Malek authored
Change-Id: I5d28f3512047871e436341f01b9bfd6e0baa2b8e Reviewed-on: https://chromium-review.googlesource.com/765575Reviewed-by:
-
Darren Shen authored
We add a test for identifier normalization that covers [1]. Note that we're only testing that an <identifier> normalizes to a CSSKeywordValue (hence the simple test). Testing of which properties normalizes to CSSKeywordValue will be done in a separate test, as it is in a separate part of the spec [2]. [1] https://drafts.css-houdini.org/css-typed-om-1/#normalize-ident [2] https://drafts.css-houdini.org/css-typed-om-1/#stylevalue-normalization Bug: 774887 Change-Id: Idc2c0bb1279389e1e7fd46373bea13ac9b5dd105 Reviewed-on: https://chromium-review.googlesource.com/765550 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#515889}
-
Bugs Nash authored
Moved the generated apply* methods from StyleBuilderFunctions.cpp to the property classes for 'auto' properties which share a non custom template: - clip - column-count - column-gap - column-width - z-index Also fixed includes so that headers required for apply* functions are only included when those functions are implemented, not when they are to be declared only. Note that this patch creates duplicated logic in make_css_property_headers.py and make_style_builder.py. Since it is planned to remove style builder as part of this project I have not bothered factoring this logic out. Diff of generated files: https://gist.github.com/1bad2de3801d6d75d77e9b08c7b128f8/revisions Bug: 751354 Change-Id: I75d9a85a50771541f8c8be64c62c4dfa0796cd8a Reviewed-on: https://chromium-review.googlesource.com/760079Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#515888}
-
John Abd-El-Malek authored
TBR=xingliu@chromium.org NOTRY=true Change-Id: I73c923f8486b611f347e914fe17545175db63970 Reviewed-on: https://chromium-review.googlesource.com/765229Reviewed-by:
-
yoshiki iguchi authored
Bug: 782005 Change-Id: Icd1888daf9873719bce2b4d37d7d66e31c24da66 Reviewed-on: https://chromium-review.googlesource.com/763031Reviewed-by:
-
Matt Falkenhagen authored
Bug: 688116, 532855, 486308 Change-Id: I0cda49c9072099fa706988c6a1aa789456af2c1e Reviewed-on: https://chromium-review.googlesource.com/765564Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#515885}
-
Ian Kilpatrick authored
Bug: 591099 Change-Id: I8c006a0669e056c9a779a282e30cbea6ae106eb4 Reviewed-on: https://chromium-review.googlesource.com/763581 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#515884}
-
Hayato Ito authored
This is a part of Incremental Shadow DOM. Resolve slot's assigned nodes incrementally, on-demand basis, instead of relying on UpdateDistribution phase. This functionality is guarded by IncrementalShadowDOM runtime flag. This CL also introduces the utility function used only for testing. The utility function can process "Mini-DSL" for declarative Shadow DOM. That is useful for writing a complex composed tree. Since SlotAssingmentTest is the only user of the function, it is inside of anonymous namespace. Bug: 776656 Change-Id: I3359f67eabe562261cdfe2467b17b6b5e46b3c72 Reviewed-on: https://chromium-review.googlesource.com/750941Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#515883}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: Ib42ace1d7ed6d3de071b14d50b92ed391b0cc825 Reviewed-on: https://chromium-review.googlesource.com/765588Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#515882}
-
Renee Wright authored
Bug: Change-Id: I599d048f34df91500eee354ad65444e7d17dcdbb Reviewed-on: https://chromium-review.googlesource.com/762888Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces static assert to check class parameter of |LayoutMixin<T>| is |LayoutBlockFlow| or derived class to avoid misuse of |LayoutMixin<T>| for improving code health. Bug: 591099 Change-Id: I252682e62b7a23d7e8af6cdef45b6810f5750780 Reviewed-on: https://chromium-review.googlesource.com/763028 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515880}
-
John Abd-El-Malek authored
This reverts commit 098549fc. Reason for revert: Causing a bunch of test failures, see original commit's replies for list Original change's description: > Fix an issue in download with network service. > > Download code uses frame_tree_node_id to find WebContents when browser > side navigation is enabled. The WebContents is used in UI layer code > to close the tab when the request is a download. > > > Bug: 715630, 781565 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ib9490a64692027e3b16c70b77b54aceebcfcb9b7 > Reviewed-on: https://chromium-review.googlesource.com/761269 > Commit-Queue: Xing Liu <xingliu@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515816} TBR=jam@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 715630, 781565 Change-Id: I5c969d11f411c5742dec2762017609db351d7a28 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/765388Reviewed-by:
-
Matt Falkenhagen authored
To help reviewing this patch first changes the test and another one will move it to external/wpt. The subject matter seems fine for WPT although the final promise_test was intended as just a crash test and Chromium's behavior is not totally matching the spec. I wrote the expectation according to my interpretation of the spec and nhiroki's TODO. Bug: 688116, 532855, 486308 Change-Id: Ia6b9b178c21691a1abca3c60c7fc38ee86ea0989 Reviewed-on: https://chromium-review.googlesource.com/761270 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515878}
-
Xiaocheng Hu authored
File core/editing/ImeTextSpanTest.cpp is a leftover after we moved IME- related files to core/editing/ime. It is no longer listed in BUILD.gn, and is identical to core/editing/ime/ImeTextSpanTest.cpp. Hence this patch removes the redundant file. Bug: 761254 Change-Id: If4227e675b2866b34ac3f505f41a98e2da06ba26 Reviewed-on: https://chromium-review.googlesource.com/764876 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ryan Landay <rlanday@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515877}
-
Nicholas Verne authored
The first version of this cl/759621 was reverted because there were some instances of additional_param_names/values hidden behind build flags, not found by the default trybots. The main work here is mojo-ing IsInternalPluginAvailableForMimeType then renaming PluginInfoMessageFilter to PluginInfoHostImpl. Tbr: wfh@chromium.org Bug: 577685 Change-Id: I23f11f6567f1930189074809620c89f6c4f589dd Reviewed-on: https://chromium-review.googlesource.com/765549 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Ken Buchanan authored
Throttle OOPIFs when they are off screen or clipped. This adds a VisibilityObserver to RemoteFrames with LocalFrame parents, and sends an update across processes to the OOPIF when throttling status should change. This also fixes ScreenOrientation browser tests which has some flakiness in OOPIF tests that appears when this patch is applied. Bug: 761478 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I9bfb57058e534e796c23e238664a66a142be3c4a Reviewed-on: https://chromium-review.googlesource.com/719601Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#515875}
-
Miguel Casas-Sanchez authored
This CL cleans up a bit the order of DLOG()s and DCHECK()s, so that debug printouts are before DCHECK()s, and DCHECK()s of the current task runner go before the actual code. This CL also removes the function name from VLOGF()s because those already include it, so it's just duplicated. Also I shortened a condition if (a) return false; return true; into: return !a; TEST=No new code (except the condition simplification). Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I627b3077904a87ecd0da8f0cfbfaa7d70d232c35 Reviewed-on: https://chromium-review.googlesource.com/765109 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#515874}
-
Nicholas Verne authored
initialize PluginInfoPtrs. The crash happens when chrome::mojom::GetPluginInfo fails in sync mode. Then the output PluginInfoPtr is left null. We instead default initialize it with PluginInfo::New() as this is what the subsequent code expects. Bug: 783189 Change-Id: I51e25b127858b8ede79f6762f0f5e870166254d1 Reviewed-on: https://chromium-review.googlesource.com/762848Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
-
- 12 Nov, 2017 1 commit
-
-
Hwanseung Lee authored
merge constructor using optional keyword in CSSTransformValue and CSSTranslation Bug: 545318 Change-Id: I67fe1f7b8db1dd59689d6aa8c49938f48152c5f8 Reviewed-on: https://chromium-review.googlesource.com/763149Reviewed-by:
-
