- 18 Jun, 2020 32 commits
-
-
Mike Dougherty authored
Update BreadcrumbPersistentStorageKeyedSerice to perform file writes on background thread. Additionally, trim the stored breadcrumbs file size to prevent it from growing too large. BreadcrumbPersistentStorageKeyedSerice was implemented previously but never used so this CL makes is fully ready for use. Bug: 1082892 Change-Id: Ifbd477dd3bf32f71a70a742dbf45b0fa5fc3665a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226416 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#779587}
-
Nigel Tao authored
Some deleted methods explicitly have "Deprecated" in their names. Others are non-static methods, which can cause confusion when mixed with static methods (e.g. crrev.com/c/2227944, crrev.com/c/2237582). Also delete the constructors. All remaining methods are static. Bug: 1069271 Bug: 1070409 Change-Id: I81e9791cef4edcc0ef55d5c637f5f65336d45a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227726 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779586}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e2091446b577..c84220a61be7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1079293,chromium:1095885 Tbr: alexmos@google.com Change-Id: I6cee97d5f3b12eb62e086453a73977ac3baadebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250804Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779585}
-
Rakib M. Hasan authored
For blink web tests, resultsdb requires the artifact paths to be in lists. Bug: 937369 Change-Id: I1a33fa340778129c9b4f7ed8c834cfa22a728f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247082Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#779584}
-
Andrew Grieve authored
This reverts commit cd6be6cc. Reason for reland: compile_targets doesn't take a list of targets Change-Id: I02d776acf2a996caca0a3712a64bec9eb0784de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248733Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#779583}
-
Fritz Koenig authored
Specify the precision of the timestamp so that it lines up with other timestamp logs. BUG=b:149663704 TEST=./video_decode_accelerator_tests --use_vd Change-Id: Ib76f2fc4309f340084dfe550af434fd606be4a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246854Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: J Kardatzke <jkardatzke@chromium.org> Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779582}
-
Daniel Rubery authored
The current link goes to a generic APP FAQ, but we can link to the specific section related to Advanced Protection download warnings. This fixes b/153866355 Change-Id: I449e4d627fb70ac295fa6937a40c89a1e3879bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250824 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779581}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/590e8db5d863..72f403c343dc 2020-06-17 cbracken@google.com Use Mac font manager for both iOS and macOS 2020-06-17 djsollen@google.com Revert "Convert Skottie build instructions to build an Android Library (AAR) instead of app (APK)" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Iacd89bfeba6ebdcb9999e5e6b14840e36ac571bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250805Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779580}
-
David Maunder authored
CriticalPersistedTabData is a UserData object which enables fields to be moved out of Tab and also provides persistence of such fields across restarts. mRootId and getRootId are moved - setRootId is to come. Bug: 1086224 Change-Id: I0c89c3087291d124f66948c63ab2b9f60277ac63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233605Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#779579}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592420122-44e320f5cb874678ca6b77bfdebbccbe803d44fc.profdata to chrome-win32-master-1592423969-e01d88a08e241296f5d620a14f440c7e17e47880.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I06d5824ea0f22645e03f2b2a2c20f78a735e2e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250803Reviewed-by:
-
Jimmy Gong authored
- This policy prevents managed users from deleting their print history. - Disables the print management app delete history button and disables print history deletion from browser history deletions. Bug: 1087942,1053704 Test: browser_tests Change-Id: Ifecf547883e9c9f9ee3f7559f7c220aaba5a7056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228115 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#779577}
-
Adrienne Walker authored
This is only used by one unit test, so move it out of content/test. This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/2246957 Bug: 1094811 Change-Id: I5ecc0637514dca22055850d59c933c5380537710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250342 Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#779576}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592423969-e9cdc767cf2ee2d28a487cba4bbc17ede63357fc.profdata to chrome-win64-master-1592427517-ded8b7e7fc728e470cefdc642111adb273503cec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I410b0c29355cb86e889cd0c998b2958f91fa631c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250806Reviewed-by:
-
Michael Thiessen authored
Ensure that we don't launch external fallback URLs, when we've otherwise decided that we should not launch an external navigation (even if it was possible to). Also prevent auto subframe navigation from launching external fallback URLs. Bug: 1094442 Change-Id: I3828a0957c160c6ed2c2a38b54cf54af9b797327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248124Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Collin Baker authored
There are currently no cross platform metrics for touch mode. This adds a pair of actions logged at browser start and when the current touch mode changes. Change-Id: I67da675c8c7ce9f11d0d0b53bd13047bf35a2afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238363 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#779573}
-
Ankit Kumar authored
This is a reland of 9c48a1c1 Original CL: http://crrev.com/c/2208832 Revert CL: http://crrev.com/c/2247941 Reason for revert: Causing PDFExtensionAccessiblity tests to fail on Mac Debug. The method GetStaticTextNodeFromNode() had an assumption that highlight node would only have one children. The original CL changed that as the popup note is added as a child of the highlight node. Original change's description: > Add contents of popup note associated with a highlight in PDF accessibility tree > > This CL adds the note text data associated with a highlight to the > accessibility tree. The CL makes the content of the note text accessible > to users via screen readers. > > Tests have been modified to validate the addition of note text data to > the accessibility tree. > > Bug: 1008775 > Change-Id: I086d039b9296d0b8ac1b13926835375a7943f8c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208832 > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#779008} CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_chromium_dbg_ng Bug: 1008775 Change-Id: If9eb9ae1a0f975b99e00e01ca68e6d301989cd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249263Reviewed-by:🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779572} -
Daniel Cheng authored
Use googletest's value-parameterized tests to reduce the amount of boilerplate. Bug: 41905 Change-Id: Ib2ef6bdf8e98c75193a5efd57f8683bdeec0f89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247382 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#779571}
-
Mike Wasserman authored
Suggested via https://github.com/webscreens/window-placement/issues/13 Marking the screen member non-nullable allows callers to omit a value or pass undefined to effectively request fullscreen on the current screen. Passing null now yields TypeError "member screen is not of type Screen" This also fixes a crash checking for the id of a null screen. Bug: 1084321 Test: enable-experimental-web-platform-features and requestFullscreen({screen:null}) Change-Id: I92b7bd8367be1bafd8903c60a719ee45738a925d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241729Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#779570}
-
Andrey Kosyakov authored
... by assuring field order in protocol objects We do not guarantee order of the fields in the objects passed over the protocol, nor does it matter in JSON, so make sure test expectations don't depend on it. Just use testRunner.log(obj) instead of testRunner.log(JSON.stringify(obj)) most of the time. Change-Id: I96e6b819e30960b856ca107269b6b7ac4fd2aa41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250819 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#779569}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/46485a0b8536..7a1d99d0be42 2020-06-17 capn@google.com Add a benchmark with multisampling enabled 2020-06-17 capn@google.com Refactor multisample benchmark support 2020-06-17 capn@google.com Implement multisample support for the triangle benchmark If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia69bdc0af2cc617198a4393c956076a792a71d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250802Reviewed-by:
-
Haiyang Pan authored
This reverts commit ba58fd11. Reason for revert: Three tests org.chromium.components.external_intents.RedirectHandlerTest#testNavigation* start being flaky in several android builders since this CL: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_out_of_process_chrome_public_test_apk&tests=org.chromium.components.external_intents.RedirectHandlerTest And cause quite a few CQ retries: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVykQELEgVGbGFrZSKFAWNocm9taXVtQGNocm9tZV9wdWJsaWNfdGVzdF9hcGtAb3JnLmNocm9taXVtLmNvbXBvbmVudHMuZXh0ZXJuYWxfaW50ZW50cy5SZWRpcmVjdEhhbmRsZXJUZXN0I3Rlc3ROYXZpZ2F0aW9uRnJvbUxpbmtXaXRob3V0VXNlckdlc3R1cmUM TBR=jochen@chromium.org, tedchoc@chromium.org Change-Id: I7155b0ed534e0f3b4a5e712d6f9ac4685c50d7cb No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250936 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#779567}
-
My Nguyen authored
In preparation for adding show_setting_link param for personal info suggestion. Bug: 1094267 Change-Id: Id9e4a5d5de335613df93bf80142a3df8bb564fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243073 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#779566}
-
David Maunder authored
As information is sent to the server, we should only use the server fetcher if the user has consented via the agreement they consent to when they sign in. We should also be able to control the server fetcher via a flag as needed. Bug: 1095132 Change-Id: I0886902d7618aa194f924f7274dd46ff609ad58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246874 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779565}
-
Adam Argyle authored
Intent to prototype: https://groups.google.com/a/chromium.org/d/msg/blink-dev/oNJTem41LBs/CA4Nx05aAwAJ Bug: 1051189 Change-Id: I2ff88a70858cf322725f50e40f979c9596f45b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083838 Commit-Queue: Adam Argyle <argyle@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#779564}
-
Anand K Mistry authored
The provided implementations are the same as the default, so just use default. Bug: None Change-Id: Ie4c772a6371805cd869673b9979983cfa7714f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249284Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#779563}
-
Alexander Cooper authored
Bug: 1095740 Change-Id: I041f123e851ac4364e1c044b17f601f9925b3f5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236038 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779562}
-
Andrew Xu authored
As reported by Clusterfuzz, hotseat widget may not have enough space to fully show even one shelf icon. Under that edge case, the end of the last shelf icon will be outside the scrollable shelf. Based on the current code, |last_visible_view_index| will be -1. This CL fixes the issue. Bug: 1094363 Change-Id: Ib4a49267c82a54e3c66f88df9702dddb216eca89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250706 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I0c69dcf8d27d25b30d4e211bce41f80de70d110b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248575 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779560}
-
Anand K Mistry authored
Using 'default' is the modern C++ approach used by chromium, and some analysers complain about the old style. Bug: None Change-Id: Ic531d39490f3005abb163830dfc312e1351b003a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249283Reviewed-by:
-
Xing Liu authored
A unit test only for compiling MockDownloadItem is not needed. Bug: NONE Change-Id: I106c2a9a5bacad516373905df1d4e8141ff1c441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250930 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779558}
-
Victor Vasiliev authored
R=dschinazi@chromium.org Change-Id: I561e3c9d88d6301e150c12b102911ffb22d92c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250954Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779557}
-
Jun Kokatsu authored
This change improves sanitizer in parse_html_subset.js by using allow-list of tags and attributes. Bug: 1086318 Change-Id: I56b94350d49bbb9e218336c9292897ac2e619316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222115Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
- 17 Jun, 2020 8 commits
-
-
Matt Jones authored
This patch moves all of the bottom sheet files to their new home in components/browser_ui/android/bottomsheet. Files have been split into several build targets: - /: The root directory contains the public API; any feature is allowed to depend on this. - embedder: This target is for systems embedding the bottom sheet as part of their activity. These classes are necessary to effectively manage the sheet. - internal: This target contains the actual implementation of the sheet and should not be exposed outside of the bottom sheet component. - test: Tests (eventually) and test support. Bug: 1002277, 1004415 Change-Id: Ic6a76044555da27ce75d8843de8e624d1b1788c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242112 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#779555}
-
Daniel Libby authored
This is currently only used for scrollbar parts, which do not have descendant layers. Instead just set needs paint on the painting layer and invalidate the DisplayItemClient (the same LayoutObject the ObjectPaintInvalidator is initialized with) via SlowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient. There was not any unit test coverage for InvalidatePaintIncludingNonCompositingDescendants which uses the same traversal algorithm, so convert tests of the deleted method to use this one instead, and validate only the paint invalidation side-effects. Bug: 1007989 Change-Id: Ic9849f889958300941bc9a48d97cf7f04a91c786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247157Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779554}
-
Shengfa Lin authored
With JSON_REPLACE_INVALID_CHARACTERS option, json parser is replacing lone high surrogate but not lone low surrogate. This is to replace lone low surrogate. Tests: autoninja -C out/Default content_shell base base_unittests services services_unittests out/Default/base_unittests --gtest_filter="JSONParserTest.*:JSONReaderTest.*:JSONStringEscapeTest.*:StringUtilTest.IsStringUTF8" Bug: chromedriver:3515 Change-Id: I547b8b7edaa24e7de79dc980746815de607a0918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248342Reviewed-by:Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Jacques Newman authored
By calling these methods internally, we cause the histograms to be inaccurate, as they should be tracking external calls. Bug: 1095772 AX-Relnotes: n/a Change-Id: I505a7bcddee34a382ead4387088c53dc921571af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247346 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779552}
-
Daniel Libby authored
No callers and is not correct for CompositeAfterPaint. Found as part of investigating crbug.com/1007989 Change-Id: Ic572b50a39f21e9e9ea30a5ed5d7fe3ca1b57f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246434 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
-
Ben Pastene authored
The two sets of pools should be identical now. So this moves all tests back to the old pools so we can delete the temporary *.template ones. Bug: 812428 Change-Id: Ibdb1525d299d911b1e5b1d4b0ba71cfa1abcc293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250086 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#779550}
-
Jason Lin authored
* kPluginVmAppId -> kPluginVmShelfAppId: This id is also used by Plugin VM installer as the shelf id on the window. Rename to make it clearer. * IsPluginVmWindow() -> IsPluginVmAppWindow(): This function only return true for the Plugin VM app window but not the installer window. Rename to make it clearer. Bug: 1087726 Change-Id: Ib7cf899133ed970bd795c859ac740f5c15f77b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247460Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Jose Dapena Paz authored
Calls to memset and std:all require the includes they are declared. Bug: 819294 Change-Id: I58f4ed8d6c0645a5785077e728faa500282e863e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248186Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#779548}
-
