GitLab

There's only one field, for the enabled_ state. I made
an InnerEnable private function so we don't need a seperate
boolean to distinguish any more.

Change-Id: I65cc41c775d0c01ea10ce54c261b36d1e92dc7fe
Reviewed-on: https://chromium-review.googlesource.com/1159687Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580246}

There's no need to define _LAST enumerators, since Mojo provides these
automatically.

Bug: 742517
Change-Id: Ibafea09dd000cf14db4033790bef6a860b5030e6
Reviewed-on: https://chromium-review.googlesource.com/1159263Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580245}

ET_SCROLL_FLING_START/CANCEL are represented as GestureEvents if
EF_FROM_TOUCH is set, otherwise ScrollEvents. The deserializer always
treated them as ScrollEvents.

BUG=867035
TEST=covered by test

Change-Id: I2540ccc8766fbf59eafa0c3beadd8dd2e4ec4ade
Reviewed-on: https://chromium-review.googlesource.com/1159621
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580244}

This mode can be used in QuicStreamFactoryTest to simulate cases where connection
migraiton is triggered while crypto handshake is not completed.

Bug: 790547
Change-Id: I3c32f156d503318b9a9b203c772d3ec4ed41d9f8
Reviewed-on: https://chromium-review.googlesource.com/1157439
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580243}

Because the dialog must be displayed before the Profile initalization as
the process might load the extensions which might open browser windows.

TEST=Set up a invalid token by setting any non-empty string in policy.
     MachineLevelUserCloudPolicyEnrollmentToken.
     a) Login mac.
     b) Create com.google.Chrome.plist (org.chromium.Chromium.plist for chromium) for the
        following content:
         <?xml version="1.0" encoding="UTF-8"?>
         <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
         <plist version="1.0">
         <dict>
            <key>MachineLevelUserCloudPolicyEnrollmentToken</key>
            <string>invalid-token</string>
         </dict>
         </plist>
     (More details in https://support.google.com/chrome/a/answer/7550274?hl=en)
     Launch Chrome. Instead of the chrome window, there should be an error dialog indicates
     that launching is blocked.
     1) The error dialog could be hidden/shown, lose or gain focus without any issue.
     2) Clicking any option in the menu bar or dock menu shouldn't open any browser window.

Bug: 860540
Change-Id: Ibf4b7c2794a8ad78b9fedb2da67512508d3d7621
Reviewed-on: https://chromium-review.googlesource.com/1145862
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580242}

We are having issues where starting a GPU process consistently fails on
some systems. Currently OOP-D runs the display compositor in the GPU
process always. This includes when both hardware acceleration and
SwiftShader are disabled. If we can't start the GPU process, we can't
run the display compositor and Chrome crashes.

This CL changes where the VizCompositorThread runs if the GPU access is
disabled on Windows. We start the thread after giving up on the GPU
process and create FrameSinkManagerImpl + dependencies on it.

Also fix chrome://gpu page so that OOP-D and surface sync features are
still correct if |gpu_access_blocked| is true.

There is a lot of peripheral cleanup and code reuse possible as a follow
up to this CL. It's not attempted here to make this easier to merge back
to M69.

Bug: 849639
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ica6a3ec5b0e7951cb6807b135df4b4cfe410e394
Reviewed-on: https://chromium-review.googlesource.com/1158723Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580241}

This CL introduces a bare content feature to allow landing experimental
work and future CLs on MimeHandlerView using cross process frames. The
feature will be disabled by default.

MimeHandlerViewContainer is currently the last remaining GuestView
which still relies on BrowserPlugin. Eventually and starting with this
CL, the new implementation of MimeHandlerView will be based on
cross-process frames that no longer requires a BrowserPlugin.

Bug: 659750, 330264
Change-Id: I52a8eba4e9f2446ae0d899cd3a639f418bc01d12
Reviewed-on: https://chromium-review.googlesource.com/1073923
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580240}

This isn't needed anymore as we're now using LLD.

Bug: 804926, 821764
Change-Id: I3c6e4ce0793997823b89978cf7eda5b3a26399b8
Reviewed-on: https://chromium-review.googlesource.com/1108185Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580239}

When accessibility mode is enabled, show a preference in accessibility
settings that allows uers to disable the accessibility tab switcher.

We make a best effort guess as to when we should show the accessibility
tab switcher. Some users would prefer to use the regular tab switcher,
however.

BUG=859401

Change-Id: Ie8a8cf317a216b4343188e1a6d6cc037d31aae64
Reviewed-on: https://chromium-review.googlesource.com/1125323
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580238}

This change updates the close button to be a fixed size regardless of
the window size.

Bug: 870186
Change-Id: Ib9de9508cef6f1faea272be7a223a15e86d7ac87
Reviewed-on: https://chromium-review.googlesource.com/1159987Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580237}

This CL adds a simple test case for exercising the Linux specific video capture
code for capturing video from a V4L2 device in singe-plane mode.

It fills in enough implementation in FakeV4L2Impl to make the test case work.

This CL is part of a series, see Design Doc at
https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing

Change-Id: I6def56fb99d662b5fc9683ed19671af4c219ee40
Reviewed-on: https://chromium-review.googlesource.com/1128272
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580236}

I thought it was nice to name everything Clear, but when I tried
to use it in one of the pending PRs it felt too much like action
from a distance to clear the agent state which causes the fields
to be cleared. So the more explicit name (like you suggested it)
is better. Sorry about the churn.

Change-Id: I33ab0b02a714dd93c2375ec28327a5eb58748135
Reviewed-on: https://chromium-review.googlesource.com/1159996Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580235}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7b323896..d1de8d3d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib25a70f5a74e8fdfe74e0f053a3861e50f455476
Reviewed-on: https://chromium-review.googlesource.com/1160868Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580234}

This updates the icon to use the custom drawn icon supplied by UX. This
icon is only used in the toolbar indicator.

Bug: 870118
Change-Id: Idd3ee8767e372c855d149cd7debb0ec6d6b4aa90
Reviewed-on: https://chromium-review.googlesource.com/1159993Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580233}

The setup complete event it was gated on is deprecated. Now we should
just update device locale on start.

Bug: None
Test: locally build and run, watch the locale updated
Change-Id: Ieaaa6bd1926ab6c6a64da5f74d2b26ca9925de51
Reviewed-on: https://chromium-review.googlesource.com/1159734Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580232}

The tab switch button isn't ever truly focused, since focus remains with
the Omnibox. Thus, it never gets an accessibility event. This change
causes an accessibility event to be generated when we trigger a
simulated focus of the button.

Bug: 853929
Change-Id: I7db6a8bd906a1785f047dc62b2beb03f14e22114
Reviewed-on: https://chromium-review.googlesource.com/1157071
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580231}

Change-Id: I6863a2999525ac07cf942c26da5d6f8cf97eafa1
Reviewed-on: https://chromium-review.googlesource.com/1159352Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580230}

This re-lands commit 1edc413f.

Original change is ps1, fix is in latest patchset.

Original change's description:
> OopAsh: port/enable some more browser tests.
>
> Bug: 854704
> Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d
> Reviewed-on: https://chromium-review.googlesource.com/1153777
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579476}

Bug: 854704
Change-Id: I0a264093a2d90b00bcdc5a0e2e71a9d391336fea
Reviewed-on: https://chromium-review.googlesource.com/1159086
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580229}

These errors are causing all of the Settings tests to fail on CrOS. Fixing
those in preparation of adding webui_polymer2_browser_tests test suite.

Bug: 862472
Change-Id: Ica46f1fbef0f119c554d9003734544606c095c3c
Reviewed-on: https://chromium-review.googlesource.com/1160864Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580228}

This CL introduces impression and click metrics for all actions and
suggestions and the accessory sheet in general.

Bug: 853766
Change-Id: I47376dae669b99ae0e8701fb2e04efa292e8f673
Reviewed-on: https://chromium-review.googlesource.com/1157005Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580227}

The capture state lives in ash, where ChromeVox sets the state (extension -> browser -> ash).

This state gets delivered (ash -> browser) to the SpokenFeedbackEventRewriterDelegate.

At that point, we should always allow the event to continue onto ChromeVox, and only re-inject if the key is captured.

The previous logic was put into place when this code always sent the delegate all keys.

Bug: 868573
Change-Id: I6bde8b021d093c52d4450682c4d037a7ef4938a0
Reviewed-on: https://chromium-review.googlesource.com/1159176Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580226}

Adds a sleep (ew) after entering presentation in VR tests for testing
that the Daydream controller's app buton exits presentation. This works
around a VrCore issue when skipping the DON flow that causes the
controller to briefly disconnect and reconnect when entering VR, eating
any controller input that's sent during that time.

Bug: 870031
Change-Id: Id888826907c9548120d36b0dde67e30271d4bc85
Reviewed-on: https://chromium-review.googlesource.com/1159398Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580225}

ZipFile does not implement Closeable interface prior to api19:
https://developer.android.com/sdk/api_diff/19/changes/java.util.zip.ZipFile
It was introduced as a fix for failed library extraction here:
https://chromium-review.googlesource.com/c/chromium/src/+/930332
So, this code gets executed quite rare, but I can see some
"java.lang.IncompatibleClassChangeError: interface not implemented" errors
on our radars at Yandex, mostly Huawei 4.1.2, 4.2.* and 4.3.*. Since
non-googlers don't have access to crash tickets, I can't check if Chrome
has same issues, but I believe that you have.

This CL adds a custom closeQuietly method for ZipFile, and rewrites a
try-with-resources statement with it. Docs say that ZipFile.close() also
closes all the streams, so I removed InputStream from try as well:
https://developer.android.com/reference/java/util/zip/ZipFile.html#close().

R=agrieve@chromium.org,ranj@chromium.org

Change-Id: I6b626bf87f01f5598ab61be3ac88759b4c7076e2
Reviewed-on: https://chromium-review.googlesource.com/1156397Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580224}

Bug: 869447
Change-Id: I64c205b5ffb2126382c04f5aeefe1cb88010744a
Reviewed-on: https://chromium-review.googlesource.com/1156993Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580223}

https://skia.googlesource.com/skia.git/+log/174d7f61ba90..a31f4e51d559


git log 174d7f61ba90..a31f4e51d559 --date=short --no-merges --format='%ad %ae %s'
2018-08-02 egdaniel@google.com Make sure we check the version number of Vulkan Extensions.


Created with:
  gclient setdep -r src/third_party/skia@a31f4e51d559

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I3fe8a2af61bd1ecc4dd6ee5939967da537d384b6
Reviewed-on: https://chromium-review.googlesource.com/1160784Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580222}

Change-Id: I5c9b07a3252a6cc3c303c8da3ccd2252be72d242
Reviewed-on: https://chromium-review.googlesource.com/1158717
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580221}

Bug: 649392
Change-Id: I1dcafd6ea561c3d4505c3e4507904a0872dadbac
Reviewed-on: https://chromium-review.googlesource.com/1156986Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580220}

Previously the startMainActivityOnBlankPage() ca;; could result in a
task being added to the stored task info list. This change fixes this
by simply clearing the list of stored task infos.

Bug: 868647
Change-Id: I0719613e697dd8c5f618db99d02490ce3313a2da
Reviewed-on: https://chromium-review.googlesource.com/1155762
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580219}

When the drag ends, the source window might still be in bounds animation,
thus we should compare the expected bounds to its target bounds.

Bug: 869614, 823769
Change-Id: Ied81296fed19d16d3c833430860f9b20d2623431
Reviewed-on: https://chromium-review.googlesource.com/1159526Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580218}

https://chromium.googlesource.com/catapult.git/+log/9ac709a1b2a5..7110f0868455


git log 9ac709a1b2a5..7110f0868455 --date=short --no-merges --format='%ad %ae %s'
2018-08-02 sadrul@chromium.org rendering: Add pipeline:draw in the report.


Created with:
  gclient setdep -r src/third_party/catapult@7110f0868455

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855328
TBR=sullivan@chromium.org

Change-Id: Iccfd9692ee21b9bf9e96cbdf4a44377c1c1e8918
Reviewed-on: https://chromium-review.googlesource.com/1160781Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580217}

Suppress failures for

gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_WebGLGreenTriangle_NoAA_Alpha
gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_WebGLGreenTriangle_NoAA_NoAlpha

on Android FYI Release (Nexus 5).

Bug: 870023
TBR: kbr@chromium.org
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6de26ae7b418a54bafd9ecc8059a51e125b021f2
Reviewed-on: https://chromium-review.googlesource.com/1160596
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580216}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f812e132d25..5300616351f5


git log 6f812e132d25..5300616351f5 --date=short --no-merges --format='%ad %ae %s'
2018-08-02 jbudorick@chromium.org bot_update: expose patch_refs as an option to ensure_checkout.


Created with:
  gclient setdep -r src/third_party/depot_tools@5300616351f5

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:865882
TBR=agable@chromium.org

Change-Id: I8cd29238576f9f10b148c69ee961c911580c8b49
Reviewed-on: https://chromium-review.googlesource.com/1160783Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580215}

R=mek@chromium.org

Bug: 868578
Change-Id: I1c90f993f3e71d543b414c37a1b92bae5948b766
Reviewed-on: https://chromium-review.googlesource.com/1155483
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580214}

Instrument GLES2DecoderImpl::DoCommandsImpl to
- record in a crash key all of the GL commands that have been flushed
- flush at the end of every time that it is called

This will severely regress performance.

What we hope to learn:
- There's a good chance this will make the bug vanish (egregious glFlush
  calls have been known to do this), in which case we'll learn nothing.
  - But maybe we can add less egregious glFlush calls to avoid the issue
    in Chrome 69
- If elevated crash rates persist, hopefully this will point to a particular
  call or sequence of calls that is causing the crash

Bug: 863817
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I462fab8a6d86ee3896dcd9c0c3c4aa68f9de0a69
Reviewed-on: https://chromium-review.googlesource.com/1159831
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580213}

event_modules_factory.cc indirectly includes gamepad.mojom-blink.h, but
there's no dependency between them. That causes a flaky build failure:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939294599854040784/+/steps/compile/0/logs/raw_io.output_failure_summary_/0

Change-Id: I509f61c46957b3d3646c7c679113454148785df7
Reviewed-on: https://chromium-review.googlesource.com/1160825Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580212}

It is flaky

TBR=bradnelson@chromium.org

Bug: 870309
Change-Id: I8a55fdaae7091b0dc32247527d50a35510e7a4bf
Reviewed-on: https://chromium-review.googlesource.com/1160542Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580211}

For profiles with unified consent enabled, the sync state is completely
ignored when deciding whether UKM is enabled. The decision whether UKM
is allowed for a profile with user consent enabled is based only on the
URL-keyed anonymized data collection enabled preference.

This CL changes the UKM logic to check whether URL-keyed anonymized data
collections is enabled for profiles where unified consent is enabled.

This CL also updates the ProfileSyncServiceHarness to set/unset the
state of the UnifiedConsentGiven flag when the state of sync everything
changes.

Bug: 861777
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I974a3eea2caa424efe44c1dd8b7c6f2bb24f156e
Reviewed-on: https://chromium-review.googlesource.com/1152744Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580210}

In preparation of supporting compression of log files, introduce
an interface named LogFileWriter, which will allow
WebRtcEventLogManager to write either compressed or uncompressed
log files.

Bug: 775415
Change-Id: I4bc30fae88bba2e071d72aabfdf9fe05a5148af0
Reviewed-on: https://chromium-review.googlesource.com/1143472
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580209}

If for some reason drivefs fails to start or crashes we want to do
limited number of retries and then give up.

BUG=chromium:845388

Change-Id: Ife550b76ba060adb2b3abc1a7674ae9b396e2677
Reviewed-on: https://chromium-review.googlesource.com/1158674Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580208}

ResetFirstAfterBootTest.RollbackUnavailable has been flaky. Disabling.

TBR=xiyuan@chromium.org

Bug: 870284
Change-Id: I7226ae73ca9c4cf440de3fbeae28886309d907d9
Reviewed-on: https://chromium-review.googlesource.com/1160866Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580207}