- 23 Feb, 2018 40 commits
-
-
dpapad authored
Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id88cb1a89d7eed7e2993dbf5f690708b61cc4143 Reviewed-on: https://chromium-review.googlesource.com/932978Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#538831}
-
Joshua Bell authored
Storage back-ends notify the quota system about deltas in per-origin usage via a QuotaManagerProxy, which will do sequence-hopping to get to the right place to talk to the QuotaManager itself. Convert the entry points to pass url::Origin instances along instead of GURLs. For back-ends that are already converted to use url::Origin internally (Cache API, Indexed DB) this deletes code. For the others (AppCache, WebSQL, FileSystem), some conversions are necessary, mostly in test logic. (The QuotaManager itself is not yet updated, so the proxy itself needs to do a type conversion. That'll get tidied up soon.) Bug: 598424 Change-Id: I7e9eb04e974053ee6cc9172ee039aaa7cdec3d89 Reviewed-on: https://chromium-review.googlesource.com/927794Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#538830}
-
Xiaocheng Hu authored
This patch fixes the local point when hit test ends up in text fragments: When HitTestResult's inner node is a text node, the local point should be local to the container block flow, not the text fragment being hit-tested. We current have the latter, which is fixed in this patch. Bug: 811502 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3104c126b5ee3968f25dffa15042a45a051be160 Reviewed-on: https://chromium-review.googlesource.com/915041Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#538829}
-
Nico Weber authored
It's only needed for win/cross builds, but it's a small package and the only additional package needed for cross builds, so add it unconditionally. Change a/chrome/tools/build/win/create_installer_archive.py to use 7zr instead of 7za (both suffice for us), so that the smaller p7zip is enough. Bug: 495204 Change-Id: I5f4c5326dbab2f3a3257c8cad4d3524cb338fca6 Reviewed-on: https://chromium-review.googlesource.com/934686Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#538828}
-
David Benjamin authored
This works, as of https://boringssl-review.googlesource.com/c/boringssl/+/26164 Bug: 124610 Change-Id: I2503743fa950764facfbf7795d9b20811fe6bb2a Reviewed-on: https://chromium-review.googlesource.com/923537Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#538827}
-
Antoine Labour authored
The LayerTreeHosts will never create resources using a VulkanContextProvider directly, instead will go through the RasterInterface, so remove that option. Until that is ready, we can use a software LTFS for --enable-vulkan mode. Bug: None Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibaa522062f2282f35e03c44b4255bb4504aba5b4 Reviewed-on: https://chromium-review.googlesource.com/930034Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#538826}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/085955c56744a9cc82f98ed850deca2165252d2c..672f6fc2486745d0cabc3aaeb4e0a3cd13b37b12 BUG=none Change-Id: I44a792ba4d7341f2d2eb912787d7cef0b2e711e1 Reviewed-on: https://chromium-review.googlesource.com/933161 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#538825}
-
Tarun Bansal authored
Bug: 813184 Change-Id: I0e3dc1d458b96ebcb31506a38cdac177e2f9a859 Reviewed-on: https://chromium-review.googlesource.com/924397 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#538824}
-
Kim Paulhamus authored
Per https://w3c.github.io/webauthn/#dictdef-publickeycredentialcreationoptions Change-Id: I78783bf1722d727e7014893e5f98e8e77c313b39 Reviewed-on: https://chromium-review.googlesource.com/933372Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#538823}
-
danakj authored
Instead, make a SyncToken when generating the gpu::Mailbox for each (new) resource. If a resource is reused from the ResourcePool, then no SyncToken will be be generated. Previously we always called OrderingBarrier and inserted a SyncToken each time we prepared tiles for raster, even if the resources were reused. R=sunnyps@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4bdf5ab00f82fe8a9eed56f5cabc6628c1dffc22 Reviewed-on: https://chromium-review.googlesource.com/909070Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#538822}
-
Bartosz Fabianowski authored
This adds a class that lives from login until logout. It observes the pref that indicates whether to log events for app push-installs: * If logging is enabled, an app push-install event log manager is created that handles collection, storage and upload of app push-install event logs. * If logging is disabled, the manager is destroyed and any data related to the app-install event log is cleared from disk. Dynamic pref changes are supported. Bug: b/73277923 Test: unit_tests Change-Id: I851f75224ed6f96364a88109ffece1e05d30069e Reviewed-on: https://chromium-review.googlesource.com/929322 Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#538821}
-
https://webrtc.googlesource.com/src.git/+log/d60d5c4479d2..f35c6667d6f7 $ git log d60d5c447..f35c6667d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I017a37e60c4fa574255203d2adf5f5d906dc88fc Reviewed-on: https://chromium-review.googlesource.com/934632Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538820}
-
Ken Buchanan authored
This CL adds a new class ScrollingCoordinatorContext which contains state that used to belong to ScrollingCoordinator but needs to be duplicated for each local frame root when OOPIFs are instantiated. It is lazily created on LocalFrameViews that are belong to local roots (i.e. OOPIFs or main frames). This also moves layers_with_touch_rects_ out of ScrollingCoordinator, because reuse of that HashSet between frame roots was causing the crash in bug 812364. Bug: 680606, 812364 Change-Id: I09feb2add534b460dd9425fb918a6c856e325efb Reviewed-on: https://chromium-review.googlesource.com/922702Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#538819}
-
Joshua Bell authored
Chrome has a "should remain available" disk space threshold; when less than this amount is free, the effective quota for each origin drops to 0 so new writes will fail. This is present to avoid Chrome being responsible for filling the disk which generally makes devices unhappy. The threshold was set at 10%, which is too conservative; offline storage would basically stop working when a disk was 90% full, which is a common case - e.g. on a 200GB disk, writes start to fail with 20GB free! This change adjusts the threshold to 1%; for example, on a 32GB device this ensures Chrome does not push usage past 320MB remaining free. Similarly, Chrome has a "must remain available" threshold at which point data starts being evicted - keeping the device functional, but potentially losing user data. This was set at 1%, but is similarly adjusted down to 0.25%. For a 32GB device this ensures Chrome will drop data only when less than 80MB are free. Bug: 802027 Change-Id: I09ec3531ef34637413a1d239b546dc200d3d648a Reviewed-on: https://chromium-review.googlesource.com/933365 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#538818}
-
Ian Clelland authored
This reverts commit 97218f98. Reason for revert: This appears to be quite flaky on the Mac test bots. Flakiness dashboard for this test (failures start with this commit) https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=PowerMonitorTest.TestGpuProcess&testType=content_browsertests Original change's description: > NetworkService: fix PowerMonitorTests > > PowerMonitorTests were not expecting the utility service to be started > during initialization, and could fail due to no closure being set by the > test. We now don't attempt to bind the PowerMonitor unless the test has > asked for it beforehand. > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I15071d2a55dbc251240835c1046b095e6b22e0c4 > Reviewed-on: https://chromium-review.googlesource.com/931468 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538772} TBR=jam@chromium.org,clamy@chromium.org Change-Id: I27715f6f11388034ca501146aa0414da79b7413d No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/934861Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#538817}
-
Peter Kotwicz authored
The enterprise admin will be able to configure the display_mode (standalone/fullscreen/minimal-ui) with which the enterprise WebAPK is launched. The enterprise server will generate a WebAPK with the requested display mode in the org.chromium.webapk.shell_apk.displayMode <meta-data> tag. The WebAPK server will no longer populate the org.chromium.webapk.shell_apk.disableFullScreenMode <meta-data> tag. BUG=None Change-Id: I49c0f4965d54ea76572e34fc54d78db5e82edb50 Reviewed-on: https://chromium-review.googlesource.com/934633Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#538816}
-
Avi Drissman authored
BUG=none TEST=existing tests Change-Id: I65793a97dd3a3798014a39756441094fb4d4d4a7 Reviewed-on: https://chromium-review.googlesource.com/931624Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#538815}
-
Bartosz Fabianowski authored
This class ties together collection, storage and upload of app push-install event logs. It creates an |AppInstallEventLogger| that generates log entries, collects the entries, schedules their upload to the server and their storage on disk. All operations related to the log file happen on a background task runner. This CL also adds the |AppInstallEventLogger| which, however, for now does not generate any log entries yet. Bug: b/73277923 Test: unit_tests Change-Id: I3eb421111339b1566aa6c7f5d8897af6e16fe090 Reviewed-on: https://chromium-review.googlesource.com/929502Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#538814}
-
Michael Thiessen authored
The first few frames received after entering VR could still contain the browser-compositor-drawn omnibox texture, so we have to wait until we get a frame without that (using the content offset as a proxy to know when the omnibox is gone). Bug: 807647 Change-Id: Ib9119aacaefe653c09c80da553305e79d14a2413 Reviewed-on: https://chromium-review.googlesource.com/934404Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#538813}
-
erikchen authored
The previous calculation used platform, process counters, which includes anonymous, faulted, shared memory. Since we now explicitly track all shared memory regions, we discount by anonymous, resident, shared memory. This introduces a slight source of error [difference between resident vs faulted], but the error should be lower than previous. Measured locally, this change will cause PrivateMemoryFootprint to be lower by 0-8MB for most processes, up to 30MB [rarely] for the browser. Change-Id: I8b562fc185d215debbcfde60a3ad5c35302271b9 Bug: 812346 Reviewed-on: https://chromium-review.googlesource.com/924541 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#538812}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c891f13e..a5154855 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If6fb8f4bf8a0317afbec739a3ef973e453aacad8 Reviewed-on: https://chromium-review.googlesource.com/933614Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#538811}
-
https://skia.googlesource.com/skia.git/+log/37c0f7183ebc..413782e8540d $ git log 37c0f7183..413782e85 --date=short --no-merges --format='%ad %ae %s' 2018-02-23 angle-skia-autoroll Roll skia/third_party/externals/angle2/ f7f0b8c3a..e41df6556 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I540e6c2953e9622d24acdd2439b6ed7800007af4 Reviewed-on: https://chromium-review.googlesource.com/934319 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#538810}
-
James Cook authored
It suggested some renaming that I'm not sure is a good idea anymore. TBR=stevenjb@chromium.org Bug: none Change-Id: Icceb6281b3962f7d99b6370ed37a3a51efebf615 Reviewed-on: https://chromium-review.googlesource.com/934637Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#538809}
-
kylechar authored
The SharedBitmapManager interface is part of viz. Move the test implementation into components/viz/test to cleanup dependencies. Bug: 814475 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5b4f0129f8cf8c4e0f5f01e4e742a1bc89d314a5 Reviewed-on: https://chromium-review.googlesource.com/932843 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#538808}
-
wutao authored
This cl moves Keyboard Shortcut Viewer (KSV) from ui/chromeos to ash/components. Bug: 768932 Test: Add ksv_unittests to ash_unittests and pass. Change-Id: I3ea028dadcf75fab5235e75a8f53181c90da4778 Reviewed-on: https://chromium-review.googlesource.com/930466Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#538807}
-
Boris Yusupov authored
In test looks like featureWithParameters: ['some::kFeature', [['index', '4'],]], Change-Id: I13be297a8a7ec3509edc7ec2830b0785f058a2da Reviewed-on: https://chromium-review.googlesource.com/923981Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Boris Yusupov <boriay@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#538806}
-
Leonard Grey authored
This reverts commit 06ec9a76. Reason for revert: Bot isn't stable enough Original change's description: > Add presubmit to run the MacViews bot on Mac views changes > > Change-Id: I3188b7b0081e1e81cba3a5a09fdbcf536e1416bf > Reviewed-on: https://chromium-review.googlesource.com/922023 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537087} TBR=ellyjones@chromium.org,rsesek@chromium.org,lgrey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib9d5d25e511e50fba4233026bf90e66e7621b476 Reviewed-on: https://chromium-review.googlesource.com/934761Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#538805}
-
James Cook authored
Bug: none Change-Id: Iac0e7ffce62c000b921cb53a6174309fb99a8a72 Reviewed-on: https://chromium-review.googlesource.com/933366Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#538804}
-
khmel authored
As described TEST=git cl try BUG=N/A Change-Id: I27e72935dce8ef31d8e35a55c88909dff2e569b7 Reviewed-on: https://chromium-review.googlesource.com/933003 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#538803}
-
Emily Hanley authored
on android one. TBR=charliea@chromium.org NOTRY=true Bug: 815193 Change-Id: Ia70936dbd0602b054700f7fd6ca2555cf7035bc0 Reviewed-on: https://chromium-review.googlesource.com/934636Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#538802}
-
Gauthier Ambard authored
This CL gets the favicon sizes from HTML, allowing the favicon driver to choose the favicon with the size closest to the one wanted. Before, all the favicons were treated as if they have the same size. When choosing the largest favicon, the favicon driver had to choose at random. Bug: 812317 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I309b7f08367725ea1b50b343b5e075afb14957af Reviewed-on: https://chromium-review.googlesource.com/922061 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#538801}
-
Tim Brown authored
This reverts commit 05a0b26e. Reason for revert: http://crbug.com/815046 - same swarming bots failing because they don't have libappindicator3. Original change's description: > Use libappindicator to show icons in all cases > > libappindicator will transparently use GtkStatusIcon if an AppIndicator > listener is not available. We will lose the left click action however, > and instead the right-click menu will be shown in all instances. > > Using libappindicator in all cases not only reduces code complexity, > but also abstracts away the complexity of determining when to use > application indicators (vs legacy icons), which is a little more > complicated with newer versions of GNOME removing the legacy icon tray, > but older versions of GNOME not showing the application indicator by > default. > > I also fixed an issue with detecting GNOME. The environment variable > value is often prefixed with the distro. > > Bug: 799144, 797332, 419673 > Change-Id: I156698f1b37ba216b4df11fa2f17dd7012c593fa > Reviewed-on: https://chromium-review.googlesource.com/911820 > Reviewed-by: Elliot Glaysher <erg@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Tim Brown <timbrown@chromium.org> > Cr-Commit-Position: refs/heads/master@{#538635} TBR=thomasanderson@chromium.org Change-Id: I61db904019740f878c4f6d6303e600b717d7888d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799144, 797332, 419673 Reviewed-on: https://chromium-review.googlesource.com/934701Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#538800}
-
Stephen McGruer authored
This allows CSS animations to be in a proper state for the call. Bug: 813908 Change-Id: Ibd3870432b0c6fc8cc1766fe5c8abec3263db879 Reviewed-on: https://chromium-review.googlesource.com/927322 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#538799}
-
Stephen McGruer authored
In theory cc/animation should never refer to blink, as we support multiple animation clients (blink, ui, vr currently). Completely eradicating references has proven difficult, but this is a step in the correct direction. This CL also fixes the use of "cc::" in a cc namespace that had been annoying the upload presubmit. Bug: None Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I04bd36e1211b9c4ce95acea72d3f2ead694a1be4 Reviewed-on: https://chromium-review.googlesource.com/929355 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#538798}
-
Yash Malik authored
This CL extends our keyboard text diff computation by assing support for text compositions. This CL does the following refactoring/renaming: - KeyboardEdit becomes TextEditAction. Each action has an ActionType which roughly corresponds to a method in the android InputConnection. - We pass a list of TextEditActions, called TextEdits, to VrInputConnection in java land which calls the corresponding functions in InputConnection. The tests in content_element_unittest.cc outlines to expected TextEditActions in various scenarios. Bug: 641470 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2045b1dd5f17bfb09e2219ecb2c7de7b30b8086d Reviewed-on: https://chromium-review.googlesource.com/933701 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#538797}
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=True Bug: 815181 Change-Id: I14167f579acd5b6cdc3bcd0606e6ea3661157cc7 Reviewed-on: https://chromium-review.googlesource.com/934631Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#538796}
-
Peter Beverloo authored
By passing |serialized_value| as the first argument to the std::string::find() operation, we're not using the # sign as the separator, but rather as the offset at which we start searching for the needle. This led to tokens failing validation because the expected registration Id differs, which in turn made features drop recent subscriptions thinking they were broken. Bug: 799483 Change-Id: I9522b5093f89419c89f0f80d70adfa7d0b2f6e57 Reviewed-on: https://chromium-review.googlesource.com/932262 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#538795}
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=true Bug: 815175 Change-Id: I845756bd9ead74657ccc80a8a3568dc615ed3bb6 Reviewed-on: https://chromium-review.googlesource.com/934627 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#538794}
-
Justin Cohen authored
Adding a delegate method to update the tablet toolbar omnibox view as the NTP is scrolled. The bulk of the changes here are to rename IncognitoViewControllerDelegate to NewTabPageControllerDelegate and the new piping to add the toolbar delegate. Bug: 805642 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I765dd60d58058605272a45b97401ae5d07cdf0ad Reviewed-on: https://chromium-review.googlesource.com/932623Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#538793}
-
Julia Tuttle authored
The Reporting header parser expects to receive the result of parsing a JSON list. The production code that calls it ensures this by wrapping the normalized header value in square brackets, but my modification to the fuzzer didn't. Now it does. Bug: 815144 Change-Id: I2f017c4be2ab39ce3c5b4fb0019b95a7b991b4b0 Reviewed-on: https://chromium-review.googlesource.com/934661 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#538792}
-