- 17 Aug, 2018 40 commits
-
-
Clark DuVall authored
It looks like some of the changes to ThrottlingURLLoader in http://crrev.com/c/1157549 caused some perf regressions on mobile. This fixes the regressions. Something with how StartInfo was created and passed around before was causing problems. See bugs for more info. Confirmed regressions fixed with this CL using pinpoint. Bug: 874902, 873881, 874918 Change-Id: I34397b8f97cffa82857f87ed19ac6ef5b61a7cac Reviewed-on: https://chromium-review.googlesource.com/1178576Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584086}
-
Peter Beverloo authored
It's been crashing flakily on various platforms, and is blocking try-bots on unrelated CLs. TBR=sandersd@chromium.org NOTRY=true (disabling a test) Bug: 875278 Change-Id: I93ebe231e45bdc813e39f465056dfc6bd1cde920 Reviewed-on: https://chromium-review.googlesource.com/1179892 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#584085}
-
Fabio Tirelo authored
This is a PE fix for the CVC dialog. The current credit card number obfuscation approach uses U+2006 (SIX-PER-EM SPACE) to add a small space between bullets and between the last bullet and the first unobfuscated digit. However, that character works as a simple space and allows line breaks inside the obfuscated number on multiline dialog titles. This CL adds U+2060 (WORD-JOINER) characters between bullets and spaces in the obfuscated strings, so they can't be broken into separate lines. A previous version tried to use U+202F (NARROW NO-BREAK SPACE), but unfortunately the result looked too spacey on Android. The new character is invisible, so the only visual change is that now obfuscated numbers can't be broken. Screenshots in the bug. Bug: 873816 Change-Id: I927be848d2f63a5a76486668baebe64e7eb304f6 Reviewed-on: https://chromium-review.googlesource.com/1173338Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#584084}
-
Tarun Bansal authored
Currently, in previews, we match the document URL with the the provided hints using substring matching. This CL changes the matching algorithm to a wildcard matcher instead of substring matcher. Change-Id: I3cf827d094ee5e15a64737d9691743b29d4c0bf3 Bug: 870039 Reviewed-on: https://chromium-review.googlesource.com/1176594Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#584083}
-
Nico Weber authored
Bug: none Change-Id: I156a2d2b7d8569e3a8fe7a17e09d52c859710ae6 Reviewed-on: https://chromium-review.googlesource.com/1179607Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584082}
-
Ned Nguyen authored
This CL also refactors the method to generate the story set from benchmark into tools/perf/core/benchmark_utils.py for better code sharing Bug:874940 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I2a551840fd852162a4743eac769d92c6ee499bc4 NOTRY=true # all tests passed in patch set 3 Change-Id: I2a551840fd852162a4743eac769d92c6ee499bc4 Reviewed-on: https://chromium-review.googlesource.com/1179603 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#584081}
-
Ryan Daum authored
A single detector for both multiple and triple tap events on cast, as part of the effort so that the triple tap for the magnification gesture and the double tap inside the TouchExplorationController do not conflict. Bug: internal b/112634029 Test: manual and unit test Change-Id: Ifd23bbc40eb9cfd710acce7ca387eaae137c7ba1 Reviewed-on: https://chromium-review.googlesource.com/1178640Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#584080}
-
Tibor Goldschwendt authored
This is required so that the public and internal AR module can have different names. Bug: 863063 Change-Id: If0151c862efa2074f00868519c7f68d39836c538 Reviewed-on: https://chromium-review.googlesource.com/1178882Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584079}
-
Sammie Quon authored
Test: added test Bug: 850630 Change-Id: I50796ab56aa2888bd77d98389a7de876f42aa0d8 Reviewed-on: https://chromium-review.googlesource.com/1179303Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#584078}
-
Hiroshige Hayashizaki authored
Bug: 864748, 829084 Change-Id: I164d3a83345ca9fe02a31f6a09d7fc646299a436 Reviewed-on: https://chromium-review.googlesource.com/1141105Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#584077}
-
Roger McFarlane authored
This CL adds a feature flag to enable/disable communication with the autofill server. It further adds a feature parameter by which the autofill server URL can be controlled. This functionality is to support: - routing a % of users to exercise a staging server environment to ensure better server validation before rollout. - turning off or rerouting autofill server traffic from the test bots. By default, autofill server communication is enabled and will send traffic to the existing autofill server. Bug: 874553, 866940 Change-Id: I8a425c76d483731fce9ef0ef8e10ac0cc145cb1d Reviewed-on: https://chromium-review.googlesource.com/1176287 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584076}
-
Koji Ishii authored
This patch matches to the changes in the base expectations when flag-specific rebaselines were needed for space-only differences. TBR=eae@chromium.org, xiaochengh@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie93864457ba5ac3ff2d73fdc1783623a53b967e3 Reviewed-on: https://chromium-review.googlesource.com/1179735 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584075}
-
Peter E Conn authored
When calling SnackbarManager#dismissSnackbars with a persistent snackbar, you get an IllegalStateException from Iterator#remove. This is because we attempt to remove the persistent Snackbar from the list of non-persistent Snackbars. This CL splits out the logic so we iterate through the persistent and non-persistent Snackbar deques separately. Bug: none Change-Id: I620ba14fd1eaa75ab5ba6a34870655218bd3fd22 Reviewed-on: https://chromium-review.googlesource.com/1179672 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#584074}
-
Javier Ernesto Flores Robles authored
Obj-c model for the manual fallback passwords view controller. Also adds a convenience initializer from a password form. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0bdd704eb9cfa075f7cd78bdea2eaed191cd5bd0 Reviewed-on: https://chromium-review.googlesource.com/1172348Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#584073}
-
Gauthier Ambard authored
This CL removes the image property of the ShareToData class, as it is never set. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idd71cfe674e27705ac674c6e815e790f25a13755 Reviewed-on: https://chromium-review.googlesource.com/1179830Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#584072}
-
Chris Lu authored
Remove all references to CollectionsUIReboot flag. Bug: 875063 Change-Id: I5222da0ba5ec50da282a434f8e075758feebb59a Reviewed-on: https://chromium-review.googlesource.com/1178932Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#584071}
-
Tibor Goldschwendt authored
Bug: 862694 Change-Id: I4ab7cb60c8e397964f88449c31ff4fd0d6f4e253 Reviewed-on: https://chromium-review.googlesource.com/1173252Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584070}
-
Robert Ma authored
In https://crrev.com/c/833751 we stopped to create new baselines for testharness.js tests without existing baselines. This behaviour is in fact undesired: if a testharness.js test used to pass (and hence didn't have a baseline), we'd like to be able to create a new baseline for it using --reset-results if it starts to fail. The comment is improved so hopefully that is clear enough. Bug: 864410 Change-Id: I9b21a6e8d909585f8eb44e53dd90b488f383ea1a Reviewed-on: https://chromium-review.googlesource.com/1179363 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584069}
-
Friedrich Horschig authored
The test that used to be disabled on Win only is now disabled on Mac as well. Recent flake: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14961 Flakiness dashboard confirming the flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=components_unittests&tests=SslCastSocketTest.TestConnectEndToEndWithRealSSL TBR=wjmaclean@chromium.org Bug: 874491 Change-Id: Ida63c17fc4618d1944f947c3fcf0a0247bc04d57 Reviewed-on: https://chromium-review.googlesource.com/1179882Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584068}
-
Fredrik Söderquist authored
The 'params.name == HTMLNames::classAttr' condition will never be true, because the if-block just above it will catch that case. The |class_name_| SVGAnimatedProperty object is registered in the attribute map. Retain and update the comment about the somewhat special handling of the 'class' attribute. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9928fb6f9c29d5db961b7f937fe4b1c0fb3fde82 Reviewed-on: https://chromium-review.googlesource.com/1179749Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#584067}
-
Fabio Tirelo authored
This DCHECK is sometimes hit for the password popup on DCHECK enabled windows canary asan builds, and it shouldn't exist. Returning a default value instead. Bug: 874062 Change-Id: Ib5be385fb9108aadd8cba09bf587a61ff097cea5 Reviewed-on: https://chromium-review.googlesource.com/1174896Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#584066}
-
Justin Donnelly authored
Note that I'm omitting the URL elision experiment (OmniboxUIExperimentHideSteadyStateUrlSchemeAndSubdomains). That seems to have broken a few browser tests, so tommycli is going to fix them and add it to the testing config in a later CL. Bug: 854714, 806995, 824893 Change-Id: I99b79d22ee5f1a3df0ec780a4283c7211f107a12 Reviewed-on: https://chromium-review.googlesource.com/1176391Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#584065}
-
Domenic Denicola authored
This CL updates the implementation and tests to be adapted versions of https://github.com/domenic/async-local-storage/tree/73580d0151f04849ca9e691807907e95c4d17d12/prototype. Change-Id: I9071883a6fef8ef97c405a9a749bf9c2d3cfb58a Reviewed-on: https://chromium-review.googlesource.com/1171573Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584064}
-
Friedrich Horschig authored
Another recent flake was in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/1633 TBR=sahel@chromium.org Bug: 869726 Change-Id: I8822f4fb53a2c762ddbb46f66ba307b3803b765d Reviewed-on: https://chromium-review.googlesource.com/1179836Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584063}
-
Jeffrey Cohen authored
Bug: 864612 Change-Id: I353668033e7144714fdfc8327f9cd46962e0b22c Reviewed-on: https://chromium-review.googlesource.com/1176737Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584062}
-
Fredrik Söderquist authored
It's not used. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If6630b2e404108044833ea5512151facdfe7e59d Reviewed-on: https://chromium-review.googlesource.com/1179760Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#584061}
-
Tonko Sabolčec authored
This CL includes: - Add a util class which sets the preference on the main thread. - Use utility class in LoginDatabase to set the date on successul deletion of undecryptable passwords. - Expand DB tests to make sure that the pref is stored. Bug: 791541 Change-Id: I32c2afc70c6091175cae09a7120de7622b568448 Reviewed-on: https://chromium-review.googlesource.com/1178052 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#584060}
-
Jerry Lin authored
This fuzzer passes fuzzed message |PasswordRequirementsSpec| to function |GeneratePassword|. The random choices inside the function are still random and not replaced by the fuzzed input. R=vabr@chromium.org Bug: 847200 Change-Id: I221fe286328d5818bd50282046799e8930079298 Reviewed-on: https://chromium-review.googlesource.com/1120088Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584059}
-
Robert Ma authored
No-Try because the test hasn't been imported. TBR to unblock the importer. TBR=foolip No-Try: True Bug: 875249 Change-Id: I3a799b9aa326f59422ef60218e53c6cbdb932792 Reviewed-on: https://chromium-review.googlesource.com/1179811Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#584058}
-
Leonard Ge authored
This CL is a follow up CL of CL: 1174721. So we don't add field trial flag when the new compatibility mode flag is set. Bug: chromium:866881 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I5dae5a130445b9c61ad40cb13744a6272947424b Reviewed-on: https://chromium-review.googlesource.com/1175127Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Leonard Ge <wangge@google.com> Cr-Commit-Position: refs/heads/master@{#584057}
-
Tommy C. Li authored
Currently, if the user has unelided the URL, the URL won't reset on navigation. Instead, we should only only preserve the URL if the user has actually made modifications, rather than merely uneliding the URL. Bug: 875002 Change-Id: Ie138ee9a0b4cf7d7d903d600a739deb2378de29c Reviewed-on: https://chromium-review.googlesource.com/1178631Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#584056}
-
Friedrich Horschig authored
Adding another test to the pile of flaky test in this file. See bugs for recent failures. TBR=sahel@chromium.org,dtapuska@chromium.org Bug: 836996, 875186 Change-Id: Ie8b3565a9f785304f60ca2e2dac1c6ff77f30fb4 Reviewed-on: https://chromium-review.googlesource.com/1179827Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584055}
-
Friedrich Horschig authored
This is a known issue but the expectation was (as assumed) missing in this file: https://crrev.com/c/1074907 TBR=caseq@chromium.org Bug: 847114 Change-Id: I94ea44f67d95b0aee83745980a3b221dec79b677 Reviewed-on: https://chromium-review.googlesource.com/1179759Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584054}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aea32f9d6ad3..adc48799090c git log aea32f9d6ad3..adc48799090c --date=short --no-merges --format='%ad %ae %s' 2018-08-17 phoglund@webrtc.org Make sure video_capture_tests run sequentially. Created with: gclient setdep -r src/third_party/webrtc@adc48799090c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I97703dc019c4117946fb76f53e6c0bab863686e9 Reviewed-on: https://chromium-review.googlesource.com/1179330Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584053}
-
Antonio Gomes authored
BUG=714018 Change-Id: I59944400286435c71ed605ba019cd7f2680e5532 Reviewed-on: https://chromium-review.googlesource.com/1174656Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#584052}
-
Valeriya Sinevich authored
Change-Id: I7ad08f099b3d1901575b465fbd9bcfe46911ca7e Reviewed-on: https://chromium-review.googlesource.com/1170690 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584051}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d85a23b6c18..c7e7bd382c39 git log 3d85a23b6c18..c7e7bd382c39 --date=short --no-merges --format='%ad %ae %s' 2018-08-17 anthonyalridge@google.com Create a bar chart for data grouped by story. Created with: gclient setdep -r src/third_party/catapult@c7e7bd382c39 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I91249ff753976f235acabbc1869206a2b6c9afc1 Reviewed-on: https://chromium-review.googlesource.com/1179333Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584050}
-
Peter Wen authored
This is a bug that is already fixed in upstream apkanalyzer but not yet released and rolled in the various downstream projects and ultimately into Android SDK Tools (eventually). Bug: 874994 Change-Id: I9c83b6ee35c5691f687e174b3213ca7e71a9ea2c Reviewed-on: https://chromium-review.googlesource.com/1178687 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#584049}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates WebRtcEventLogUploaderImpl et al away from URLFetcher. Note that this CL slightly changes the flow of the WebRtcEventLogUploader code. Previously, an URLRequestContextGetter instance was acquired on UI thread, passed to the IO-capable task runner, used there, and ultimately deleted either on the UI thread or on the IO-capable task runner thread, depending on the termination circumstance (eg BrowserProcessImpl shutdown or upload completion, respectively). However, URLLoaderFactory and SimpleURLLoader have stricter threading restrictions than URLFetcher and URLRequestContextGetter. For instance, a SharedURLLoaderFactory instance needs to be created, used and deleted on the same thread. Given this scenario, a natural approach to tackle this migration would be the use of CrossThreadSharedURLLoaderFactory{Info} classes. However, as mentioned earlier, the fact that WebRtcEventLogUploader instances are constructed the aforementioned IO-capable task runner thread and the deletion thread varies, make the use of CrossThreadSharedURLLoaderFactory{Info} less straightforward. This CL makes use of the thread agnostic network::mojom::URLLoaderFactoryPtrInfo class instead: from the IO-capable task runner it posts a message to the UI thread to bind a network::mojom::URLLoaderFactory object. As per the mojo documentation [1]: "Once the LoggerPtr is bound we can immediately begin calling Logger interface methods on it, which will immediately write messages into the pipe. These messages will stay queued on the receiving end of the pipe until someone binds to it and starts reading them." [1] https://chromium.googlesource.com/chromium/src/+/master/mojo/public/cpp/bindings/README.md#Binding-an-Interface-Request BUG=773295,873187 Change-Id: Ic29222ea63e90dcb26f3124bdea1c627570dc04d Reviewed-on: https://chromium-review.googlesource.com/1171622 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Elad Alon <eladalon@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584048}
-
Julie Jeongeun Kim authored
It moves the code to read the data from FD to 'ReadDataFromFD' in WaylandDataDevice to reuse it for drag-and-drop, as WaylandDataDevice is the class to handle not only copy-and-paste but drag-and-drop and drag-and-drop needs to read the data from FD as well. It doesn't bring behavioral changes. Bug: 578890, 875164 Change-Id: I460ab9df2b4d32bbdb0e71c753cb19c572df12ab Reviewed-on: https://chromium-review.googlesource.com/1179505Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#584047}
-