GitLab

Using OnError() to deliver status codes during Initialize() complicates
upstream state paths, so require clients to return status via the
initialization callback provided instead of via the error callback.

BUG=450764
TEST=media_unittests, mojo://media_test

Review URL: https://codereview.chromium.org/870693002

Cr-Commit-Position: refs/heads/master@{#312958}

This has been causing occasional build breakage on the bots,
depending on whether we got unlucky in build ordering. Because
extensions_common and extensions_browser both cause
extensions_strings to run, I didn't notice this error before.

BUG=451442

Review URL: https://codereview.chromium.org/869743004

Cr-Commit-Position: refs/heads/master@{#312957}

BUG=393291

Review URL: https://codereview.chromium.org/873823002

Cr-Commit-Position: refs/heads/master@{#312956}

BUG=447059

Review URL: https://codereview.chromium.org/872453002

Cr-Commit-Position: refs/heads/master@{#312955}

GLShareGroup should be the same whenever MailboxManager is the same.
So store the GLShareGroup instance in the in-process service.

BUG=443464

Review URL: https://codereview.chromium.org/870693003

Cr-Commit-Position: refs/heads/master@{#312954}

The last active use of PluginReverseInterface was via its
StartupInitializationComplete()/"init_done" method, but recent
cleanups have made that into a no-op.

We can therefore remove PluginReverseInterface.  We no longer need to
call NaCl's "reverse_setup" SRPC call.

This removes the Chromium-side parts of the old SRPC-based
open_resource() implementation, which was no longer called.  This
allows us to remove OpenManifestEntry() from PPB_NaCl_Private.

Add some #includes to fix include-what-you-use problems that become
apparent after removing code.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864
TEST=NaCl tests in browser_tests

Review URL: https://codereview.chromium.org/870923004

Cr-Commit-Position: refs/heads/master@{#312953}

If two <webview>s have the same embedder process but have different embedder
WebContents, adding a WebRequest API event listener may fail if they happen
to generate the same subevent names. This CL fixes the problem by updating the
WebRequest EventListener's comparator to account for different <webview>s.

BUG=450161

Review URL: https://codereview.chromium.org/864893003

Cr-Commit-Position: refs/heads/master@{#312952}

Fixes name changes from https://codereview.chromium.org/816353008/

BUG=451541

Review URL: https://codereview.chromium.org/865403004

Cr-Commit-Position: refs/heads/master@{#312951}

If the user enters a word that triggers the alternate nav infobar (i.e. is a
search by default but also happens to be an intranet hostname), and the omnibox
navigation synchronously triggers the extension system to navigate a background
page, the background page navigation could be mistaken for the omnibox
navigation, leading to a crash when trying to show the infobar.

This could also goof up shortcut backend statistics, in theory, if the
background page navigation succeeded but the omnibox navigation did not.

This CL also adds a different CHECK to verify that the navigations that we do
pay attention to are the ones we want.  I'll convert this to a DCHECK in a
couple of weeks if it doesn't turn up anything in the field.

BUG=363105
TEST=none

Review URL: https://codereview.chromium.org/865313002

Cr-Commit-Position: refs/heads/master@{#312950}

C++11 range-based for loops make it a lot easier to iterate over an STL
container without incredibly long type names. The last users of these
typedefs have been updated and so they are no longer necessary.

BUG=

Review URL: https://codereview.chromium.org/869063004

Cr-Commit-Position: refs/heads/master@{#312949}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1c40292..6a14434

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/871913006

Cr-Commit-Position: refs/heads/master@{#312948}

BUG=449662, chrome-os-partner:35334
TEST=covered by unittest. Also tested on link_freon

Review URL: https://codereview.chromium.org/854203002

Cr-Commit-Position: refs/heads/master@{#312947}

BUG=

Review URL: https://codereview.chromium.org/872783003

Cr-Commit-Position: refs/heads/master@{#312946}

BUG=427660
TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/867963005

Cr-Commit-Position: refs/heads/master@{#312945}

Types such as DxDiagNode are causing OOMs in this case.

BUG=450268
R=inferno@chromium.org,tsepez@chromium.org

Review URL: https://codereview.chromium.org/871933003

Cr-Commit-Position: refs/heads/master@{#312944}

This is effectively a revert of commit positions 308378 and 307774.

BUG=451173
TBR=bauerb@chromium.org,rogerta@chromium.org

Review URL: https://codereview.chromium.org/872433003

Cr-Commit-Position: refs/heads/master@{#312943}

This is intentionally tiny and intended to be merged into M41.
views::Label already knows the size of the text (GetTextSize()
returns the cached size), therefore it knows the current text
does not fade at all.

Since this will avoid the check if the text may fade or not in
gfx::Canvas::DrawFadedString(), this can potentially make
the drawing 2x faster if the text doesn't fade at all.

BUG=451297
R=sky@chromium.org
TEST=on link_freon, with the bookmark sample in crbug.com/440551
  (contains ~15 bookmarks), repaint of bookmark bar is improved
  as: ~100msec -> ~55msec

Review URL: https://codereview.chromium.org/870903002

Cr-Commit-Position: refs/heads/master@{#312942}

Review URL: https://codereview.chromium.org/870913003

Cr-Commit-Position: refs/heads/master@{#312941}

BUG=chromedriver:998
NOTRY=true
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/870123002

Cr-Commit-Position: refs/heads/master@{#312940}

BUG=450854,429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/867333002

Cr-Commit-Position: refs/heads/master@{#312939}

<webview> has its own implementation of HandleKeyboardEvent that deals with back/forward keys
and so on but for keys it doesn't know how to handle, it should pass them along as other
GuestViews do.

This CL also moves WebContentsObserver and WebContentsDelegate overrides in GuestViewBase from private to protected.

BUG=none

Review URL: https://codereview.chromium.org/869193004

Cr-Commit-Position: refs/heads/master@{#312938}

This also updates the logging in shiil_property_util to use
device_event_log.h.

TBR=isherman@chromium.org for trivial change
BUG=none

Review URL: https://codereview.chromium.org/819583004

Cr-Commit-Position: refs/heads/master@{#312937}

This change eliminates the need to have a transparent button on top of
overview mode windows by installing a static event targeter on each of
the item windows. The targeter checks for events on the item bounds and
redirects events to a label button located under each item. This way, we
greatly simplify event handling while preventing events to reach the
actual windows.

The reason why we use a label button now is that it already handles clicks
and taps, as well as accessibility stuff (touch exploration, chromevox
feedback) that were being handled in the transparent window before.

The CL only involves refactoring - no features have been added or
removed.

BUG=446548
TEST=WindowSelectorTest.*

Review URL: https://codereview.chromium.org/810033010

Cr-Commit-Position: refs/heads/master@{#312936}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5b18308..9994197

TBR=kochi@chromium.org,pilgrim@chromium.org

Review URL: https://codereview.chromium.org/873543003

Cr-Commit-Position: refs/heads/master@{#312935}

BUG=450428

Review URL: https://codereview.chromium.org/861953002

Cr-Commit-Position: refs/heads/master@{#312934}

Review URL: https://codereview.chromium.org/870093002

Cr-Commit-Position: refs/heads/master@{#312933}

NativeDisplayDelegateProxy needs to read a file which is necessary to start chrome on UI thread. The file is on tmpfs, so it should be fast.

I've got jam@'s agreement, who is the owner of base/threading/thread_restriction*, in https://codereview.chromium.org/854203002/

BUG=None
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/866103002

Cr-Commit-Position: refs/heads/master@{#312932}

This pulls in a single change—a build fix for ARMv6 builds.

c5cc15b Don't expect bsaes functions on ARMv6.

BUG=none

Review URL: https://codereview.chromium.org/874543004

Cr-Commit-Position: refs/heads/master@{#312931}

Once again, issue remains in Android version 5.0.2.

BUG=438657

Review URL: https://codereview.chromium.org/867893002

Cr-Commit-Position: refs/heads/master@{#312930}

Move expire_history_backend.{cc,h} into //components/history/core/browser
and update .gyp and .gn files.

Remove some obsolete code in expire_history_backend_unittest.cc file.

BUG=370850
R=droger@google.com

Review URL: https://codereview.chromium.org/870593003

Cr-Commit-Position: refs/heads/master@{#312929}

Rename webview_ to web_view to be more consistent with naming elsewhere.

Use auto when useful.

BUG=none

Review URL: https://codereview.chromium.org/873533002

Cr-Commit-Position: refs/heads/master@{#312928}

Remove gray background color for non-focused selected list items on chrome://settings/autofillEditAddress page.

BUG=444770

Review URL: https://codereview.chromium.org/840503002

Cr-Commit-Position: refs/heads/master@{#312927}

When DelegatedFrameHost was split off from RenderWidgetHostViewAura,
I had DelegatedFrameHost access the ui::Compositor via a call into the
client. This is harder to reason about than it should be, and leaves open
the possibility of keeping the DelegatedFrameHost as an observer of a
dead ui::Compositor.

Explicitly detach the DelegatedFrameHost from the ui::Compositor
when the ui::Compositor is being destroyed. Add a check to the
observer list, to ensure that it is empty at destruction.

BUG=(paying down technical debt)

Review URL: https://codereview.chromium.org/859423002

Cr-Commit-Position: refs/heads/master@{#312926}

This patch changes the way eviction queue is built to be more like the
raster queue. That is, instead of taking a pointer to the queue to be
built, the function returns a scoped_ptr to the queue that it built.

R=reveman, danakj

Review URL: https://codereview.chromium.org/862263004

Cr-Commit-Position: refs/heads/master@{#312925}

This is never null anymore, no need to check for null-ness.

R=vmpstr

Review URL: https://codereview.chromium.org/865973007

Cr-Commit-Position: refs/heads/master@{#312924}

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/868153002

Cr-Commit-Position: refs/heads/master@{#312923}

For future CL: queueing messages, sending messages from Java to JS through message channel, transferring ports in message channels, closing channels.

BUG=393291

Review URL: https://codereview.chromium.org/831523004

Cr-Commit-Position: refs/heads/master@{#312922}

The idea here is that for reasons not fully understood at the moment, the
files in this CL failed the checkperms script, so 808773005 can't land.

This CL attempt to land the offending files, with two goals in mind. First,
unblock 80877300. Second, provide a clear repro for the chrome-infra team to
look at, in case something fails.

There is something going on uploading binary patches and permissions using
git cl upload.

BUG=450337
R=blundell@chromium.org, waffles@chromium.org

Review URL: https://codereview.chromium.org/866143002

Cr-Commit-Position: refs/heads/master@{#312921}

BUG=444242

Review URL: https://codereview.chromium.org/813873005

Cr-Commit-Position: refs/heads/master@{#312920}

This removes another source of raw process handles.

BUG=417532

Review URL: https://codereview.chromium.org/860453002

Cr-Commit-Position: refs/heads/master@{#312919}