- 03 Dec, 2019 40 commits
-
-
Omer Katz authored
During insertion the HashTable might need to expand. If that happens, a new backing store is allocated and all existing entries are moved over to the new store. Updating the backing store pointer can race with reading it during tracing. To resolve the race, the read in Trace and the write in RehashTo need to be atomic. Bug: 986235 Change-Id: I0d6d4350026144a1e1675313ec7b193fd58beaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943141Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720957}
-
Brian Salomon authored
Bug: 1028116 Change-Id: I06e931ff71384883181db349dc269cd324da6975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940447 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#720956}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d405652ad675..13c558ef1494 Created with: gclient setdep -r src-internal@13c558ef1494 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0ae1e063c03faa212547eb8a8e8bb8d33c1d5f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948600Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720955}
-
Balazs Engedy authored
Bug: 1028642 Change-Id: I0a16154ead9b668f2100afc4e46caa0a5c879269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945818 Auto-Submit: Balazs Engedy <engedy@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720954}
-
Eric Seckler authored
This reverts commit fcbcc346. Reason for revert: The benchmarks were timing out during trace conversion. We increased the timeout in [1], which hopefully resolves the flakiness / failures. [1] https://chromium-review.googlesource.com/c/catapult/+/1944488 Original change's description: > Disable tests which are failing on Android. > > browse:news:nytimes:2019 > browse:social:facebook_infinite_scroll > browse:news:washingtonpost:2019 > > TBR: crouleau@chromium.org > Bug: 1029460,1029465,1029467 > Change-Id: I0de4f43db3cc3f499724d71577fe6a0294ff229b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943137 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720173} TBR=nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029460, 1029465, 1029467 Change-Id: Ibe7dee84ecf3befba6917340b7a5eab2964fe58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948441Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#720953}
-
Mark Cogan authored
To make unit tests less cumbersome, this CL adds a parameterless constructor for TestBrowser that creates and owns a BrowserState and WebStateList internally. Tests that don't need to customize either of these classes can just use this constructor without needing to add the boilerplate set-up for TestChromeBrowserState and WebStateList. Conversion of existing tests to use this constructor will follow in another CL. Change-Id: I1c976978b8f3af01c602ac8024a0bd432dd60d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948431 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#720952}
-
Deepti Gandluri authored
Bug: chromium:988636 Change-Id: I069baf64619f6a5e65355b119eb9a534cd3b464d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946427Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#720951}
-
David Bokan authored
Since we now latch all gesture scrolling, the scroll chain calculation isn't necessary and only adds complexity to scrolling code. This CL removes the chain calculation and simply uses the first scrollable node, which was the behavior anyway. This is the first in a series of cleanups to make CC scrolling code simpler and more understandable. Bug: 582049,1016229,1029781 Change-Id: I43e11d940d105ed0ede3566b82e84112f35fc1c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944320 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#720950}
-
Ali Juma authored
This adds the file as an EG2 target, and updates #includes. Bug: 987646 Change-Id: Ia54fb85be2294a50e07cb28c6f1f43f91f7f2b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946529Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#720949}
-
henrika authored
Fine tunes current native logs to match latest changes in the AudioInputDeviceManager (AIDM). Now makes it easier to track a stream identified with a unique ID (many logs contain multiple streams). audio::IS::Ctor({id=4E660FF11A9BBFEFB85C97DF686A4E77}, {device_id=default}, {params=[format: 1, channel_layout: 3, channels: 2, sample_rate: 44100, frames_per_buffer: 441, effects: 0, mic_positions: ]}, {enable_agc=1}) AIC::DoCreate({device_id=default}) [id=4E660FF11A9BBFEFB85C97DF686A4E77] audio::IS::OnCreated({id=4E660FF11A9BBFEFB85C97DF686A4E77}, {muted=0}) audio::IS::Record({id=4E660FF11A9BBFEFB85C97DF686A4E77}) AIC::Record() [id=4E660FF11A9BBFEFB85C97DF686A4E77] audio::IS::SetOutputDeviceForAec({id=4E660FF11A9BBFEFB85C97DF686A4E77}, {output_device_id=}) audio::IS::SetOutputDeviceForAec({id=4E660FF11A9BBFEFB85C97DF686A4E77}, {output_device_id=}) AIC::OnData => (average audio level=-80.88 dBFS <=> low audio input level) [id=4E660FF11A9BBFEFB85C97DF686A4E77] AIC::OnData => (microphone volume=65%) [id=4E660FF11A9BBFEFB85C97DF686A4E77] AIC::OnMuted({is_muted=1}) [id=4E660FF11A9BBFEFB85C97DF686A4E77] AIC::OnMuted({is_muted=0}) [id=4E660FF11A9BBFEFB85C97DF686A4E77] audio::IS::Dtor({id=4E660FF11A9BBFEFB85C97DF686A4E77}) AIC::Close => (stream duration=1 seconds) [id=4E660FF11A9BBFEFB85C97DF686A4E77] No-Try: True Tbr: olka Bug: 1017219 Change-Id: I7c35459c5c161a912f1d2181639ffaeeac95e6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944682 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720948}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/69272c40ae6e..25d54ed1700d git log 69272c40ae6e..25d54ed1700d --date=short --first-parent --format='%ad %ae %s' 2019-12-03 perezju@chromium.org [Telemetry] Disable failing AndroidBrowserBackendTest's Created with: gclient setdep -r src/third_party/catapult@25d54ed1700d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1030208 Tbr: sadrul@google.com Change-Id: I313ccf2c80768ae2c4e8e6d117cb7338f82ca331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720947}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bfcc2cabed77..8a582e859273 git log bfcc2cabed77..8a582e859273 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 treehugger-gerrit@google.com Merge "Add an enum I mistakely thought was the same and also add additional fields that I missed." Created with: gclient setdep -r src/third_party/perfetto@8a582e859273 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I19eb9de118aba9d1d7ad29de46f6563e32a259b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948599Reviewed-by:
-
Roman Sorokin authored
Bug: none Change-Id: Id4a60cef0a5c49558118dcaa4d07834c5340481c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947646Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720945}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c523feb71099..becc67f976ee git log c523feb71099..becc67f976ee --date=short --first-parent --format='%ad %ae %s' 2019-12-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@becc67f976ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4eeda7f96d046993d1289e9027e8ecd1e8868b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948598Reviewed-by:
-
danakj authored
Also from StoragePetition it uses which is defined in content/public/. This changes BluetoothDevice::ConnectErrorCallback to be a OnceCallback, then the Bind() call in content can become a BindOnce(). R=clamy@chromium.org Bug: 1007763, 1007760 Change-Id: Iaf1928397c3c913df87e1297c1ad4ffe13f907a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944312 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720943}
-
Juan Antonio Navarro Perez authored
These appear to be no longer used. Also deschedule them from android-nexus5x-perf-fyi_map, where they used to be running. That fyi bot might be useful, though, so we keep it for now running another benchmark. Bug: 1029016 Change-Id: I80258ba901b4cafd3012c532fef027d47fd53987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944671 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#720942}
-
Nazerke authored
This CL adds all signin settings tests to EG2 target and updates headers and adds eg2_test source_set in build file. New app interface for signin settings tests is being introduced. Bug: 987646 Change-Id: I6d888342c059b8b1767e910697b3f4d1a9b483e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903192 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Shuhei Takahashi authored
This reverts commit bdc39552. Reason for revert: breaks graphics on some Chrome OS devices. Original change's description: > Move GPU and Plugin processes off Service Manager > > This introduces a new mode for Browser/ChildProcessHost where the > primordial pipe is a simple content.mojom.ChildProcess pipe. This will > become the new default mode of operation for child processes, and > eventually will be the only mode of operation once NaCl processes are > gone. > > GPU and plugin processes are ported to this mode here since both > require only minimal changes. This means that "content_gpu" and > "content_plugin" services no longer exist. > > Bug: 977637 > Change-Id: I39c5d2284bd84246663d5f0eb4cbab3b3483d798 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918326 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#717857} NOPRESUBMIT=true Bug: 1028852 Bug: 977637 Tbr: rockot@google.com Tbr: avi@chromium.org Tbr: rsesek@chromium.org Change-Id: I21259f3cf7718ad940cafba4a56d9349412d3b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948664 Commit-Queue: Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#720940}
-
Shuhei Takahashi authored
This reverts commit 881a65d7. Reason for revert: breaks graphics on some Chrome OS devices. Original change's description: > Move Renderer processes off Service Manager > > Migrates Renderer processes to use the simpler ChildProcess IPC > interface in place of deprecated Service Manager IPC. > > Support for preloaded files in service manifest definitions is > effectively removed in favor of explicit parameters on > BrowserChildProcessHost and ChildProcessLauncher. The only use case (V8 > snapshot files) has been migrated from manifest data to a simple map > definition, and it's used during renderer and utility process > launching. > > After this CL, only utility processes remain to be moved off of > Service > Manager IPC. > > NOPRESUBMIT=true > > Bug: 977637 > Change-Id: I1d8205cb73ead904aa21b85d6cbee11cb3fc84f5 > Tbr: boliu@chromium.org > Tbr: yucliu@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918375 > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#717920} NOPRESUBMIT=true Bug: 1028852 Bug: 977637 Tbr: rockot@google.com Tbr: boliu@chromium.org Tbr: yucliu@chromium.org Tbr: mbarbella@chromium.org Tbr: rsesek@chromium.org Tbr: avi@chromium.org Change-Id: I30a52d825cc156b066d7c2ec455c8fb588a408af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948663 Commit-Queue: Shuhei Takahashi <nya@chromium.org> Reviewed-by:
-
Shuhei Takahashi authored
This reverts commit 0a311ff4. Reason for revert: breaks graphics on some Chrome OS devices. Original change's description: > Move Utility processes off Service Manager > > This migrates Utility processes to direct ChildProcess API usage instead > of bootstrapping IPC through the Service Manager. > > As this is the last remaining use of Service Manager IPC to bootstrap > Content child processes, this also rips out a bunch of infrastructure > that existed only to support that. > > Bug: 977637 > Change-Id: I08e542f1d9f294bc1c387ea5845e8ba0d5a7d2b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919719 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718352} NOPRESUBMIT=true Bug: 1028852 Bug: 977637 Tbr: rockot@google.com Tbr: avi@chromium.org Tbr: rsesek@chromium.org Change-Id: I9b2e8ca44f5b6accc2d3718cab3cb547d979c230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948402 Commit-Queue: Shuhei Takahashi <nya@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
When we have a column spanner, we get multiple column sets, but we only set up the first one correctly. Bug: 829028 Change-Id: Icac7c8ba01d66c2508fdc60a510b42aa6d4792db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944355Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#720937}
-
Anastasia Helfinstein authored
Adds a presubmit check to enforce that all conditionals have brackets. Due to `git cl format` not matching the Chromium style guide for JS (see crbug/987439), it was decided to always use braces for the accessibility component extensions (see http://shortn/_rNxAMDRHqE). This change also creates a new directory, accessibility/common, as a first step towards sharing substantial code between the accessibility component extensions. Bug: 706981 Change-Id: I3f5134419957e4143e43a6e3f64fd11b59d1ed96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900300 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#720936}
-
Stepan Khapugin authored
Moves the user feedback delegate protocol implementation to the scene controller. Bug: none Change-Id: I5255321c4182f0d85c2ac4beccf92178b437f56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865312 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#720935}
-
Anna Malova authored
Bug: 1008592 Change-Id: I392f02daff125ff26c327ecf5467e6fe141aeb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943127 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#720934}
-
Clemens Arbesser authored
Prior to this CL, the overlay image would disappear during the flow because the check to disambiguate between full and partial overlays was wrong. Bug: 806868 Change-Id: Ice8e1bf16a4c077edea81f13fb97e286ef4a58a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948434 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720933}
-
David Roger authored
The flake should have been fixed. This CL re-enables the tests. Bug: 1014790 Change-Id: I9873a6d7a9f650f31b6992a7a10dd796ebbbb174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948433Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#720932}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I96206c6f330fa6fbd868739f02d1900d7501b019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948592Reviewed-by:
-
Henrique Ferreiro authored
Bug: 1028080 Change-Id: I15606b5c28ba03e4229b805af9f61c9bacfb7fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947649Reviewed-by:
-
Miyoung Shin authored
This CL converts InputInjector mojom interface client in content to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I95ca320495971109ac80e933ebd77be73d506f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939987 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#720929}
-
Friedrich Horschig authored
It hurts to have to disable this test since it only started flaking on Dec 3rd. But I absolutely couldn't find the culprit and its success rate is less than 50%. Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/10045 [ RUN ] All/ShelfLayoutManagerTest.NoShelfUpdateDuringOverviewAnimation/1 [4901:5087:1203/034714.153751:21185573821:ERROR:accelerometer_reader.cc(507)] Failed to initialize for accelerometer read. Received signal 11 SEGV_MAPERR fffff87dedcff277 \#0 0x55fd9d942aa9 (/b/s/w/ir/out/Release/ash_unittests+0x1947aa8) r8: 00007ffd7610501d r9: 000015330856bdfa r10: 00153f612887a8e0 r11: 0000000000000001 r12: 0000000000000002 r13: 00000780be2a83e0 r14: 00000000be167701 r15: 00000780bf39b068 di: 00000780bd57c000 si: 0000000000000042 bp: 00007ffd760cb760 bx: 00000780be2a83c0 dx: 00000000000ae0f6 ax: fffff87dedcff267 cx: 7fffffffffffffff sp: 00007ffd760cb710 ip: 000055fd9dc64b6f efl: 0000000000010297 cgf: 002b000000000033 erf: 0000000000000005 trp: 000000000000000e msk: 0000000000000000 cr2: fffff87dedcff277 [end of stack trace] Calling _exit(1). Core file will not be generated. [ RUN ] All/ShelfLayoutManagerTest.NoShelfUpdateDuringOverviewAnimation/1 [12479:12482:1203/034728.943872:21200363941:ERROR:accelerometer_reader.cc(507)] Failed to initialize for accelerometer read. Received signal 11 SEGV_MAPERR ffffde0c0ac9c95d \#0 0x5572f4ad7aa9 (/b/s/w/ir/out/Release/ash_unittests+0x1947aa8) r8: 00007fffb4fb501d r9: 00001536cf8597a6 r10: 000dd765335171fb r11: 0000000000000001 r12: 0000000000000001 r13: 000021f15f70fd40 r14: 000000005ea0c901 r15: 000021f15e6e5e68 di: 000021f15e7a15c0 si: 0000000000000021 bp: 00007fffb4ec30f0 bx: 000021f15f70fd20 dx: 0000000000071637 ax: ffffde0c0ac9c94d cx: 7fffffffffffffff sp: 00007fffb4ec30a0 ip: 00005572f4df9b6f efl: 0000000000010297 cgf: 002b000000000033 erf: 0000000000000005 trp: 000000000000000e msk: 0000000000000000 cr2: ffffde0c0ac9c95d [end of stack trace] Calling _exit(1). Core file will not be generated. TBR=amusbach@chromium.org Bug: 1030222 Change-Id: Ib96aa9208116465727cc0eabc96c526a313a9b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948435Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#720928}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/449ac187cb55..c523feb71099 git log 449ac187cb55..c523feb71099 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 aerotwist@chromium.org Updates unit tests to use new devtools_paths 2019-12-03 aerotwist@chromium.org Defaults the number of boot perf runs to 37 Created with: gclient setdep -r src/third_party/devtools-frontend/src@c523feb71099 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I25ec594fb37036703f1aaf78e178d76c8d138995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948590Reviewed-by:
-
Alex Ilin authored
We're currently adding a new remote consent flow to the OAuth2MintTokenFlow. This CL adds a new histogram to monitor the status of this new flow. Particularly, we're insterested to know how often the fallback for the remote consent flow will be called to be able to remove this fallback in the future. Bug: 1026237 Change-Id: I6ab381c5df866757c1526317246133517ee1bdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945178 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#720926}
-
Markus Handell authored
This change implements encoded output support for MediaStreamRemoteVideoSource. Change-Id: I645c97533e6d8c37c49450abc71c8916772d083f Bug: 1013590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935115 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
-
Pavel Shmakov authored
This is the second part after http://crrev.com/c/1803278. This one relies on androidx-browser API updates. Bug: 989610, 965329 Change-Id: Iccf0ed18a8db2e692e787211cfe53eaebedd5cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844987 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#720924}
-
Friedrich Horschig authored
This test (introduced on r720669) is flaky ever since: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=cyclic-syncbase-2.html TBR=fs@opera.com Bug: 1030228 Change-Id: Id5126379349c298af9aa3a1a07b066d5e2995fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947654Reviewed-by:
-
Andy Paicu authored
When using pinned tabs, the banner will immediately disappear because of the navigation to the pinned tab's address. This ensures that there is a minimum display period before the banner expires on navigations. Bug: 1001333 Change-Id: Idabc5a972696068f3ce7d5a9f70ee0ca95d4c0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925063 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#720922}
-
Morten Stenshorne authored
This may happen for column-span:all, and possibly in other cases, too. If we're inside a block that has a spanner, we'll create a break inside the block, before the next sibling to resume at (after the spanner). However, at this point we may already be past the end of the column. If this happens, we need to make sure that we don't allow the break inside, but rather break before the parent of the spanner, and then try again in the next column. Bug: 829028 Change-Id: Ie7e121679bbeb7b3dfe88567e1ad7229e104b6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944495Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#720921}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGSwitchElement>(element) in place of IsSVGSwitchElement(element) Bug: 891908 Change-Id: I82aecebb283a171095b3ff4c58895adeb23c54d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936622 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#720920}
-
Jan Wilken Dörrie authored
This change removes password_manager::BlacklistedCredentialsCleaner and the corresponding kBlacklistedCredentialsNormalized pref. The clean-up logic was introduced in M76 and has run its course. The corresponding histogram will be marked as obsolete. Bug: 952336, 988696 Change-Id: I590acfa828f03ec851480c7e0369af2fe3e1c927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936488Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#720919}
-
Shuhei Takahashi authored
This reverts commit a47f7784. Reason for revert: breaks graphics on some Chrome OS devices. Original change's description: > Delete bind_interface_helpers.h > > This header provides a bunch of helper functions for Content processes > modeled as Service Manager services. Since those are no longer a thing, > this no longer needs to be a thing. > > Bug: 977637 > Change-Id: Ia1ae177b4a9665b727618b12a35be905d5605ce9 > Tbr: jam@chromium.org > Tbr: erikchen@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929396 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#718367} Bug: 1028852 Bug: 977637 Tbr: rockot@google.com Tbr: jam@chromium.org Tbr: erikchen@chromium.org Change-Id: Ie621804e4a6c03c26bf64130bab49f6a9380dea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948401Reviewed-by:
-
