- 28 Nov, 2017 40 commits
-
-
Sheng-Hao Tsao authored
Original CL (https://chromium-review.googlesource.com/c/chromium/src/+/712134) is reverted by https://chromium-review.googlesource.com/c/chromium/src/+/763309 Patch set 1 is the old CL. Implement JPEG encode acceleration interface with VAAPI VaapiJpegEncodeAccelerator implements JpegEncodeAccelerator. It calls VaapiJpegEncoder to populate necessary VA buffers and submit them via VaapiWrapper. BUG=b:67488323 TEST=Tested on caroline that a YUV image can be successfully encoded. TBR=dalecurtis@chromium.org,jcliang@chromium.org,isherman@chromium.org,blundell@chromium.org Change-Id: Iea718427e1501ebd98727c4b4afe7035a455df54 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/780945Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#519656}
-
Morten Stenshorne authored
TBR=bratell@opera.com,tzik@chromium.org Change-Id: I18ed5a01a9142725c96972a8d774e41f69f6f818 Reviewed-on: https://chromium-review.googlesource.com/792942Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#519655}
-
Henrik Boström authored
Bug filed: https://crbug.com/789111 TBR=horo@chromium.org,chenwilliam@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789111 Change-Id: I63b3f9af581d8f6778b25b6cd4b7540182a5f87c Reviewed-on: https://chromium-review.googlesource.com/793038Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#519654}
-
Takashi Toyoshima authored
EndSession will fail if the client is not registered, and it results in leaking the MidiManager instance inside MidiService when the dynamic instantiation mode is enabled. This happens when the StartSession fails and returns non-Result::OK status. Once a failure happens in the MidiManager initialization, the failed MidiManager instance is living until the browser shutdown, and continues to return the same error. This patch changes to register clients even on failure cases, and allows to succeed EndSession call from the failed client. This does not fix the macOS specific dynamic instantiation mode issue, but would help to save it from potential similar cases on all platforms. Bug: 718140 Change-Id: I1b6ddf3020fd9f9a26c4c1f0e30bcd7974be2894 Reviewed-on: https://chromium-review.googlesource.com/788720Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#519653}
-
Kinuko Yasuda authored
Started failing after around the new interceptor change. https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/7682 TBR=jam@chromium.org NOTRY=true Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Idf83194c73bb9214655a404b681dad2f40a908f3 Reviewed-on: https://chromium-review.googlesource.com/792320 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519652}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/884db2336247..b9d9a104ca83 $ git log 884db2336..b9d9a104c --date=short --no-merges --format='%ad %ae %s' 2017-11-27 perezju [Telemetry] Remove PortKeeper Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I088cf6812192876ec056c88a4ef0d215ce1fe303 Reviewed-on: https://chromium-review.googlesource.com/792658 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519651}
-
jdoerrie authored
This change improves U2fDevice by: - Migrating to base::BindOnce() and OnceCallbacks - Using more appropriate datastructures - Removing dead code - Fixing #includes to be absolute Bug: 763303, 714018, 730593, 729950 Change-Id: If577c7f5484896a6115af997fade0c51e555df60 Reviewed-on: https://chromium-review.googlesource.com/787451 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#519650}
-
Tatiana Gornak authored
BUG=788660 Change-Id: I404f1d9efb3e0b1df2119ff3ea7981988ebf3c76 Reviewed-on: https://chromium-review.googlesource.com/788913Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#519649}
-
Mihai Sardarescu authored
This CL opens Gaia add session URL in the current tab when sign-in from is started from the welcome page. This CL also add google.com as the continue URL for the as otherwise Gaia navigates to myaccount which may be very confusing for the user if Chrome somehow fails to load the new tab at the end of the sign-in flow. Bug: 787843 Change-Id: I5f3b942e71f92d856cecf5f413bab684aeb51c4b Reviewed-on: https://chromium-review.googlesource.com/785913 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#519648}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5784f65c..5a92b85d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If35e2672de53ce7ac1e905c88771ca8407d4bded Reviewed-on: https://chromium-review.googlesource.com/792282Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#519647}
-
Boris Sazonov authored
This CL records Signin_SigninWithDefault_FromX, Signin_SigninNotDefault_FromX and Signin_SigninNewAccount_FromX when corresponding buttons are clicked in personalized signin promos. Bug: 788818 Change-Id: Ib36e9aaac2b562db5eff732908f627a3be2ac692 Reviewed-on: https://chromium-review.googlesource.com/791230Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#519646}
-
tzik authored
As a preparation to make base::DefaultTickClock a singleton. This CL removes a local DefaultTickClock instance from Blink bindings code. Bug: 789079 Change-Id: Ie3d917804b715ca2fc38d8b3ed9c35c07008af9c Reviewed-on: https://chromium-review.googlesource.com/792557 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#519645}
-
Marijn Kruisselbrink authored
This significantly speeds up the FileReader API because we no longer have all the overhead of creating a blob URL and going through the whole network stack. Bug: 749275 Change-Id: Ie45d782d60caafc7f94ea6cb21cf5969b9a07101 Reviewed-on: https://chromium-review.googlesource.com/587710 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#519644}
-
Kinuko Yasuda authored
This reverts commit 64ae7852. Reason for revert: suspected to cause bunch of MSAN errors https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/4406/steps/browser_tests Original change's description: > [desktop-pwas] Add content setting indicators to Hosted App frame. > > This CL adds ContentSettingImageViews to the HostedAppButtonContainer by: > - Factoring out a Delegate for ContentSettingImageView which the > HostedAppButtonContainer and LocationBarView implement > - Adding an icon color override to ContentSettingImageView > - Moving the HostedAppButtonContainer to BrowserNonClientView instead of > BrowserNonClientViewAsh so that BrowserView can access it > (which also prepares its addition to OpaqueBrowserFrameView). > > This all allows the content setting indicators to be embedded in the > hosted app frame, get notified of content setting changes, and respond > to active/inactive states. > > Bug: 762401 > Change-Id: I3f65f022201740c8e5a066937d32c189f283a048 > Reviewed-on: https://chromium-review.googlesource.com/756634 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519562} TBR=jamescook@chromium.org,tapted@chromium.org,calamity@chromium.org Change-Id: I3a9511ecb27f2e388e4a8dab3a46cdf37cbc3647 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762401 Reviewed-on: https://chromium-review.googlesource.com/792585Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519643}
-
Kinuko Yasuda authored
This reverts commit 1ee2c9ad. Reason for revert: sorry, let me revert this one too to successfully revert the other one. (This can probably be re-landed after that) Original change's description: > Fix some DefaultFrameHeader semantics. > > This CL removes back button as a constructor arg and renames the > setters for the back button and the left header view to set_property to > clarify the semantics of the methods. > > Bug: None > Change-Id: Ia73a173696ff434bc4e96168c82ed95fce6dd6e9 > Reviewed-on: https://chromium-review.googlesource.com/778265 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519599} TBR=jamescook@chromium.org,tapted@chromium.org,calamity@chromium.org Change-Id: I43ef07f352e96d1040594066822449d806c4e91e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/792734 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519642}
-
Renee Wright authored
Replace CSSPropertyIDs with CSSProperty references in StylePropertyShorthand and in closely related methods. Bug: 779939 Change-Id: I4f8ef90f28dcd7bc9f6192e82723948330e0a791 Reviewed-on: https://chromium-review.googlesource.com/778201 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#519641}
-
Jochen Eisinger authored
If we copied the security origin, we automatically inherit the suborigin, and if not, there's nothing to enforce BUG=none R=mkwst@chromium.org Change-Id: Iaa334c37373e945e02a1876fa6c8eb69d1e428a8 Reviewed-on: https://chromium-review.googlesource.com/790350 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#519640}
-
Matt Falkenhagen authored
These were removed from the specification: https://github.com/w3c/ServiceWorker/commit/0d09f488c062f0db5d65a243da0bbddaec3de1dd This also prepares for removal of Foreign Fetch + Link registration by changing the status from experimental to disabled, so tests run with them disabled. Bug: 788604 Change-Id: I700a041b3d981872bf82c5573efa9ac8fd8feba9 Reviewed-on: https://chromium-review.googlesource.com/792754Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#519639}
-
Henrik Boström authored
This reverts commit 0122ab84. Reason for revert: Speculative revert for flaky content_browsertests failure on WebRtcGetUserMediaBrowserTest. TwoGetUserMediaAndVerifyFrameRate, see https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/7694 Original change's description: > Replacing the last addExpectedEvent with promises. > > This concludes the refactoring. The tests now have a MUCH clearer > control flow, and test success is no longer handled behind the scenes. > > I found that it's better to keep promise chains as long as possible, > since we can then append a single .catch(failTest) at the end. This > isn't strictly necessary - the test will time out since an error > will break the promise chain and not call reportTestSuccess, but > it's much nicer if the test fails right away on exceptions, rather > than timing out after 45 seconds. > > Bug: chromium:777857 > Change-Id: If8f269adc88a7626d4df64793861372c07fc7bbd > Reviewed-on: https://chromium-review.googlesource.com/789883 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519297} TBR=phoglund@chromium.org,guidou@chromium.org Change-Id: I15428ea72187469886e39aaa035f9d293f883b17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:777857 Reviewed-on: https://chromium-review.googlesource.com/793010Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#519638}
-
Kinuko Yasuda authored
This reverts commit 23985150. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[desktop-pwas] Add content setting indicators to Hosted App frame." > > This reverts commit 64ae7852. > > Reason for revert: suspected to cause bunch of MSAN error > > https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/4406/steps/browser_tests > > Original change's description: > > [desktop-pwas] Add content setting indicators to Hosted App frame. > > > > This CL adds ContentSettingImageViews to the HostedAppButtonContainer by: > > - Factoring out a Delegate for ContentSettingImageView which the > > HostedAppButtonContainer and LocationBarView implement > > - Adding an icon color override to ContentSettingImageView > > - Moving the HostedAppButtonContainer to BrowserNonClientView instead of > > BrowserNonClientViewAsh so that BrowserView can access it > > (which also prepares its addition to OpaqueBrowserFrameView). > > > > This all allows the content setting indicators to be embedded in the > > hosted app frame, get notified of content setting changes, and respond > > to active/inactive states. > > > > Bug: 762401 > > Change-Id: I3f65f022201740c8e5a066937d32c189f283a048 > > Reviewed-on: https://chromium-review.googlesource.com/756634 > > Commit-Queue: calamity <calamity@chromium.org> > > Reviewed-by: James Cook <jamescook@chromium.org> > > Reviewed-by: Trent Apted <tapted@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#519562} > > TBR=jamescook@chromium.org,tapted@chromium.org,calamity@chromium.org > > Change-Id: Id42cff75e0792818065a9a3fc9816011b7caa367 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 762401 > Reviewed-on: https://chromium-review.googlesource.com/792583 > Commit-Queue: Henrik Boström <hbos@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519631} TBR=jamescook@chromium.org,kinuko@chromium.org,tapted@chromium.org,calamity@chromium.org,hbos@chromium.org Change-Id: I90d290ed7c70afb695c2f8b2b11cf1dbb9265db7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762401 Reviewed-on: https://chromium-review.googlesource.com/792584Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519637}
-
Julien Isorce authored
This is non-ozone specific and this will help maintenance. Also this is useful to select DRM(egl) or TFP(glx) at runtime, i.e. with --use-gl=egl or --use-gl=desktop. Note that a switch(gl::GetGLImplementation()) is not practicable here because of the way generate_stubs.py works. This is another preliminary step for the subsequent CL https://chromium-review.googlesource.com/c/chromium/src/+/766787 Bug: 785201 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icc4f2c6a0ff448ce1507798bfbc708d2fe16ff29 Reviewed-on: https://chromium-review.googlesource.com/787432Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Cr-Commit-Position: refs/heads/master@{#519636}
-
Shanmuga Pandi M authored
Loading SVG with 0x0 instrinsic dimension should dispatch load event rather than unexpected 'error' event. As per https://www.w3.org/TR/SVG/struct.html#SVGElementWidthAttribute, zero intrinsic size SVG is a valid image. Bug: 776710 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I10f17b7aa2d1a127b7e330b4750e1c8bcbe1965a Reviewed-on: https://chromium-review.googlesource.com/741104 Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#519635}
-
Olivier Robin authored
This reverts commit 54d8c4e9. Reason for revert: CRWWebControllerTest.SslCertError fails consistently on device. Original change's description: > [Nav Experiment] Abort native URL navigation if new navigation starts > > With LegacyNavigationManagerImpl, native URLs are loaded synchronously > during the call to CRWWebController.loadCurrentURL, so it's impossible > for another navigation to start before the native URL navigation finishes. > > With WKBasedNavigationManager, the call to loadCurrentURL triggers an > placeholder navigation on the WKWebView, and the actual work to load the > native URL happens when that placeholder navigation is finished. Since > the placeholder navigation happens asynchronously, a new navigation > (creating a new pending navigation item) can start before the placeholder > navigation finishes. In this situation, when the placeholder navigation > finishes, running its completion handler to load the native URL results > in incorrect behavior and a DCHECK, since the current navigation item > (the new one) no longer corresponds to that native URL navigation. > > This CL skips running the completion handler for a placeholder navigation > when another navigation has started. This means that a WebStateObserver > sees neither a DidStartNavigation call nor a DidFinishNavigation call > for the native URL navigation. > > This fixes crashes in several tests when loading a URL after opening a > new tab, when using WKBasedNavigationManager. > > Bug: 775645 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I88ce3f524ca4298ad5905430c12dca759a9b7202 > Reviewed-on: https://chromium-review.googlesource.com/788173 > Commit-Queue: Ali Juma <ajuma@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519382} TBR=ajuma@chromium.org,eugenebut@chromium.org,danyao@chromium.org Change-Id: I0dee4db324947553e1c9b6c8d480f9eda3981644 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775645 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/792990Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519634}
-
Balazs Engedy authored
According to [1], if there are no credentials to return, navigator.credentials.get() should resolve the returned promise with `null`, and not with `undefined`. After this CL the implementation is now in compliance with the spec. [1]: https://www.w3.org/TR/credential-management-1/#abstract-opdef-request-a-credential Bug: 740081 Change-Id: I7ad62bf8d06c5e06d244ed5a3b6b067c233826b1 Reviewed-on: https://chromium-review.googlesource.com/787980 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#519633}
-
Oleh Prypin authored
This behaves the same as mac_sdk_overrides. Allows selecting ios_deployment_target per-project. Bug: webrtc:8570, chromium:768876 Change-Id: I5cb77cca1b3dc28b9a4205fd68a1edc976e969bc Reviewed-on: https://chromium-review.googlesource.com/790391Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#519632}
-
Kinuko Yasuda authored
This reverts commit 64ae7852. Reason for revert: suspected to cause bunch of MSAN error https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/4406/steps/browser_tests Original change's description: > [desktop-pwas] Add content setting indicators to Hosted App frame. > > This CL adds ContentSettingImageViews to the HostedAppButtonContainer by: > - Factoring out a Delegate for ContentSettingImageView which the > HostedAppButtonContainer and LocationBarView implement > - Adding an icon color override to ContentSettingImageView > - Moving the HostedAppButtonContainer to BrowserNonClientView instead of > BrowserNonClientViewAsh so that BrowserView can access it > (which also prepares its addition to OpaqueBrowserFrameView). > > This all allows the content setting indicators to be embedded in the > hosted app frame, get notified of content setting changes, and respond > to active/inactive states. > > Bug: 762401 > Change-Id: I3f65f022201740c8e5a066937d32c189f283a048 > Reviewed-on: https://chromium-review.googlesource.com/756634 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519562} TBR=jamescook@chromium.org,tapted@chromium.org,calamity@chromium.org Change-Id: Id42cff75e0792818065a9a3fc9816011b7caa367 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 762401 Reviewed-on: https://chromium-review.googlesource.com/792583 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519631}
-
Sriram authored
Removing the tests media/track/opera/track/webvtt/parsing/ infavor of the web platform tests in external/wpt/webvtt/parsing/file-parsing/ Bug: 782555 Change-Id: Ie2523cd2efa677c62c955e1ad95c18e308dbb661 Reviewed-on: https://chromium-review.googlesource.com/792555Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#519630}
-
Roman Sorokin authored
Switches JoinAdDomain and AuthenticateUser to protobuf args. Also switches RefreshUserPolicy to ObjectGUID. Should be landed after Chrome OS part will be landed. BUG=chromium:785956 TEST=manual CQ-DEPEND=CL:771630,CL:774741 Change-Id: I23db60080e684cc1d6cc51fcbafbb10c306bc924 Reviewed-on: https://chromium-review.googlesource.com/774883 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#519629}
-
Gauthier Ambard authored
The setToolsMenuStateProvider method wasn't used in the Toolbar. This CL removes it. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1314bf4859541c21bb6504ef78b96d8133995177 Reviewed-on: https://chromium-review.googlesource.com/789190Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#519628}
-
Kinuko Yasuda authored
DownloadTest.CloseNewTab4 SBNavigationObserverBrowserTest.DownloadViaHTML5FileApiWithoutUserGesture SBNavigationObserverBrowserTest.DownloadViaHTML5FileApiWithUserGesture TBR=qinmin@chromium.org NOTRY=true Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I72fa971fbadf7e9c52d59b07b478af6529e53010 Reviewed-on: https://chromium-review.googlesource.com/792893 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519627}
-
Kinuko Yasuda authored
HTMLAnchorElement download tests started to fail probably after r519463 (downloadmanager change) * fast/dom/HTMLAnchorElement/anchor-download.html * fast/dom/HTMLAnchorElement/anchor-nodownload-set.html TBR=qinmin@chromium.org NOTRY=true Bug: 789081 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia690b83acabd68971a71d8755411f37222700557 Reviewed-on: https://chromium-review.googlesource.com/792772 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#519626}
-
Jochen Eisinger authored
Maybe it's less prone to time out, if we split it up.. BUG=753691 R=mkwst@chromium.org Change-Id: Ie4cbb6e1312c8ab850b1c552d1127e12f41da523 Reviewed-on: https://chromium-review.googlesource.com/789889 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#519625}
-
Mihai Sardarescu authored
Screenshot: https://drive.google.com/a/chromium.org/file/d/1V1Vwt-YMX02NSgkbza-q836r0ENb2d2t/view?usp=sharing Bug: 787293 Change-Id: I209c9a138f6319435ef3717a93cbf4c31827a621 Reviewed-on: https://chromium-review.googlesource.com/790352Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#519624}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0aa02c66. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6425 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=rbyers No-Export: true Change-Id: Id665ddf8c074a4f9079e7f201c1a3dbeaa204b19 Reviewed-on: https://chromium-review.googlesource.com/792850 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#519623}
-
tzik authored
Change-Id: I77fbf6d97c9dd26f2ead1c48d3ddedcc9dbf04c0 Reviewed-on: https://chromium-review.googlesource.com/792691 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#519622}
-
Dominik Röttsches authored
This should fix another set of layout tests and make us less dependent on distribution specific font packages. Add a font usage line in languages-emoji-rare-glyphs.js to make sure that Noto Sans Khmer is used. Bug: 772116 Change-Id: I0acfb2186eeb180a3a464cd6337539cbe1cdf45d Reviewed-on: https://chromium-review.googlesource.com/779520 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#519621}
-
Gauthier Ambard authored
This CL adds a SearchEngineObserver as a standalone class, instead of having it duplicated in two files. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iea5d4628e75ea4ae1e7afc349cfb958292f6a38d Reviewed-on: https://chromium-review.googlesource.com/790990Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#519620}
-
Gauthier Ambard authored
This CL adds the real toolsmenu button to the Toolbar. It takes into account the Reading List state. Bug: 788395 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I78bd5f23f9aa55c52b377be788dc13b6be8bdfe6 Reviewed-on: https://chromium-review.googlesource.com/788914Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#519619}
-
Hajime Hoshi authored
This CL is the third trial to add the UKM Document. OutliveTimeAfterShutdown. This CL uses the existing Document:: UKMRecorder() and avoids requesting from content renderer to content browser. Actually, I have confirmed that this CL doesn't emit the problematic log "Connection InterfaceProviderSpec prevented service: content_renderer from binding interface: ukm::mojom::UkmRecorderInterface exposed by: content_browser" on my local machine. This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is recorded when a Document object survives 5, 10, 20 or 50 garbage collections after detached. If a document outlives such long time, the document might be leaked. The UKM would be very useful to know where such leaky documents exist and to fix them. Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing Bug: 757374 Change-Id: I4615f170626faab7151444b4a898c40761fbb6e1 Reviewed-on: https://chromium-review.googlesource.com/763187 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#519618}
-
Christian Dullweber authored
A ServiceWorkerRegistration was accessed after move. Bug: 788277, 788611 Change-Id: Icd2a86f2273ccdd0fb4d0a902f8cff0086019410 Reviewed-on: https://chromium-review.googlesource.com/789888Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#519617}
-