- 28 Jan, 2020 40 commits
-
-
Olivier Li authored
This class is a successor to ThreadWatcher which aims to be more versatile and provide a larger coverage for hang watching. Bug: 1034046 Change-Id: I365fe8824eb34c37c75e6ddf6874ff26ecd494c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008189 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#736080}
-
nancy authored
Check whether extensions::ContextMenuMatcher commands are enabled in AppServiceContextMenu, which is the current implementation: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/extension_app_context_menu.cc?l=167 Also update set LaunchType command to add SetAppUserDisplayMode function for Web apps when kDesktopPWAsWithoutExtensions is enabled: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/web_app_context_menu.cc?l=131 BUG=1038487 Change-Id: Ib8e6582313938dca6291aabbc872a094e4a994bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025010Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736079}
-
Kyle Milka authored
Apply the standard mode tint to first party sharing features in the sharing hub. This ensures they display correctly in dark mode. Bug: 1009124 Change-Id: I9e3fd8f8fc59853ce0d46ebc512d85d5cfdf6f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020404 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736078}
-
Robert Ogden authored
Checks in two separate places, the TabHelper and the URLLoaderInterceptor. Bug: 1023486 Change-Id: I93e5775f700e6da0852c4a956f0893b40b5808d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024494Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#736077}
-
Manu Cornet authored
Change-Id: I42931af323cbfbd4da06eeb11c93cc06258ba74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025467 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736076}
-
Andrew Xu authored
Now the calculation on the area of the gradient zone relies on the location of arrow buttons. Actually the area can also be computed with the visible space, which is more concise and readable. This CL should not bring any noticeable difference to UI. It helps the landing of the following CLs on fading in arrow buttons. Bug: 1026957 Change-Id: I9ab34c56a0a0e233a9d633e2aee873b7e070985d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021322 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
nancy authored
This is the preparing for CL:2022585. The function GetCommandIdVectorIcon will be used by AppServiceShelfContextMenu. BUG=1038487 Change-Id: Ib1d67bbbf5482c752a82f3d85659246515e7b24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025009Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL also removes unnecessary testlib/testlib.js. Bug: 1045479, https://github.com/whatwg/html/issues/3890 Change-Id: I59709cdfd33ba1be18d2aab3393daffb83ce8f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663585 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#736073}
-
Lijin Shen authored
Disable share button when tab is null. Otherwise, clicking on share button may cause crash. Bug: 1028893 Change-Id: I59ef6cef96cb2e12175cd673993603a496837a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023403Reviewed-by:
-
Trevor Perrier authored
To give Clank language parity with Android 27 new locales are being added. 26 of those locales have been added in two previous CLs: - https://crrev.com/c/1941058 - https://crrev.com/c/1952288 zh-hk was skipped because currently resources for it are mapped to zh-tw. This CL skips that mapping for bundle builds where zh-hk is now included. zh-hk is still mapped to zh-tw in apk builds. There is an increase in size even when language splits are used in bundles. A bug has been created to look into this: - APK Bundles wastes a lot of space in resources.arsc (400kb) - https://crbug.com/1031645 Bug: 1034774 Binary-Size: Size increase is unavoidable (see above). Change-Id: I4edb9d5213e8dd3443522deee5395e500af34371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970258Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
(gone) Eric Stevenson <estevenson@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#736071}
-
Jonah Ryan-Davis authored
Based on glXGetMscRateOML from GLX_OML_sync_control. Bug: chromium:1042393 Change-Id: I1cf2fd43aad041b157dc2f26104ff80b10056ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015684 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#736070}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b52c8dc280ff..e6148d3266a2 Created with: gclient setdep -r src-internal@e6148d3266a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:927262 Tbr: jbudorick@google.com Change-Id: I38815d1884bf6fdceecad0302605bde6c493ba05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736069}
-
Jonah Chin authored
This CL encompasses 3 changes that are in preparation of the OOP-R Canvas change: 1. With OOP-R Canvas we need the ability to validate clip stack on canvas' other than the drawing canvas. This change updates ValidateStateStack to accept the canvas that needs to be validated. 2. RestoreBackBuffer() added to CanvasResourceProvider(). In the future, Canvas2DLayerBridge won't have access to the backing Skia canvas in the resource provider. This change pulls functionality that relies on the Skia canvas out of the Canvas2DLayerBridge and puts it in the CanvasResourceProvider. 3. Removed initial save on Skia canvas. With Deferral Always On, the Skia canvas is only used to rasterize RecordPaintCanvas' and RecordPaintCanvas tracks the current clip stack. With this change, during Canvas2DLayerBridge::WritePixels() (or equivalent), ValidateStateStackWithCanvas() inside RestoreMatrixClipStack validates the clip stack on the Skia canvas. The initial save was resulting in a mismatch with the count of saves from the BaseRenderingContext2D. This came from PaintCanvasAutoRestore() inside Canvas2DLayerBridge::WritePixels() pushing an additional save. Bug: 1019288 Change-Id: Ib134f600721a3d0acc2f7123a1ee1c798f6b9e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006648Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736068}
-
ssid authored
The tracing metrics provider now directly calls the field trials provider to get the field trial data. This doesn't scale well for additional system profile providers, but as we don't want to automatically include the full system profile in all independent metrics and we don't currently have a way of selectively including this, for now we manually populate the field trials data Change-Id: I6397f6500470d719987e54f9c038f50daad58556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024162 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#736067}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/89e678dea268..f03c11602172 git log 89e678dea268..f03c11602172 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 senorblanco@chromium.org Roll dawn and adjust for new SwapChain API. 2020-01-28 bsalomon@google.com Add fallback for asyncRescaleAndReadPixelsYUV420 without PBOs. 2020-01-28 reed@google.com Experimental coretext backend for SkShaper Created with: gclient setdep -r src/third_party/skia@f03c11602172 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I701a9d603fb8f894a20c8e56d8076ad8cf91cbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736066}
-
Saman Sami authored
Plumb mailbox for the primary plane to OverlayProcessorOzone and use SharedImageInterface to obtain the corresponding NativePixmap. Bug: 756454 Change-Id: Ic537d05253bc68c27a8fed961de8547ace359e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016327Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736065}
-
Erik Staab authored
Bug: 1042819 Change-Id: If9dc84c5a7c5da5e1597b8ae030cab43ea269cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006139Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#736064}
-
Aga Wronska authored
This code is used since 2014 and it should not be considered experimental. Bug: b/145953755 Change-Id: If378a9c93edbc33d50d93b0ae9bb86ad19db1057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003573Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#736063}
-
Luke Zielinski authored
TBR=robertma Change-Id: Ib95daef5df9daed0114e72b41c36a84586c5e7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025867Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#736062}
-
Wez authored
This test was disabled on Fuchsia due to flakiness, but is also extremely flaky on Linux, suggesting a more general cross-platform raciness or timing issue. TBR=falken Bug: 1029434 Change-Id: I02969efdb4e318a46c47fe292e63c5a7129946cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025707Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#736061}
-
John Lee authored
This CL sets up the ability to drag a tab from one WebUI tab strip and drop it into another WebUI tab strip. The CL currently only places the dropped tab to the end of the tab strip, and does not set the index or the pinned state of the tab. Future CLs will handle the UI for dropping a tab specifically into place, and visually differentiating the drops that are allowed and disallowed. This implementation currently still uses the Extensions API for moving tabs between windows, and the Extensions API already checks to make sure the tab can be legally moved, taking into account multiple profiles and incognito windows. Bug: 1005560 Change-Id: I7da09a561144d911660f068f76919efe72f3638a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020609 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736060}
-
Yi Gu authored
This test is flaky on Linux TSAN: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUB2aXpfdW5pdHRlc3RzQEdQVVJlbmRlcmVyUGl4ZWxUZXN0LlRyaWxpbmVhckZpbHRlcmluZww TBR=backer@chromium.org Bug: 1044587 Change-Id: Ibedfa580c7d2c79585ef1d8dd795a9eed775114e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025827Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736059}
-
Patrick To authored
With the current location of where OpenXR events are processed, Blink is not notified when the session has ended. When a session ends, there is first an event to set the visibility state to hidden before the event indicating the session has ended. Setting the visibility state to hidden will prevent Blink from requesting anymore frames. Since XRCompositorCommon:GetFrameData() checks for session ended at the beginning of the function, before requesting a frame from OpenXR where events are processed, it never detects that the session has ended to call ExitPresent. Moving event processing to OpenXrApiWrapper::HasSessionEnded ensures that the most current state is returned to XRCompositorCommon. Bug: 1044641 Change-Id: I0bf5d1ffc810720df6e4a9c37daac4d5d58a77c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021336 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#736058}
-
Lan Wei authored
When we scroll the page and stops at the middle of the omnibox, the page should either go up or down to either show the whole omnibox or not show the omnibox at all. When I moved the ScrollEnd function (https://chromium-review.googlesource.com/c/chromium/src/+/1688884) in InputHandlerProxy::HandleGestureScrollEnd to be called for only impl thread scroll only, so the scroll snap does not happen for main thread scroll. We should call ScrollEnd for both impl and main threads scroll. Bug: 1026033 Change-Id: Id15379d70e4ccaab28b578e0798735141caac627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972460 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736057}
-
Sahel Sharify authored
This reverts commit 08e5b730. Reason for revert: Added test fails on ChromeOS Original change's description: > [Payments]Don't show "add card" button when basic card is not requested. > > This is a Desktop only change to ensure that the "add card" button is > shown in payment method window only when the "basic card" method is > supported. > > Change-Id: Ibfc31141cf45595c0db216d017b5c8c484094424 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024923 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735978} TBR=rouslan@chromium.org,sahel@chromium.org Change-Id: I9a6de704172c06d1f13b71d4efcdf97713586eb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025876Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736056}
-
ccameron authored
This reverts commit 0caa3dc5. Reason for revert: crbug.com/1046518 Pixel_PaintWorkletBasics failing on all Android FYI bots Original change's description: > Make paint worklet pixel test better > > This CL improves an existing gpu pixel test, to exercise more > canvas API calls, such as resetTransform. > > Bug: None > Change-Id: I4870e3fed726dfb4d8e6b2d8e9631d444b9cc3f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005813 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735987} TBR=zmo@chromium.org,xidachen@chromium.org Change-Id: Icdd7c23ad9032eaee444dc9416bd581fc61ae483 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025922Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#736055}
-
Adam Langley authored
This change allows items with a throbber(*) to be added to a hover list view. These views are used for things like the transport selection and account selection dialogs. Have confirmed that there's no pixel differences in either of those dialogs due to this change. A future change will actually use the capability. (*) That's the views name for it. I think most people would call it a spinner. BUG=1002262 Change-Id: I3accb09edcef4684275c67bef76b2f5acb229192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025576Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#736054}
-
Shakti Sahu authored
This CL fixes a crash due to a boolean flip which was added inadvertently in CL https://chromium-review.googlesource.com/c/chromium/src/+/1919909 Bug: 1046230, 1046232 Change-Id: I413791e1fa879ab98f4ee5b890616e23026ad3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024493Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#736053}
-
Bence Béky authored
Bug: 1043531 Change-Id: I5cdd53d27492f8745936467d2aaca2268ba6768e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024475Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#736052}
-
Yi Gu authored
This test is flaky on Win10. See bug for details. TBR=estade@chromium.org Bug: 1045731 Change-Id: I01d7ec83a2c92b67696596955f9ef3a7bf1f4ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025908Reviewed-by:
-
Nic Champagne Williamson authored
This change begins adding high contrast support to the ink drop. This work is behind the EnablePlatformHighContrastInkDrop flag, which is disabled by default. The InkDropHighlight will now use 1.0 opacity (completely opaque) when in platform high contrast mode. This will ensure that the ink drop color is fully visible in high contrast. To start, the ink drop color is set to the correct high contrast color for the toolbar buttons. Future work will set the ink drop color correctly in more areas, and fix element layering to ensure the foreground is always visible on top of the ink drop background. Bug: 776871 Change-Id: Iecdbedc7f4d735096e650d2b65a53d3de64643f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023362 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736050}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/32d4291f7a61..3c63cf70e3b3 git log 32d4291f7a61..3c63cf70e3b3 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 thestig@chromium.org Rename cmap_int.h to fpdf_cmaps.h. 2020-01-28 thestig@chromium.org Use FXARGB_[ARGB]() macros in more places. Created with: gclient setdep -r src/third_party/pdfium@3c63cf70e3b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iff224e463693b929436849cccc89b4ae556187ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025634Reviewed-by:
-
Yi Gu authored
The test is flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBzZXJ2aWNlc191bml0dGVzdHNATmV0d29ya1NlcnZpY2VUZXN0V2l0aFNlcnZpY2UuQUlBRmV0Y2hpbmcM TBR=mmenke@chromium.org Bug: 1045732 Change-Id: I192f6523c3baca956c7a99b5fbbda7bf1c1005ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025532Reviewed-by:
-
Mohammad Refaat authored
TabModel is provided to the CrashRestoreHelper as a SessionWindowRestore protocol delegate. and it's used to restore sessions from there. Replace that with browser and use sessionRestorationBrowserAgent from the CrashRestoreHelper instead. Also while at it, i changed the members ivars to use trailing underscore instead of the leading underscore. Bug: 1010164 Change-Id: I53360ac9a34f7f9e42aacd459e233f40c5def60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024028 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#736047}
-
Avery Musbach authored
When you start dragging a maximized window from overview and drag into another display, the drop target on that display shall be adjusted to reflect that if you drop the window there, it will fill the work area. Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.DropTargetBoundsForMaximizedWindowDraggedToOtherDisplay/? Bug: 961170 Change-Id: I682d75dd8a95544ffa0d952920d174f8ab102c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024153Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#736046}
-
Wez authored
This test was disabled on Fuchsia in 2018, due to flake, but appears to be flaky across all platforms, especially Mac, suggesting that the test is inherently racey or timing-dependent. TBR=sahel@chromium.org Bug: 866946 Change-Id: If4669a4935833101422f60fa56a6e58b23b704c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025430Reviewed-by:
-
Yi Gu authored
This test has been flaky on Mac and Win10. Only 1 occurrance on Linux: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZQsSBUZsYWtlIlpjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2JsdWV0b290aC9pZGwvaWRsaGFybmVzcy50ZW50YXRpdmUuaHR0cHMud2luZG93Lmh0bWwM TBR=jameshollyer@chromium.org NOTRY=True Bug: 1041851 Change-Id: If303b5744745a9f13a72155fac21f4fde48478fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025916 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Katie D authored
In some places, Reader Mode was still being referred to as distilled pages. Corrects this. Bug: 1016619 Change-Id: I6ee56597b60c8a95550a9e2eec90891751ce5024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025635 Commit-Queue: Katie Dektar <katie@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736043}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 34e2627e. With Chromium commits locally applied on WPT: 3157910d "SharedWorker: Add WPT for referrer-policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9cce59568aec57c537f12f5dc79e692d86a5feeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025329Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736042}
-
Elly Fong-Jones authored
This change introduces alternatives to overriding these methods on DialogDelegate: Accept Cancel Close Each of these methods now has a corresponding settable callback. callback. The callback, if set, is invoked from the default implementation of the corresponding method before it returns its default value. For many cases, this obviates the need to override Accept/Cancel/Close. Bug: 1011446 Change-Id: I4b7ce930bb6f7108665a2d5b6c789aa29e4ec839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017988 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736041}
-
