- 01 Apr, 2014 5 commits
-
-
yoav@yoav.ws authored
This reverts commit d1eea2e66e64c3c019885ad7e94933aa0fc05576. On top of that, this CL makes sure that only the preloader uses the thread safe MQ parser. That's in order to reduce the risk of breaking content when introducing the new MQ parser. BUG=358078 Review URL: https://codereview.chromium.org/219183002 git-svn-id: svn://svn.chromium.org/blink/trunk@170494 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rafaelw@chromium.org authored
R=ojan BUG= Review URL: https://codereview.chromium.org/216443004 git-svn-id: svn://svn.chromium.org/blink/trunk@170493 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
avi@chromium.org authored
BUG=357782 TEST=no change Review URL: https://codereview.chromium.org/219163005 git-svn-id: svn://svn.chromium.org/blink/trunk@170492 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
a.renevier@samsung.com authored
This patch is the blink side. The chromium side is handled on issue #180153010 It doesn't revert functions anymore in blink. Instead, it sets the direction parameter to WebAnimation, which will in turn pass it to the compositor BUG=348071 Review URL: https://codereview.chromium.org/178263006 git-svn-id: svn://svn.chromium.org/blink/trunk@170491 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jl@opera.com authored
When reading property on a CSSStyleDeclaration object, the property name is transformed into a possible CSS property name and looked up as such. This transformation involves copying the property name to a StringBuilder while converting from camelCase to dash-separated. Positive matches are cached in a local static hash map, but negative matches were not. A script reading properties like "getPropertyValue" would trigger the conversion to "get-property-value" and CSS property lookup every time. Optimize by caching negative matches as well as positive ones. BUG= Review URL: https://codereview.chromium.org/219153002 git-svn-id: svn://svn.chromium.org/blink/trunk@170490 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
- 31 Mar, 2014 35 commits
-
-
dsinclair@chromium.org authored
This CL updates FrameView::repaintTree to skip issuing invalidations for any RenderObject if they don't have a layer and their RenderView did a full invalidation. This seems to be closer to the behaviour that the system exhibits with repaint-after-layout disabled. BUG=320139 Review URL: https://codereview.chromium.org/212553004 git-svn-id: svn://svn.chromium.org/blink/trunk@170489 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
japhet@chromium.org authored
This API will function as a temporary shim to enable history functionality to move to content/renderer, without any broken intermediate steps. This is step 1 of 5 from http://crbug.com/357327 BUG=357327 Review URL: https://codereview.chromium.org/214723003 git-svn-id: svn://svn.chromium.org/blink/trunk@170488 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ltilve@igalia.com authored
Review URL: https://codereview.chromium.org/219023006 git-svn-id: svn://svn.chromium.org/blink/trunk@170487 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dsinclair@chromium.org authored
This CL adds a few trace events in to gather information about the cause and size of repaints. BUG=320139, 351498 Review URL: https://codereview.chromium.org/208143003 git-svn-id: svn://svn.chromium.org/blink/trunk@170486 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chrishtr@chromium.org authored
This is a nice cleanup, and sets us up for separating StyleInvalidator from RuleFeatureSet, which will allow us to more easily TargetedStyleRecalc for style sheet loads. BUG=318468 Review URL: https://codereview.chromium.org/217713002 git-svn-id: svn://svn.chromium.org/blink/trunk@170485 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rego@igalia.com authored
Current code always mark the grid as dirty in RenderGrid::removeChild(). If the grid auto flow property is different to none, the grid has to be marked as dirty when a child removed. Just in case, the grid contains auto-placed items, that might need to be re-positioned. Otherwise, we can simple remove the child from the grid cells where it is present and update the coordinates cache accordingly. BUG=248151 TEST=fast/css-grid-layout/grid-item-removal-auto-placement-update.html Review URL: https://codereview.chromium.org/211053002 git-svn-id: svn://svn.chromium.org/blink/trunk@170484 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jchaffraix@chromium.org authored
The parameter was never NULL but the code wasn't clear about it. This lead to a couple of unneeded NULL-checks that obfuscated what could happen. Review URL: https://codereview.chromium.org/217563003 git-svn-id: svn://svn.chromium.org/blink/trunk@170482 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rafaelw@chromium.org authored
TBR=kbr@chromium.org BUG=358313 Review URL: https://codereview.chromium.org/218623010 git-svn-id: svn://svn.chromium.org/blink/trunk@170481 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
wjmaclean@chromium.org authored
This code is only used in a test, and cc-side support is going away, so remove it in Blink. Review URL: https://codereview.chromium.org/215033003 git-svn-id: svn://svn.chromium.org/blink/trunk@170480 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kenrb@chromium.org authored
Blink revision 170347 introduced a crash because Document::focusedFrame() fails to check properly for having a null Frame. This corrects the check. BUG=358172 R=eseidel@chromium.org, abarth@chromium.org Review URL: https://codereview.chromium.org/219453004 git-svn-id: svn://svn.chromium.org/blink/trunk@170478 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
avi@chromium.org authored
BUG=357782 TEST=no change Review URL: https://codereview.chromium.org/218743002 git-svn-id: svn://svn.chromium.org/blink/trunk@170477 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oysteine@chromium.org authored
Chrome side: https://codereview.chromium.org/109283006 R=eseidel@chromium.org,abarth@chromium.org BUG=277886 Review URL: https://codereview.chromium.org/100563004 git-svn-id: svn://svn.chromium.org/blink/trunk@170476 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
r170454 was almost Oilpan-ready, add missing bits. R=mvanouwerkerk@chromium.org BUG= NOTRY=true Review URL: https://codereview.chromium.org/219753004 git-svn-id: svn://svn.chromium.org/blink/trunk@170475 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
- numbers are formatted with thousands separators in the Allocation view similar to other views - all numeric columns' text is aligned on the right hand side BUG=277984 Review URL: https://codereview.chromium.org/219383003 git-svn-id: svn://svn.chromium.org/blink/trunk@170474 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
RenderLayer should not be friending a bunch of other classes. Better for the de facto public API to be the de jure public API. Review URL: https://codereview.chromium.org/218053002 git-svn-id: svn://svn.chromium.org/blink/trunk@170473 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eseidel@chromium.org authored
This code was intending to make sure that layout() timers get a chance to fire before parser timers do. However we no longer use SharedTimer for schedulingLayout. Instead we use the compositor's scheduleAnimation timer which is only called when the compositor actually is going to put up a frame. I could imagine scenerios whereby a layout was scheduled and either was called and didn't clear the m_pendingLayout bit due to the Document being inactive or some other early-return, or a scenerio in which a layout was scheduled but the compistor never needed to put up a frame, which would result in the Parser spinning like this waiting for the layout timer to fire and clear the m_pendingLayout bool, but it never happened. As the FIXME said, the real fix here is to reduce the max duration of the parser and possibly coordinate with the compositor to allow the parser to do work directly after the frame has been put up, in the time when the main-thread is otherwise idle waiting for the compositor and gpu threads to actually put up the frame. This may cause a regression on SpeedIndex benchmarks and we may need to find a different way to implement what this code was trying to do. I was not able to produce a test which triggered this bug, but I'm confident it's possible to get Blink into such a confused state. BUG=288265 Review URL: https://codereview.chromium.org/218373002 git-svn-id: svn://svn.chromium.org/blink/trunk@170472 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
skobes@chromium.org authored
This relands the following changes: http://crrev.com/208393008 Preserve autosizing multiplier on style recalc. http://crrev.com/209853007 Fix line height when changing multiplier. http://crrev.com/209353003 Clean up handling of autosizing state changes. These changes were reverted in http://crrev.com/212163006, because the first one broke AwSettingsTest.testLayoutAlgorithmWithTwoViews. They are safe to reland due to the fix in http://crrev.com/215063004. BUG=353309 Review URL: https://codereview.chromium.org/215503003 git-svn-id: svn://svn.chromium.org/blink/trunk@170471 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
keonho07.kim@samsung.com authored
According to specification, minDecibels, maxDicibels and smoothingTimeConstant are defined to double. Specification mismatched, internal member valuables already are defined to double as well. Do not need to cast from float to double. http://www.w3.org/TR/webaudio/#AnalyserNode BUG=356636 Review URL: https://codereview.chromium.org/212793002 git-svn-id: svn://svn.chromium.org/blink/trunk@170469 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
https://codereview.chromium.org/216843002/lushnikov@chromium.org authored
Reason for revert: Implied a bug: https://code.google.com/p/chromium/issues/detail?id=358136 Original issue's description: > DevTools: fix xhr breakpoint text overflow > > BUG=357520 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170337 TBR=vsevik@chromium.org NOTREECHECKS=true NOTRY=true BUG=357520 Review URL: https://codereview.chromium.org/219473005 git-svn-id: svn://svn.chromium.org/blink/trunk@170468 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rafaelw@chromium.org authored
Caused build failures on Android. TBR=zvorygin BUG= Review URL: https://codereview.chromium.org/219243006 git-svn-id: svn://svn.chromium.org/blink/trunk@170467 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zvorygin@chromium.org authored
Speeds up blink compilation ~ 1.5% BUG= Review URL: https://codereview.chromium.org/218583007 git-svn-id: svn://svn.chromium.org/blink/trunk@170466 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rafaelw@chromium.org authored
TBR=earthdok BUG=328552 Review URL: https://codereview.chromium.org/219673002 git-svn-id: svn://svn.chromium.org/blink/trunk@170465 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eseidel@chromium.org authored
This should help us better understand long HTMLDocumentParser::insert blocks when we encounter them on traces. BUG=356292 Review URL: https://codereview.chromium.org/208793004 git-svn-id: svn://svn.chromium.org/blink/trunk@170464 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caseq@chromium.org authored
This lets timeline views that don't operate on timeline records to display details. BUG= Review URL: https://codereview.chromium.org/219363002 git-svn-id: svn://svn.chromium.org/blink/trunk@170463 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
lushnikov@chromium.org authored
This patch rolls codemirror to version 4.0.3. It also rolls all supporting plugins we use, though leaving highlighting modes intact. BUG=356878 Review URL: https://codereview.chromium.org/216973004 git-svn-id: svn://svn.chromium.org/blink/trunk@170462 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
b.kelemen@samsung.com authored
This CL adds a basic test for 'gamepadconnected' and 'gamepaddisconnected' events and extends the api test to check the differences between the prefixed and non-prefixed api's. BUG=344556 Review URL: https://codereview.chromium.org/212813008 git-svn-id: svn://svn.chromium.org/blink/trunk@170461 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hayato@chromium.org authored
The previous attempt, https://codereview.chromium.org/208503004, was reverted in https://codereview.chromium.org/212303005/. The reason of reverting is that there is a JavaScript code uses prefixed Shadow DOM API in the chromium side. I've fixed that in https://codereview.chromium.org/214093002/. Let me re-land r170008. I hope it won't break anything this time. BUG=242153 Review URL: https://codereview.chromium.org/218943003 git-svn-id: svn://svn.chromium.org/blink/trunk@170460 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dgozman@chromium.org authored
We now try to satisfy preferred size, but when it's impossible ensure minimum size at least. BUG=none Review URL: https://codereview.chromium.org/214663005 git-svn-id: svn://svn.chromium.org/blink/trunk@170459 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
TBR=apavlov Review URL: https://codereview.chromium.org/219573002 git-svn-id: svn://svn.chromium.org/blink/trunk@170458 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
fs@opera.com authored
Drop the case in which m_code has been set without also setting m_exception. Followup to https://codereview.chromium.org/219263002/. R=haraken@chromium.org Review URL: https://codereview.chromium.org/219373005 git-svn-id: svn://svn.chromium.org/blink/trunk@170457 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
alph@chromium.org authored
Review URL: https://codereview.chromium.org/218393010 git-svn-id: svn://svn.chromium.org/blink/trunk@170456 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
BUG=277984 Review URL: https://codereview.chromium.org/218933003 git-svn-id: svn://svn.chromium.org/blink/trunk@170455 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mvanouwerkerk@chromium.org authored
Intent to implement thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLXyXABvA_0 BUG=350378 Review URL: https://codereview.chromium.org/213013006 git-svn-id: svn://svn.chromium.org/blink/trunk@170454 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
R=sergeyv@chromium.org Review URL: https://codereview.chromium.org/218703002 git-svn-id: svn://svn.chromium.org/blink/trunk@170453 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
lushnikov@chromium.org authored
This patch is a workaround for compositing bug observed on MacBook Pro with retina display. BUG=358161 Review URL: https://codereview.chromium.org/219413003 git-svn-id: svn://svn.chromium.org/blink/trunk@170452 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-