- 08 Oct, 2019 26 commits
-
-
Daniel McArdle authored
This CL should make it easier to add a third request for ESNI info. Bug: 1003494 Change-Id: I307d62bac816df1e058bf8c502ae9f448163ae9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815845Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#703563}
-
Jeremie Boulic authored
Add optional argument to the QuickView file_metadata_formatter.js to add extra precision to the file size shown in the metadata box. Change the underlying bytesToString() formatting function to add the desired number of precision digits to the file size text if needed. Test: browser_tests --gtest_filter="*FileManagerJsTest.UtilTest" Bug: 977068 Change-Id: Iaa6a08fbcbd7663ce2ec8d9347fc659894343926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760840Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#703562}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2682b5a02d16..a333b87cfcbe git log 2682b5a02d16..a333b87cfcbe --date=short --no-merges --format='%ad %ae %s' 2019-10-07 courtneygo@google.com Vulkan: Handle D24 -> D32FS8X24 depth fallback 2019-10-07 jonahr@google.com D3D11: Buffers larger than MAX_UNIFORM_BLOCK_SIZE Created with: gclient setdep -r src/third_party/angle@a333b87cfcbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:angleproject/3937,chromium:906683 Change-Id: I12dc104a610a6f39d6154a19a5fcee6e47a37742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846595Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703561}
-
Simeon Anfinrud authored
Bug: 142062297 Test: With internal patch, view Cast settings UI on emulator Merge-With: eureka-internal/322486 Change-Id: I91ab48f651c998bcdc0456d8c4a2bd6911bf1d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846017Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703560}
-
Kenichi Ishibashi authored
To generate better trace log for performance investigation. Bug: 1011214 Change-Id: Ic7548af0f039bd8c67b8a990b66bfea88ff43ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843801 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703559}
-
Mei Liang authored
This CL adds a TabGridMessageCardView for tab switcher and registers the item view if the close tab suggestion feature flag is enabled. TabGridMessageCardView is not used anywhere in the code other than the tests yet. Change-Id: Ib06d6c45070c3e24e64ac3592d698ff610f634b9 Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808559 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703558}
-
Kenneth Russell authored
This is a two-sided patch requiring an ANGLE update for this extension to start working again in Chromium. Since ANGLE will roll forward quickly, simplify this patch by not retaining intermediate support for the CHROMIUM_ version. Bug: 1011653 Change-Id: Ib6e87cd0859153c253f21f9b5417d49e293ab6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843315 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#703557}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I618215c6a328c480de75d3b526d4365eeb5c9d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844916Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#703556}
-
Austin Eng authored
https://dawn.googlesource.com/dawn.git/+log/21dfc919547f..8eb8385e2efc git log 21dfc919547f..8eb8385e2efc --date=short --no-merges --format='%ad %ae %s' 2019-10-07 enga@chromium.org dawn_wire: Tag deserialize commands with volatile pointer 2019-10-07 rharrison@chromium.org Add build time flag to control enabling SPIRV-Cross reflection 2019-10-07 rafael.cintron@microsoft.com Add MaybeError to d3d12::Device::ExecuteCommandList 2019-10-07 zino@chromium.org Rename PipelineStageDescriptor to ProgrammableStageDescriptor 2019-10-07 cwallez@chromium.org dawn_wsi: Pass the Metal queue to the SwapChainImpl 2019-10-04 rharrison@chromium.org Adding missing reflection API sources to SPIRV-Cross targets Created with: gclient setdep -r src/third_party/dawn@8eb8385e2efc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None TBR=cwallez@chromium.org Bug: dawn:232 Change-Id: I54d35f507e6bfd6bb96295eead08b4b947afa586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846082 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#703555}
-
Cliff Smolinsky authored
On Win7 with DWM off there is a composition bug which results in the aura tooltips either not showing or getting cut off. For this scenario we can simply use the legacy tooltips. Bug: 1007262 Change-Id: Ie811b8c26a9b75b8c4a1a3d577eec72e6bf4cec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842502Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703554}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/40324d671c25..333d22c01cc4 git log 40324d671c25..333d22c01cc4 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 wbbradley@chromium.org pkg_size: create a simple CLI tool to dump a system size report Created with: gclient setdep -r src/third_party/chromite@333d22c01cc4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I91c1163bfa66d7788fb096cb8b62d186804d2007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846241Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icaa773109dd623ee706f1987afdefb6b0bd7df95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846409Reviewed-by:
-
inglorion authored
ToT Clang now warns on some code in Courgette, causing the ToT bots to fail because of -Werror. This change temporarily downgrades bool-operation to a warning so we can continue to build while we work on a fix. Bug: 1011810 Change-Id: I97d248539a0a3427fc374a7f4525e96234ef801e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846084Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#703551}
-
Evan Stade authored
This reverts commit 5d024fd7. Reason for revert: breaks chrome os compile: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/145309 Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 5 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: I49cfab31ec57b183570cf4551e4cd1acd20a1a75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844752 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#703549} TBR=tkent@chromium.org,gyuyoung@igalia.com Change-Id: I80c6d6a5225fd17170a1cdc6e60dacd533da641d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846816Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#703550}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I49cfab31ec57b183570cf4551e4cd1acd20a1a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844752Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3306bbe476fd..eeafa0eaece5 git log 3306bbe476fd..eeafa0eaece5 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 inglorion@chromium.org Revert "gclient_utils: buffer output as bytestrings in Annotated" Created with: gclient setdep -r src/third_party/depot_tools@eeafa0eaece5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I5594f380e280eafdf02052d44d9a24a89bbcf3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846240Reviewed-by:
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including foo.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in blink header files. This CL has no behavior changes and following CLs will continue replacing them more. Bug: 1001360 Change-Id: I91ea1806b38f02be2303312745d3f615b1dab885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844915Reviewed-by:
-
Jon Mann authored
This updates test classes and unit tests to avoid using ssid as a key to uniquely identify networks. Bug: 966270 Change-Id: Ic1ff783e8685b908cb54555b98356314fdba0d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838307Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#703546}
-
Andrey Kosyakov authored
Change-Id: Id8943bd70fa5fd7df1e2d4b5b02bff7117e6cf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832915 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#703545}
-
David Black authored
This CL removes feature flags for: - Timer notifications - Alarm/timer manager - Timer ticks These features have been enabled for a while and seem stable. Keeping these flags around makes the code harder to understand. Bug: b:142152334 Change-Id: I3677cfe7df827045d51c2b03237c515d25ba18de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842558Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#703544}
-
Ahmed Fakhry authored
BUG=988771, 988743 Change-Id: I5653ef78777516ce4ae937c407ab530aa0d1d33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846337Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#703543}
-
Ionel Popescu authored
Bug: 994219 Change-Id: I7b7f79d2d5fb5898491ea39568bfb1163450ff1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844432 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#703542}
-
Patrick Monette authored
This CL splits ServiceWorkerContextCoreObserver::OnRunningStateChanged() into OnStarting(), OnStarted(), OnStopping() and OnStopped(). It also splits ServiceWorkerContextObserver::OnVersionRunningStateChanged() into OnVersionStartedRunning() and OnVersionStoppedRunning(). And both Started notification contains additional information about the service worker, notably the process ID, the scope and the script URL. Change-Id: I11ad9c5d7a686c258bc53813e346cdac96cf525d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842213Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#703541}
-
Dana Fried authored
SHIFT+[RIGHT|LEFT] now moves AX-selected tab. If a tab is moved into or out of a group, its group will be updated appropriately. Also added a handful of browser tests since the move right/left functionality needs to be tested in integration with a live TabStripModel. Still to do: announce the change to the screen reader. Bug: 996850 Change-Id: I0fe1b36c0bab0f7740cb0876bc94a04cfa092786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793547 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703540}
-
Min Qin authored
All the parallel requests are now half open, no need for this field. And it is very strange to pass a request's length to download file, as the download file should know the whole file length, rather than an individual stream's length. BUG=1011427 Change-Id: Id29b5c2859441e7bfffee165bc760c183b5a6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841183 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703539}
-
Sebastien Marchand authored
The MultiSourceMemoryPressureMonitor is the new default memory pressure monitor and this class will eventually be merged with the MemoryPressureMonitor one, in the meantime this change will allow downcasting the fake monitor into a multi source monitor. Change-Id: I6ccd1f196a6e50f1fa7f2a7a547fc326732f97aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835161Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#703538}
-
- 07 Oct, 2019 14 commits
-
-
Julian Watson authored
Change-Id: I7be1eae82702d0576e6bcd701c985be97724c7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839279 Commit-Queue: Julian Watson <juwa@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#703537}
-
Wenyu Fu authored
Before the fix, when trying to edit an editable directory in bookmarks, the font style is set to Google Sans. This fix reset the style to be consistent with other bookmarks editing style Bug: 1003551 Change-Id: I3339f9c07b6823c0a0ba32cdcd04f32ee6471705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846038Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@google.com> Cr-Commit-Position: refs/heads/master@{#703536}
-
David Staessens authored
This CL adds guado-kernelnext to the import mode blacklist used by the video_decode_accelerator(_perf)_tests. The blacklist makes sure the tests are run in allocate mode on devices not supporting import mode. Currently only guado is on the blacklist, this CL adds guado-kernelnext. TEST=compiled video_decode_accelerator_tests BUG=b:139841588 Change-Id: Icee92dffa9134d3da06542d130f522f5b7b48e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844751Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#703535}
-
Johannes Henkel authored
Looks like they're not used. Change-Id: I78acd0704c1d3caff98f54e9124f968ee65cd234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845581Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#703534}
-
Chris Harrelson authored
Tbr: nasko@chromium.org Change-Id: Ief500917465b2cdf29f07ee627248aa7f3b9a2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842752 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703533}
-
Miriam Zimmerman authored
This enables code that tests the crash reporter subsystem to collect crash dumps. Bug: 983725 Change-Id: I9454fb24423a631f36fd01b56050deacde2219b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836661Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#703532}
-
Brian Sheedy authored
Refactors most of the code from "PixelIntegrationTest" and "CloudStorageIntegrationTestBase" into "SkiaGoldIntegrationTestBase", deleting some old unused code in the process. "PixelIntegrationTest" now only contains code specific to the tests invoked via the "pixel" test type. Bug: 1008524 Change-Id: Ibe8e80ea7a4e16becd889d1484738e1abbcf32bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845951 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#703531}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ccec3700953..fa01042385e5 Created with: gclient setdep -r src-internal@fa01042385e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iaa90056863f31b38687dbf2af520f01a84f5776e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845708Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703530}
-
Mike Jackson authored
This change updates gen_include_files in the build.gn to account for the files included in test code via GEN_INCLUDE. With this change, dependencies should now be expressed correctly, and will pick up future updates to axe-core. gen_include_files are both read at compile time, and included at runtime. This means they support compile time directives like GEN and GEN_INCLUDE which can generate code and include further files - and those further files could have their own directives, and so on. Bug: 984817 Change-Id: Iabde6f2c5c7c2c3dedb1c32e45c086e11ec6d4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841575Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703529}
-
Eric Willigers authored
When a longhand value is omitted, the longhand should have the specific initial value for the shorthand, not 'initial'. Bug: 501673, 772772 Change-Id: I0986013e6785852861b79926dd0696314c758ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839934Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#703528}
-
Christian Biesinger authored
This fixes the following error on Python 3: Traceback (most recent call last): File "tools/flags/generate_expired_list.py", line 126, in <module> main() File "tools/flags/generate_expired_list.py", line 120, in main output = gen_expiry_file(sys.argv[0], sys.argv[1]) File "tools/flags/generate_expired_list.py", line 107, in gen_expiry_file output += gen_file_body(list_flags.load_metadata(), get_chromium_version()) File "tools/flags/generate_expired_list.py", line 96, in gen_file_body flags = list_flags.keep_expired_by(flags, mstone) File "/usr/local/google/home/cbiesinger/chromium/src/tools/flags/list_flags.py", line 46, in keep_expired_by return [f for f in flags if -1 != f['expiry_milestone'] <= mstone] File "/usr/local/google/home/cbiesinger/chromium/src/tools/flags/list_flags.py", line 46, in <listcomp> return [f for f in flags if -1 != f['expiry_milestone'] <= mstone] TypeError: '<=' not supported between instances of 'int' and 'str' Bug: 941669 Change-Id: Ia2c7cb7e618a1407d79c0a868358f88b579778b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845583 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: -
Mounir Lamouri authored
Because the media controls are not the target of the events, we do not benefit from the built-in mechanism for preventDefault(). This change makes sure that we follow preventDefault() when needed. Worth noting that because of when the event is run, the website event handler may run after the media controls one. Registering the event handlers before inserting the element to the tree should guarantee the order. Bug: 947373 Change-Id: Ic43a42ecbc370ddd57a4ccb6461878fce53f7275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845775Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#703526}
-
Garrett Beaty authored
The configuration is "generated" by copying the hand-written files to the generated subdirectory. The LUCI project configuration must be updated to point at the new location before the hand-written configuration files can be removed in favor of being actually generated by starlark. Bug: 1011908 Change-Id: I81349a96876315045694df809ab1fbf6c28ce91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845698 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703525}
-
Julie Jeongeun Kim authored
This is a reland of d6027891 It was pointed out as a suspicious CL for crbug.com/1008178 and reverted. But, it turned out it's not related to the issue. So, it's relaned without any change from the original CL. Original change's description: > Convert nacl.mojom to new Mojo types > > This CL converts NaClRendererHost and NaClExitControl > to new Mojo types. > > It also updates ProvideExitControl from nacl.mojom > and methods and members which implement it. > > Bug: 955171 > Change-Id: Ie6b875e07796b08818825474e8493e5f48072c3f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810509 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#697852} TBR=bbudge@chromium.org,dschuff@chromium.org Bug: 955171 Change-Id: I1024c06b573794a885f8ed856613ea27909e33a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844511 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#703524}
-
