- 21 Jul, 2020 40 commits
-
-
Toby Huang authored
When the parent disables the "Permissions for sites, apps and extensions" toggle, supervised users can't install new extensions and can't approve permission updates on existing extensions by themselves. Otherwise, supervised users can install new extensions with parent/ custodian approval and approve permission updates on existing extensions by themselves. Therefore, this toggle is very important for controlling extensions behavior for supervised users. Since this toggle is enabled by default, we want to track how often the toggle is disabled for supervised users by adding a new UMA metric. Bug: 1096763 Change-Id: Ie1506fccc14e81a4fc2711335ede3457cb4813b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296823 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#790528}
-
Xing Liu authored
We're shipping offline prefetch notification with this feature. So extend the metrics expiration date. Bug: 1097841,1097840,1097839,1097838,1097837,1097836,1097835,1097834,1097833 Change-Id: I18464473d264428c746ba14aaa0f6d45fd3a4bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308992Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790527}
-
Kevin Ellis authored
Change-Id: Icae6ce1abc3691bc00d8bd45e27963008b2bf7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305511 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790526}
-
Will Harris authored
This CL adds a gn flag "win_enable_cfg_guards" to allow CFG guard dispatch calls to be generated by the compiler. This also adds a test to verify that a guarded indirect call to an invalid location results in a 0xC0000409 fast fail. It also turns on the CFI linker for base_unittests and sbox_integration_tests. BUG=584575 Cq-Include-Trybots: luci.chromium.try:win7-rel Change-Id: I446d3a28733a46fa4d8f96f28cdfc7b132b10772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300634Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790525}
-
cfredric authored
Add ukm::SourceIds to SharedWorkerHosts, and propagate the SourceId of the client when new connections are made. A followup cl will use these source IDs in UKM events. Bug: 1085645 Change-Id: I02853df540b734816cb48920f0254ad452336786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273483 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790524}
-
Mikel Astiz authored
Overriding HistoryService and BookmarkModel after the profile has been created is problematic and known to cause hard-to-debug test flakiness. Instead, this patch adopts TestingProfile::Builder for tests in chrome/browser/extensions. Change-Id: Ifcf2999a5e12c0a2a3c2c23f06ae86711a54a982 Bug: 1106699,1106339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310490Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790523}
-
Xianzhu Wang authored
Bug: 1104064 Change-Id: I943b1c59bcf9b3bbe60205387693c71e2b457284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306755 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790522}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Iabb83afa045a3e3f16a257f55c2a60ed16759222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308514Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#790521}
-
Lei Zhang authored
Replace existing code that does exactly the same thing. Bug: 1009837 Change-Id: I7f2612bbc03301bf1b43c42c153ab2f795a82616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285849Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#790520}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I5dbc5ed6af51ce56dd24bb4427bb8f93db154dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303772 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#790519}
-
Luis G Garcia authored
Enable grouping of the AR and Camera permission types in order to present both permissions within a single prompt to the user. This prompt will be displayed when a session is requested with camera access as a requested feature. UX Design Doc: https://docs.google.com/document/d/19iYmlZeyEIYwZFurDbYvwT0WEc1MfJ4TKS9V_JA2fF8/edit#heading=h.kffoh0tkafi0 Fixed: 1105590 Bug: 1106874 Change-Id: Ie6c1985f1dd717d3df88d0a856174ec1bdbc3b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303376 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#790518}
-
John Z Wu authored
- Created SharedPasswordController to share ios specific code without being either ios/chrome or ios/web_view specific. - Move MakeSimpleFormData into test_helpers. - Make PasswordSuggestionHelper and PasswordFormHelper injected at initialization to aid with mocking in unit test. - Left some TODOs to continue cleanup of shared code in //components/password_manager/ios/... Change-Id: Ia877ecef4cb44d87f069500fbccb1d0f7320a598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254351 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#790517}
-
Becca Hughes authored
Change-Id: I14c9805056baa6c042d0c391ca3bc87504e59dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305119Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#790516}
-
George Steel authored
Update WPT tests to match spec. Spec: https://drafts.csswg.org/css-writing-modes-4/#text-combine-upright Bug: 1105144 Change-Id: Ia89fdf3f14bab8dfbce1a9e2315f64e9315423e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303353Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#790515}
-
Stefan Zager authored
Previously, <iframe> elements were always composited, and CompositingLayerAssigner specifically disallows squashing them. Due to a recent change (see bug), <iframe> elements are not always composited; but we cannot squash layers across an iframe with composited contents. With this change, an iframe with composited contents will end the current squashing context in the embedding document. BUG=1095935 Change-Id: Ie60becde8b99d204395a2c8f35bc1ce1076334a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309141 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790514}
-
Pavel Feldman authored
This change introduces a binary post data field in the Network.Request type. New field contains entries that correspond to the http body data entries. New PostDataEntry type supports text/bytes data only, but allows progressive enhancement for other types such as files and blobs. Bug: 1107728 Change-Id: I205dd7fc93d627a14c111cc2a05a63ce962bc449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309660Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790513}
-
Jan Wilken Dörrie authored
This change implements ranges overloads for the algorithms found in the alg.sort section. Bug: 1071094 Change-Id: I024bca1346ff67bbbb9bef7a6fd6aa8dbff2ebeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310349 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Fixed: 1089106 Change-Id: I068dd5976b4c6798ad69653b53157fbd8a7edfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310651 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Ken Rockot authored
This is a mechnical translation of .typemap files into equivalent GN mojom target settings. Bug: 1059389 Change-Id: I128f2d16ad19617d4cdf7df33bc268823ad70abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304939Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
-
Ted Choc authored
We need to maintain InstantApp support till Android N is deprecated, so this moves out the expiry for a few years since N is far from being removed. BUG=1088538 Change-Id: I136f6463c673679980022c7f6521610521c9c79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309035Reviewed-by:
-
Ali Juma authored
When a WebState isn't in a WebStateList, it doesn't have tab helpers. WebStates used to update the reading list in the background aren't in any WebStateList. When such a WebState encounters an SSL error, it currently attempts to display an error interstitial. With committed interstitials, IOSBlockingPageTabHelper is used to display SSL errors, but since tab helpers aren't created for WebStates that aren't in a WebStateList, trying to use an IOSBlockingPageTabHelper results in a crash. Without committed interstitials, an error interstitial is created and displayed in the WebState, but is never seen by the user since the WebState itself is not visible (and will never be visible). This CL stops attempting to display an SSL error interstitial for a WebState that isn't in the WebStateList. Bug: 1107534 Change-Id: Iae88f30a024dd770f59b15b1aa3fc6f2ea23f06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308910 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#790508}
-
Jérôme Lebel authored
This fix is for Multi window. The sign-in upgrade promo has to be shown in only one window when Chrome is started. This promo will be shown a second time on a second start. Instead of each window opening the sign-in upgrade promo, the main controller needs to select only one window to show the promo: -[MainController startUpAfterFirstWindowCreated] goes through the list of scene to find the active one which can display the sign-in upgrade promo. Fixed: 1098188 Change-Id: I986b6b75e9f9a7c598381b68de766004e0259f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273281 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#790507}
-
Brian Malcolm authored
This redirects all DeviceNativePrinter settings to the newer DevicePrinters policy (including incoming GPO policies). At a future date, DeviceNativePrinter will be removed. BUG=chromium:1105185 Change-Id: I8f37c2fa53678ef2581120689bf649e3c30f4773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304108 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790506}
-
Tommy Nyquist authored
The added test is flaky: groupAndCloseTabSuggestionDismissedAndShowNext_temp so disabling the test. Example build failure: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/32933 Bug: 1085452 Change-Id: I5e7a655d03f56273bd58a16b4686672fea12036a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307914Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#790505}
-
Francois Doray authored
These test performs multiple navigations, which takes time and can cause timeouts on ASAN. It was already disabled on debug builds. Almost all flakes are on linux_chromium_asan_rel_ng and are timeouts: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTgsSBUZsYWtlIkNjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFRhYk1hbmFnZXJUZXN0LkRpc2NhcmRUYWJzV2l0aE9jY2x1ZGVkV2luZG93DA https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBicm93c2VyX3Rlc3RzQFRhYk1hbmFnZXJUZXN0LkRpc2NhcmRUYWJzV2l0aE1pbmltaXplZFdpbmRvdww It is known from previous experience that performing multiple navigations in a browser test can exceed the test timeout on ASAN. Bug: 1106485 Change-Id: Ic7ed2ed0b867a576fa9d09d9d75cb45841ebe443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305514 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#790504}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7d529ff6e1c2..f272427bda39 2020-07-21 capn@google.com Eliminate dead host/target feature code for Subzero If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:937268 Tbr: swiftshader-team+autoroll@google.com Change-Id: I9f7f18bbfacc3e3dff5502536c952f3afe8134ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790503}
-
Aaron Leventhal authored
In bug 593646 (https://codereview.chromium.org/2024053003/) a rule was added, apparently similar to a rule in WebKit, that prevents aria-activedescendant on an editable combobox field from moving focus into its listbox. However, removing this condition fixes an issue where the first item is not read. It also improves the verbalization, providing the user with the positional info, e.g. "2 of 5". Removing this line also does not seem to break the example attached to bug 593646. Bug: 1082865 Change-Id: I4250fb152f4b06f3c57b300ebe7ef5549c58d624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303789Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790502}
-
Josip Sokcevic authored
Bug: 1007686 Change-Id: Ide3b3717d87de9cf6c49bd57684cd855f3d48b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300049Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Cr-Commit-Position: refs/heads/master@{#790501}
-
ckitagawa authored
This CL restores the tests in PaintPreviewPlayerTest by generating an SkPicture of specified dimensions with a proto.pb containing specified metadata. No new tests are added in this CL; however, the new generation capability can be adapted/expanded to vastly improve integration test coverage of the Player. Bug: 1106035 Change-Id: I10a2e631a54badce6533ad25ce854eb8c714fb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308137 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790500}
-
Aaron Colwell authored
This is the first of 2 changes that rename classes that use blacklist in their class/variable/function names. There are no functional differences here. This patch will be followed by a second change that renames the files and updates the build rules. - Replaced blacklist references with blocklist. This was chosen because the block term was already being used by this code. - Replaced whitelist references with allowlist. - Minor code modernization changes to make ClangTidy happy. These should not cause any behavior changes. Bug: 1097278 Change-Id: I69167b1b720d943d9146b08c5195f2128b10d5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270838Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Dave Tapuska authored
To move the Emulation methods to blink we need to define a mojom definition for this struct. Create typemaps for it as well. BUG=1093963 Change-Id: I673c3d95579f67a6a6169982e5dd0fc557238eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303491Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
Yao Xiao authored
Bug: 1076933 Change-Id: I576a7640e3fa7720122da19e298e336fb0b3a599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305036 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#790497}
-
Xida Chen authored
The problem is in the constructor of this class, which calls NegateIfPossible that takes a int32_t. But the callsites of the NegateIfPossible give doubles. This CL fixes it by static_cast<int32_t> on the doubles. Bug: 1102403 Change-Id: I3ba3097ce99e5b955a885c84c66471b3dc7dd589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289613Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790496}
-
Yuly Novikov authored
Added SwANGLE waterfall and updated Sheriff-O-Matic. Bug: 1064477 Change-Id: Ie37ed9acdf42ed77fd135f7e233f259466a2eb14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309811 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790495}
-
edchin authored
UrlLoadingBrowserAgent is the proper way to load a URL in the current tab. This CL also deprecates use of DropAndNavigate in favor of the new URLDragDropHandler. This CL should have no visible user change. Test: Enable DragAndDrop flag. In iPad multitasking, drop a URL onto the NTP. Change-Id: If593598f7ab6da4f54078ccd4f7765134aa32234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288738Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790494}
-
Nicolas Arciniega authored
This change creates a functional proxy resolver for Windows that relies on WinHttp APIs. This is not in its final state, though. This CL represents the simplest, least-work way to implement this proxy resolution service. Work still to come includes: - Complete NetLogs - Better error reporting from WinHttp APIs - Proxy Delegate - Proxy retry info - Assurance that the proxy configs we're receiving are from the system The WindowsSystemProxyResolutionService is the object that external callers use to resolve a proxy. These callers can keep track of the status of this proxy resolution via a ProxyResolutionRequest, implemented here as a WindowsSystemProxyResolutionRequest. The request object is mainly intended to kick off a specific proxy resolution and report a result via a caller-provided callback. Both of these objects deal with a WindowsSystemProxyResolver. The WindowsSystemProxyResolver is a new class that does all the required interfacing with WinHttp APIs. It is a reference counted object created by the WindowsSystemProxyResolutionService. Once created, it is used for the lifetime of the WindowsSystemProxyResolutionService. Throughout that time, the Resolver indirectly keeps a WinHttp session handle open. Each WindowsSystemProxyResolutionRequest is given a reference to the new resolver. When the Request object attempts to resolve a proxy for a given URL, it'll call into the Resolver object. Under the hood, the Resolver object creates a handle for the proxy resolution and runs the async call to WinHttp. At any time, the Request object can choose to ignore a pending result from the Resolver (ex: shutdown). The Resolver object must be reference counted because async WinHttp calls call back directly into the Resolver object, so it needs to stay alive as long as we're waiting for an async response from WinHttp. The only other new object is the WinHttpAPIWrapper, which is just a thin wrapper over WinHttp APIs which we use to enable easier testing and to simplify some interactions with WinHttp. A WinHttpAPIWrapper is owned by a WindowsSystemProxyResolver. The Resolver object is the only object that should interact with the Wrapper object in any meaningful way. Internally, the WinHttpAPIWrapper keeps track of the opened WinHttp session handle that we're using for the lifetime of the Resolver object. This change includes tests for the WindowsSystemProxyResolver layer (by mocking out the WinHttpAPIWrapper) and the WindowsSystemProxyResolutionService (by mocking out the WindowsSystemProxyResolver). Bug: 1032820 Change-Id: Ic1c60033ff148e6e8f3708e37a2af366613fefac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159128 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790493}
-
Daniel Murphy authored
There wasn't a simple sync integration test around app 'uninstall' syncing between profiles, so this test adds that. R=loyso@chromium.org Change-Id: Ia0d1c8a69c958de16d12c885452e2c05f71134ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298173 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#790492}
-
Noah Rose Ledesma authored
This CL adds a method to MediaNotificationService used by the MediaNotificationAudioDeviceSelectorView to query the system for audio output device descriptions. The device selector view will then display the available devices to the user. Bug: 1096242 Change-Id: I22d0dedd22697c2ecf8a725d7c8ca65880b86819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283417Reviewed-by:
-
Bailey Berro authored
This change makes it so that a highlight around the currently selected display is only shown once dragging of the display in the Display Layout section begins. Previously, whenever Display settings was open and multiple displays were attached to the device, whichever display was currently selected in settings would be highlighted at all times. Bug: 1070122 Change-Id: I2ab461dc15db4b63b98a54383ca8966e5083ffdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290353 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#790490}
-
Etienne Pierre-doray authored
This is a reland of fb56fbc5 Issue: Trace event under lock cause PostTask and lock inversion. Fix: Move trace event outside of lock (to both callsites of WaitForParticipationOpportunity), this should give us mostly the same information but scope is a bit bigger. See patchset 2 Original change's description: > Reland "[Jobs API]: Use worker_lock in JobTaskSource." > > This is a reland of 6eb566d2 > > Reason for revert: Cause failure in CheckedLockImpl::Acquire > crbug.com/1099649 > Mark worker_released_condition_ declare_only_used_while_idle > to prevent priority queue from being acquired in ScopedBlockingCall. > > Original change's description: > > [Jobs API]: Use worker_lock in JobTaskSource. > > > > Possible race when Join(): > > - thread A: Join: worker_released_condition_->Wait() > > - thread C: WillRunTask: > > GetMaxConcurrency() returns > 0 > > - thread B: already running, finishes all the work > > GetMaxConcurrency() goes 0 > > - thread B: DidProcessTask: > > worker_released_condition_->Signal(), > > - thread A: Join returns (GetMaxConcurrency() is 0) > > - thread C: TryIncrementWorkerCountFromWorkerRelease > > worker count goes 1 > > - thread C: runs worker_task after Join > > > > To fix race when Joining, all writes to |state_| are protected by > > |worker_lock|. Memory ordering is no longer necessary. > > > > Alternative: cancel before Join returns with a compare and swap and > > loop again if new workers. > > > > Change-Id: I4e478ffae2bdaec56386739f78de089d0e74e42c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248159 > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#781453} > > Change-Id: I1c7c0054a52b9b12dd6d0edd049ab2a7912df361 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272942 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789526} Change-Id: I0b08ee9fb7efd6b5cfdf9d171f2a280ccbb1fa5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309572Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#790489}
-
