- 04 Jan, 2018 33 commits
-
-
Fady Samuel authored
Prior to this patch, ResizeDueToAutoResize does not always allocate a new LocalSurfaceId. In the case of extension popups, the window is not resized until loading the extension is done: See ExtensionViewViews::DidStopLoading. However, in the meantime, multiple resizes may occur. Surface synchronization expects that a new LocalSurfaceId is allocated every time a CompositorFrame is produced, even if those surfaces aren't referred to by any parent. In order to maintain that invariant, this CL allocates a new LocalSurfaceId on every auto-resize. Bug: 791154 Change-Id: I71cdf101351290276639f95e67f9ebb5d140ab65 Reviewed-on: https://chromium-review.googlesource.com/847942 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#526897}
-
Minh X. Nguyen authored
Bug: 722942 Change-Id: I9b164dda08861749c9d033ff32f4a82391bc0d0e Reviewed-on: https://chromium-review.googlesource.com/822760Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526896}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: Iac87a469d61d677e188a670a4bb8fd501abe914a Reviewed-on: https://chromium-review.googlesource.com/849642Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#526895}
-
Pedro Amaral authored
|LegacyPastePopupMenu#positionAt| expects the coordinates of the bottom of the selection caret not the bottom of the touch handle. Bug: 732742 Change-Id: Idc6d92076695bf865afc093c4980f10e1c48282e Reviewed-on: https://chromium-review.googlesource.com/849493Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#526894}
-
Ahmed Fakhry authored
Instead of pre-populating the feedback description of crash reports with text that ends up being sent to the server, we should instead add this text as a placeholder instruction to the user. BUG=756630 TEST=manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86bbead3eed94d028277721239cc12fecd886484 Reviewed-on: https://chromium-review.googlesource.com/848501Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#526893}
-
danakj authored
ResourcePool makes uses of creating resources on ResourceProvider, which is a functionality of LayerTreeResourceProvider (ie compositor clients). We replace it with 3 vectors in GLRenderer, and ScopedGpuMemoryBufferTexture, of which ownership is moved through those vectors. ScopedGpuMemoryBufferTexture allocates a texture backed by an image + GpuMemoryBuffer, so that it can be used as an overlay. The first vector is the set of in-flight textures. Once SwapBuffersComplete happens, we move them to a set awaiting release from CA. Then on signal from CA we recycle them back into the available set. R=ccameron@chromium.org Bug: 730660, 738190 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I24efe515b69aaa7ec30d7163f28a66f96c3562c0 Reviewed-on: https://chromium-review.googlesource.com/843127 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526892}
-
Tarun Bansal authored
This reverts commit 24f046fc. Reason for revert: The previous revert was by mistake. Original change's description: > Revert "Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN" > > This reverts commit 0c2c9838. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN > > > > Bug: 656170 > > Change-Id: I44efd7c4209a0acac58c3a9857cf6842d1c9f509 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > Reviewed-on: https://chromium-review.googlesource.com/848234 > > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#526728} > > TBR=tbansal@chromium.org,ryansturm@chromium.org > > Change-Id: I2cff4f9fe1d39eeaa49f0264746cb404aee605fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 656170 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/849672 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526890} TBR=tbansal@chromium.org,ryansturm@chromium.org Change-Id: Ieb308bff8ea947752977a9c36c9590122c1ff7a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 656170 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/849573Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#526891}
-
Tarun Bansal authored
This reverts commit 0c2c9838. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reenable unittests in //net/nqe/observation_buffer_unittest.cc on OS_WIN > > Bug: 656170 > Change-Id: I44efd7c4209a0acac58c3a9857cf6842d1c9f509 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/848234 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#526728} TBR=tbansal@chromium.org,ryansturm@chromium.org Change-Id: I2cff4f9fe1d39eeaa49f0264746cb404aee605fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 656170 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/849672Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#526890}
-
Scott Violet authored
This makes it possible to turn on content_browsertests with --mus BUG=785536 TEST=test only change TBR=sadrul@chromium.org Change-Id: I92ac83e6ff596f270947a75956f760bef79017d8 Reviewed-on: https://chromium-review.googlesource.com/849656Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526889}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ebe839b6bfc3..d9a6756b24ae $ git log ebe839b6b..d9a6756b2 --date=short --no-merges --format='%ad %ae %s' 2018-01-03 agable Blacklist http(s): from being parsed as a git footer Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ic8021670c21ca0e0cc2234ad239f5ee59daa30a3 Reviewed-on: https://chromium-review.googlesource.com/849632Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526888}
-
Wez authored
This includes a fix for the Real-Time Clock driver for x86-64. Bug: 798578, 707030 Change-Id: I633c221cb8f65f16cb683658665656d273ba8423 Reviewed-on: https://chromium-review.googlesource.com/849613 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#526887}
-
Darren Shen authored
Implements style property map for interacting with CSS rules. The tests are copied from the inline style property map tests, with the only change being createInlineStyle -> createDeclaredStyle. Spec: https://drafts.css-houdini.org/css-typed-om-1/#declared-stylepropertymap-objects Bug: 785132 Change-Id: I63aedf6d02ccacc506e7a1873c17fecafe466779 Reviewed-on: https://chromium-review.googlesource.com/823508 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#526886}
-
Kenneth Russell authored
Most OS compositors expect premultiplied alpha content. If the user selects non-premultiplied rendering and WebGL is rendering into a GpuMemoryBuffer, then make one last copy of the user's rendered content into the GMB, premultiplying alpha at that point. This allows the OS's compositor to handle premultipliedAlpha:false WebGL content rather than falling back to Chrome's GL compositor. BUG=786945 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib43828bf9b02fcad38d210096adfc00a61804766 Reviewed-on: https://chromium-review.googlesource.com/846478Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526885}
-
Ken MacKay authored
Mutex priority inheritance is useful to avoid cases where a high-priority thread is waiting for a mutex that is held by a low priority thread that may not get to run for a while. This is particularly useful for realtime applications. For more discussion, see https://www.kernel.org/doc/Documentation/pi-futex.txt Some platforms (eg Chromecast) are known to fulfill the requirements for safe use of mutex priority inheritance; add a GN arg and buildflag so that priority inheritance can be enabled for those platforms. Chromecast uses Linux 4.1 or greater, and glibc 2.23-r10, so the bugs mentioned in LockImpl::PriorityInheritanceAvailable() are not present. Bug: Change-Id: I21cecd2144d82f038e35aa30a2a51c35d541c644 Reviewed-on: https://chromium-review.googlesource.com/847642 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#526884}
-
Eugene Ostroukhov authored
1. Do not initialize 'receive' timestamp with -1. Quoting the spec: "The send, wait and receive timings are not optional and must have non-negative values." 2. Account for a possibility of blocked, dns, connect and ssl fields beeing -1. Bug: 760547 Change-Id: I82693812a2f7aea1edfea53d85212e0f09d43360 Reviewed-on: https://chromium-review.googlesource.com/835471Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#526883}
-
erikchen authored
Some clients emit too many entries, which causes memory bloat. This has been observed to consume 3GB+ in the wild. Bug: 798012 Change-Id: Ia230d9bd338c3173fa0f3fb86e641c731605b016 Reviewed-on: https://chromium-review.googlesource.com/849485Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526882}
-
Bruce Dawson authored
Windows.h is included in a number of key header files which means that a majority of the translation units when building Chrome include Windows.h. This is slowing down builds. This change creates a new header - base/win/windows_types.h - which contains typedefs and defines of common Windows.h types - and uses this in place of windows.h in enough places to reduce the number of translation units that include windows.h in a build of the 'chrome' target (debug component non-jumbo) by 5219, from 19041 to 13822, giving measurable build-time speedups (~2.5-3.0%). Follow-up changes will apply the same techniques to more headers and drop the number much further. Perversely enough, this change also adds includes of windows.h in many places - places that always needed windows.h but were implicitly depending on it being included elsewhere. TBR=jochen@chromium.org,wfh@chromium.org,rockot@chromium.org,mef@chromium.org,raymes@chromium.org,joedow@chromium.org,rogerta@chromium.org,jsbell@chromium.org,dpranke@chromium.org,sky@chromium.org TBRing mechanical changes, reviewers: jochen@ : Please review changes to chrome/, components/, content/, third_party/WebKit/Source/platform wfh@ : Please review changes to courgette/, sandbox/win rockot@ : Please review changes to device/, ipc/, services/ mef@ : Please review changes to net/ raymes@ : Please review changes to ppapi/ joedow@ : Please review changes to remoting/ rogerta@ : Please review changes to rlz/ jsbell@: Please review changes to storage/ dpranke@ : Please review changes to tools/gn/ sky@ : Please review changes to ui/ Bug: 796644,798763 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3958d0d7d813bed74d9b166e0358dbde5b5729af Reviewed-on: https://chromium-review.googlesource.com/846422 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#526881}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/da6d0720300a..9fc53624a09f $ git log da6d07203..9fc53624a --date=short --no-merges --format='%ad %ae %s' 2018-01-03 reed check for irect with overflow width/height 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 8b5e8fdb3..36937a64f (1 commit) 2018-01-03 liyuqian Update 2pt conical document 2018-01-03 reed Revert "Revert "remove legacy support for old old picture versions"" 2018-01-02 halcanary SkFloatToDecimal moved to src/utils 2018-01-03 kjlubick Add SkPipe fuzzer Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I39c8a63f9467abc051d9a8fe59d0023f463d7059 Reviewed-on: https://chromium-review.googlesource.com/848251Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526880}
-
Leo Zhang authored
Add native read/write functions for language's blocked state. Once the user selects the enabled menu item, it will toggle the state. Demo link: https://googleo.users.x20web.corp.google.com/screenrecord/lang-settings-toggle.mp4 Bug: 783049 Change-Id: I3b144d1b0c23705931b480dc9a869a0efe0dae00 Reviewed-on: https://chromium-review.googlesource.com/848753Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#526879}
-
Trent Apted authored
ZoomBubbleView has a raw, weak pointer to WebContents which can result in lifetime problems. On Mac, a UAF can result. Elsewhere, the result is typically a deleted pointer being passed to FindBrowserWithWebContents (which is less likely to cause badness). Also on Mac currently, the zoom bubble isn't immediately hidden on tab switch. This is because Cocoa bubbles are managed by base_bubble_controller.mm in a general way: it observes the tab strip via a bridge and dismisses a bubble of whatever type is currently showing. However, views bubbles can not opt into this framework. On other platforms, BrowserView explicitly closes the zoom bubble on tab switch. Most other views bubbles observe WebContentsObserver::WasHidden(), so do the same for the zoom bubble. And test. Bug: 791907, 404979 Change-Id: I36d174530423dbcdb7f93d5e3a575ce07f74d8e7 Reviewed-on: https://chromium-review.googlesource.com/848113 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#526878}
-
Sergey Berezin authored
FORCE_MAC_TOOLCHAIN is forced to be ON for any Mac: https://chromium.googlesource.com/chromium/tools/build/+/05a8b2a97eea031ffd564a8ff2324a4ee1a4e7a7/scripts/slave/recipe_modules/chromium/config.py#192 This is a temporary hack to override it for one builder, so it doesn't interfere with the new Xcode/CIPD flow. BUG=797051 TBR=justincohen@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3a7f36d80438b18924405826c2778e99fd803692 Reviewed-on: https://chromium-review.googlesource.com/849634 Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526877}
-
Wenzhao Zang authored
Fixes a regression since [1]. Prior to that |LoginPasswordView| relied on |LoginAuthUserView| to call Clear() to initialize the states. Now the initialization is moved to the ctor of the password view. [1] https://chromium-review.googlesource.com/c/chromium/src/+/688734 Bug: 795237 Change-Id: I80892ad097a4f0152230921c8b264a9777e9e62e Reviewed-on: https://chromium-review.googlesource.com/845319Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#526876}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/8b5e8fdb3c35..6df487ef1e61 $ git log 8b5e8fdb3..6df487ef1 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 fjhenigman Move angle_enable_* inside declare_args(). 2018-01-03 jmadill HandleAllocator: Fix heap ordering using std::greater. 2018-01-03 jmadill Revert "Enable depth buffer to workaround driver bug on Intel windows" Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I6af7a3889903db4e93be7d741067d242b3b1e396 Reviewed-on: https://chromium-review.googlesource.com/849486 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526875}
-
Parastoo Geranmayeh authored
Show the hint as the first item on the dropdown. This way, when the hint is clicked on, and we move on the items on the list, we see the items on the top first. This is specially important for the Billing Addresses on the Card Editor, where the most relevant item is on the top. Refactor: Use two different adapters for hinted adapters: 1. The ones with '+' icon for their last item, 2. The ones without an icon. Tests were modified for the Card Editor, because now the first item on the dropdown list is the "Select" option, and not the first address. Bug: 795031 Change-Id: Ibccdd1256aa093e661890ea6ef11949c7d074766 Reviewed-on: https://chromium-review.googlesource.com/826005 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#526874}
-
Aga Wronska authored
The override is set in LockWindow now. Test that keyboard does not overlap with lock screen UI. Bug: 791817 Change-Id: Ic789efd897fcfd60f3c6bfe6189e22f6140bbda2 Reviewed-on: https://chromium-review.googlesource.com/828027 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#526873}
-
Will Chen authored
This test hasn't been marked as flaky yet, but it's quite flaky because there's a race condition on when the console messages are printed: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=%20http%2Ftests%2Fdevtools%2Fconsole-xhr-logging-async.js The XHR loaded console message should be suppressed, but it's used to notify when the XHR is loaded. Bug: none Change-Id: If76c37e0e9c31fa2fce033ec440a5c8b580e15bc Reviewed-on: https://chromium-review.googlesource.com/847699Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526872}
-
Eric Roman authored
seconds. This applies to both fetches for WPAD, as well as explicit PAC URLs. 30 seconds should be comparable to Microsoft Edge's defaults (based on some testing on Windows 10). Bug: 251682 Change-Id: Id2cbe60d4d27946de043946a7aad8f926b40c9d9 Reviewed-on: https://chromium-review.googlesource.com/849116Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526871}
-
Hiroshige Hayashizaki authored
TBR=xidachen@chromium.org NOTRY=true Bug: 798735 Change-Id: Ic222eca158f094d52bcb09bbf959d0d6572d2ce8 Reviewed-on: https://chromium-review.googlesource.com/849640Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#526870}
-
Tom Anderson authored
Chromium Embedded Framework [1] is a project that requires a Gtk2 build. [1] https://bitbucket.org/chromiumembedded/cef BUG=610428 R=erg Change-Id: Iefecaccdc026cd5ab4bd692f15926e7410909fc7 Reviewed-on: https://chromium-review.googlesource.com/849482Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#526869}
-
Doug Turner authored
ErrorPageOfflineTestWithAllowDinosaurFalse.CheckEasterEggIsDisabled requires http://mock.request.failed to be handled. This CL installs a default interceptor which handles this request. Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic5b2dca7b3d46b20368094c677ea85456a39b016 Reviewed-on: https://chromium-review.googlesource.com/847917 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526868}
-
Sergey Ulanov authored
Fuchsia exe runner script waits for "ping google.com" to succeed before launching the target to ensure it's launched after network is configured. Due to bug in Fuchsia (see NET-336) ping never succeeds. Workaround this bug by running ping with -c0. This allows to wait for DNS resolion to succeed without sending any pings. Also added a sleep 1 to avoid log noise caused by bug 798801 Bug: 798801 Change-Id: I2fb9f2a8e1608304ebf7007f767c6deb2b43b295 Reviewed-on: https://chromium-review.googlesource.com/848516Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#526867}
-
Kristian H. Kristensen authored
Bug: 586475, 733703 Change-Id: Id8a08fefff1af4f80fd5520a18cc1c9417147552 Reviewed-on: https://chromium-review.googlesource.com/848301Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526866}
-
Sergei Datsenko authored
Test for cross-origin frames. Test for content security policy. Bug: chromium:787197 Change-Id: Ice5fc749edad052ceecd4bb8251a89198271fd89 Reviewed-on: https://chromium-review.googlesource.com/846612 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#526865}
-
- 03 Jan, 2018 7 commits
-
-
Darren Shen authored
This patch uses idlharness.js to test the CSSStyleValue interface. Bug: 774887 Change-Id: I20e487e2ec0e733e5ab152e1f9e9fa6bc2c5a605 Reviewed-on: https://chromium-review.googlesource.com/848116Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#526864}
-
Steven Bennetts authored
After earlier re-factoring, these tests no longer actually test any code in display_preferences.cc. Bug: none Change-Id: Ie8d81f6efafb23918cda3af892ab48ee63cbfb29 Reviewed-on: https://chromium-review.googlesource.com/848247Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#526863}
-
Jayson Adams authored
This cl cleans up some of the tab favicon handling code in preparation for swapping in the new Material Design spinner. In particular, it preserves a tab's iconView when not visible rather than remove the iconView from the view hierarchy. Bug: 602558 Change-Id: I357054ae0f383880d64be3de2e024c634880b99a Reviewed-on: https://chromium-review.googlesource.com/822179 Commit-Queue: Jayson Adams <shrike@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#526862}
-
Gregory Chatzinoff authored
The tools menu item animation that is triggered after the dismissal of the Incognito In Product Help Bubble flickers at the end. This happens because there is a gap between the end of the autoreversed animation (where the item has a highlighted background) and the completion handler (which sets the item to a white background). The fix is to use a CABasicAnimation instead of |animateWithDuration|. Bug: 767202 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I79d57ecf7e77281e9d6d112a66e8e7d20efcccef Reviewed-on: https://chromium-review.googlesource.com/849176 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#526861}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/35d2b7e9de9d..8e126fca476a $ git log 35d2b7e9d..8e126fca4 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic779de68a3bb6e5ecd52f0a0815e079e0ae64613 Reviewed-on: https://chromium-review.googlesource.com/849198Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526860}
-
Bo Liu authored
Only call onAttachedToWindow during init, not every time WebContentsAccessibility is retrieved. Bug: 798629 Change-Id: I5a7036dc1e6dac00b1a0bb250eefc18e36cebf72 Reviewed-on: https://chromium-review.googlesource.com/849393Reviewed-by:
Dmitry Skiba <dskiba@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#526859}
-
George Burgess IV authored
** This change may cause significant performance and binary size differences. ** This is our first (external) attempt to turn on AFDO for Chromium on Android. AFDO, in short, is a feature that lets us feed profiles into the compiler to help it make better optimization decisions. The default AFDO configuration in Chromium also instructs the compiler to make size optimization decisions based on this profile, so code that's built with -O2 but isn't present in the profile will get optimized for size instead. Internal builds and benchmarks look very promising, and indicate that this is a win in both binary size and Chrome's speed. We have many external bots that might disagree, so I guess we'll see. ¯\_(ツ)_/¯ Bug: 794750 Test: apks/ChromePublic.apk builds using the provided profile. Change-Id: I79e3fdb47fb653661a73e9317163d032d6c8b8d9 Reviewed-on: https://chromium-review.googlesource.com/847902Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#526858}
-