GitLab

media: Support simultaneous permission requests from multiple WebContents in ProtectedMediaIdentifierPermissionContext.

ProtectedMediaIdentifierPermissionContext is shared by multiple WebContents.
Even though we don't support multiple permission requests from the same page
(WebContents), we should support permission requests from multiple WebContents.

Test step:
1. Make sure no allowed or blocked exception in content settings.
2. Open a tab/extension, navigate to a page that requests permission. A prompt
should appear. Don't do anything.
3. Open another tab/extension, navigate to a page that requests permission. A
prompt should also appear.
4. Play with allow/block/dismiss and see whether permission status is as
expected and whether content settings are updated correctly.

BUG=446263
TEST=See above.

Review URL: https://codereview.chromium.org/903873002

Cr-Commit-Position: refs/heads/master@{#314933}

Currently smoothness action (e.g. scrolling) starts when the
document.readyState = interactive or complete. It is noticed that when
the readyState = interactive, the page can still be loading resources
so there would be contention on the main thread between resources loading
and input handling, which could have impact on the smoothness metrics.

It is to our interests in actually solving the contention issues so we
don't want to artificially delay the action start just to avoid the
contention. But I do see the benefit in running an experiment on just
wikipedia with delayed action start so as to understand to which degree
this contention is affecting our metrics.

So this CL makes a duplicate of the Wikipedia page in the
key_mobile_sites_smooth and running that particular page with
starting scrolling on readyState = complete.

BUG=455277

Review URL: https://codereview.chromium.org/901563003

Cr-Commit-Position: refs/heads/master@{#314932}

BUG=455533

Review URL: https://codereview.chromium.org/886933008

Cr-Commit-Position: refs/heads/master@{#314931}

This CL introduces MojoHandleAttachment, a MessageAttachment subclass.
With this and ChannelMojo, we are able to send Mojo MessagePipes
over IPC.

There is also MojoMessageHelper which provides some static member functions
that reads and writes MessagePipes from/to a Message. In coming changes,
we'll add ParamTraits for MessagePipe based on this.

R=agl@chromium.org, viettrungluu@chromium.org
TEST=IPCChannelMojoTest.SendMessagePipe, IPCChannelMojoTest.SendPlatformHandleAndPipe
BUG=448190

Review URL: https://codereview.chromium.org/866223005

Cr-Commit-Position: refs/heads/master@{#314930}

1. Using a GDI bitmap -- switch to SkSurface instead

2. Lazily loading a font. This breaks for two different reasons.
The first is a DCHECK for doing IO on the Compositor thread. This
could have been just ignored in general since it's only for debug
usage, the drawbacks of minor jank are limited.

However, once lockdown is on, the font load hard fails from the
renderer. So, load the typeface before lockdown and pass it into
CC and the hud via LayerTreeSettings.

R=danakj@chromium.org
BUG=453731,455104
TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8

Review URL: https://codereview.chromium.org/900063002

Cr-Commit-Position: refs/heads/master@{#314929}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f71b4c1..27f398f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/899893003

Cr-Commit-Position: refs/heads/master@{#314928}

Use DCHECK to validate the ThreadChecker results in RendererScheduler.

Also add a WARN_UNUSED_RESULT modifier to
ThreadChecker::CalledOnValidThread.

Review URL: https://codereview.chromium.org/904593002

Cr-Commit-Position: refs/heads/master@{#314927}

The UseSkiaGpuBackend is false always and not queried anywhere. I
left this behind when I removed the Ganesh-in-GLRenderer thing we
had before.

The ExpandedViewport is slightly more mysterious but also not queried
anywhere, so I guess leftover from refactorings.

R=enne, vmpstr

Review URL: https://codereview.chromium.org/883353009

Cr-Commit-Position: refs/heads/master@{#314926}

Pinch zoom is done by the renderer process now. Note that this leaves
the PreHandleGestureEvent in place, as most if not all instances of it
preventing gesture events are still desirable with the new pinch zoom
behavior.

BUG=451559

Review URL: https://codereview.chromium.org/899283004

Cr-Commit-Position: refs/heads/master@{#314925}

This is a follow-up CL of r314351.

Currently this is invoked from PermissionContextBase. Since this is for
protected media identifier only, it's better to put it in
ProtectedMediaIdentifierPermissionContext.

Also included in this fix:
- Pass |requesting_origin| to PlatformVerificationDialog::ShowDialog().
  Currently we are using the origin of the GetLastCommittedURL(), which is
  wrong.
- Add ProtectedMediaIdentifierPermissionContext::CancelPermissionRequest() so
  that we can cancel the prompt and drop the callback properly. Otherwise, this
  will cause a DCHECK in PermissionServiceImp when closing the browser while the
  prompt is shown.

BUG=446263
TEST=Manually tested various cases.

Review URL: https://codereview.chromium.org/881983003

Cr-Commit-Position: refs/heads/master@{#314924}

Keying off of the driver manufacturer name doesn't work on some systems, so use SetupAPI to enumerate all installed display adapters to check if both an AMD and Intel display adapter are installed.

BUG=455046,451420
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/893993006

Cr-Commit-Position: refs/heads/master@{#314923}

Also fix WebView resource config to not try to include OWNERS files from
resource directories in its APK, as the regular Android build does.

BUG=None

Review URL: https://codereview.chromium.org/894153004

Cr-Commit-Position: refs/heads/master@{#314922}

Historically, the OSX Keychain has been misconfigured on some perf bots, which
has caused Telemtry tests to stall. This CL adds checks to emit warnings if the
Keychain is misconfigured.

I added checks for three common misconfigurations:
  - Is the default Keychain locked.
  - Is the default Keychain configured to automatically lock after a period of
  time.
  - Are the ACLs of a commonly accessed key in the default keychain
  misconfigured for the perf bots.

The first and third checks are performed by short C programs since the
information is easily available through the Security framework, but not from
the security CLI.

BUG=443340

Review URL: https://codereview.chromium.org/809473004

Cr-Commit-Position: refs/heads/master@{#314921}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d953d07..dc9973e

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/886643004

Cr-Commit-Position: refs/heads/master@{#314920}

It is not used only when toolkit_views is enabled. This fixes some
unresolved reference errors that will break the linux_ecs_ozone trybot
once we enable -Wl,-z,defs.

This dependency is already unconditional in the GN build.

BUG=445627
TEST=linux_ecs_ozone tryjob

Review URL: https://codereview.chromium.org/874163004

Cr-Commit-Position: refs/heads/master@{#314919}

This is a vestige of old UpdateDrawProperties and instead should go
directly to the target_id on the transform node.  Also, the root node
was setting the target_id incorrectly because its transform_node_index
was not set before being referenced.

This is a fix contributing towards getting property trees to entirely
replace UpdateDrawProperties on the main thread.

Review URL: https://codereview.chromium.org/897373002

Cr-Commit-Position: refs/heads/master@{#314918}

BUG=455818

Review URL: https://codereview.chromium.org/893353002

Cr-Commit-Position: refs/heads/master@{#314917}

Version 0.8.5.0

[cec4a29a57] Add support for rate targeted heaps
[562794745b] Add support for more AVX2 instructions.

BUG=454269

Review URL: https://codereview.chromium.org/880573006

Cr-Commit-Position: refs/heads/master@{#314916}

Review URL: https://codereview.chromium.org/905573003

Cr-Commit-Position: refs/heads/master@{#314915}

BUG=266140

Review URL: https://codereview.chromium.org/900103002

Cr-Commit-Position: refs/heads/master@{#314914}

This patch splits the work we do in ReleaseResources into two parts:
ReleaseResources and RecreateResources. If any part of invalidating or
creating new resources requires access to new structures (such as a new
tile manager and new output surface), this is the way to get this
information.

That is, ReleaseResources happens while old objects are alive and
accessible. RecreateResources happens when the new objects are alive and
accessible.

R=danakj, enne

Review URL: https://codereview.chromium.org/899313003

Cr-Commit-Position: refs/heads/master@{#314913}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5e1378d..f71b4c1

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/902493008

Cr-Commit-Position: refs/heads/master@{#314912}

Calling preventDefault in the click event prevents buttons from handling the event.

BUG=455617

Review URL: https://codereview.chromium.org/879243007

Cr-Commit-Position: refs/heads/master@{#314911}

This prevents transient audio creation errors from cumulatively
breaking audio output by blackholing everything to a fake audio
stream after fallback attempts are exhausted.

BUG=453560
TEST=new unittest, manual testing.

Review URL: https://codereview.chromium.org/899923003

Cr-Commit-Position: refs/heads/master@{#314910}

Review URL: https://codereview.chromium.org/896053002

Cr-Commit-Position: refs/heads/master@{#314909}

This is preparatory work for bug 444244.

BUG=444244
TBR=sky

Review URL: https://codereview.chromium.org/882273003

Cr-Commit-Position: refs/heads/master@{#314908}

+ On small screens the navigation buttons are anchored to the bottom of the screen.
+ Tweaks to the text colour
+ Change button styling of safe browsing page

BUG=422882

Review URL: https://codereview.chromium.org/885283005

Cr-Commit-Position: refs/heads/master@{#314907}

The library uses functions from "math.h". This fixes the embedded build
with -Wl,-z,defs.

BUG=445627
TEST=linux_ecs_ozone tryjob
TBR=cpu

Review URL: https://codereview.chromium.org/901273002

Cr-Commit-Position: refs/heads/master@{#314906}

- Pass gaia auth init params via postMessage instead of URL params;
- Validate message origins on both ends to ensure gaia auth only
  takes params from intended hosting pages and hosting pages only
  send params to gaia_auth;
- Add string data storage to GaiaAuthExtensionLoader;
- Use the string data storage to pass frameURL for switchToFullTab;
- Update CSP in manifests to be more restrictive;
- Clean up unused code in util.js;

BUG=453994

Review URL: https://codereview.chromium.org/902493003

Cr-Commit-Position: refs/heads/master@{#314905}

BUG=412078

Review URL: https://codereview.chromium.org/896523002

Cr-Commit-Position: refs/heads/master@{#314904}

Revert of Update sync promo string in chrome://settings (patchset #1 id:100001 of https://codereview.chromium.org/904513002)

Reason for revert:
165 Browser test crashing on Linux after the patch

Sample failure:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38668/steps/browser_tests/logs/OptionsWebUIExtendedTest.ShowPageWithHistory

Original issue's description:
> Update sync promo string in chrome://settings
>
> BUG=455273
> Committed: https://crrev.com/fdef2865f067f30e99f1f11b33d8811d98bf1e54
> Cr-Commit-Position: refs/heads/master@{#314875}

TBR=noms@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/884743004

Cr-Commit-Position: refs/heads/master@{#314903}

Should be reverted once we have one from crashing startup.warm.blank_page perf test.

BUG=433966

Review URL: https://codereview.chromium.org/899293003

Cr-Commit-Position: refs/heads/master@{#314902}

Review URL: https://codereview.chromium.org/904723002

Cr-Commit-Position: refs/heads/master@{#314901}

The server will now always do processing for nodes that don't have
stars.id set, so no need to flip this flag any more.

BUG=

Review URL: https://codereview.chromium.org/888983002

Cr-Commit-Position: refs/heads/master@{#314900}

BUG=454140

Review URL: https://codereview.chromium.org/884843002

Cr-Commit-Position: refs/heads/master@{#314899}

Previously we were re-using 'gypbuild' for both 64 and 32.
This change increases the complexity of the build but
is more correct and robust and allows us to avoid cleaning
the gyp output folders between builds.

Review URL: https://codereview.chromium.org/898613002

Cr-Commit-Position: refs/heads/master@{#314898}

1) glGetUniformBlocksCHROMIUM

This is Chromium GPU command buffer internal command. The purpose is to
fetch UniformBlock related information in a linked program from service side
in one command instead of multiple ones.

2) glGetUniformBlockIndex
3) glGetActiveUniformBlockName

Get value from client side cache (retrieved by GetUniformBlockCHROMIUM);
if that fails, send the command to service side.

What's missing: glGetActiveUniformBlockiv.  It requires some extra tuning, so
leave that for a separate CL.

BUG=453127,429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/895933004

Cr-Commit-Position: refs/heads/master@{#314897}

A more efficient way to draw a simple oval with alpha.
It saves memory too since the view's layer no longer needs a backing buffer.

Also simplified fade out animation code when dismissing.

Review URL: https://codereview.chromium.org/894423003

Cr-Commit-Position: refs/heads/master@{#314896}

Add new flag to disable screen orientation locking. Update ScreenOrientationController to be enabled by default, and to check flag state for disabling.

TEST=Set flag to check feature was disabled.
BUG=396760

Review URL: https://codereview.chromium.org/901963002

Cr-Commit-Position: refs/heads/master@{#314895}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/abac64f..d953d07

TBR=dcheng@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/902793006

Cr-Commit-Position: refs/heads/master@{#314894}