GitLab

The gRPC directory API use chromoting.directory instead of chromoting,
and FTL signaling requires an additional scope.

Change-Id: Ifbe3fe32fc30bbd94b71cac46810ebbfd77160cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603769
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658338}

This patch redacts recipient, organization, phone and address line from
the shipping address before returning it for onshippingaddresschange.
The goal is to minimize the personal information returned to merchant
website before user fully commits to the payment transaction.

Spec: https://w3c.github.io/payment-request/#shipping-address-changed-algorithm
Intent to ship and implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/69dw-4Myc_A
Chrome Status entry: https://chromestatus.com/features/5653566570102784

This patch lands the feature behind the #enable-web-payments-experimental-features
flag so developers can start testing in M76, with the intention to ship in M77.

Bug: 821771
Change-Id: I2cda43615844b1533310dfe54903cbefeafc7980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600720
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658337}

Offline Page's init on Android is making this flaky. This changes the
test to pass a null browser context so that doesn't happen.

Bug: 960773
Change-Id: Ife6b78321bd72ada6c4ed7b9c70e12472fb2e5f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603842Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658336}

This reverts commit d80f755b.

Reason for revert: Waterfall linux-chromeos-rel build failed:

https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/24116

Failing tests:

EnrollmentLocalPolicyServerBase.ManualEnrollment
EnrollmentLocalPolicyServerBase.ManualEnrollmentWithDeviceAttributes
EnrollmentLocalPolicyServerBase.ManualEnrollmentWithMultipleLicenses

Original change's description:
> DeviceStateMixin: Update local state and support for setting policy
> 
> Taking over rsorokin's patch at CL:1578742, given that he is OOO.
> 
> DeviceStateMixin now initialized device state values in local
> state during setup.
> 
> Add support for setting device policy and device local account policies
> in in-memory fake session manager client, in a way similar to
> UserPolicyMixin. Later this functionality can be moved to a separate
> mixin, which might make sense if/when we add functionality for setting
> up policy served by local test policy server to this mixin (this should
> already be possible using LocalPolicyTestServerMixin).
> 
> Uses AutoLaunchedKioskTest as an example of new usage.
> 
> Also fixes a number of tests to wirk with the new device state setup.
> 
> Bug: 952855
> Change-Id: I1c0314a51581137d0f5a0907a09a4ef5b0bccda3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600857
> Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Commit-Queue: Toni Baržić <tbarzic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#658297}

TBR=tbarzic@chromium.org,antrim@chromium.org,alemate@chromium.org

Change-Id: I73316a1dab02d817c16209a46c5a662682901269
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 952855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604383Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658335}

DDoc: go/cups-plugin

Adds flag to condition above printing pipeline on. Will be used to
condition the CupsProxyService startup.

Bug: chromium:495409
Test: build unit_tests & run CheckHistograms + EveryFlagHasMetadata
Change-Id: Id4b75ceca33a9930992e1732537621cbc154a64b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601835Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658334}

Bug: 958230
Change-Id: I544e7557cfaa0f93d23df2a40a3136a6c3232d53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597973
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658333}

BUG=914844,941495

Change-Id: I8ab2eb17b308440dd4d29c231526e03d1d66fd56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601685Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658332}

Pass crash key-value pairs info from native while writing crash reports
as MIME minidumps to CrashFileManager in order to be used later by
WebView to show them in WebView Crash UI.

R=tobiasjs@chromium.org

Bug: 958340
Change-Id: Ib594c0429b3721bb8ee1d5a806fcab094d108842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591635
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658331}

Bug: 823744
Change-Id: I5a18e0650366001efd78055b529c36489e87ebfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600340
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658330}

These test a dialog which shows info about an app, including the size
of the app. When run in a test the app doesn't exist. The size
calculation still runs, however, and ends up calculaing the size of
the working directory, which can be really slow.

This change skips calculating the size if the app doesn't have a path.

Bug: 953964
Change-Id: Ie7ec878bfd26f2ac9c53bde3fa1c7c0327f0198c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594384
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658329}

Change-Id: I9576f5f8191a42d518b984966cb745bc4b97d6f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600861
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658328}

Bug: 959978
Change-Id: Icb31f4706eb527f03e697a5cd285422413a592c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603485Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658327}

This CL implements the permission prompt for Bluetooth scanning API
on desktop:

1. Implements a permission prompt suggested on the design doc. The
message at the top of the prompt calls out that the user is being asked
the permission for a site to receive nearby Bluetooth advertisement
packets. The prompt lists device name for found nearby Bluetooth devices.

2. Adds a ShowBluetoothScanningPrompt method to the WebContentsDelegate
interface which launches a permission prompt displaying the nearby
Bluetooth devices.

I uploaded some screenshots of the permission prompt in the issue link.

Design doc:
https://docs.google.com/document/d/18Rqg1HRGeDngPv60DAGoMnIwRB-Zjh5gOWmANmH8lTo/edit

Bug: 953075
Change-Id: I2924e177f927cf3411fe00f4df180e206341d731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589267
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658326}

Register local_state for CloudPolicyEnabled policy.
Reigster local_state for lastUploadTimestamp

Bug: 956237
Change-Id: I567607568e66cb2f1b9d7dfc87d134a3a0e90260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590645
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658325}

This is all dead code.

BUG=960503
TEST=covered by tests

Change-Id: I2fe889b5f75bf73e63ceadc8f01a89d9d284ee50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603883Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658324}

Currently the dialog is blocking the other overview mode windows. Hide
it for now to fix the issue.

Bug: b/131186127, 942714
Test: Manual Test
Change-Id: I470b4f334cc5126f8a32a3880e7d54533a47a81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603770Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658323}

Instead of using the AudioManager worker thread, which has normal thread
priority; use a realtime thread for audio loopback. This is needed
because the GenerateMoreAudio() tasks were executing way too late during
low-available-CPU situations, and this was causing audio underruns and
lots of cut-outs/glitching for the end user.

Bug: 960161
Change-Id: I4350aab93a1678c57a8e8769dc7852a2d181be39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602114Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658322}

This is a small cleanup of the following issues in the paint docs:
*) A table of contents has been added
*) The core and platform READMEs have been linked
*) Diagrams and lists have been formatted so the markdown creates a
diagram and list. This usually requires a newline before the diagram or
list.
*) The PaintInvalidation document lifecycle phase has been removed.
*) A small summary has been added at the top of the core paint file.
*) Broken links have been fixed (e.g., swapping [] and ()).

Change-Id: Ie7263cc8d55bc4815a068da466873dfa861fec61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603963Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658321}

Internal script will generate the proto structure based on
whitelisted fields.

BUG=925148

Change-Id: I24d136031fd0bb5441272d6e90efff90181decc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600718Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658320}

Bug: 960659
Change-Id: I74730095e546d020c42ca499568e15151b5e4f16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603052Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658319}

Bug: 823744
Change-Id: I353e25fc7f215afc8b835a873b31eb87aeb87703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603765Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658318}

Change-Id: I14139ced0ed1fb23650d976784b723cf48e973ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603488
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658317}

Bug: 960779
Change-Id: I21dedf74f9930732cb130ece2bfeee737aba6dc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603062
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658316}

And instead has ash directly access the startup time.

BUG=958213
TEST=covered by tests
TBR=tsepez@chromium.org

Change-Id: I146c27edef79ff8fb69ca7cdd7f230ad77f040a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602854Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658315}

When sample is served from a bucket, the URL of the xrray polyfill
is incorrect.

TBR=bajones@chromium.org

Change-Id: I923aad855e2c8cf0353773441f4d20da4076dcab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603474Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658314}

- Call LocalFrameView::SetGraphicsLayersChanged() when graphics layer
  hierarchy changes or any graphics layer changes property tree state
  or offset. The function also sets PaintArtifactCompositorNeedsUpdate.

- Use a long-live paint controller in LocalFrameView to collect
  foreign layers of graphics layers. If graphics layers didn't change,
  just use the previous collected foreign layers.

Change-Id: I0c95b19098807cf0c640d9d26c62e68eb33acec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600302Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658313}

This mechanically replaces kXXX_SkTextEncoding with SkTextEncoding::kXXX
and kXXX_SkFontHinting with SkFontHinting::kXXX. This will allow Skia to
remove these old macro constants and get everyone on the new enums.

Change-Id: Id3e4b953ede7fb0c16d2b6fcef83f48b762998ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602600Reviewed-by: Herb Derby <herb@google.com>
Cr-Commit-Position: refs/heads/master@{#658312}

Update CreateAllBlobs() to get the current SequencedTaskRunner
from the handle, instead.

Bug: 717812
Change-Id: I5c3a883dc587883f0a0630fa93325debb3c38365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534305
Commit-Queue: Chase Phillips <cmp@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658311}

This flag (and the backing switch) are now not used.

Bug: None
Change-Id: I1858102174bcf792eaf4e85fbce16d81d34ce497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602735
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658310}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8a2a5a8d2777..2e48312247a8


git log 8a2a5a8d2777..2e48312247a8 --date=short --no-merges --format='%ad %ae %s'
2019-05-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@2e48312247a8

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I6cf864a4a66770f5877b0778e857ac0586f274e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603602Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#658309}

This CL adds retry logic for PWA installation. Installation result
code histogram will only be recorded when all the retry attempts fail
or when installation succeeds.


Bug: 960144
Change-Id: I9915f834c77b50298753bc02e098d91d5132d8d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597952
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658308}

Bug: 961179
Change-Id: I040f5c36d30fcfaa80e59df3f048028052386f79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602446Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658307}

Bug: 952652
Change-Id: Ibab893bcd8e139fae5417fdedeb66b76a7015a07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603262Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658306}

This adds CastMediaBlocker as a built-in capability for CastWebContents.
CastWebView::CreateParams is restructured to allow passing in
CastWebContents::InitParams directly, rather than with duplicate fields.

Merge-With: eureka-internal/269059

Bug: internal b/77879457
Test: CQ

Change-Id: I2ebd547e7c9ecb7f1f417616d18fb28629b29157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600160
Commit-Queue: Sean Topping <seantopping@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658305}

Remove separate Snoopable modes "deferred" versus "realtime" and just
give all Snoopers access to the audio data in realtime, without any
copying or thread-hopping. This is to mitigate audio glitches when
using loopback on low-end machines that are CPU-limited, where normal
priority threads do not run their tasks often enough.

Moved the special "SanitizeAudioBus()" function closer to where it is
being used, with a simple "modify only if needed" mechanism. This
function was clamping the audio samples; but, by being in
audio::OutputController, this would mutate the audio data being
delivered to both the operating system as well as other Snoopers.

Bug: 960161
Change-Id: If91952462960f7c72562436ffeebb64498b5372f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602312
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Auto-Submit: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658304}

The buffer passed to CmaBackend::PushBuffer may be stored in the backend
decoder for some time before actual playout.  It should not be modified
since it could corrupt audio that is yet to play out.

Bug: b/124402185, b/126295803
Test: Tested multizone on Android
Change-Id: Ie31d3b8f9d831597e00f2f5b72b3e2694b38406b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603762
Commit-Queue: Alex Leung <alexleung@google.com>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658303}

Extend the expiry of Extensions.Messaging.IncludeChannelIdBehavior to
December 2019. It will be useful to audit whether we can remove support
for the includeTlsChannelId property in runtime.sendMessage since
channel ID is no longer supported.

Bug: 902099
Change-Id: Ieb129cef4960da1c0cb257e3d1ac03bb906d1c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601690Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658302}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/136b57f5f7ce..cb68382c9842


Created with:
  gclient setdep -r src-internal@cb68382c9842

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=dvadym@google.com,noel@google.com,jbroman@google.com,xialinyan@google.com

Change-Id: I433bf8f494f199a5a318b79f35a3acce5c9fd40d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603328Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#658301}

Bug: 961449
Change-Id: Ia45b11b8976f4fa7fb98bb4cd7451d2737027365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603525Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658300}

This is a reland of 133ed70b

TabStripModelObserver was updated in a separate patch to remove the union which
caused the original reversion.

Original change's description:
> [Tab Groups] Stop using TabGroupData pointers as group IDs.
>
> Tab groups are currently identified using TabGroupData pointers. However,
> this is fragile because those pointers may not be valid forever and
> because memory address may be reused. It makes more sense to use an
> opaque int ID for this purpose instead. This also allows the API to
> explicitly define when a group may be null or not, by using
> base::Optional. Also, in a future patch, tab_strip_layout.h/cc will be
> able to operate using that ID and continue to avoid knowledge of any
> particular View type.
>
> This patch also includes some miscellaneous refactoring in
> tab_strip_model_unittest.cc.
>
> Bug: 905491
> Change-Id: I9700a50d5fa9e4050ec2169af8e1362d11d9dade
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562764
> Commit-Queue: Bret Sepulveda <bsep@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652391}

Bug: 905491
Change-Id: Ic1d02267c81c03b2da12ed502d4f4d736c1cad9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577922
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658299}