- 03 Apr, 2020 36 commits
-
-
Wei Li authored
These image colors are either used as placeholder background colors or error colors. We can safely replace them with kPlaceholderColor. BUG=1059867 Change-Id: Ie4485eb333dae5d52a238eeeb8e9cf6c6391553c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134625Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#756110}
-
James Cook authored
Add a row for "Settings sync" per go/cros-sync-mock. Implement this by forking the existing HTML because I anticipate other tweaks to the structure, layout, etc. Screenshot: https://screenshot.googleplex.com/jBQkUEZoT1O Note that there are now 3 versions of this dialog: * Current * SplitSettingsSync v1 * SplitSyncConsent (aka SplitSettingsSync v2) Bug: 1067212 Change-Id: I64861026cf66d59800511dc559669743410707a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134198 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756109}
-
Xianzhu Wang authored
When PaintLayerScrollableArea::NeedsScrollbarReconstruction() is true (in case that scrollbar theme is changed by DevTools device emulator, etc.) in UpdateAfterLayout(), we should ensure scrollbar reconstruction regardless of DelayScrollOffsetClampScope (which prevents scrollbar destruction in SetHas*Scrollbar(false)). Call scrollbar_manager_.DestroyDetachedScrollbars() to execute the delayed scrollbar destruction immediately. Bug: 1062597 Change-Id: Ia0524c3e836a03fdb707dee3004850772f4faa6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134945Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756108}
-
Livvie Lin authored
Use the same OWNERS as ios/chrome/browser/ui/util, since that's where the code in this directory came from. Change-Id: I817e7d77df70efcc2ae9e2cc92b05a091736a2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133163Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756107}
-
David Grogan authored
These tests used script-after-body but also an external stylesheet. script-after-body can be run before the stylesheet has loaded. The script-after-body stuff is now in an onload handler. Bug: 1063749 Change-Id: Id725c51ef2375ba9584cfacfa81e328b2b586ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133271Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756106}
-
Noel Gordon authored
If the pointer is down anywhere in the app, hovering over the tree Tab items shows their :hover and cursor effects even though these Tabs are not interactive: disable these effects so the Tabs look inert. So what about Pressed state for a Tab? No spec for this: reuse the Tab Hover state color for Pressed state for now (--google-grey-100). No-try: true Bug: 992819, 1062902 Change-Id: I571b252dbe4ddc3050284af505ae3432ad5521d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134088Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#756105}
-
Chong Gu authored
Bug: 1067357 Change-Id: I398ce1632636fb3f81e64c1e3c28fa997f5c5528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134582 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756104}
-
Yuly Novikov authored
These would be used for Chromium on top of SwANGLE testing, like WebGL. Linux64, Mac64, Win32 Not running any tests at this point, to be added in a follow up CL. Also renames the GCE pools used for non-Chromium SwANGLE trybots. Bug: 1064477 Change-Id: I11172672a1b41bc567c84778554ecd3eaf353190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135132Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756103}
-
danakj authored
Rename the target to web_test_common_mojom target and make it a public dependency of web_test_common, in order to treat them as one big build target. The power_monitor_test mojom is for browsertests so separate it into content_browsertests_mojom, and depend on it from content shell (which makes the impl) and from content_browsertests (which calls it). TBR=thakis Bug: 866140 Change-Id: Ibb40798e1afa94a3f8e983f921f9a5ce64d5882b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134622Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756102}
-
Jeff Yoon authored
- try bot and builder migrated to Chromium via *.star files. ios-simulator-full-config trybot in trunk - mb_config ios_simulator_debug_static_bot for try and builder - tests all set to test_suites.pyl Bug: 1055164,912681 Change-Id: I1e5f9b3a0fbccb2c88f2fad26f1559ab3cc418f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119612 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#756101}
-
Peter Kasting authored
Move calls to the files that best match the directories the factories live in. In most cases this has little practical effect; see per-file comments for the exceptions. Bug: none Change-Id: If634e455c68f80361536243382ea9362d84181a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134926 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Kelvin Jiang authored
This CL adds functions for UrlPatternIndex which return all matching UrlRules. These functions will be used to evaluate modifyHeaders rules for the declarativeNetRequest API. Bug: 1064497 Change-Id: Iab0260892a2d7ad4ab5180b84320dfa2675cbf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116563 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756099}
-
Xiaocheng Hu authored
This reverts commit 0e19fa7c. Reason for revert: should go through the normal review process Original change's description: > Reland "Record split UMA histograms when rendering has been delayed for font preloading" > > This reverts commit 950810de. > > Reason for revert: Loading behavior fixed > > Original change's description: > > Revert "Record split UMA histograms when rendering has been delayed for font preloading" > > > > This reverts commit 4a7fe529. > > > > Reason for revert: The loading behavior is designed wrong. > > > > The objective of these split histograms is to study, when there's font preloading, how effective delaying rendering is. > > > > Currently: the behavior is observed when rendering is delayed by font preloading. > > > > What's actually needed: the behavior is observed when font preloading occurs > > > > Original change's description: > > > Record split UMA histograms when rendering has been delayed for font preloading > > > > > > This patch adds split histograms of the following metrics when > > > rendering delay for web font preloading has been triggered: > > > - PaintTiming.NavigationToFirstPaint > > > - PaintTiming.NavigationToFirstContentfulPaint > > > - PaintTiming.NavigationToLargestContentfulPaint > > > - LayoutInstability.CumulativeShiftScore > > > > > > This will help us understand the effectiveness of this optimization, and > > > adjust the length of the delay to the best value. > > > > > > Bug: 1040632 > > > Change-Id: I6f8aa151c576c9d8d583647a3a7ef6fcb8fb833d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109251 > > > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > > > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#754771} > > > > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org > > > > Change-Id: I7829822fea47183df9d4ed27c0eec2a1f888aa0b > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1040632 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131010 > > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755081} > > TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org > > Change-Id: Ibae7230089fe9e56e91cf1480d19c7bc70778567 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1040632 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131011 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755108} TBR=chrishtr@chromium.org,ksakamoto@chromium.org,skobes@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1040632 Change-Id: I80ae98e1f0ec97a11f35bb2c55ad9d591f1b07b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135047 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#756098}
-
Peter Kasting authored
* Put calls to other "ensure factories built" metafunctions before calls to build specific factories. * Name all the metafunctions EnsureBrowserContextKeyedServiceFactoriesBuilt(). * Alphabetize. * Remove unnecessary blank lines. * Remove no-longer-applicable comments. Bug: none Change-Id: Ibc17ccc32d16b0cd8692cbea719ded3c9de9d662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134621 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Scott Violet authored
IsOfficialBuild() appears unused. BUG=none TEST=none Change-Id: I4a2552d143015bb22f112bcbde2faa9e2d243280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132666 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#756096}
-
Karandeep Bhatia authored
This CL: - Allows extensions to specify no static Rulesets as part of the "rule_resources" manifest key or optionally to omit the "declarative_net_request" manifest key. Since we support dynamic rules, we should allow this. Also, we plan to implement the ability to toggle the set of enabled static rulesets, under which a state with no enabled static rulesets should be allowed. - Since we now allow extensions to not specify any static rulesets, don't fail if an extension calls updateDynamicRules or getDynamicRules if the extension doesn't have any registered rulesets. - Also, move the book-keeping for the set of extensions with active rulesets to RulesetManager from RulesMonitorService. RulesetManager already maintains the set of active rulesets, so it should be the source of truth for this info. BUG=754526, 953894, 931967 Change-Id: I3d9c6eae5f4d0691b8272ffa4e81c6791f273c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125691Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756095}
-
John Budorick authored
Bug: 965140 Change-Id: Icdac9b49d15dc489aec21e0f2a99f4184621245f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627560 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#756094}
-
Sophie Chang authored
This also re-enables the browser tests since the flakes were mostly tied to the UMA histogram reporting. Bug: 1060966,1060397 Change-Id: I67a1dfafa5d220e3a2165981e4bd4a6812174aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134645 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#756093}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some os and browser routes had the same name. This was a bit confusing. If some c++ code called the route '/languages', it is not clear if this url is a chrome or browser subpage. A distinction needed to be made. This CL renames OS specific route LANGUAGES, which is shared with browser routes to a more distinguishable name OS_LANGUAGES. Allowing this bug(990169) to be unblocked. Bug: 990169 Change-Id: Ic2d6dc3120d505ef2a864023c6d89a57301acdd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123311 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756092}
-
Xiaohan Wang authored
In general, after playback starts, we do NOT support removing or resetting the CDM if one is already set. There's no use case for this at least for now and foreseeable future, and this change would help simplify some logic. Bug: 1066893 Change-Id: I53ad2445fab79d78b34e76d252c9c069c3e8950d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133173Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756091}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, home button would be hidden when Start surface is on, except for the single-pane variation. Bug: 1055561 Change-Id: I8dd7862dffcb42fab77eaf1829ce441d30a5ea34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112330 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#756090}
-
Daniel Rubery authored
We want to fail open, but we don't want to tell the user "Scan complete" if the scan didn't actually complete. Change-Id: I174a9cec446ade9282438d1b1dd240cbbe3153be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132782 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#756089}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I3d893bdb737ec96f5f0cd3f998eb147388b0753d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132351Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756088}
-
Lily Chen authored
This reverts commit 2507555f. Reason for revert: Expected full rollout delayed Original change's description: > Enable SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure > > TBR=jschuh@chromium.org > > Bug: 953306 > Change-Id: I5bde61d8ff66261ade4e68caadafda73c522df00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122809 > Reviewed-by: Lily Chen <chlily@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753807} TBR=jschuh@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 953306 Change-Id: Ic7da4e9938184e2833895ff263325c01948be6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135046Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#756087}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Icf74f98bc7d2472c1475b38558aec93bd13640e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132079Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Id7281021934fb65c18236ab7d2c28ccefe7342d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132350Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I36d9b145b303908274be19d9f8374dc181e9af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132021Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iac720bf6eed6f24e55fc017ce97eb7e2e4e52f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132078Reviewed-by:
-
Majid Valipour authored
Implement basic element-based IDL and processing. - Change existing start and end offset to accept a dictionary at the moment it only has target and threshold but no edge or rootMargin. - Add ScrollTimelineOffset that can handle both the existing string or the new dictionary based offset. - Update ScrollTimeline to use new the offset class. - Implement basic validation logic for new element-based offset. - Add test verify correct parsing and validation on construction. This is the first patch in a series. Follow up patch [1] would use this new offset input to produce the resolved offset. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2100887 Test: wpt/scroll-animations/constructor.html Bug: 1023375 Change-Id: Ie14fb2127d089a39379c498b4b15c86e6b2dd272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070673 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Auto-Submit: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#756082}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I5e86464399de6553de95300992a7582ecf63eaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132076Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4400d32f044c..f954babacc6c git log 4400d32f044c..f954babacc6c --date=short --first-parent --format='%ad %ae %s' 2020-04-02 btolsch@chromium.org Fix bot name in try bucket Created with: gclient setdep -r src/third_party/openscreen/src@f954babacc6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I280e61d4cf9104f8b8fd41afa34612f362695acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756080}
-
K. Moon authored
tools/autotest.py currently uses `"win" in sys.platform` to detect if the current platform is Windows. macOS uses "darwin" as the platform, so this check erroneously detects macOS as Windows. According to the documentation for sys.platform, the platform value should be matched against sys.platform as a prefix: https://docs.python.org/3/library/sys.html#sys.platform This change tightens the check to only detect platforms starting with "win32" as Windows. R=mthiesse Change-Id: Ic46cbc3b28c250d6557a58f583d5a9ba03df5b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134964 Auto-Submit: K Moon <kmoon@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#756079}
-
Xiaoqian Dai authored
Bug: 1061144 Change-Id: I1977fceb66746a6d56913b3cbb2b7c0551760681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135012Reviewed-by:
-
Jimmy Gong authored
- Hooks up the Mojo handler interface to the Print Management app. - Generates js-lite bindings from printing_manager.mojom. Bug: 1053704 Change-Id: If5df4fe8313e510de0548a72b50277bda585535a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117163Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#756077}
-
John Budorick authored
Bug: 1011494 Change-Id: I8618af474f354fd6b4e50d43d3d1a3e995f2ef4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135148Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#756076}
-
Jinsuk Kim authored
ChromeTabUtils.fullyLoadUrlInNewTab sometimes takes long to finish on Tablet. Replaced it with ActivityTestRule.loadUrl. What they do is different but doesn't matter for the goal of the tests as long as they load a given URL. Swiping left and immediately swiping right on rendered pages sometimes fails. This CL gives a bit of delay before the second swiping starts for the gesture navigation to be ready. The tests for left swipe were removed, since those testing right swipe also include left swipe. Tested locally on Nexus 7. Bug: 1041233, 1051221 Change-Id: I4bf866f2521c02b3c4500d47776ba80fdea91ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125914 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756075}
-
- 02 Apr, 2020 4 commits
-
-
Johann authored
Use the HeapMojoReceiver wrapper so that Oilpan will GC the object. Bug: 1049056 Change-Id: I591340da66ae1e581d87e644ed143d90ef092e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117140Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#756074}
-
Anders Hartvoll Ruud authored
Change-Id: Id8b9b3ede1a3589ee8ce19afa0ca84db303a7c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132196Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#756073}
-
Gyuyoung Kim authored
This CL moves radiobutton-min-size.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Bug: 1063749 Change-Id: Id38ac0e7fab2bae3e60de87b9dfbab9817985545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132658Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756072}
-
James Cook authored
This logic was duplicated in 3 places, so consolidate in a new helper function. Bug: 1059085 Test: browser_tests, unit_tests Change-Id: I5101d19f195f7ee9c1157330fa634a5f14b47cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132332 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
-
