GitLab

This renames payment_method_change_response.idl to the more generic
payment_request_details_update.idl name.
payment_request_details_update.idl is the redacted version of updated
payment details received from the merchant in case of payment method,
shipping address, or shipping option changes. This redacted version
is sent to the payment handlers to notify them about the changes in
payment request details.

The rename is needed since this is used for changes in shipping address/
option in addition to payment method.

I will remove the stub mojo struct once the clank cl is landed:
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2029744

TBR=mkwst@chromium.org

Bug: 984694
Change-Id: I927f1fca7a58bcb640407544db4fc091f2ad7e4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865469Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709647}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/86244d691364..4861444124e0

git log 86244d691364..4861444124e0 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 yura.yaroshevich@gmail.com Specify open file encoding explicitly.

Created with:
  gclient setdep -r src/third_party/depot_tools@4861444124e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:None
Change-Id: I33b4d04f51d6b35a4fb4d09a065aea4977547ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709646}

For some reason, separator logic didn't always fill the separator when
the resolution was not a multiple of 50%. It now fills the background.

Spearators will still be 1 DIP rather than 1px.

Bug: 1016760
Change-Id: I5cc8e9907c23d2db6ee519aa4298c2c99660cfb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880531Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709645}

Bug: 1018197
Change-Id: Id660174b4f96cb2c6103e04efeaf45ff1abf91bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880542Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#709644}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I4c954381ede93de6fd081c8295ba134130cbac58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881111Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709643}

These failures were primarily due to some missing logic within the
NGBoxFragmentPainter for CAP.

See:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8899518345262305936/+/steps/webkit_unit_tests__with_patch_/0/logs/Deterministic_failure:_All__x2f_BoxPainterScrollHitTestTest.ScrollHitTestOrderWithLocalBackgroundAttachment__x2f_1__status_FAILURE_/0
... as an example of the failure.

The additional CAP failure, also fails in the same way with:
--blink-enable-features=CompositeAfterPaint --disable-blink-features=LayoutNG

The code was effectively just lifted from BlockPainter.

Bug: 988015
Change-Id: I8cf273e552b2e84246eef69910c8abace9a485b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869676Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709642}

Bug: 1018373
Change-Id: I9261f794749e250bd08265cf32596d6a2a766e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879204
Commit-Queue: Katharine Daly <dalyk@google.com>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709641}

This cl adds a new diff of class symbols in dex to the current diff of
method symbols.

Bug: 1012371
Change-Id: Ief062e055ad2eb96d22a4534fa4cfdfd8cbf8b3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869835
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709640}

4 password sites were failing on windows because the screen
resolution was too small and thus the dynamic html was not
consistent from recording (or linux replay).

Update password captured sites cipd version to get thew new
version of these sites.


diff -r q_mI3rtAXvNUW_X3zxca3VcUVdHkgwRqhfTLHt9H7rIC/capture_update_pass/nexon.test MuT6UWjyB52nWFDuu4RCv4o_vMPIZdI4P2m2YsC66fAC/capture_update_pass/nexon.test
44,61d43
<       "selector": "//span[@data-v-5af1f5e3 and text()=\"My Account\"]",
<       "visibility": 7,
<       "context": {
<         "isIframe": false
<       },
<       "type": "click",
<       "action_index": 5
<     },
<     {
<       "selector": "//nav/div[@data-v-5af1f5e3][1]/div[@data-v-5af1f5e3][2]/ul[@data-v-5af1f5e3]/li[@data-v-5af1f5e3][1]/a[@data-v-5af1f5e3 and @id=\"accountSetting\" and text()=\"Account Settings\"]",
<       "visibility": 7,
<       "context": {
<         "isIframe": false
<       },
<       "type": "click",
<       "action_index": 6
<     },
<     {
66a49
>       "force": true,
diff -r q_mI3rtAXvNUW_X3zxca3VcUVdHkgwRqhfTLHt9H7rIC/capture_update_pass/paypal.test MuT6UWjyB52nWFDuu4RCv4o_vMPIZdI4P2m2YsC66fAC/capture_update_pass/paypal.test
17,18c17
<
<       "selector": "//a[@href=\"/myaccount/settings/password/edit/\"]/span[text()=\"Update\"]",
---
>       "selector": "//div[@id=\"securityTab\"]/div/ul/li[1]/div[1]",
diff -r q_mI3rtAXvNUW_X3zxca3VcUVdHkgwRqhfTLHt9H7rIC/sign_up_pass/battle_net.test MuT6UWjyB52nWFDuu4RCv4o_vMPIZdI4P2m2YsC66fAC/sign_up_pass/battle_net.test
36,37c36,37
<       "selector": "//div[@data-value=\"3\"]",
<       "visibility": 7,
---
>       "selector": "//div[@data-value=\"12\"]",
>       "visibility": 3,
43a44
>     { "type":  "PressEscape" },
diff -r q_mI3rtAXvNUW_X3zxca3VcUVdHkgwRqhfTLHt9H7rIC/sign_up_pass/indeed.test MuT6UWjyB52nWFDuu4RCv4o_vMPIZdI4P2m2YsC66fAC/sign_up_pass/indeed.test
42c42
<       "visibility": 7,
---
>       "visibility": 3,


Bug: 984662
Change-Id: Ib82de8b9ca886bdedbcc0f217c5d3e576013f049
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880016
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#709639}

Eexecuting tests with vpython on Windows fails like

E:\chromium\src\out\debug_x64>git cl upload
Running presubmit upload checks ...
 checking owners took a long time: 505ms** Presubmit ERRORS **ImportError raised: No module named win32pipe
Traceback (most recent call last):
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 196, in main
   exit_status = run_checks(host, options)
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 154, in run_checks
   failures.extend(lint(host, options))
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\lint_test_expectations.py, line 44, in lint
   ports_to_lint = [host.port_factory.get(name) for name in host.port_factory.all_port_names(options.platform)]
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\factory.py, line 84, in get
   module = __import__(module_name, globals(), locals(), [], -1)
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\android.py, line 46, in <module>
   from blinkpy.web_tests.port import base
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\base.py, line 55, in <module>
   from blinkpy.web_tests.port import server_process
 File E:\chromium\src\third_party\blink\tools\blinkpy\web_tests\port\server_process.py, line 45, in <module>
   import win32pipe
ImportError: No module named win32pipe

Add pywin32 wheel to fix it.

Bug: 1017410
Change-Id: Ic64fb6631fa113dfd5cce30a636daaa3be978d52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876985Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709638}

These tests used to check if the ephemeral tab feature is enabled to
add the context menu item to the expected items list. This CL updates
them to use EphemeralTabPanel#isSupported() as #isSupported also checks
if the device is low-end.

Bug: 1018172
Change-Id: I7b05e7f736f3fbbfdfb4cd1d9df935497c1b4cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880958Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#709637}

For the SVGBoolean, SVGEnumeration, SVGPreserveAspectRatio and SVGString
we can just select either the 'from' or 'to' value and use that as the
animated value. Rather than implementing this in each of the subclasses,
do this selection in SVGAnimateElement::CalculateAnimatedValue.

Bug: 1017723, 231517
Change-Id: I4a374c0c015ce1716c08c6c5d18b011b34681364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881148
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709636}

This is a reland of https://crrev.com/c/chromium/src/+/1813780,
without switching to STATIC_HISTOGRAM_POINTER_GROUP, in order to
assess whether that caused the regressions in https://crbug.com/1006940
Diff: https://crrev.com/c/chromium/src/+/1872425/1..3

Since the blocking and non-blocking have been merged, there is no
need to report data for blocking tasks in separate histograms.

This CL also makes passing an |histogram_label| to the constructor
of ThreadPoolImpl optional. If no |histogram_label| is provided, no
histograms are recorded. This CL takes advantage of that to not record
histograms from TaskEnvironment.

TBR=altimin@chromium.org

Bug: 1006940, 1002318, 995496, 982145, 980409, 972890, 972888, 972883
Change-Id: I0ac49273e2a25b217c1c93216737ae985f6d053d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872425Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709635}

On bot, often we can only catch black screen for dialog. I found a similar
bug crbug.com/687387 related to gpu. To repro the same result locally,
pass in --disable-gpu when running test locally.
To fix the flakiness, we don't catch the screen from HDC. Instead, we
catch from Layer::RequestCopyOfOutput.
This change also refactor some code to reuse some existing lib.

browser_tests.exe
  --build-revision=fd1bb443
  --test-launcher-filter-file=testing/buildbot/filters/pixel_browser_tests.filter
  --browser-ui-tests-verify-pixels
  --enable-pixel-output-in-tests
  --disable-gpu
  --no-luci-auth
can pass.

TEST: tested multiple times the tests won't catch black screen anymore.
Bug: 958242
Change-Id: Ie7df0e304fb74eb1d2b6c013612529dcdf549605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879506
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709634}

Since there are just basically "pair" types, we can call the underlying
type Add/CalculateAnimatedValue for each component.

Bug: 1017723
Change-Id: I8b14246b5a760cec18f9758b360e7c5c4df7b7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879897
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709633}

Update a few styles to fix the scrollbar issue on the value prop and
voice match screens.

Bug: b/143266371
Test: Manual Test
Change-Id: I147b81315b2d79cb879754b834d0f707256e5ea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880668Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709632}

Bug: 1017396
Change-Id: Ifad68f5fbd17b62aee6a34778bbe969638383eef
Binary-Size: Expected size increase because of AppBarLayout.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879770
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709631}

https://chromium.googlesource.com/angle/angle.git/+log/02c89327172a..04ee27effffb

git log 02c89327172a..04ee27effffb --date=short --no-merges --format='%ad %ae %s'
2019-10-25 jmadill@chromium.org Capture/Replay: Add ANGLE_get_image extension.
2019-10-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 883e817b14bf..f44f7c066a67 (4 commits)

Created with:
  gclient setdep -r src/third_party/angle@04ee27effffb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@google.com

Bug: None
Change-Id: I6e82f98197c3c9acdf2a6a4e5fcc59d53e60b10e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881672Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709630}

Create a separate a11y-only aria-description text that reads relevant
info without needing to use the rendered DOM.

Also denote which element is selected via aria-selected.

Bug: 1017915,1017877
Change-Id: Ic4fc56eecf5f9d5b6fcdac319d5fb4ba78835262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880273
Auto-Submit: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709629}

https://webrtc.googlesource.com/src.git/+log/67ac9e8ecb89..91e3ebe46843

git log 67ac9e8ecb89..91e3ebe46843 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true.""
2019-10-25 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."
2019-10-25 yura.yaroshevich@gmail.com Added usrsctp reliablitiy stress test.

Created with:
  gclient setdep -r src/third_party/webrtc@91e3ebe46843

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I530e7c1d0ac851fd8b8fbf9cae8c7f7241e9e12e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881668Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709628}

This is responsible for updating the local network stack to match
incoming WifiConfigurationSpecifics protos from the sync backend.

Bug: 966270
Change-Id: Ib4bdf1c22604b2528bc2abad5bc2ac1672e58290
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768877
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709627}

SampleProbeData dereferences a battery pointer without
checking whether it is null first.

crrev.com/c/1881538 and check
/var/log/chrome/chrome for VpdSkuNumber

Bug: b:128683357
Test: cherry-pick crrev.com/c/1779132 and
Change-Id: Ifdffb28957405b0d4536b5b7fc76710e75aba2ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880582Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709626}

Change-Id: Ia91901ea5380399a3fe92aec38b68b8454908560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879863Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709625}

Bug: 995880
Change-Id: I02239e098b4e8928c2ae1eba872eb83f75a0b40f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876868
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709624}

site_details_message_ is only used in Android, so rename it and ifdef
to Android only.

Change-Id: I94563bc1c4ea8df1ffab903ac193944fa4a199a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737045
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709623}

This is needed to allow the Finch experiment CL enabling the
feature in Beta to be submitted.

Bug: 943901
Change-Id: I77b1bf1c46b501d263748fb83a176e4ab7a7ea2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880179Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709622}

The main objective is to remove all files reachable from chromevox/injected but not reachable from cvox2/. This resulted in a lot of files being pruned away including some old assets. There was some manual modifications like getting rid of ChromeVoxJSON, host/chrome/ files specific to content scripts, old keymaps, and more.

The testing/ files were also modified accordingly and chromevoxclassic was given its own testing/ fork.

Change-Id: I6f4130f901dcacb2601887d4bcd34d73ff732d56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880174
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709621}

BUG=1016429

Change-Id: I9fb433e70c398c00c505c8b00324be23a1f44032
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878767Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709620}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad3655cf0bd3..66ce5c605a58

git log ad3655cf0bd3..66ce5c605a58 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 dburger@chromium.org Shutdown afdo-chrome-pupr-generator build API endpoint.
2019-10-25 tcwang@google.com afdo: Add builders to verify Chrome profiles, and changes schedules.

Created with:
  gclient setdep -r src/third_party/chromite@66ce5c605a58

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Iccde8df750be95541fdc34f7e07d4117081ab47d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881385Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709619}

Do not allow the drag if the drag position starts above the shelf.

Bug: 997885
Change-Id: Ifd5619cd28d96de889c28cd2c51fe67586224783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880079Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709618}

Future OpenXR runtimes are more stringent on validating correct usage
of APIs. The structure type of XrView objects passed into xrLocateViews
are not currently set. The current version of the WMR OpenXR runtime
from the Windows store does not do this validation, but future versions
will.


Bug: 1015223
Change-Id: Ib4e3fca557cc6e192bd166e2ebb604a3884e7811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865042Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Patrick To <patrto@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#709617}

On some bots the partner bookmarks folder is unexpectedly showing up,
causing flakiness due to an unexpected number of items in the bookmarks
manager. Force an empty partner bookmarks folder.

Also add a speculative fix for
BookmarkReorderTest.testShowInFolder_OpenOtherFolder that waits for a
stable RecyclerView to try to prevent an NPE that's occassionally
occuring.

BUG=1018170

Change-Id: I1112125c07a13173c4a2afc65d87e066ff432717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881367Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709616}

This also necessitates passing a const SVGAnimationElement to
SVGPropertyBase::CalculateAnimatedValue, so do that as well.

Bug: 1017723
Change-Id: Id866e2aa3c42a8f4dc2b03338984dbb2b0b8ca1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879248Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#709615}

Bug: 1013688
Change-Id: Iff04a8d0c4b4fdf8f143bd0a66a6f46cf0dc447d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879900
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709614}

Directly implement AddMessageToConsole on LocalFrame.

BUG=1008432

Change-Id: I39afa2e57676af5514daf43f9d4bb46320cce3a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875282Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709613}

Changed to match the app list spec.

Bug: 1002139
Change-Id: I2a9c4814bf3f54f53f1f4e286d9680b130f917ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880075
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709612}

For devices that don't have Assistant key on the keyboard, the open
Assistant shortcut [search + a] should be listed in the keyboard
shorcut viewer in Keyboard Settings for better user experience.

Bug: b/141929862
Test: manully.
Change-Id: I982d4be0ded50c6c2e5e2d174ab059db83d3fca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879326Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709611}

The Payment Handler of the Chrome Custom Tab solution blocks the
insecure content. The Payment Handler of the bottom-sheet solution also
requires the same check. This CL is to add the check.

The security check was implemented according to the spec:
https://www.w3.org/TR/payment-handler/#authorized-payment-apps

After this change, opening a payment app that has invalid or insecure
content (invalid url, insecure content, http) or interstitial page
would cause an error in the payment app. And the payment handler would
be hidden right away in these cases.

Bug: 999196

Change-Id: I664803b0bd7ccc128cc8d0c61dd889fcb964b733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874519
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709610}

Consider the following tree :
++kRootWebArea AXID:1
++++kGenericContainer AXID:2
++++++kGenericContainer AXID:3
++++++++kStaticText AXID:4 "some text"
++++++++kStaticText AXID:5 "more text"
...(possibly more content following)

If GetAttributeValue is called on a range :
start_: TEXT_POSITION anchor_id=4 text_offset=0 "<s>ome text"
end_:   TEXT_POSITION anchor_id=2 text_offset=17 "some textmore tex<t>"

This GetAttributeValue would overrun the |end_| because iterating with
|CreateNextAnchorPosition| doesn't create ancestor positions, so the
looping condition will not exit the loop.

Instead, the loop continues until reaching the end of document, where
it will return a NULL_POSITION and |GetDelegate| returns a nullptr.

Snapping the iterator start/end positions to be |AsLeafTextPosition|
fixes this loop.

Bug: 1011057, 928948
Change-Id: If038d8d4bc0ed596fd2339931258822897c3c8d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879778
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#709609}

This skips a check that is only needed for html:style and, for SVG elements,
animatable SVG attributes (including html:class). In cases where we statically
know that is not the case, we should use the fast variants (as we do in most
existing uses).

Generated by:
  git grep -l hasAttribute.*html_names third_party/blink/renderer | xargs perl -pi -e 's/hasAttribute(?=\(html_names::k(?!(Class|Style)Attr\b)[A-Za-z]+Attr\b)/FastHasAttribute/'
  git grep -l getAttribute.*html_names third_party/blink/renderer | xargs perl -pi -e 's/getAttribute(?=\(html_names::k(?!(Class|Style)Attr\b)[A-Za-z]+Attr\b)/FastGetAttribute/'
  git cl format

Plus the minimum changes needed to satisfy check_blink_style, and two corrections
for attributes which could collide with animatable SVG attributes (type and href)
where the local context does not make it clear that the element is in fact an
HTMLElement.

Change-Id: I56bd622b20eb7a893e53e902e7d576c9cba0dd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880150
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709608}