- 22 Nov, 2018 18 commits
-
-
Jazz Xu authored
Change-Id: I26e660eb8146a9f4aa856ba2f972b715ca25ce3a Reviewed-on: https://chromium-review.googlesource.com/c/1347572 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610285}
-
Nico Weber authored
The string is used to replace things in a json-encoded string, so it needs to be json-encoded. TBR=hans Bug: 899438 Change-Id: Iababe77ed7f8c2dafd0d0443f28f480082bc72d0 Reviewed-on: https://chromium-review.googlesource.com/c/1347312Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610284}
-
Alex Danilo authored
Context menu 'New Folder' selection was causing the menu to jump up and down (easier seen on captured video on the bug). This was caused by a 'change' event fired that updated the state of the context menu tasks-separator bar to visible despite there being no items above it (which in turn, makes the menu taller temporarily). That happened mid-animation of the menu and the bar is reset to hidden after more event processing. Removing the fake data that was passed into the updateContextMenuTaskItems_() method stops it happening. offending code to visually check fix works. Ran test on desktop and real device to confirm. Bug: 698176 Test: Ran all FilesApp browser tests. Single-stepped through the Change-Id: Icd7a2c41ad85bf93e30fe90632d83a8890b294bf Reviewed-on: https://chromium-review.googlesource.com/c/1347631Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#610283}
-
Sam McNally authored
File changes (e.g. file creation) within the current directory would trigger a rescan. This causes file changes to disable "New folder". This causes flickering of the new folder menu item and button for multi-file operations in the current directory. Avoid this by allowing new folder while scanning. Bug: 618002 Change-Id: I5943deeb0186ab425824eeb70ed69414e702da42 Reviewed-on: https://chromium-review.googlesource.com/c/1347633Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610282}
-
DongJun Kim authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Ie237b994b8e871b1d3b6a999341847ad975a25a9 Reviewed-on: https://chromium-review.googlesource.com/c/1343581Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#610281}
-
Jakob Gruber authored
This moves logic to handle LSAN leak warnings into ~BlinkFuzzerTestSupport. Two related call sites are updated. Bug: chromium:906425 Change-Id: I2b7c6d5145e67a3d9d919e5f17e51a28eacee7bc Reviewed-on: https://chromium-review.googlesource.com/c/1341522Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#610280}
-
Robert Ogden authored
Bug: 907665 Change-Id: I07737f4e4dee8c28741dc63016eb376604c21723 Reviewed-on: https://chromium-review.googlesource.com/c/1346996Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610279}
-
Eric Roman authored
The previous implementation was effectively: getaddrinfo(gethostname()) The new approach uses a similar strategy to Firefox, by first prioritizing the default local address used for connecting to the internet, followed by various fallbacks including testing routes to private IPs. This also deletes the ChromeOS specific implementation, as the generic one addresses the original problem it was fixing. Bug: 735637, 827533 Change-Id: I31a5d1a58af48398afad787aefc1edd6cc4510ac Reviewed-on: https://chromium-review.googlesource.com/c/1336063 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610278}
-
Joel Hockey authored
Check #gear-menu select-all for disabled rather than hidden. Change messages to make exact point of failure clear. Change-Id: Ie114bdcba79ca0b939d0ea54865961ea1a39b7cd Reviewed-on: https://chromium-review.googlesource.com/c/1347632 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610277}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: Ic3c52165f48b66c4c5fe7047d3f909ea1ab53464 Reviewed-on: https://chromium-review.googlesource.com/c/1344061 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610276}
-
Stuart Langley authored
Replace the exiting data that was being recorded using GA with UMA for long hash calculate and search by hash results. GA was disabled some time back so this data has not been being recorded for some time. We'll switch to UMA for the time being and then make a decision on either keeping or removing these metrics altogether at a later date. Bug: 847729 Change-Id: I6b2fac50a3275b1cd3684ef3b438f26d147ea64c Reviewed-on: https://chromium-review.googlesource.com/c/1341434 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#610275}
-
Noel Gordon authored
Closure JS compiler type annotations for this unit test were added in CL:1345690: enable them and auto-generate the unit test code. Remove import_history_unittest.html - make file_manager_jstest.cc auto-generate the unit test code BUILD file: enable Closure compiler - update js_library(import_history) deps for Closure compiler - add js_unittest(import_history_unittest) auto-generate rule import_history_unittest.js: remove unused Drive sync leftovers - Drive sync moved to its own unittest rule in the past so ... - chrome.fileManagerPrivate.onFileTransfersUpdated > /dev/null - chrome.syncFileSystem, TestSyncFileEntryProvider > /dev/null Bug: 905934 Change-Id: I16b93e755c3a4a00378b426616cf030afc6a325f Reviewed-on: https://chromium-review.googlesource.com/c/1346430Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Roger Tawa authored
Bug: 907614 Change-Id: Ic8383f2e9d04a202296ff3e25fb64e7093d7818f Reviewed-on: https://chromium-review.googlesource.com/c/1347582Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#610273}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: If80e780ce6f0b976be03ced6af121dd47ebd4a34 Reviewed-on: https://chromium-review.googlesource.com/c/1347789Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#610272}
-
Max Moroz authored
Bug: 906129, 870331 Change-Id: I19b7ceb187cfd1e6a28a808005606311bc4c96cc Reviewed-on: https://chromium-review.googlesource.com/c/1347691 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d69ae20edf94..aa21a922d4a8 git log d69ae20edf94..aa21a922d4a8 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 eroman@chromium.org Use ts_proxy_server on Chrome OS (remote) the same as on other platforms. 2018-11-21 lwsong@google.com Show hover text for transparent values and fixed hide Y Axis 2018-11-21 kris.selden@gmail.com Fix crashes on performance.measure name parsing. 2018-11-21 cbruni@chromium.org [pinpoint] Show bot, benchmark and story if no job title is provided Created with: gclient setdep -r src/third_party/catapult@aa21a922d4a8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:652385 TBR=sullivan@chromium.org Change-Id: I69efa2ee8a2fc49535873d7eb0cb427e31e5d6cb Reviewed-on: https://chromium-review.googlesource.com/c/1347522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610270}
-
Maksim Ivanov authored
Add unit tests for the DiagnosticsdBridge class - specifically, for the Mojo bootstrapping via a D-Bus call and the related retry logic. BUG=chromium:869377 TEST=unit_tests --gtest_filter=DiagnosticsdBridge* Change-Id: I4979bacef872bbbd250e5778df1a85707520768a Reviewed-on: https://chromium-review.googlesource.com/c/1337613 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610269}
-
Sergey Ulanov authored
GetScanoutFormats() isn't used anywhere, so it can be removed. Change-Id: I7ae437f4800df649d727e18e3810aa5e890dcf44 Reviewed-on: https://chromium-review.googlesource.com/c/1347590Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610268}
-
- 21 Nov, 2018 22 commits
-
-
Katie Dillon authored
This test has workers sending different realistic payloads back and forth from the parent context to the worker. Change-Id: I656df3737d037593c9ce54d2739b58cebcde198b Reviewed-on: https://chromium-review.googlesource.com/c/1323559Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
-
Aiden Benner authored
- Move golden/javap files to jni_generator/golden/ - Make method capitalization more consistent with jni_generator py files - Split proxy native tests to a different test suite - Decouple utility functions from TestGenerator into a base test class - Fix bug where tests would fail if ran from a different directory - Adds tests for enable/disable/require mock flags Bug: 898261 Change-Id: Ieae930c73539b00653dfcf32c89d9a79a3ceecf6 Reviewed-on: https://chromium-review.googlesource.com/c/1345239 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610266}
-
Alice Boxhall authored
Bug: 906310 Change-Id: I62438e397d3551c7cc0787df4ff5faa985fb3f56 Reviewed-on: https://chromium-review.googlesource.com/c/1345714 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#610265}
-
Ken Buchanan authored
This is a speculative fix to flakiness on SitePerProcessBrowserTest.CrossProcessInertSubframe, yielding the UI thread after navigation but before sending the script to test for inertness. This should ensure the inertness bit propagates to the new frame before the script is sent for execution. Bug: 792477 Change-Id: Iee370a863003045399730ba4a49831051d20316c Reviewed-on: https://chromium-review.googlesource.com/c/1347617Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610264}
-
Aiden Benner authored
Adds the REQUIRE_MOCKS flag to GEN_JNI. If both the REQUIRE_MOCKS and TESTING_ENABLED flags are set, calls to native implementations must have had a mock instance set first through TEST_HOOKS, otherwise an UnsupportedOperationException will be thrown. If only TESTING_ENABLED is set, calls to the native implementation will use a test mock if it is provided, and otherwise fallback to the native implementation. This is used for instrumentation tests that may want to mock out some native implementations but not all. In the annotation processor version of GEN_JNI both these flags are mutable and so they can be set by a JNI test rule for unit tests. Instrumentation tests that want to mock a native implementation can pass flags to JNI registration generator to set the corresponding GEN_JNI flags. Bug: 898261 Change-Id: I6a90e91a29368df692d458f35c9ea92f8898064b Reviewed-on: https://chromium-review.googlesource.com/c/1344554 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
-
Alexei Svitkine authored
On a recent review [1], I wasn't happy with the exact comment that was being used and requested changes, but turns out the author had used the sample comment we have in the header file. Update that comment to improve it. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1337297 Bug: None Change-Id: I49bc65b64824839a5ffe112a6e1bc5ae6447e75e Reviewed-on: https://chromium-review.googlesource.com/c/1346732Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610262}
-
Stephen McGruer authored
Upstream, the spec has changed to remove 'auto' as a value for ScrollDirection. TBR=majidvp@chromium.org Bug: None Change-Id: I5fa47e0f31c5229b5d734dc39d0717973936543e Reviewed-on: https://chromium-review.googlesource.com/c/1347033Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610261}
-
Nicolás Peña Moreno authored
This reverts commit 5d945012. Reason for revert: FindIt thinks this is causing Layouttest failures Original change's description: > Unify input delay computations > > This CL unifies the timestamp computations for FID as reported to UMA and FID as > exposed in the Web Perf API. It moves the UMA reporting from the > PageWidgetDelegate to the EventTiming class. After this CL, the same types of > events are logged by both the UMA metric and the webexposed metric. In addition, > this CL removes the check that there are default actions or event handlers from > EventTiming, which means that now the webexposed API will expose events even if > they have no associated event handlers. In particular, this means that a click > will now trigger mousedown, click, and mouseup entries, in that order. This is > reflected in changes to the layout tests. > > Bug: 897656 > Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc > Reviewed-on: https://chromium-review.googlesource.com/c/1334564 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610201} TBR=tdresser@chromium.org,dtapuska@chromium.org,npm@chromium.org Change-Id: I27e189ee26fb04fa92e8ca6232c8c70730b0c373 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897656 Reviewed-on: https://chromium-review.googlesource.com/c/1347692Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610260}
-
Jia authored
It will be enabled in experiments later. Bug: 881215 Change-Id: Ic1664d82810311b69658a279661624f285493bbb Reviewed-on: https://chromium-review.googlesource.com/c/1347629Reviewed-by:
Marti Wong <martiw@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#610259}
-
Brian Sheedy authored
This reverts commit 41ee7d38. Reason for revert: Cause of https://crbug.com/907602 Original change's description: > Android: Factor InProductHelp UI out of Tab > > This CL moves the methods handling InProductHelp UI in Tab to > ToolbarButtonInProductHelpController using ActivityLifecycleDispatcher and > Tab page load observing mechanism. Now the methods are handled by > ChromeTabbedActivity only. > > Bug: 889682 > Change-Id: Idce805f60f32ad90418c0f6e3ded80df6d18f9b1 > Reviewed-on: https://chromium-review.googlesource.com/c/1272779 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609881} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org,jinsukkim@chromium.org,robertogden@chromium.org Change-Id: I539d82b07ee8f6a3012ad72e1f2ba35eda613d72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889682 Reviewed-on: https://chromium-review.googlesource.com/c/1347199Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610258}
-
John Budorick authored
Tbr: martiniss@chromium.org Bug: 904636 Change-Id: I7e8d7ed29da753a1813f304d17efccb8a327f441 Reviewed-on: https://chromium-review.googlesource.com/c/1347612Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610257}
-
Hiroshige Hayashizaki authored
This reverts commit 02c7f5d5. Reason for revert: I expect crbug/906964 is fixed by reverting another CL, so relanding this. Original change's description: > Revert "Add referrer-policy module worker tests" > > This reverts commit ec589a5c. > > Reason for revert: crbug.com/906964 > > Original change's description: > > Add referrer-policy module worker tests > > > > This CL adds WPT tests for referrer policy applied to > > module worker top-level script fetch. > > > > The only manual changes are > > - referrer-policy/generic/common.js > > - referrer-policy/generic/referrer-policy-test-case.js > > - referrer-policy/spec.src.json > > and all other modifications are made by > > referrer-policy/generic/tools/generate.py. > > > > Bug: 880027 > > Change-Id: Ib1f9136161e8efacf317fb9b7e9ba0651a103c41 > > Reviewed-on: https://chromium-review.googlesource.com/c/1330906 > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#609589} > > TBR=hiroshige@chromium.org,nhiroki@chromium.org,jochen@chromium.org > > Change-Id: I0931159c0494b981a1d6b07232af55b20f68f559 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 880027, 906964 > Reviewed-on: https://chromium-review.googlesource.com/c/1344213 > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609731} TBR=hiroshige@chromium.org,nhiroki@chromium.org,jochen@chromium.org Change-Id: I48d40a578e06526558fc7a4733395e1e505b9694 Bug: 880027, 906964 Reviewed-on: https://chromium-review.googlesource.com/c/1344267 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#610256}
-
Ryan Hansberry authored
Bug: 907312 Change-Id: If3efbb895fa8ed77330e5879c8608ee92b8497ef Reviewed-on: https://chromium-review.googlesource.com/c/1345126 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#610255}
-
khachatryan authored
Disabling failing tests testDownloadDirectoryOverridesExistingPreferences and testExistingDevToolsPortFile on Waterfall on Windows build bot Bug: 907608:chromedriver:2673 Change-Id: I74adcfa17f6349aa74805e6905fa630661ea4a9b Reviewed-on: https://chromium-review.googlesource.com/c/1347613Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610254}
-
Toni Barzic authored
Removes oauth2_token_fetcher_ and auth_url_loader_factory_ from OAuth2LoginManager, as they are no longer used - the usage was removed in CL:1212962 BUG=None Change-Id: Ia025818376f239e406dd285cdd288dca164c0ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1347447Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#610253}
-
Xi Cheng authored
Change-Id: I07f07f12c0799e1e93d648419ff2488fff5db2da Reviewed-on: https://chromium-review.googlesource.com/c/1347580Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#610252}
-
Owen Min authored
The option is read from the Registry with the same key as the enrollment token. The value is CloudManagementBlockOnFailureEnabled. Bug: 904983 Change-Id: Ia8bada4e79d236fb9f85320e38ed6588f34a5ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1345211Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610251}
-
Darwin Huang authored
Helps fix errors in apps which prefer text/plain content while pasting over img, even though it is less spec-conformant to provide fewer types than possible. As noted in the crbug, these apps (ex. Messenger) generally prefer text/plain content due to compatibility issues with Microsoft Word. This does also make us more consistent with other platforms (ex. Windows/Linux), where we don't provide the text/plain field. Also moved a browser test to a layout test for future ease of testing. The browser test wasn't able to generate text/plain to reproduce the bug, due to images only previously producing text/plain output on images with alt text, and execCommand only operating on iframe DOM objects (not image DOM objects) Bug: 838808 Change-Id: I28b2d8d223c2448f47e887323afccae73d6bcf44 Reviewed-on: https://chromium-review.googlesource.com/c/1319032Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eacc22d07da8..e89f85283d4c Created with: gclient setdep -r src-internal@e89f85283d4c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I90152301df4986c82048f98057fa78848fa65544 Reviewed-on: https://chromium-review.googlesource.com/c/1347076Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610249}
-
Antonio Gomes authored
BUG=907533 Change-Id: Ib8714aa26040bbfb9338454c5c327f9194a20d32 Reviewed-on: https://chromium-review.googlesource.com/c/1347149Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610248}
-
Sean Kau authored
Bug: None Change-Id: If683748053284fd0912c4652481de1b37783f033 Reviewed-on: https://chromium-review.googlesource.com/c/1345547 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#610247}
-
Eric Karl authored
We currently track various GL values (format/type/swizzle) for each viz::Format on SharedImageBackingFactoryGLTexture. Depending on whether we plan to use TexStorgae2D or TexImage2D, we calculate these differently. With the ability to upload data at texture creation time, we need to dynamically chose TexStorage2D or TexImage2D. Rather than duplicate the calculate format/type/swizzle, this CL ensures that these were actually the same all along (and fixes some cases where they weren't). This lets us simplify our format info calculation logic a bit. Bug: 906794 Change-Id: I4c97aade94ecf267df8a1adfb45aeda8e14d1c12 Reviewed-on: https://chromium-review.googlesource.com/c/1345538 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610246}
-
