GitLab

Followup to:
Kill [SetWrapperReferenceFromReference] IDL extended attribute
https://codereview.chromium.org/181513002/

TBR=haraken
BUG=345503

Review URL: https://codereview.chromium.org/176993007

git-svn-id: svn://svn.chromium.org/blink/trunk@168259 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a font resource takes a long time to download, currently Blink
keeps the text invisible until the font is ready. After this patch,
Blink behaves similar to FireFox; keeps the text invisible until 3
seconds, then fallback to the next available font in the fallback
list. When the webfont finally loads, change the text to use it.

- Add a Timer to FontResource that fires after 3 seconds since load start.
- fontLoadWaitLimitExceeded() callback invalidates the fallback font and
  triggers style recalc.
- Fallback fonts have m_skipDrawing boolean in CustomFontData, that is
  false if the font load exceeds the wait limit.
- FontFallbackList::shouldSkipDrawing() returns true if it contains at
  least one FontData with m_skipDrawing == true.

BUG=235303
TEST=http/tests/webfont/slow-loading.html

Review URL: https://codereview.chromium.org/171823002

git-svn-id: svn://svn.chromium.org/blink/trunk@168258 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/171743004

git-svn-id: svn://svn.chromium.org/blink/trunk@168257 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Right now, this can return true even if the frame is detached, since it
doesn't check that the frame has a non-null host.

The remaining changes in DOMWindow are to preserve current web visible
behavior, as well as fixing a null pointer dereferences that this exposes
in Performance and ScreenOrientation.

BUG=347331
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/131113003

git-svn-id: svn://svn.chromium.org/blink/trunk@168256 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These will need baselines too, most likely.

TBR=scottmg@chromium.org
BUG=309197

Review URL: https://codereview.chromium.org/185303004

git-svn-id: svn://svn.chromium.org/blink/trunk@168255 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prior to this CL, we were setting the style of the RenderView on every style
recalc because we were comparing the RenderView's overflow style with the wrong
value. This CL corrects the bug.

This CL doesn't have much effect yet, but it will become important in a future
CL when we use style modification on RenderLayers to scope compositing updates.

Review URL: https://codereview.chromium.org/185263002

git-svn-id: svn://svn.chromium.org/blink/trunk@168254 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a crash on xe.com where the text autosizer would call
isEmpty() on a RenderObject and crash. The issue is that RenderSVGShape
overrides RenderObject::isEmpty and implements it differently:
RenderObject::isEmpty() - true if the RenderObject has children
RenderSVGShape::isEmpty() - true if the bounding box is empty

I've refactored RenderSVGShape::isEmpty() as isShapeEmpty() to both
clarify the override and fix a crash.

BUG=302005
NOTRY=true

Review URL: https://codereview.chromium.org/185243002

git-svn-id: svn://svn.chromium.org/blink/trunk@168252 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Normally if run-webkit-tests detects regressions, it returns the number
of regressions in the exit code (i.e., if 5 tests fail, the exit code is 5).
We also use a few magic values to indicate other errors (like 130 for
interrupted, -1/254 for internal error, etc.). This means that if we get
a lot of errors, we can overlap and produce confusing results.

This change adds a range check on the number of errors; if we get more than
101 failures, we limit the exit code to 101. This should prevent overlap
while preserving behavior in all but very abnormal circumstances.

Arguably a better change would just be to use 1 for the error and ignore
the number of failures altogether, but that might break scripts so I'm
not going to do this now.

TBR=scottmg@chromium.org
BUG=309197

Review URL: https://codereview.chromium.org/185503002

git-svn-id: svn://svn.chromium.org/blink/trunk@168251 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change suppresses the remaining failures resulting from the
switch to Visual Studio 2013 until scottmg or I can go through
and rebaseline them. There's probably a couple local failures from
my machine that shouldn't be rebaselined, and a couple of legit bugs
as well, which is why I don't want to use 'NeedsRebaseline' for the
bot to automatically deal with this.

TBR=scottmg@chromium.org
BUG=309197

Review URL: https://codereview.chromium.org/183973012

git-svn-id: svn://svn.chromium.org/blink/trunk@168250 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/185273002

git-svn-id: svn://svn.chromium.org/blink/trunk@168248 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prefer this helper function when throwing TypeErrors.

R=
BUG=

Review URL: https://codereview.chromium.org/183253003

git-svn-id: svn://svn.chromium.org/blink/trunk@168247 bbb929c8-8fbe-4397-9dbb-9b2b20218538

indexeddb is available in Worker contexts, including this event.

R=
BUG=340522

Review URL: https://codereview.chromium.org/185323003

git-svn-id: svn://svn.chromium.org/blink/trunk@168246 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rationale
1. GraphicsLayer deals with background-color layer as a contents layer, so a
background-color layer is in trouble in terms of the correct order with negative
z-order children.
2. CompositedLayerMapping has the big hack to decide the given layer can be
background-color layer. Unfortunately, the big hack is incomplete and invasive.
3. Hybrid Accelerated Rasterization will cover this optimization in more generic way.
4. background-color layer covers very limited cases. A layer-promoted box
object must not have children, not have decoration, only have a background-color
property.

BUG=114658, 340691
TEST=compositing/background-color/background-color-drawn-over-child.html,
compositing/*

Review URL: https://codereview.chromium.org/178013003

git-svn-id: svn://svn.chromium.org/blink/trunk@168245 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves some code relating to walking the RenderLayer tree and updating
GraphicsLayers out of RenderLayerCompositor. This code didn't interact with any
of the state in RenderLayerCompositor, so it's easy to untangle.

I've also taken the opportunity to remove a pretty gross hack using static
variables to communicate data across the recursive tree walk. Now we just use
normal member variables in the stack object that manages the tree walk.

This CL shouldn't change any behavior.

Review URL: https://codereview.chromium.org/185293002

git-svn-id: svn://svn.chromium.org/blink/trunk@168244 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper. (https://codereview.chromium.org/177473003/)

Reason for revert:
crash in SkCanvas::getTotalMatrix (crbug.com/348122)
Reverting this to see if it fixes it, otherwise we can reland.

Original issue's description:
> Use SkLayerDrawLooper::Builder to construct SkLayerDrawLooper.
> 
> The addLayer() methods of SkLayerDrawLooper will soon be removed. This CL
> updates all uses of those methods with the corresponding methods in
> SkLayerDrawLooper::Builder.
> 
> BUG=skia:2141
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168041

TBR=schenney@chromium.org,jbroman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2141

Review URL: https://codereview.chromium.org/178113003

git-svn-id: svn://svn.chromium.org/blink/trunk@168243 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The only reason we had a HashMap in the overlap map was to handle a recursive
treewalk in the case where we need to be composited because of our children. It
turns out the HashMap was wrong in the case where those children got composited
into another non-root layer. In that case, they would already be in the overlap
map and would be excluded in the recursive walk.

This CL removes the HashMap and instead just unites the bounds of all the
children during the normal recusive walk. If we need to composite ourself
because of our decendants, we use the united rect instead of recursively adding
all the descendant rects individually. This is both faster (3% on the
toggle_drawer compositing update) and more correct (see test).

R=enne@chromium.org

Review URL: https://codereview.chromium.org/178313004

git-svn-id: svn://svn.chromium.org/blink/trunk@168242 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Two problems with the current srcset parsing algorithm are fixed here:
1. When a set of descriptors contained only invalid descriptors, the resource wasn't ignored.
2. When more than 1 resource shared a single DPR value, the last one was taken into account, rather than the first one.

I've also added test and fixed current ones to prevent this from regressing in the future.

BUG=347998

Review URL: https://codereview.chromium.org/184523003

git-svn-id: svn://svn.chromium.org/blink/trunk@168241 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CloseEvent and XMLHttpRequestProgressEvent are also exposed inside Workers.

R=
BUG=340522

Review URL: https://codereview.chromium.org/178193014

git-svn-id: svn://svn.chromium.org/blink/trunk@168240 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pkasting@chromium.org,dpranke@chromium.org,pdr@chromium.org
BUG=309197

Review URL: https://codereview.chromium.org/183803005

git-svn-id: svn://svn.chromium.org/blink/trunk@168239 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=335247

Review URL: https://codereview.chromium.org/179873018

git-svn-id: svn://svn.chromium.org/blink/trunk@168238 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It always created like InlineBox(*this) so it always has a renderer.
Also removes NULL checks and asserts which are not longer required.

BUG=

Review URL: https://codereview.chromium.org/184023003

git-svn-id: svn://svn.chromium.org/blink/trunk@168237 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove call to ResourceLoadPriorityOptimizer from RenderBlock Destructor. This isn't necessary since it's already called from the RenderObject destructor.

BUG=

Review URL: https://codereview.chromium.org/148523010

git-svn-id: svn://svn.chromium.org/blink/trunk@168236 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Calling clippedByAncestor is not free, we should avoid calling it unless
the compositingReasons() say we need to.

R=ojan@chromium.org,vollick@chromium.org,abarth@chromium.org

Review URL: https://codereview.chromium.org/183263003

git-svn-id: svn://svn.chromium.org/blink/trunk@168234 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bot more likely to succeed at rebaselining.

BUG=none
TEST=none
TBR=ojan

Review URL: https://codereview.chromium.org/185173002

git-svn-id: svn://svn.chromium.org/blink/trunk@168233 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These tests should continue to run correctly without rebaselines.

BUG=345027

Review URL: https://codereview.chromium.org/183703003

git-svn-id: svn://svn.chromium.org/blink/trunk@168232 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I incorrectly removed some these workaround functions for VS2013 at
https://codereview.chromium.org/27009003 . The other non-workaround
functions (that just didn't exist previously) seem to be OK, but the
behaviour around +-Inf is still different than we expect for JS and
XPath.

R=jamesr@chromium.org
BUG=347870

Review URL: https://codereview.chromium.org/184103006

git-svn-id: svn://svn.chromium.org/blink/trunk@168231 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The member was no longer big enough to store all the 
enumerators so the setter could fail. The net result was
that if you tried to set the reason to 4, it *always*
looked like this reason changed. I was seeing a full
tree build on every mouse move!

R=abarth@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/177653010

git-svn-id: svn://svn.chromium.org/blink/trunk@168181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch updates the computed position values used for blending to be a horizontal
left offset and a vertical top offset. When positions include a center, bottom, or
right position offset, it is converted to the appropriate top/left coordinate as
a calc expression. Serialized values still use the original bottom/right directions
when present, and also omit the top/left keywords where possible.

A test is added to shape-outside.html since it had no test for interpolation of extended positions.

Patch by Bear Travis.

BUG=308251

Review URL: https://codereview.chromium.org/144373002

git-svn-id: svn://svn.chromium.org/blink/trunk@168180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because we always compile SVG there is no need anymore to have this in a separate file. Also now we end up with only one isSystemColor.

Review URL: https://codereview.chromium.org/184693003

git-svn-id: svn://svn.chromium.org/blink/trunk@168179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=337919


git-svn-id: svn://svn.chromium.org/blink/trunk@168178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

with Windows-specific native behaviors from ScrollbarThemeWin.cpp:

* Snap the scrollbar back to its drag origin when dragged too far off the track.
  This code matches the old code we had for years and also matches my Win 7
  native scrollbars pixel-for-pixel.

* Don't jump the scroll thumb to the mouse cursor on a middle-click, only on a
  shift-click.  Middle-click must be a GTK-ism.

This is the Blink side of the changes to re-add this behavior.

BUG=337919
TEST=Drag a scroll thumb to somewhere in the track, then without releasing, move the mouse far away from the track.  The scroll thumb should snap back to the scroll origin.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/151483008

git-svn-id: svn://svn.chromium.org/blink/trunk@168177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=249427
TBR=

Review URL: https://codereview.chromium.org/184113008

git-svn-id: svn://svn.chromium.org/blink/trunk@168176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

targeted style recalc.

This simplifies the code a bit and unifies the code paths.

BUG=335247
R=esprehn@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/183583002

git-svn-id: svn://svn.chromium.org/blink/trunk@168175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- standard font family should go Android path on Android;
- for non-generic font families, familyNameFromSettings should return
  an empty AtomicString.

BUG=347121
TEST=platform/android/fast/text/international/non-generic-font-fallback.html
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/184703003

git-svn-id: svn://svn.chromium.org/blink/trunk@168173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SpeechSynthesis.cpp incorrectly assumed that calling
m_platformSpeechSynthesizer->cancel() would immediately call
didFinishSpeaking or speakingErrorOccurred, which would null out
m_currentSpeechUtterance. This assumption was true in WebKit/Mac, but
Chromium's platform implementation is asynchronous, so that call may
come later.

Fix the issue and simplify the logic by getting rid of the raw pointer
to the current utterance altogether. Now the RefPtr at the front of the
utterance queue is the current utterance, and the platform implementation
is allowed to fire events on utterances that are no longer in the queue.

BUG=344881
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168092

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168169

Review URL: https://codereview.chromium.org/180553004

git-svn-id: svn://svn.chromium.org/blink/trunk@168171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Wrong merge base when committing!

> Fix use-after-free of m_currentSpeechUtterance.
> 
> SpeechSynthesis.cpp incorrectly assumed that calling
> m_platformSpeechSynthesizer->cancel() would immediately call
> didFinishSpeaking or speakingErrorOccurred, which would null out
> m_currentSpeechUtterance. This assumption was true in WebKit/Mac, but
> Chromium's platform implementation is asynchronous, so that call may
> come later.
> 
> Fix the issue and simplify the logic by getting rid of the raw pointer
> to the current utterance altogether. Now the RefPtr at the front of the
> utterance queue is the current utterance, and the platform implementation
> is allowed to fire events on utterances that are no longer in the queue.
> 
> BUG=344881
> R=abarth@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168092
> 
> Review URL: https://codereview.chromium.org/180553004

TBR=dmazzoni@google.com

Review URL: https://codereview.chromium.org/185093002

git-svn-id: svn://svn.chromium.org/blink/trunk@168170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SpeechSynthesis.cpp incorrectly assumed that calling
m_platformSpeechSynthesizer->cancel() would immediately call
didFinishSpeaking or speakingErrorOccurred, which would null out
m_currentSpeechUtterance. This assumption was true in WebKit/Mac, but
Chromium's platform implementation is asynchronous, so that call may
come later.

Fix the issue and simplify the logic by getting rid of the raw pointer
to the current utterance altogether. Now the RefPtr at the front of the
utterance queue is the current utterance, and the platform implementation
is allowed to fire events on utterances that are no longer in the queue.

BUG=344881
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168092

Review URL: https://codereview.chromium.org/180553004

git-svn-id: svn://svn.chromium.org/blink/trunk@168169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

At the time that landed, these were already marked as needing rebaselines for a
different bug, and the rebaselining for that bug crossed in-flight, leaving
these with incorrect baselines.

BUG=345609
TEST=none
TBR=tkent

Review URL: https://codereview.chromium.org/184043012

git-svn-id: svn://svn.chromium.org/blink/trunk@168168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=248938
TEST=none
TBR=apavlov

Review URL: https://codereview.chromium.org/185053003

git-svn-id: svn://svn.chromium.org/blink/trunk@168167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Caused various iframe accessibility tests to fail across platforms.

> Add an accessibility role for the iframe element.
> 
> We can add a layout test after adding TestRunner support on the Chromium side,
> or we could just test it in Chromium.
> 
> BUG=347464
> 
> Review URL: https://codereview.chromium.org/183183005

TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/185003006

git-svn-id: svn://svn.chromium.org/blink/trunk@168166 bbb929c8-8fbe-4397-9dbb-9b2b20218538